[{"id":1754459,"web_url":"http://patchwork.ozlabs.org/comment/1754459/","msgid":"","list_archive_url":null,"date":"2017-08-22T21:12:12","subject":"Re: [U-Boot] [PATCH v4 3/3] armv8: ls1088aqds: Add support of\n\tLS1088AQDS","submitter":{"id":67822,"url":"http://patchwork.ozlabs.org/api/people/67822/","name":"York Sun","email":"york.sun@nxp.com"},"content":"On 08/17/2017 10:45 PM, Ashish Kumar wrote:\n\n\n\n> +void ls1088a_handle_phy_interface_sgmii(int dpmac_id)\n> +{\n> +\tstruct mii_dev *bus;\n> +\tstruct ccsr_gur __iomem *gur = (void *)CONFIG_SYS_FSL_GUTS_ADDR;\n> +\tu32 serdes1_prtcl, cfg;\n> +\n> +\tcfg = in_le32(&gur->rcwsr[FSL_CHASSIS3_SRDS1_REGSR - 1]) &\n> +\t\t\t\tFSL_CHASSIS3_SRDS1_PRTCL_MASK;\n> +\tcfg >>= FSL_CHASSIS3_SRDS1_PRTCL_SHIFT;\n> +\tserdes1_prtcl = serdes_get_number(FSL_SRDS_1, cfg);\n> +\n> +\tint *riser_phy_addr;\n> +\tchar *env_hwconfig = getenv(\"hwconfig\");\n\ngetenv() is no longer used. See commit 00caae6d47. Please rebase your code.\n\n> +\n> +\tif (hwconfig_f(\"xqsgmii\", env_hwconfig))\n> +\t\triser_phy_addr = &xqsgii_riser_phy_addr[0];\n> +\telse\n> +\t\triser_phy_addr = &sgmii_riser_phy_addr[0];\n> +\n\nDo you run this function when U-Boot runs in flash? If not, you should \nconsider hwconfig() instead of hwconfig_f().\n\nYork","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"YEAnwB4t\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=york.sun@nxp.com; "],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xcNYP5YWyz9s76\n\tfor ;\n\tWed, 23 Aug 2017 07:12:25 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 3B1A1C21E85; Tue, 22 Aug 2017 21:12:19 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 7A507C21DFE;\n\tTue, 22 Aug 2017 21:12:17 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 30A31C21DFE; Tue, 22 Aug 2017 21:12:16 +0000 (UTC)","from EUR01-VE1-obe.outbound.protection.outlook.com\n\t(mail-ve1eur01on0046.outbound.protection.outlook.com [104.47.1.46])\n\tby lists.denx.de (Postfix) with ESMTPS id 1B844C21C27\n\tfor ; Tue, 22 Aug 2017 21:12:15 +0000 (UTC)","from VI1PR04MB2078.eurprd04.prod.outlook.com (10.166.43.18) by\n\tVI1PR04MB3150.eurprd04.prod.outlook.com (10.170.229.24) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1362.18; Tue, 22 Aug 2017 21:12:13 +0000","from VI1PR04MB2078.eurprd04.prod.outlook.com\n\t([fe80::5ce6:46c1:8a2c:ca59]) by\n\tVI1PR04MB2078.eurprd04.prod.outlook.com\n\t([fe80::5ce6:46c1:8a2c:ca59%14]) with mapi id 15.01.1362.019;\n\tTue, 22 Aug 2017 21:12:12 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=t25pEwD+Ya8GnJ2iy4uXT9LpOZ2tIapBVWfUXskQzqo=;\n\tb=YEAnwB4tdU+tw/AEu4B7eEdmvFqutCA7i6qLPSzv+pHSM0+vijWVC5mjd77Ua/zlZV8/KKs6XXglPXt6X6t5ae9Ne2XAd59na0sWp7Sy7hcWQjPk4648M1tjv4ySvxXl4uHvlo4WNQ8pKJklCBLjws+a/2Q/AlzHJ9N/35Szfx4=","From":"York Sun ","To":"Ashish Kumar , \"u-boot@lists.denx.de\"\n\t","Thread-Topic":"[PATCH v4 3/3] armv8: ls1088aqds: Add support of LS1088AQDS","Thread-Index":"AQHTF+UhBeMUEYYXFEGZKYoDxxU1Eg==","Date":"Tue, 22 Aug 2017 21:12:12 +0000","Message-ID":"","References":"<1503035091-28883-1-git-send-email-Ashish.Kumar@nxp.com>\n\t<1503035091-28883-3-git-send-email-Ashish.Kumar@nxp.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"YEAnwB4t\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=york.sun@nxp.com; "],"x-originating-ip":"[192.88.168.1]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; VI1PR04MB3150;\n\t6:qXZNnTJYTeV5fTI2oEdo09hsuQh48uc0Ngvu4gtEsoPiN++mm7PTk29jBFtNGW6T2MdfxVH+oYOvs5GCyyAHBxWO6AJxeV2BsYMY1h6z/khOikrFXuHnJhE8ZjAmqNVbqqsS1tudGfDRlwJL4RkG2olu8h6F/Gt5L7KrYfSBSRgkVN4MZQyEVSWrviyN2vlIDlJP6+btp8Mzd9kITpiqOv40Wgmw7DagtKzyypqvWr9+m3cNJNwheEo1Jy2GSniGzStiBGUXeo6vnnrNEEFh0Yj4FTSucY/x5PKXMbRJXeOh0ZWlHpYeHTCttncbDGbCKdOK3rgy1ZusO5HVFvikAg==;\n\t5:9B0CeqzknkSfKvD5mlgIVAc9zumdYFzRX4NqPDj7ltqqzeUfBnVTV8OMebQrKECr8H1eusv9q9rnYNtkEE7S/SwA9FZ5O9AM50hKKc5nGthm/I+et506WL+TGqMWOcTJSNeamT/hu+peLi1nKOZ/Pw==;\n\t24:/HH5TUUpjDCy0qAKT3xBEddiYXGIZsaj6EyfAYm8HfCpquLF5bAYL3L8kLCRKtY6Wg5tPT1wSgUMxO8G9XI7aRw1rB8aonkSrdedZ/cy3W4=;\n\t7:2FpkzaJj0KcZT/KjwaS3k4ntclDZH3nAfNFLErdK/zkOzyvH0RjTJaXYEfHqG3DfxZXyruxP4tg5ccGSkFao0UwB5mEFBwbRwAUd847VdVozfesO44kuXHbha8K+skQCV3hMLPsfOKrl4GFZMvYUPi5GdwfCW0PRBa0DUlxpS614HF6BnBmbG2HSVGQXBmdmg8WCVl7IFcXToQFNqv+mbvTEJ5cAY1ZB7v9HXZO2sxE=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;SSOR;","x-forefront-antispam-report":"SFV:SKI; SCL:-1; SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(199003)(189002)(24454002)(377454003)(5660300001)(25786009)(54356999)(189998001)(76176999)(43066003)(6506006)(6436002)(55016002)(53936002)(9686003)(99286003)(54906002)(101416001)(2900100001)(50986999)(86362001)(5250100002)(102836003)(4326008)(7696004)(68736007)(6116002)(53546010)(106356001)(66066001)(305945005)(3660700001)(3450700001)(33656002)(3280700002)(3846002)(81156014)(8936002)(2906002)(478600001)(2501003)(74316002)(81166006)(229853002)(6246003)(8676002)(14454004)(7736002)(97736004)(105586002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB3150;\n\tH:VI1PR04MB2078.eurprd04.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","x-ms-office365-filtering-correlation-id":"229d6e7d-3d57-4d09-323e-08d4e9a27564","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:VI1PR04MB3150; ","x-ms-traffictypediagnostic":"VI1PR04MB3150:","x-exchange-antispam-report-test":"UriScan:;","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123560025)(20161123562025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR04MB3150; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR04MB3150; ","x-forefront-prvs":"04073E895A","received-spf":"None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"22 Aug 2017 21:12:12.8596\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR04MB3150","Cc":"Shaohui Xie ","Subject":"Re: [U-Boot] [PATCH v4 3/3] armv8: ls1088aqds: Add support of\n\tLS1088AQDS","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"York Sun ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]