[{"id":1751316,"web_url":"http://patchwork.ozlabs.org/comment/1751316/","msgid":"","list_archive_url":null,"date":"2017-08-18T16:12:50","subject":"Re: [U-Boot] [U-Boot,12/18] rockchip: sdhci: Convert to livetree","submitter":{"id":53488,"url":"http://patchwork.ozlabs.org/api/people/53488/","name":"Philipp Tomsich","email":"philipp.tomsich@theobroma-systems.com"},"content":"> Update the Rockchip SDHCI wrapper to support a live device tree.\n> \n> Signed-off-by: Philipp Tomsich \n> ---\n> \n> drivers/mmc/rockchip_sdhci.c | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n\nAcked-by: Philipp Tomsich ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xYpbH0ZBmz9t3p\n\tfor ;\n\tSat, 19 Aug 2017 02:35:07 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid D362CC22127; Fri, 18 Aug 2017 16:33:55 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 0AC55C220F7;\n\tFri, 18 Aug 2017 16:33:53 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 45F5AC22094; Fri, 18 Aug 2017 16:33:42 +0000 (UTC)","from mail.theobroma-systems.com (vegas.theobroma-systems.com\n\t[144.76.126.164])\n\tby lists.denx.de (Postfix) with ESMTPS id 7E1A8C220D9\n\tfor ; Fri, 18 Aug 2017 16:33:38 +0000 (UTC)","from 89-104-28-141.customer.bnet.at ([89.104.28.141]:52968\n\thelo=vpn-10-11-0-14.lan) by mail.theobroma-systems.com with esmtpsa\n\t(TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80)\n\t(envelope-from )\n\tid 1dijtC-00081J-5e; Fri, 18 Aug 2017 18:12:50 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","MIME-Version":"1.0","From":"Philipp Tomsich ","To":"Philipp Tomsich ","In-Reply-To":"<1502904758-7562-13-git-send-email-philipp.tomsich@theobroma-systems.com>","References":"<1502904758-7562-13-git-send-email-philipp.tomsich@theobroma-systems.com>","Message-Id":"","Date":"Fri, 18 Aug 2017 18:12:50 +0200","Cc":"u-boot@lists.denx.de, Klaus Goger ","Subject":"Re: [U-Boot] [U-Boot,12/18] rockchip: sdhci: Convert to livetree","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1758041,"web_url":"http://patchwork.ozlabs.org/comment/1758041/","msgid":"","list_archive_url":null,"date":"2017-08-26T13:40:06","subject":"Re: [U-Boot] [PATCH 12/18] rockchip: sdhci: Convert to livetree","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 16 August 2017 at 11:32, Philipp Tomsich\n wrote:\n> Update the Rockchip SDHCI wrapper to support a live device tree.\n>\n> Signed-off-by: Philipp Tomsich \n> ---\n>\n> drivers/mmc/rockchip_sdhci.c | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n\nReviewed-by: Simon Glass \n\nPlease see below.\n\n>\n> diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c\n> index f31d329..8d62bf9 100644\n> --- a/drivers/mmc/rockchip_sdhci.c\n> +++ b/drivers/mmc/rockchip_sdhci.c\n> @@ -9,7 +9,6 @@\n> #include \n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include \n> @@ -82,7 +81,7 @@ static int arasan_sdhci_ofdata_to_platdata(struct udevice *dev)\n> struct sdhci_host *host = dev_get_priv(dev);\n>\n> host->name = dev->name;\n> - host->ioaddr = devfdt_get_addr_ptr(dev);\n> + host->ioaddr = (void *)dev_read_addr(dev);\n\nCan you please add a dev_read_addr_ptr() ?\n\n> #endif\n>\n> return 0;\n> --\n> 2.1.4\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"THHijg96\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"CA32n1/k\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xffwQ2lQlz9t3w\n\tfor ;\n\tSun, 27 Aug 2017 00:06:46 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 2294AC22151; Sat, 26 Aug 2017 13:58:09 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 9806EC220F2;\n\tSat, 26 Aug 2017 13:57:31 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 1023BC220EB; Sat, 26 Aug 2017 13:40:33 +0000 (UTC)","from mail-qt0-f174.google.com (mail-qt0-f174.google.com\n\t[209.85.216.174])\n\tby lists.denx.de (Postfix) with ESMTPS id 75636C21EFC\n\tfor ; Sat, 26 Aug 2017 13:40:28 +0000 (UTC)","by mail-qt0-f174.google.com with SMTP id e2so9872293qta.0\n\tfor ; Sat, 26 Aug 2017 06:40:28 -0700 (PDT)","by 10.200.52.117 with HTTP; Sat, 26 Aug 2017 06:40:06 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=LRCUBBBGH9fBaCKtz4EoCOH0kPkH7QRxjvV4FkjUFS8=;\n\tb=THHijg96r73B5XyZtC3+pQPDGi8zZo1T4RicLc11denVusL2AgC4zIkAL9MhS8YruS\n\tiHkTrUhT5IwTv/kWAognJ6nGvnctv4oBsiFk6yJP7anvTcYjvxOK4P8GPfoMTLv0/OJB\n\tVstz+oc0UBfXTCegD9YULCNacq4T4pZRS0cQv0geYn1mCh/dLcbxZReid3Mo7AWHp0rn\n\tyOJXGlWWUnmPnw+LtrLZK3byuV1lR2Iy6R5Duu5qaAZ0BdRLhbkOLSrkytjogKB3zoc/\n\tTgMzDssF2D5u37sXpIuFV5T2+jEEP5dmFRCdNrFTyP6wKh2catbVg3aqhB70+97Q0rjh\n\t7NqQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=LRCUBBBGH9fBaCKtz4EoCOH0kPkH7QRxjvV4FkjUFS8=;\n\tb=CA32n1/k5+ABLjZCmKQozmCqVy3KPVRLWlzDb1aJ4wCqtwDttm0bHpKycN/UzlGAJQ\n\tJ10ANmPsYKzaxA6ctS/9PkNSM0LQH8xW3NqNntnSZObnbz3QCc7L4gR9ppP9GFxke+yL\n\tDw7TUiys5wTt36IXr5jlwz/R9nrXy3D7XwdRI="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=LRCUBBBGH9fBaCKtz4EoCOH0kPkH7QRxjvV4FkjUFS8=;\n\tb=skPaPmR5ExcEcINcJ9O/f5VQkjDQ1HYcvas+m7u3HWJc+r4LXfl3EwzElsqODg8Eh1\n\tmX1qGKyrJ+h9NheMPkc07UH2sAwahwV+vhESxiz49mpKpBmzZprqCtXO2bbXvER3WaNm\n\tKec1iJSbuHfsBNMPv1/XcFlIjhaeapgc6T67OVCCbsFwTHSvbwlskUtLGt+ztUCAs66z\n\tCXfYygLJqAJULR5eJTg8F8gon8f2duXn2XPhlMyvighkpaczzLDbPqJA4GadCbrgXLPH\n\t7qOockAf/KcdE2Ts2p698LMJ6SO/FGHPH2cu8k84wl0CIeG4jA8J/vG1MJzhiDF7vZcT\n\tFLig==","X-Gm-Message-State":"AHYfb5hpJMw/Keb9dZwAU5rZNN+DttWYILuw5vmuA+9xM5gCw5REuDHA\n\tzF0KgQ/0jTE6iGq9CqyamGUQDPXQBeKn","X-Google-Smtp-Source":"ADKCNb4mfOsoP/YuGrVhVHnScSP8oNArupDjzc/QNaySU5HfQbSlnjyd8RCTuys72r9hTw8hmlj0wNlYBbaAMroApFI=","X-Received":"by 10.200.24.139 with SMTP id s11mr2119261qtj.122.1503754827269; \n\tSat, 26 Aug 2017 06:40:27 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1502904758-7562-13-git-send-email-philipp.tomsich@theobroma-systems.com>","References":"<1502904758-7562-1-git-send-email-philipp.tomsich@theobroma-systems.com>\n\t<1502904758-7562-13-git-send-email-philipp.tomsich@theobroma-systems.com>","From":"Simon Glass ","Date":"Sat, 26 Aug 2017 07:40:06 -0600","X-Google-Sender-Auth":"WuFZHn_Tu0RBMegsa6lJiPcQi8k","Message-ID":"","To":"Philipp Tomsich ","Cc":"U-Boot Mailing List ,\n\tKlaus Goger ","Subject":"Re: [U-Boot] [PATCH 12/18] rockchip: sdhci: Convert to livetree","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]