[{"id":1750060,"web_url":"http://patchwork.ozlabs.org/comment/1750060/","msgid":"<20170817162957.fes3tu64onuiqspe@ninjato>","list_archive_url":null,"date":"2017-08-17T16:29:57","subject":"Re: [PATCH][i2c-next] i2c-cht-wc: make cht_wc_i2c_adap_driver static","submitter":{"id":22495,"url":"http://patchwork.ozlabs.org/api/people/22495/","name":"Wolfram Sang","email":"wsa@the-dreams.de"},"content":"On Wed, Aug 16, 2017 at 10:16:59AM +0100, Colin King wrote:\n> From: Colin Ian King \n> \n> The structure cht_wc_i2c_adap_driver is local to the source\n> and does not need to be in global scope, so make it static.\n> \n> Cleans up sparse warning:\n> symbol 'cht_wc_i2c_adap_driver' was not declared. Should it be static?\n> \n> Signed-off-by: Colin Ian King \n\nCCing Hans to ask him if he maybe wants to create a MAINTAINERS entry\nfor this driver, so he'll get CCed for such patches? :)\n\n> ---\n> drivers/i2c/busses/i2c-cht-wc.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c\n> index fe5caf70c7fe..01c94c918d4c 100644\n> --- a/drivers/i2c/busses/i2c-cht-wc.c\n> +++ b/drivers/i2c/busses/i2c-cht-wc.c\n> @@ -322,7 +322,7 @@ static struct platform_device_id cht_wc_i2c_adap_id_table[] = {\n> };\n> MODULE_DEVICE_TABLE(platform, cht_wc_i2c_adap_id_table);\n> \n> -struct platform_driver cht_wc_i2c_adap_driver = {\n> +static struct platform_driver cht_wc_i2c_adap_driver = {\n> \t.probe = cht_wc_i2c_adap_i2c_probe,\n> \t.remove = cht_wc_i2c_adap_i2c_remove,\n> \t.driver = {\n> -- \n> 2.11.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xYBWs3xD3z9t3G\n\tfor ;\n\tFri, 18 Aug 2017 02:30:01 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751850AbdHQQ37 (ORCPT );\n\tThu, 17 Aug 2017 12:29:59 -0400","from sauhun.de ([88.99.104.3]:60416 \"EHLO pokefinder.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751107AbdHQQ37 (ORCPT );\n\tThu, 17 Aug 2017 12:29:59 -0400","from localhost (p54B3365B.dip0.t-ipconnect.de [84.179.54.91])\n\tby pokefinder.org (Postfix) with ESMTPSA id AE37D2C348E;\n\tThu, 17 Aug 2017 18:29:57 +0200 (CEST)"],"Date":"Thu, 17 Aug 2017 18:29:57 +0200","From":"Wolfram Sang ","To":"Colin King ,\n\tHans de Goede ","Cc":"linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH][i2c-next] i2c-cht-wc: make cht_wc_i2c_adap_driver static","Message-ID":"<20170817162957.fes3tu64onuiqspe@ninjato>","References":"<20170816091659.10738-1-colin.king@canonical.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"pahcufooeqkrvjxi\"","Content-Disposition":"inline","In-Reply-To":"<20170816091659.10738-1-colin.king@canonical.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1759188,"web_url":"http://patchwork.ozlabs.org/comment/1759188/","msgid":"<20170829100941.ipn2zt4or7znee37@ninjato>","list_archive_url":null,"date":"2017-08-29T10:09:41","subject":"Re: [PATCH][i2c-next] i2c-cht-wc: make cht_wc_i2c_adap_driver static","submitter":{"id":22495,"url":"http://patchwork.ozlabs.org/api/people/22495/","name":"Wolfram Sang","email":"wsa@the-dreams.de"},"content":"On Wed, Aug 16, 2017 at 10:16:59AM +0100, Colin King wrote:\n> From: Colin Ian King \n> \n> The structure cht_wc_i2c_adap_driver is local to the source\n> and does not need to be in global scope, so make it static.\n> \n> Cleans up sparse warning:\n> symbol 'cht_wc_i2c_adap_driver' was not declared. Should it be static?\n> \n> Signed-off-by: Colin Ian King \n\nApplied to for-next, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhPWt5Bcyz9rxm\n\tfor ;\n\tTue, 29 Aug 2017 20:10:02 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751899AbdH2KJp (ORCPT );\n\tTue, 29 Aug 2017 06:09:45 -0400","from sauhun.de ([88.99.104.3]:43843 \"EHLO pokefinder.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751887AbdH2KJn (ORCPT );\n\tTue, 29 Aug 2017 06:09:43 -0400","from localhost (p54B33289.dip0.t-ipconnect.de [84.179.50.137])\n\tby pokefinder.org (Postfix) with ESMTPSA id 26FFE2C0524;\n\tTue, 29 Aug 2017 12:09:42 +0200 (CEST)"],"Date":"Tue, 29 Aug 2017 12:09:41 +0200","From":"Wolfram Sang ","To":"Colin King ","Cc":"linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH][i2c-next] i2c-cht-wc: make cht_wc_i2c_adap_driver static","Message-ID":"<20170829100941.ipn2zt4or7znee37@ninjato>","References":"<20170816091659.10738-1-colin.king@canonical.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"piib7iadrgtwifmq\"","Content-Disposition":"inline","In-Reply-To":"<20170816091659.10738-1-colin.king@canonical.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}}]