[{"id":1758037,"web_url":"http://patchwork.ozlabs.org/comment/1758037/","msgid":"","list_archive_url":null,"date":"2017-08-26T13:39:18","subject":"Re: [U-Boot] [PATCH 11/13] x86: braswell: Add FSP configuration","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 15 August 2017 at 23:42, Bin Meng wrote:\n> Add FSP related configuration for Braswell.\n>\n> Signed-off-by: Bin Meng \n> ---\n>\n> arch/x86/cpu/braswell/Makefile | 2 +-\n> arch/x86/cpu/braswell/fsp_configs.c | 158 ++++++++++++++\n> .../include/asm/arch-braswell/fsp/fsp_configs.h | 89 ++++++++\n> arch/x86/include/asm/arch-braswell/fsp/fsp_vpd.h | 172 +++++++++++++++\n> arch/x86/include/asm/arch-braswell/gpio.h | 234 +++++++++++++++++++++\n> 5 files changed, 654 insertions(+), 1 deletion(-)\n> create mode 100644 arch/x86/cpu/braswell/fsp_configs.c\n> create mode 100644 arch/x86/include/asm/arch-braswell/fsp/fsp_configs.h\n> create mode 100644 arch/x86/include/asm/arch-braswell/fsp/fsp_vpd.h\n> create mode 100644 arch/x86/include/asm/arch-braswell/gpio.h\n>\n\nReviewed-by: Simon Glass \n\nCan this use drivers instead of manual device-tree access?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"tS0/MRKP\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"AgG8yoXc\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xfftq2VxMz9t3w\n\tfor ;\n\tSun, 27 Aug 2017 00:05:23 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 1BD1AC2213E; Sat, 26 Aug 2017 13:57:16 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 18799C220EB;\n\tSat, 26 Aug 2017 13:57:14 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 84F43C22093; Sat, 26 Aug 2017 13:39:48 +0000 (UTC)","from mail-qt0-f177.google.com (mail-qt0-f177.google.com\n\t[209.85.216.177])\n\tby lists.denx.de (Postfix) with ESMTPS id 44CB7C22091\n\tfor ; Sat, 26 Aug 2017 13:39:40 +0000 (UTC)","by mail-qt0-f177.google.com with SMTP id d15so9764963qta.4\n\tfor ; Sat, 26 Aug 2017 06:39:40 -0700 (PDT)","by 10.200.52.117 with HTTP; Sat, 26 Aug 2017 06:39:18 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=JPqlZkWewaSpoL9IwjdVXlOKdQfR00UK+Nuyts0UcwA=;\n\tb=tS0/MRKPjjprnA0uKSjhPd+kVA230eGwTg41YGMSyHff/J0wgqn9B3NacStQo8W7FR\n\tPgy5WDXM+tY/CokLEeighhaSljHvZT3Q5UcTDshOI4D10w5+mr7yt6XEgQ8TY7nKuNWr\n\tbL0kLNpVCAcF7wj5MA2COtvIng/vD96OVckylz2Y0afgyXxZoEBF9klGZJ3fc7R+8rqh\n\tilQl88AB9v44yrcnXNkSsl8oIvsXPayKl4CZp2+NZUkameKS68xvRJmYzSYuQybdjcrn\n\tD9TLl2+CJW8KmD/Z+3oj0MFmFxE/5B32bPUXRwDvZE4RfXtB1UYT7QtSYhUJudsZb0Yc\n\tRNPQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=JPqlZkWewaSpoL9IwjdVXlOKdQfR00UK+Nuyts0UcwA=;\n\tb=AgG8yoXcovJtqQR1LYGBxI4DK8LXVBRVEC8asuAZTAE8SqyoQt/I0LFY/tChvaIksa\n\tWD3cTXW2OnJX2TpuOfgqCNzqK+/00mPmCjIvKutTQiNjYs8/Fu+ydFlaUHKhV8oOvhZy\n\tKkJ6KyOsoHiSoZR12+/DWG3iXnqwp4D1Ne2Cc="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=JPqlZkWewaSpoL9IwjdVXlOKdQfR00UK+Nuyts0UcwA=;\n\tb=UMige8Ca8cNjK+RaDUdgPZpyt3ICjTEQgEIogBe1wc20ETjI6hll2IsqjrwyDNUCEi\n\twF2QvF85eihiiHuF+yPFGQ5NyiLPIr1ICwLAOxB5gjDUQyllWrzDKR5iTzIuqwhBobB+\n\t6FZnjISBEgWgIlRAl6FOK2aDvob1WiMLqTt5vbX4a5G78ZMx559MnXnVZo8btB+SAk8Y\n\tOOAFMEc8gTCzO0UUHabP5h1uKvtlKTZUY0sf4ZUjqlgjOWvetvWMrZHVby6TJuFSGsVj\n\tIf0n09IGBPnO20FmHgsfqq0eS0KqUeC6Xvgq4d7e2cY+5Z0lAsOp5QKhSAzBN2qVI2Cl\n\tLj4Q==","X-Gm-Message-State":"AHYfb5hGMQWDCuNn1xYlWKxfDi8GkG17NrHal0ztOY8DXIFitEeHJG5U\n\tSzIYo2Sb9FY0FuxOykQYSUKpE19iRz9C","X-Google-Smtp-Source":"ADKCNb6XiprrLpEwHCWe4VSHBcDfW2kfb8yT4QRhJftp2eppovJfQoofwP4AUQ2vLCzI0QT52ex2iWIV/uBHsxNJ8Kc=","X-Received":"by 10.200.39.52 with SMTP id g49mr2516869qtg.137.1503754779025; \n\tSat, 26 Aug 2017 06:39:39 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1502862122-14771-12-git-send-email-bmeng.cn@gmail.com>","References":"<1502862122-14771-1-git-send-email-bmeng.cn@gmail.com>\n\t<1502862122-14771-12-git-send-email-bmeng.cn@gmail.com>","From":"Simon Glass ","Date":"Sat, 26 Aug 2017 07:39:18 -0600","X-Google-Sender-Auth":"_5aSgkjhI-47Gbxm6rCNo_UxkY0","Message-ID":"","To":"Bin Meng ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 11/13] x86: braswell: Add FSP configuration","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1758052,"web_url":"http://patchwork.ozlabs.org/comment/1758052/","msgid":"","list_archive_url":null,"date":"2017-08-26T13:56:11","subject":"Re: [U-Boot] [PATCH 11/13] x86: braswell: Add FSP configuration","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"content":"Hi Simon,\n\nOn Sat, Aug 26, 2017 at 9:39 PM, Simon Glass wrote:\n> On 15 August 2017 at 23:42, Bin Meng wrote:\n>> Add FSP related configuration for Braswell.\n>>\n>> Signed-off-by: Bin Meng \n>> ---\n>>\n>> arch/x86/cpu/braswell/Makefile | 2 +-\n>> arch/x86/cpu/braswell/fsp_configs.c | 158 ++++++++++++++\n>> .../include/asm/arch-braswell/fsp/fsp_configs.h | 89 ++++++++\n>> arch/x86/include/asm/arch-braswell/fsp/fsp_vpd.h | 172 +++++++++++++++\n>> arch/x86/include/asm/arch-braswell/gpio.h | 234 +++++++++++++++++++++\n>> 5 files changed, 654 insertions(+), 1 deletion(-)\n>> create mode 100644 arch/x86/cpu/braswell/fsp_configs.c\n>> create mode 100644 arch/x86/include/asm/arch-braswell/fsp/fsp_configs.h\n>> create mode 100644 arch/x86/include/asm/arch-braswell/fsp/fsp_vpd.h\n>> create mode 100644 arch/x86/include/asm/arch-braswell/gpio.h\n>>\n>\n> Reviewed-by: Simon Glass \n>\n> Can this use drivers instead of manual device-tree access?\n\nWhich part?\n\nRegards,\nBin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"qtMu5zBZ\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xfg442PTwz9t5W\n\tfor ;\n\tSun, 27 Aug 2017 00:13:24 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 1FB7DC221B6; Sat, 26 Aug 2017 14:08:26 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id ECC36C22171;\n\tSat, 26 Aug 2017 14:08:23 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 77C0AC220FB; Sat, 26 Aug 2017 13:56:12 +0000 (UTC)","from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65])\n\tby lists.denx.de (Postfix) with ESMTPS id 3EA59C220ED\n\tfor ; Sat, 26 Aug 2017 13:56:12 +0000 (UTC)","by mail-wm0-f65.google.com with SMTP id j72so2458480wmi.3\n\tfor ; Sat, 26 Aug 2017 06:56:12 -0700 (PDT)","by 10.223.135.121 with HTTP; Sat, 26 Aug 2017 06:56:11 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=4ne2bA11Zy2v4tB16UlKvnLRLTe3pyzmZYEKlyg2Kw8=;\n\tb=qtMu5zBZAa1fd6R8tRDI/2t7L+D/vJK+5ApkfPRrE0i3wMzVowoV8yTMVZub1LtMpf\n\trYzvRu2yXkf6XxMl+TafCxWfxYT8FRSUoYRD1hXVitW8CqqChqYuwVltZmF3/+gC39hO\n\tK4MHsMVtzRLVS8RC9aY7GmiWJ46qi+9cEI9LXqlDGl9VflGmYMntFgz2HZ+dmgOYBIaf\n\t4nUluXaGNV/ZeQN5/0O4nmDxINpj4LchlfgitGaVuCrtrtrpqIKmq0jkTIj1u7pEUAtz\n\tQVuWWsCdV4b7ogS6zqlMZj9VLOK+ye2iYY2zOxty3ZuGr+I5Jjp2sngf4kc9I+Q/Uid0\n\t2ULw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=4ne2bA11Zy2v4tB16UlKvnLRLTe3pyzmZYEKlyg2Kw8=;\n\tb=SQZO8wN1uoqjw5YBUQYPvzuADY/OeHG7x/mInwNLHUp7YNjfUAgHNWMNBW8qa1B985\n\tvQZxkQhwo33AnMWHd2bWSY3S842AKOdsX6DnJ078IGGm1PH8E9P34DMY0GL2u+1lXJSg\n\tXBausiL2+igCYwxgSowTnQW4fVq9vxtcW5+H0l3bzI2BwuWLFDJRnCAEEWO9jxvyQxod\n\t5EqDL0PuAy7Xj9XDzjUkuCPvlOICGrCq+DJv/AoNBif4sY1pQ5AejZjreGG9Feo4YTgz\n\t2rbhuoV0Ah+OHnT8sy1EjC+/I6R0VGd/4SMRDdb5zcXx/hs07y7UfNm+XEVNx/Fjo81b\n\tqSWw==","X-Gm-Message-State":"AHYfb5jKAHSRF9qxj8e03uAVYqhdbOjhr3wowkPl2M0dWdZ15awKCC/x\n\tm3ZZpwnRdtON3WVkZiKogkIFcMJ9Eg==","X-Received":"by 10.28.98.66 with SMTP id w63mr896019wmb.34.1503755771891; Sat,\n\t26 Aug 2017 06:56:11 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1502862122-14771-1-git-send-email-bmeng.cn@gmail.com>\n\t<1502862122-14771-12-git-send-email-bmeng.cn@gmail.com>\n\t","From":"Bin Meng ","Date":"Sat, 26 Aug 2017 21:56:11 +0800","Message-ID":"","To":"Simon Glass ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 11/13] x86: braswell: Add FSP configuration","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1758145,"web_url":"http://patchwork.ozlabs.org/comment/1758145/","msgid":"","list_archive_url":null,"date":"2017-08-26T22:39:50","subject":"Re: [U-Boot] [PATCH 11/13] x86: braswell: Add FSP configuration","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Bin,\n\nOn 26 August 2017 at 07:56, Bin Meng wrote:\n> Hi Simon,\n>\n> On Sat, Aug 26, 2017 at 9:39 PM, Simon Glass wrote:\n>> On 15 August 2017 at 23:42, Bin Meng wrote:\n>>> Add FSP related configuration for Braswell.\n>>>\n>>> Signed-off-by: Bin Meng \n>>> ---\n>>>\n>>> arch/x86/cpu/braswell/Makefile | 2 +-\n>>> arch/x86/cpu/braswell/fsp_configs.c | 158 ++++++++++++++\n>>> .../include/asm/arch-braswell/fsp/fsp_configs.h | 89 ++++++++\n>>> arch/x86/include/asm/arch-braswell/fsp/fsp_vpd.h | 172 +++++++++++++++\n>>> arch/x86/include/asm/arch-braswell/gpio.h | 234 +++++++++++++++++++++\n>>> 5 files changed, 654 insertions(+), 1 deletion(-)\n>>> create mode 100644 arch/x86/cpu/braswell/fsp_configs.c\n>>> create mode 100644 arch/x86/include/asm/arch-braswell/fsp/fsp_configs.h\n>>> create mode 100644 arch/x86/include/asm/arch-braswell/fsp/fsp_vpd.h\n>>> create mode 100644 arch/x86/include/asm/arch-braswell/gpio.h\n>>>\n>>\n>> Reviewed-by: Simon Glass \n>>\n>> Can this use drivers instead of manual device-tree access?\n>\n> Which part?\n\nWell you have intel,braswell-fsp for example. You could create a\ndriver with the two compatible strings and have it read the platdata\nfrom the DT in the ofdata_to_platdata() method.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"dGc9HJkn\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"TWIwT1Ga\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xftK73PtMz9sDB\n\tfor ;\n\tSun, 27 Aug 2017 08:40:26 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid C3CE8C22177; Sat, 26 Aug 2017 22:40:16 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id EFE7BC220FF;\n\tSat, 26 Aug 2017 22:40:13 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid EEFEAC220FF; Sat, 26 Aug 2017 22:40:12 +0000 (UTC)","from mail-qt0-f171.google.com (mail-qt0-f171.google.com\n\t[209.85.216.171])\n\tby lists.denx.de (Postfix) with ESMTPS id 5A4B3C220D3\n\tfor ; Sat, 26 Aug 2017 22:40:12 +0000 (UTC)","by mail-qt0-f171.google.com with SMTP id v29so12421225qtv.3\n\tfor ; Sat, 26 Aug 2017 15:40:12 -0700 (PDT)","by 10.200.52.117 with HTTP; Sat, 26 Aug 2017 15:39:50 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=VZ5wqJvLmwq8p+E5OoEwzZfjfKvyZUqudmfmenad/FA=;\n\tb=dGc9HJknjFnGBpAxeINCtXKnOsyLc0qTYfDyeO1GH78UZjOrWKX7B7Cs6w7a8C+9KE\n\tvIdHuPVD/XyXTQ2c99NFhDuzG8yDCvctokfFy/WYElgwVD2k23HCBU8BM4kjC7lCOM5o\n\txfETPHGzphE9TN/vsGf51AFo6r7UKtNLdomnDR3Evv5mYqZ8Y9utxCggd78cUEjj6+G1\n\tG220VRGhiIO1VE9zLuIONOgxRAImK8TFOnEWA3/PTmwoY1EQ74XDfxSKoi6doJn8vN3e\n\t5Wbu1TIjCDwX4Dsjgy4fnoytqAC76CZd3wadClCotqw6U8ft8Hy2BrEXbJJBhqmIapKb\n\tZJ9A==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=VZ5wqJvLmwq8p+E5OoEwzZfjfKvyZUqudmfmenad/FA=;\n\tb=TWIwT1Gah4C1PUJReKFePijDanVX19sM/sbTce8aD78C1rjOOnqG4atBEh6RiC81YI\n\tm7JSiEkmY4F2pXvoTirG0oMNp8Dukl5aSZKCF+ygay+fXPMu9KVGGikPQZfbdt0CertL\n\ttDnML3r7UVTPEHbXVI8fP4f9sdBIW4Ch1OdYo="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=VZ5wqJvLmwq8p+E5OoEwzZfjfKvyZUqudmfmenad/FA=;\n\tb=BAep4EMEqVYDet3A1oC2PKA/zBLjUBjIqF9wJh4N4d1SkmqatGBCKleAH5WS/7sKry\n\tivE7YMk1yXwPxsqUiXu/NwZaxmu9m3HwtdFOCcBpLuNc/WhZxAMrWO/CPe6sz1TK52t8\n\t7w8gwL3YC8bYYdi+xnyaZGtXjgyy0HAFOVQR1EEFUuyYxybkfnpDw1O9xFWPbytuksUm\n\tjKChVbGAzFw1Mqmzk3Iqm96LyhCbVSSNPKnwrf4q6cfIHg2GEt7lTuvLXLmCpe8UC19m\n\t/L6nZGmUPj8D4kaU9sXEIuajP1KuCVwAtvFIUy3EsCSPVsbzRoaJCCvOQU7qLczjKo0h\n\tw/SQ==","X-Gm-Message-State":"AHYfb5i9KJH7bWIfvU2fh0M5vGlJn44wm7goZtK8GSDX63RfRaJAiIQL\n\tpGkriQlVw/Lm44xHHA1Fawqjkf14rLkP","X-Google-Smtp-Source":"ADKCNb6+tGZAxRf80oLmOn34imf3uioZcYTfY6dljJW/bTfIOPE52/CGaqvq/+tUtInIM9O98FzXh7UTliJsPtc34KM=","X-Received":"by 10.200.39.52 with SMTP id g49mr4244378qtg.137.1503787210865; \n\tSat, 26 Aug 2017 15:40:10 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1502862122-14771-1-git-send-email-bmeng.cn@gmail.com>\n\t<1502862122-14771-12-git-send-email-bmeng.cn@gmail.com>\n\t\n\t","From":"Simon Glass ","Date":"Sat, 26 Aug 2017 16:39:50 -0600","X-Google-Sender-Auth":"ZdknlXMpME4a-eALEb6pe0znR50","Message-ID":"","To":"Bin Meng ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 11/13] x86: braswell: Add FSP configuration","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1758178,"web_url":"http://patchwork.ozlabs.org/comment/1758178/","msgid":"","list_archive_url":null,"date":"2017-08-27T00:10:09","subject":"Re: [U-Boot] [PATCH 11/13] x86: braswell: Add FSP configuration","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"content":"Hi Simon,\n\nOn Sun, Aug 27, 2017 at 6:39 AM, Simon Glass wrote:\n> Hi Bin,\n>\n> On 26 August 2017 at 07:56, Bin Meng wrote:\n>> Hi Simon,\n>>\n>> On Sat, Aug 26, 2017 at 9:39 PM, Simon Glass wrote:\n>>> On 15 August 2017 at 23:42, Bin Meng wrote:\n>>>> Add FSP related configuration for Braswell.\n>>>>\n>>>> Signed-off-by: Bin Meng \n>>>> ---\n>>>>\n>>>> arch/x86/cpu/braswell/Makefile | 2 +-\n>>>> arch/x86/cpu/braswell/fsp_configs.c | 158 ++++++++++++++\n>>>> .../include/asm/arch-braswell/fsp/fsp_configs.h | 89 ++++++++\n>>>> arch/x86/include/asm/arch-braswell/fsp/fsp_vpd.h | 172 +++++++++++++++\n>>>> arch/x86/include/asm/arch-braswell/gpio.h | 234 +++++++++++++++++++++\n>>>> 5 files changed, 654 insertions(+), 1 deletion(-)\n>>>> create mode 100644 arch/x86/cpu/braswell/fsp_configs.c\n>>>> create mode 100644 arch/x86/include/asm/arch-braswell/fsp/fsp_configs.h\n>>>> create mode 100644 arch/x86/include/asm/arch-braswell/fsp/fsp_vpd.h\n>>>> create mode 100644 arch/x86/include/asm/arch-braswell/gpio.h\n>>>>\n>>>\n>>> Reviewed-by: Simon Glass \n>>>\n>>> Can this use drivers instead of manual device-tree access?\n>>\n>> Which part?\n>\n> Well you have intel,braswell-fsp for example. You could create a\n> driver with the two compatible strings and have it read the platdata\n> from the DT in the ofdata_to_platdata() method.\n\nI thought this before. We discussed the possibility of adding a new\nFSP uclass long time ago. When I added the Braswell support, I wanted\nto have a try since Braswell's FSP is v1.1 spec complaint and if we\nhave a uclass for FSP we can put the common stuff in the uclass\ndriver. But in the end I did not do it because:\n\n1. FSP's initialization sequence is just a one time initialization and\nwe don't do anything after the initialization completes.\n2. Making a uclass for FSP means we have to delay fsp_init() to after\ninitf_dm().But after fsp_init(), we will return to board_init_f()\nagain and do the initialization for the second time. So all previous\nplatdata of FSP that is set up by DM gets lost during this process.\n3. There are some other architecture-dependent stuff in the\narch_fsp_init() that is not suitable to be put in a FSP driver.\n\nRegards,\nBin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"VXg64DxT\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xfwJq1zxpz9sDB\n\tfor ;\n\tSun, 27 Aug 2017 10:10:19 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 05D1AC22179; Sun, 27 Aug 2017 00:10:14 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 5875DC22179;\n\tSun, 27 Aug 2017 00:10:12 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid B8DE4C221F7; Sun, 27 Aug 2017 00:10:10 +0000 (UTC)","from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65])\n\tby lists.denx.de (Postfix) with ESMTPS id 630C2C22179\n\tfor ; Sun, 27 Aug 2017 00:10:10 +0000 (UTC)","by mail-wm0-f65.google.com with SMTP id t201so189750wmt.5\n\tfor ; Sat, 26 Aug 2017 17:10:10 -0700 (PDT)","by 10.223.135.121 with HTTP; Sat, 26 Aug 2017 17:10:09 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=U+XUwjILT+JK0a7ScbtfpORdlM/1jGAuWWXWitP56ZU=;\n\tb=VXg64DxTIhFf1kQcFIKcCEG7TtpBJ3nQjocidAjhW9WJjD34BaFjYTNaGuo4lMN61c\n\tp6GKjuwIijqO2AYK8Ua4z22iHHRyhTcLqvbaOUXoWF5X/nCa71w1W9xYn2ds1mMJ4WdH\n\t3ecE8IoCnpnjYA6mpCejm6M+Gq9tFfoPdOfdJLKLFsXRK3Z/HnTyA2OhuB4x6yMbUJN3\n\trurNZ1g8UN5dfFvBPs0/CfVhm7TCEhMh+1gWL2uUeQIxJWbleHu1GfV5xg0umhWsPB0a\n\t5jFik2ffhlBuq5eigu0Ki7TFqpViayjTWz5bze4U6AjLkWVa2qh/pwQ0Q6R0pgmdbEzI\n\to7ag==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=U+XUwjILT+JK0a7ScbtfpORdlM/1jGAuWWXWitP56ZU=;\n\tb=SwK7y2y7wdlxB5OPkuXmKx+ruD2tbNQERePUxL64A9Y/CtmPGIOfugReeFa+NkGbZy\n\tpDDlaYmz9hSizOL3QrWWDXFcAsSMS4KEAYpdORGuNBbsJVPzfh5GPMEW/uTTqzYMW2Ie\n\ttV7DUrvzlTJccJE1FX3BoGqzJC3pYWTFT9bexYdtqyNZe3yGqT15XqQF92tbXfuX/kCq\n\tkLztQ6qrbjWlKg22hlZOkMA3iUjF4Dgz3TeyjhKmw/3EU2PTViAbvHMGHow4QUCzCqtn\n\tB2YFAU/zYV8nAbD/0DyMKtjudQAtB9iSRtFsBuazA0OKZ1yH+pQjuGYBO7w9n54MoKE0\n\tVguQ==","X-Gm-Message-State":"AHYfb5hyllifEydo6VsfUmAiuHbU48U6XEvDwrvF5KaS0SLYXwSRuHkK\n\tId8S18swfrPKGOyq8BkGcGmi/fyYgg==","X-Received":"by 10.28.74.218 with SMTP id n87mr1669867wmi.137.1503792609922; \n\tSat, 26 Aug 2017 17:10:09 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1502862122-14771-1-git-send-email-bmeng.cn@gmail.com>\n\t<1502862122-14771-12-git-send-email-bmeng.cn@gmail.com>\n\t\n\t\n\t","From":"Bin Meng ","Date":"Sun, 27 Aug 2017 08:10:09 +0800","Message-ID":"","To":"Simon Glass ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 11/13] x86: braswell: Add FSP configuration","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1763775,"web_url":"http://patchwork.ozlabs.org/comment/1763775/","msgid":"","list_archive_url":null,"date":"2017-09-06T01:39:36","subject":"Re: [U-Boot] [PATCH 11/13] x86: braswell: Add FSP configuration","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Bin,\n\nOn 26 August 2017 at 18:10, Bin Meng wrote:\n> Hi Simon,\n>\n> On Sun, Aug 27, 2017 at 6:39 AM, Simon Glass wrote:\n>> Hi Bin,\n>>\n>> On 26 August 2017 at 07:56, Bin Meng wrote:\n>>> Hi Simon,\n>>>\n>>> On Sat, Aug 26, 2017 at 9:39 PM, Simon Glass wrote:\n>>>> On 15 August 2017 at 23:42, Bin Meng wrote:\n>>>>> Add FSP related configuration for Braswell.\n>>>>>\n>>>>> Signed-off-by: Bin Meng \n>>>>> ---\n>>>>>\n>>>>> arch/x86/cpu/braswell/Makefile | 2 +-\n>>>>> arch/x86/cpu/braswell/fsp_configs.c | 158 ++++++++++++++\n>>>>> .../include/asm/arch-braswell/fsp/fsp_configs.h | 89 ++++++++\n>>>>> arch/x86/include/asm/arch-braswell/fsp/fsp_vpd.h | 172 +++++++++++++++\n>>>>> arch/x86/include/asm/arch-braswell/gpio.h | 234 +++++++++++++++++++++\n>>>>> 5 files changed, 654 insertions(+), 1 deletion(-)\n>>>>> create mode 100644 arch/x86/cpu/braswell/fsp_configs.c\n>>>>> create mode 100644 arch/x86/include/asm/arch-braswell/fsp/fsp_configs.h\n>>>>> create mode 100644 arch/x86/include/asm/arch-braswell/fsp/fsp_vpd.h\n>>>>> create mode 100644 arch/x86/include/asm/arch-braswell/gpio.h\n>>>>>\n>>>>\n>>>> Reviewed-by: Simon Glass \n>>>>\n>>>> Can this use drivers instead of manual device-tree access?\n>>>\n>>> Which part?\n>>\n>> Well you have intel,braswell-fsp for example. You could create a\n>> driver with the two compatible strings and have it read the platdata\n>> from the DT in the ofdata_to_platdata() method.\n>\n> I thought this before. We discussed the possibility of adding a new\n> FSP uclass long time ago. When I added the Braswell support, I wanted\n> to have a try since Braswell's FSP is v1.1 spec complaint and if we\n> have a uclass for FSP we can put the common stuff in the uclass\n> driver. But in the end I did not do it because:\n>\n> 1. FSP's initialization sequence is just a one time initialization and\n> we don't do anything after the initialization completes.\n\nThat's not a very good reason though. There will be several drivers like that.\n\n> 2. Making a uclass for FSP means we have to delay fsp_init() to after\n> initf_dm().But after fsp_init(), we will return to board_init_f()\n> again and do the initialization for the second time. So all previous\n> platdata of FSP that is set up by DM gets lost during this process.\n\nYes, although this is in the nature of the broken FSP API that we hope\nIntel will fix. As I understand it we already do the init twice, this\nis just a case of knowing what stage we are at.\n\n> 3. There are some other architecture-dependent stuff in the\n> arch_fsp_init() that is not suitable to be put in a FSP driver.\n\nBut I am suggesting having a driver specific to the arch, not a\ngeneric one, so this should not be a problem.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"F/lkiuMg\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"PJ9/5P1u\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xn5r44SJfz9sNc\n\tfor ;\n\tWed, 6 Sep 2017 11:40:20 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 3EF26C21E72; Wed, 6 Sep 2017 01:40:16 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 36A76C21D94;\n\tWed, 6 Sep 2017 01:40:15 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 92332C21E8E; Wed, 6 Sep 2017 01:40:01 +0000 (UTC)","from mail-qt0-f178.google.com (mail-qt0-f178.google.com\n\t[209.85.216.178])\n\tby lists.denx.de (Postfix) with ESMTPS id 30BA3C21E0A\n\tfor ; Wed, 6 Sep 2017 01:39:58 +0000 (UTC)","by mail-qt0-f178.google.com with SMTP id h15so16527080qta.4\n\tfor ; Tue, 05 Sep 2017 18:39:58 -0700 (PDT)","by 10.200.28.108 with HTTP; Tue, 5 Sep 2017 18:39:36 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=3eZdtbQ0Hm95lW8OQrOnTkbgOuL18LR7tdYxGXqUar8=;\n\tb=F/lkiuMgmZWmtk8luEnOmqHUWxxiKqvbxBrsrB3LIphsMhos4p4rqFJ44y7+eX5RTu\n\tQXBUhY9j/u0X3m3WYRH/RmLgpaWEoUpbo4eaCIkhO6Hnka4mCYDzoCDtXEXC/JKdNWCT\n\tDp+hya3S2sVHkVTsfjTaS0ozH3WeBmMPDurMjb8sz3/mMEEgbpkNAGsc0F1ZYLgvi1ri\n\t+zJUHh0TKUqP7BKXk072iv1tTP40ETOpHNAJsiT7wxvk0afBF6VI2fRk+JGD8rP536NF\n\t+QiQHcehe5HZD12lMrHqD649IVqehgBwzZ9sukssSUMDK9z5zk9+KTLj9t/gxjSSEKKX\n\trQnw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=3eZdtbQ0Hm95lW8OQrOnTkbgOuL18LR7tdYxGXqUar8=;\n\tb=PJ9/5P1uQhvqSMc1oTPbaIMEF7oAnbYoUxnZ5MUQc+uxDQ6rU4KI5PJYeC94gUulCA\n\tfiTF1Rt4DoEh15WeozZOS3G6FrNFt0SG3aPTomDOSEcSkA/gh8GJ7w7v6KTMe5rGr6kz\n\t9xNpD+FnyLaMZWTCxYmroWyYmBZxpxZ2JBOQA="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=3eZdtbQ0Hm95lW8OQrOnTkbgOuL18LR7tdYxGXqUar8=;\n\tb=icJlhTVLLeFugXY4iKKFX3/9yt93AN9xt6qB/03dk3wfCKy9pZCnjmOFqdWqGuv99J\n\tVPH0DULolM7pnfklYwk2LbBIpwOh08TQ2N2IN5Y7sjQC5uXzgDJUMObA1D3iPYwp3ZU0\n\tsBdtGE12+qJYZT5h0xZMR2eq+aEeGcG9vbyj2y8gioX7zZISh4z7A4N12m6Ix3qm7H9D\n\tS9HmT2RDUIWgoeBx9o9iryiNY32XIF2pYsLwzznky9wPweM/A8CxSZ+f+DgS6WrDBRj5\n\tHHzcE2vaGIhuP0a4vXWhICXN3EPjW8F26R8rMembybr44VJa+U+FK1bJRGW+A1gdD146\n\tuoGQ==","X-Gm-Message-State":"AHPjjUjhnYnmbxdl6dbSyd0U5qStaGaO0d8uYGgQpH4Be0qy5bC6sSEp\n\tT7VpK/Pzvl6KLau8tFCA4bc3ZOYdioc5","X-Google-Smtp-Source":"ADKCNb691Sa3qTNXlgkH4B9WWcpQZlIeILhinE2cNw+xVCszZOwCauB1QjoHnobosRnamsLfn59lmUcqziFDjNya8KQ=","X-Received":"by 10.200.53.67 with SMTP id z3mr1488055qtb.145.1504661996868;\n\tTue, 05 Sep 2017 18:39:56 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1502862122-14771-1-git-send-email-bmeng.cn@gmail.com>\n\t<1502862122-14771-12-git-send-email-bmeng.cn@gmail.com>\n\t\n\t\n\t\n\t","From":"Simon Glass ","Date":"Tue, 5 Sep 2017 19:39:36 -0600","X-Google-Sender-Auth":"kZ_cSsc1JfH66OXJbxsugfK8UaE","Message-ID":"","To":"Bin Meng ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 11/13] x86: braswell: Add FSP configuration","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1767160,"web_url":"http://patchwork.ozlabs.org/comment/1767160/","msgid":"","list_archive_url":null,"date":"2017-09-12T15:20:19","subject":"Re: [U-Boot] [PATCH 11/13] x86: braswell: Add FSP configuration","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"content":"Hi Simon,\n\nOn Wed, Sep 6, 2017 at 9:39 AM, Simon Glass wrote:\n> Hi Bin,\n>\n> On 26 August 2017 at 18:10, Bin Meng wrote:\n>> Hi Simon,\n>>\n>> On Sun, Aug 27, 2017 at 6:39 AM, Simon Glass wrote:\n>>> Hi Bin,\n>>>\n>>> On 26 August 2017 at 07:56, Bin Meng wrote:\n>>>> Hi Simon,\n>>>>\n>>>> On Sat, Aug 26, 2017 at 9:39 PM, Simon Glass wrote:\n>>>>> On 15 August 2017 at 23:42, Bin Meng wrote:\n>>>>>> Add FSP related configuration for Braswell.\n>>>>>>\n>>>>>> Signed-off-by: Bin Meng \n>>>>>> ---\n>>>>>>\n>>>>>> arch/x86/cpu/braswell/Makefile | 2 +-\n>>>>>> arch/x86/cpu/braswell/fsp_configs.c | 158 ++++++++++++++\n>>>>>> .../include/asm/arch-braswell/fsp/fsp_configs.h | 89 ++++++++\n>>>>>> arch/x86/include/asm/arch-braswell/fsp/fsp_vpd.h | 172 +++++++++++++++\n>>>>>> arch/x86/include/asm/arch-braswell/gpio.h | 234 +++++++++++++++++++++\n>>>>>> 5 files changed, 654 insertions(+), 1 deletion(-)\n>>>>>> create mode 100644 arch/x86/cpu/braswell/fsp_configs.c\n>>>>>> create mode 100644 arch/x86/include/asm/arch-braswell/fsp/fsp_configs.h\n>>>>>> create mode 100644 arch/x86/include/asm/arch-braswell/fsp/fsp_vpd.h\n>>>>>> create mode 100644 arch/x86/include/asm/arch-braswell/gpio.h\n>>>>>>\n>>>>>\n>>>>> Reviewed-by: Simon Glass \n>>>>>\n>>>>> Can this use drivers instead of manual device-tree access?\n>>>>\n>>>> Which part?\n>>>\n>>> Well you have intel,braswell-fsp for example. You could create a\n>>> driver with the two compatible strings and have it read the platdata\n>>> from the DT in the ofdata_to_platdata() method.\n>>\n>> I thought this before. We discussed the possibility of adding a new\n>> FSP uclass long time ago. When I added the Braswell support, I wanted\n>> to have a try since Braswell's FSP is v1.1 spec complaint and if we\n>> have a uclass for FSP we can put the common stuff in the uclass\n>> driver. But in the end I did not do it because:\n>>\n>> 1. FSP's initialization sequence is just a one time initialization and\n>> we don't do anything after the initialization completes.\n>\n> That's not a very good reason though. There will be several drivers like that.\n>\n>> 2. Making a uclass for FSP means we have to delay fsp_init() to after\n>> initf_dm().But after fsp_init(), we will return to board_init_f()\n>> again and do the initialization for the second time. So all previous\n>> platdata of FSP that is set up by DM gets lost during this process.\n>\n> Yes, although this is in the nature of the broken FSP API that we hope\n> Intel will fix. As I understand it we already do the init twice, this\n> is just a case of knowing what stage we are at.\n>\n\nBut DM initialization is unnecessary to get FSP run. This will lead\nlonger boot time.\n\n>> 3. There are some other architecture-dependent stuff in the\n>> arch_fsp_init() that is not suitable to be put in a FSP driver.\n>\n> But I am suggesting having a driver specific to the arch, not a\n> generic one, so this should not be a problem.\n\nI mean there will be some non-FSP driver stuff (eg: MRC cache, ACPI\nS3) in the FSP driver, which doesn't look very good IMO.\n\nRegards,\nBin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CMWShU1L\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs7lk4PHlz9sRg\n\tfor ;\n\tWed, 13 Sep 2017 01:20:33 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 1E2BBC22167; Tue, 12 Sep 2017 15:20:25 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 2F0E0C21F9E;\n\tTue, 12 Sep 2017 15:20:23 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 0B957C21F9E; Tue, 12 Sep 2017 15:20:20 +0000 (UTC)","from mail-wm0-f67.google.com (mail-wm0-f67.google.com\n\t[74.125.82.67])\n\tby lists.denx.de (Postfix) with ESMTPS id AD5EEC21F92\n\tfor ; Tue, 12 Sep 2017 15:20:20 +0000 (UTC)","by mail-wm0-f67.google.com with SMTP id x17so9220626wmd.5\n\tfor ; Tue, 12 Sep 2017 08:20:20 -0700 (PDT)","by 10.223.135.121 with HTTP; Tue, 12 Sep 2017 08:20:19 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=jdAQjfn4y3JDA4j+D0Qo4SJvvhTzQhLvaAPeJuINkXs=;\n\tb=CMWShU1LV9flWBmw2ktyWgqSYslE3RKw6emOqOSBJbCgJdcxZfNgMB6QDF7DQjDTr5\n\ti/c73kMJeqpvPNmIELbZSnOqPCK5I6I2QFcSqv6XkI/iIqGG01RaJt0y3ZoHrYVUi6IM\n\tAUNDTjYJB6uKzcMkDmApWi6u6mIPIaHFKxg9lOLlXZzeFS09rgQF2qhxkqtTecODWagh\n\twEt36hxvQxVO8LS6yIPdVOnbm5KCTcr7ydoaPe8VEXXzgb8rsv1m50/+1KFTSxQHCZKM\n\t2pGyi5I/KbFolQlSGrRCM1amS24LIbJdo/5ecFqIT9ekDNR+kwqEheqKzdMFrGnUUYqJ\n\tdCRg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=jdAQjfn4y3JDA4j+D0Qo4SJvvhTzQhLvaAPeJuINkXs=;\n\tb=EtwzhdcAbAVQW8TPnzRDcEuP+b+7ngObpk+JO/3Z1ils9Pjk6KnpDkiH1ua3lgoV+X\n\t0iiLHbflkDbhADL2LpL4gbPLqOsOeSrPdf+ox/GnLUrEjQZUExV6d29T2h1vzlXQEubc\n\tOun1nRKEgmEdmchWB1DYjZxXPuF54orozDdEnfJnwpNIuNr1ELLJ+aBym6P4xynf6Pmp\n\toHtQ7sGBF5wYW0s35kD7fiKndB0CofKgImG/iQqRF9ZVIn9b70YUPaRbNq93Y+pM7DJP\n\tC9fU/6f0/gbiVTnNBurjDIdaRqLfK9oi0FouyB1MXGc0bvxpDAvt8gl8Maibqc6+pmlk\n\t7duw==","X-Gm-Message-State":"AHPjjUiomVZ8FVTcwPfDTdEJBn+YeYgud11F0ucnaMGVbyA3vKbymiyW\n\tx+ltY5E1WD7VtDNFiJIlMHCctkKlRg==","X-Google-Smtp-Source":"AOwi7QCXvMCwZSPCEis3u/NR7RowHEUUawbhEIug6VtCoYmdSOPBkpuByFZRMIVNwxkxrmVu4BQAhIC65zqP9VDrJHw=","X-Received":"by 10.28.218.141 with SMTP id r135mr174353wmg.63.1505229620248; \n\tTue, 12 Sep 2017 08:20:20 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1502862122-14771-1-git-send-email-bmeng.cn@gmail.com>\n\t<1502862122-14771-12-git-send-email-bmeng.cn@gmail.com>\n\t\n\t\n\t\n\t\n\t","From":"Bin Meng ","Date":"Tue, 12 Sep 2017 23:20:19 +0800","Message-ID":"","To":"Simon Glass ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 11/13] x86: braswell: Add FSP configuration","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1767502,"web_url":"http://patchwork.ozlabs.org/comment/1767502/","msgid":"","list_archive_url":null,"date":"2017-09-13T02:31:32","subject":"Re: [U-Boot] [PATCH 11/13] x86: braswell: Add FSP configuration","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Bin,\n\nOn 12 September 2017 at 09:20, Bin Meng wrote:\n> Hi Simon,\n>\n> On Wed, Sep 6, 2017 at 9:39 AM, Simon Glass wrote:\n>> Hi Bin,\n>>\n>> On 26 August 2017 at 18:10, Bin Meng wrote:\n>>> Hi Simon,\n>>>\n>>> On Sun, Aug 27, 2017 at 6:39 AM, Simon Glass wrote:\n>>>> Hi Bin,\n>>>>\n>>>> On 26 August 2017 at 07:56, Bin Meng wrote:\n>>>>> Hi Simon,\n>>>>>\n>>>>> On Sat, Aug 26, 2017 at 9:39 PM, Simon Glass wrote:\n>>>>>> On 15 August 2017 at 23:42, Bin Meng wrote:\n>>>>>>> Add FSP related configuration for Braswell.\n>>>>>>>\n>>>>>>> Signed-off-by: Bin Meng \n>>>>>>> ---\n>>>>>>>\n>>>>>>> arch/x86/cpu/braswell/Makefile | 2 +-\n>>>>>>> arch/x86/cpu/braswell/fsp_configs.c | 158 ++++++++++++++\n>>>>>>> .../include/asm/arch-braswell/fsp/fsp_configs.h | 89 ++++++++\n>>>>>>> arch/x86/include/asm/arch-braswell/fsp/fsp_vpd.h | 172 +++++++++++++++\n>>>>>>> arch/x86/include/asm/arch-braswell/gpio.h | 234 +++++++++++++++++++++\n>>>>>>> 5 files changed, 654 insertions(+), 1 deletion(-)\n>>>>>>> create mode 100644 arch/x86/cpu/braswell/fsp_configs.c\n>>>>>>> create mode 100644 arch/x86/include/asm/arch-braswell/fsp/fsp_configs.h\n>>>>>>> create mode 100644 arch/x86/include/asm/arch-braswell/fsp/fsp_vpd.h\n>>>>>>> create mode 100644 arch/x86/include/asm/arch-braswell/gpio.h\n>>>>>>>\n>>>>>>\n>>>>>> Reviewed-by: Simon Glass \n>>>>>>\n>>>>>> Can this use drivers instead of manual device-tree access?\n>>>>>\n>>>>> Which part?\n>>>>\n>>>> Well you have intel,braswell-fsp for example. You could create a\n>>>> driver with the two compatible strings and have it read the platdata\n>>>> from the DT in the ofdata_to_platdata() method.\n>>>\n>>> I thought this before. We discussed the possibility of adding a new\n>>> FSP uclass long time ago. When I added the Braswell support, I wanted\n>>> to have a try since Braswell's FSP is v1.1 spec complaint and if we\n>>> have a uclass for FSP we can put the common stuff in the uclass\n>>> driver. But in the end I did not do it because:\n>>>\n>>> 1. FSP's initialization sequence is just a one time initialization and\n>>> we don't do anything after the initialization completes.\n>>\n>> That's not a very good reason though. There will be several drivers like that.\n>>\n>>> 2. Making a uclass for FSP means we have to delay fsp_init() to after\n>>> initf_dm().But after fsp_init(), we will return to board_init_f()\n>>> again and do the initialization for the second time. So all previous\n>>> platdata of FSP that is set up by DM gets lost during this process.\n>>\n>> Yes, although this is in the nature of the broken FSP API that we hope\n>> Intel will fix. As I understand it we already do the init twice, this\n>> is just a case of knowing what stage we are at.\n>>\n>\n> But DM initialization is unnecessary to get FSP run. This will lead\n> longer boot time.\n\nLooking at the init sequence in board_f(), we have fsp_init() quite early:\n\n#if defined(CONFIG_HAVE_FSP)\narch_fsp_init,\n#endif\narch_cpu_init, /* basic arch cpu dependent setup */\nmach_cpu_init, /* SoC/machine dependent CPU setup */\ninitf_dm,\narch_cpu_init_dm,\n\nI still feel that ultimately FSP should be a driver (and should happen\nbefore arch_cpu_init_dm(), and that this should not affect boot time\n(since we need to do DM init at some point), but I think this needs\nmore investigation. We would need to first empty out arch_cpu_init()\nand march_cpu_init().\n\nSo for now, let's leave it as is.\n\n>\n>>> 3. There are some other architecture-dependent stuff in the\n>>> arch_fsp_init() that is not suitable to be put in a FSP driver.\n>>\n>> But I am suggesting having a driver specific to the arch, not a\n>> generic one, so this should not be a problem.\n>\n> I mean there will be some non-FSP driver stuff (eg: MRC cache, ACPI\n> S3) in the FSP driver, which doesn't look very good IMO.\n\nWell given the nature of FSP (whole platform init) I think this is\nfine. The FSP driver can call out to common code or pull in other\ndrivers as needed.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"eNrCgf33\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"UAs1x/+5\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsR5z6sv8z9t30\n\tfor ;\n\tWed, 13 Sep 2017 12:52:23 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid AC562C22412; Wed, 13 Sep 2017 02:49:12 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id EA78FC2230F;\n\tWed, 13 Sep 2017 02:49:09 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid D3763C22423; Wed, 13 Sep 2017 02:31:58 +0000 (UTC)","from mail-qt0-f173.google.com (mail-qt0-f173.google.com\n\t[209.85.216.173])\n\tby lists.denx.de (Postfix) with ESMTPS id 8E9FAC22361\n\tfor ; Wed, 13 Sep 2017 02:31:54 +0000 (UTC)","by mail-qt0-f173.google.com with SMTP id i50so29699395qtf.0\n\tfor ; Tue, 12 Sep 2017 19:31:54 -0700 (PDT)","by 10.200.37.200 with HTTP; Tue, 12 Sep 2017 19:31:32 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=hc0LZsXC8iFnWDnu0ufuhISvmBBJ00jQOJ7cxrLlZrA=;\n\tb=eNrCgf33cjRVOC0qypvw/6joVv+lIMqPCLarR/XZk1IGoY43IZ/odS5KObJF49d+WZ\n\tBtNjkOx8h+sYfSuwld2ozggS14VOHBTIGawiayP0FtAZLe0J8xgy2pjG7ChySXIpAjIf\n\tvha5d1t/qBSGHa1ltb1R13JlQcM1l/tiQg+vd6LNbgXtgxxR/2hKEGkvVOw7ksHvMICJ\n\t1dtP2CXgvOT4KlLOS1AddMMof+vYTlEqOTMarZlUvVq8C0J3i3h121PDQMqu1AqCvpfU\n\ttmPhgM0oQxAm0zuLomixHm8VojZgqE8fQDdUazTHbtOZO2uxdy4eryk1SDHilprmTKJK\n\tc5VA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=hc0LZsXC8iFnWDnu0ufuhISvmBBJ00jQOJ7cxrLlZrA=;\n\tb=UAs1x/+5mdM63a/ASep/Z28lhvucNC5S/6RSRQ5QUrLHoZM33cenjl2spyUPRgLkFf\n\tHhHrI6Jqz9lO3L6q9/ZM8/nSrLWjp1lE2/vvF7lTCTjwo8mLXbVvy6SiRPRy5NZ7Db31\n\ty8Px7n5upxh0eouu9WE/Oq1pa3I0fpPjWYazo="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=hc0LZsXC8iFnWDnu0ufuhISvmBBJ00jQOJ7cxrLlZrA=;\n\tb=VS+eOT1KA8ldxQkaRPzHPsVW1h3tROQYOovBJxuAhcE7MxN/tl+Rknm/f4CP3K43ho\n\tWeTlLFskR8bo44dvGmhtCkhdoKxM9o831KH4YkhO3THFnub+A6gSXrA2GM2tSEbYEQ6R\n\tH9Msc8WrRJLCfhxz3FePDOC/q4bMuJyP2SR6PPKYLXTT/tGMZupUObss0WQK3oRpauAk\n\tGGzPJm7ZbFPKNCVJGXULefJBC8P3OEa/OFQz706rdW6pvucMABEbQ/+57/DxcFBOlpk2\n\taJQ/q3gkARcGuZRE5bPwUwwnajvfD6sf6mVoUHYCAqqaErnPbbxvorNxc7h7CCcZBAbf\n\tOHlw==","X-Gm-Message-State":"AHPjjUhaGmVxNwks5HCiKiiojI3ufJ48+IfjTYfmwDbKKecPca8XpI4w\n\tYUTIKAKeOY9ngWLIgtTR81zb2aPo0ylFP6ue4XWa1A==","X-Google-Smtp-Source":"AOwi7QDw5+lWBifDQ01DYBYnklifLAmu0AK5U+kx2kGv8OBiAhW10IvKCem+aBTvJtVuQHP7lAf7JsUktEQSHKCy4gc=","X-Received":"by 10.237.37.182 with SMTP id x51mr23370665qtc.5.1505269913052; \n\tTue, 12 Sep 2017 19:31:53 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1502862122-14771-1-git-send-email-bmeng.cn@gmail.com>\n\t<1502862122-14771-12-git-send-email-bmeng.cn@gmail.com>\n\t\n\t\n\t\n\t\n\t\n\t","From":"Simon Glass ","Date":"Tue, 12 Sep 2017 20:31:32 -0600","X-Google-Sender-Auth":"hER7P71PSMl19-dFA8adnwSdvsA","Message-ID":"","To":"Bin Meng ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 11/13] x86: braswell: Add FSP configuration","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769558,"web_url":"http://patchwork.ozlabs.org/comment/1769558/","msgid":"","list_archive_url":null,"date":"2017-09-16T04:32:40","subject":"Re: [U-Boot] [PATCH 11/13] x86: braswell: Add FSP configuration","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"content":"On Sat, Aug 26, 2017 at 9:39 PM, Simon Glass wrote:\n> On 15 August 2017 at 23:42, Bin Meng wrote:\n>> Add FSP related configuration for Braswell.\n>>\n>> Signed-off-by: Bin Meng \n>> ---\n>>\n>> arch/x86/cpu/braswell/Makefile | 2 +-\n>> arch/x86/cpu/braswell/fsp_configs.c | 158 ++++++++++++++\n>> .../include/asm/arch-braswell/fsp/fsp_configs.h | 89 ++++++++\n>> arch/x86/include/asm/arch-braswell/fsp/fsp_vpd.h | 172 +++++++++++++++\n>> arch/x86/include/asm/arch-braswell/gpio.h | 234 +++++++++++++++++++++\n>> 5 files changed, 654 insertions(+), 1 deletion(-)\n>> create mode 100644 arch/x86/cpu/braswell/fsp_configs.c\n>> create mode 100644 arch/x86/include/asm/arch-braswell/fsp/fsp_configs.h\n>> create mode 100644 arch/x86/include/asm/arch-braswell/fsp/fsp_vpd.h\n>> create mode 100644 arch/x86/include/asm/arch-braswell/gpio.h\n>>\n>\n> Reviewed-by: Simon Glass \n>\n\napplied to u-boot-x86, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"hOP6Kpj+\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvKCT1KNbz9t16\n\tfor ;\n\tSat, 16 Sep 2017 14:33:41 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid EF035C21FAB; Sat, 16 Sep 2017 04:33:27 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 13A54C21DD0;\n\tSat, 16 Sep 2017 04:33:25 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 04000C21E76; Sat, 16 Sep 2017 04:32:44 +0000 (UTC)","from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65])\n\tby lists.denx.de (Postfix) with ESMTPS id 56C8AC21F8F\n\tfor ; Sat, 16 Sep 2017 04:32:41 +0000 (UTC)","by mail-wm0-f65.google.com with SMTP id x17so4215217wmd.5\n\tfor ; Fri, 15 Sep 2017 21:32:41 -0700 (PDT)","by 10.223.145.3 with HTTP; Fri, 15 Sep 2017 21:32:40 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=dWxTuScwlhPYtUcuYx2H0Ol2OoLtnUC7y4wzLDVApXw=;\n\tb=hOP6Kpj+WaooEQ6n/YgQ1ft+AEpQz1nqrgv95ZyPikC34o5aObpjFjpfCpRpFUoQz4\n\tD72n/iP9Z2skQL0uuZDL8nJypiY7+WD12BcZ8ttw6qEEjKH0hBIcDv7WxPh7p7wULGwn\n\tcWL0MdgW1U8wuthu5vhiXvEXdiIe2iYU3eaKFqzmhpiqXB/KM7hpj9gqMlaFZlGY296s\n\taHJD0vai1ugiiZv/he/GW6P5oBS77NiwkhlaQwV55mynFD79WnbGcjggdV5hsfYn3D+p\n\t57NMr3Dv8oZITO+5myTL685OJsQm5q6h00i20C4LGva/NTqZfrSpxCFnp06HxbSrT3GB\n\tSa+g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=dWxTuScwlhPYtUcuYx2H0Ol2OoLtnUC7y4wzLDVApXw=;\n\tb=Ws9tY5VHWzhNj6EcWXca2d6YjGNPaCltunK7r6tPQsQ6uNHzXXOfjJBtYIriRkqTlu\n\tHiJL/JplYTXCZeWuxikFRlGbf+2FTYlCzd++7/SXEs6At6W2IlL2zuJl7Fi4heQlsao4\n\t7X8aZW5juRLJ4JxkwBViXjh8UXhO/dsERv3UZtnP2JqqHx6zLVs2rS1KBerEArnuCQ4t\n\tY7TfjdTHa2Lzcuh2yTr7GZqQGtVGfQH7qFNGdqWMMlQ3yQgr3LQfeFDBuhNu57NEY7hc\n\tzR38DmVmVDYc9CWM55lro0RN7A75XyM55F8+9rl0PD73aqOEcgIpp6Alzsw00EJbwMsq\n\tN1gw==","X-Gm-Message-State":"AHPjjUiW9TosDqQ5XmMoJE8hcNpGiwPFbpZW4NCfqsixzwE3IiVVIr3L\n\t0KBS3hewo5BT61MQIq/HcySOWoR0NExQvEPR2tQ=","X-Google-Smtp-Source":"AOwi7QA+LeNGeW4aW9cyVyz9bB0j/pRb2AMBZKJ+CTeq2ZBx2GNn3XSybL6ek0zBk8/HEvEIfNSYXIiBwYXkeUtx+DU=","X-Received":"by 10.28.130.131 with SMTP id e125mr4613014wmd.125.1505536361100;\n\tFri, 15 Sep 2017 21:32:41 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1502862122-14771-1-git-send-email-bmeng.cn@gmail.com>\n\t<1502862122-14771-12-git-send-email-bmeng.cn@gmail.com>\n\t","From":"Bin Meng ","Date":"Sat, 16 Sep 2017 12:32:40 +0800","Message-ID":"","To":"Simon Glass ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 11/13] x86: braswell: Add FSP configuration","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]