[{"id":1760295,"web_url":"http://patchwork.ozlabs.org/comment/1760295/","msgid":"<f7ttw0pyrvg.fsf@dhcp-25-97.bos.redhat.com>","list_archive_url":null,"date":"2017-08-30T15:53:07","subject":"Re: [ovs-dev] [PATCH] redhat: fix upgrades where group doesn't exist","submitter":{"id":67184,"url":"http://patchwork.ozlabs.org/api/people/67184/","name":"Aaron Conole","email":"aconole@redhat.com"},"content":"Aaron Conole <aconole@redhat.com> writes:\n\n> The upgrade from older Open vSwitch versions on RHEL will try, as much as\n> possible, to preserve the system.  This means no new users or groups are\n> created.  As an effect, it's possible for the chown to fail, because the\n> hugetlbfs group may not exist.  While it did on my systems, it was not\n> there on others.\n>\n> This change allows the ExecStartPre commands to fail.  In the case that the\n> user doesn't use DPDK, it won't matter anyway.\n>\n> Fixes: e3e738a3d058 ('redhat: allow dpdk to also run as non-root user')\n> Signed-off-by: Aaron Conole <aconole@redhat.com>\n> Reported-by: Jean-Tsung Hsiao <jhsiao@redhat.com>\n> Tested-by: Jean-Tsung Hsiao <jhsiao@redhat.com>\n> ---\n\nPing.","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=aconole@redhat.com"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xj95R1pjDz9sP5\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 01:53:15 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 6ACEFB66;\n\tWed, 30 Aug 2017 15:53:11 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id CA307B59\n\tfor <dev@openvswitch.org>; Wed, 30 Aug 2017 15:53:09 +0000 (UTC)","from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 99B7D41E\n\tfor <dev@openvswitch.org>; Wed, 30 Aug 2017 15:53:09 +0000 (UTC)","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0F6C96146E;\n\tWed, 30 Aug 2017 15:53:09 +0000 (UTC)","from dhcp-25-97.bos.redhat.com (unknown [10.18.25.172])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 8ADF518213;\n\tWed, 30 Aug 2017 15:53:08 +0000 (UTC)"],"X-Greylist":["domain auto-whitelisted by SQLgrey-1.7.6","Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 30 Aug 2017 15:53:09 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0F6C96146E","From":"Aaron Conole <aconole@redhat.com>","To":"dev@openvswitch.org","References":"<20170814201814.15993-1-aconole@redhat.com>","Date":"Wed, 30 Aug 2017 11:53:07 -0400","In-Reply-To":"<20170814201814.15993-1-aconole@redhat.com> (Aaron Conole's\n\tmessage of \"Mon, 14 Aug 2017 16:18:14 -0400\")","Message-ID":"<f7ttw0pyrvg.fsf@dhcp-25-97.bos.redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"Flavio Leitner <fbl@sysclose.org>","Subject":"Re: [ovs-dev] [PATCH] redhat: fix upgrades where group doesn't exist","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1760390,"web_url":"http://patchwork.ozlabs.org/comment/1760390/","msgid":"<20170830150923.698a5ddb@plex.home>","list_archive_url":null,"date":"2017-08-30T18:09:23","subject":"Re: [ovs-dev] [PATCH] redhat: fix upgrades where group doesn't exist","submitter":{"id":3387,"url":"http://patchwork.ozlabs.org/api/people/3387/","name":"Flavio Leitner","email":"fbl@sysclose.org"},"content":"On Mon, 14 Aug 2017 16:18:14 -0400\nAaron Conole <aconole@redhat.com> wrote:\n\n> The upgrade from older Open vSwitch versions on RHEL will try, as much as\n> possible, to preserve the system.  This means no new users or groups are\n> created.  As an effect, it's possible for the chown to fail, because the\n> hugetlbfs group may not exist.  While it did on my systems, it was not\n> there on others.\n> \n> This change allows the ExecStartPre commands to fail.  In the case that the\n> user doesn't use DPDK, it won't matter anyway.\n> \n> Fixes: e3e738a3d058 ('redhat: allow dpdk to also run as non-root user')\n> Signed-off-by: Aaron Conole <aconole@redhat.com>\n> Reported-by: Jean-Tsung Hsiao <jhsiao@redhat.com>\n> Tested-by: Jean-Tsung Hsiao <jhsiao@redhat.com>\n> ---\n\nAcked-by: Flavio Leitner <fbl@sysclose.org>","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=sysclose.org header.i=fbl@sysclose.org\n\theader.b=\"EZF5OXcp\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjD6m3lYDz9s8J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 04:09:36 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 9C779C46;\n\tWed, 30 Aug 2017 18:09:32 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id DD429C09\n\tfor <dev@openvswitch.org>; Wed, 30 Aug 2017 18:09:31 +0000 (UTC)","from sender-of-o52.zoho.com (sender-of-o52.zoho.com\n\t[135.84.80.217])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 3FEBD1AC\n\tfor <dev@openvswitch.org>; Wed, 30 Aug 2017 18:09:31 +0000 (UTC)","from plex.home (187.95.127.252 [187.95.127.252]) by mx.zohomail.com\n\twith SMTPS id 1504116568035806.6619546989336;\n\tWed, 30 Aug 2017 11:09:28 -0700 (PDT)"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1504116568;\n\ts=zoho; d=sysclose.org; i=fbl@sysclose.org;\n\th=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding;\n\tl=819; bh=ZAIAhA7gT2DCkASXdYJjHyCpEj0WXmZVH8gS36pOMm0=;\n\tb=EZF5OXcpk6XgWmyDqsVntCJuAw+HaTJUuC9LTgswxtKfcXnVlY9zQgXAg+qJl7pn\n\t4lN5WpAsUAsan3Jv8GXSVlo1jm0G83ex6ZouzaTOcSOKifCkV95RRpiKGZOsP01dK7P\n\t4/pQrqVAaKA3O2JYJNXZEn7Tgj6npD0xJ/DTI1yw=","Date":"Wed, 30 Aug 2017 15:09:23 -0300","From":"Flavio Leitner <fbl@sysclose.org>","To":"Aaron Conole <aconole@redhat.com>","Message-ID":"<20170830150923.698a5ddb@plex.home>","In-Reply-To":"<20170814201814.15993-1-aconole@redhat.com>","References":"<20170814201814.15993-1-aconole@redhat.com>","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","X-ZohoMailClient":"External","X-Spam-Status":"No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH] redhat: fix upgrades where group doesn't exist","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1760563,"web_url":"http://patchwork.ozlabs.org/comment/1760563/","msgid":"<CA+0q_Pi7psAO+Qw_Ww=31uEXHMQoYUjwJe9huYkzbft5_gVQQg@mail.gmail.com>","list_archive_url":null,"date":"2017-08-30T23:05:04","subject":"Re: [ovs-dev] [PATCH] redhat: fix upgrades where group doesn't exist","submitter":{"id":67631,"url":"http://patchwork.ozlabs.org/api/people/67631/","name":"Russell Bryant","email":"russell@ovn.org"},"content":"On Wed, Aug 30, 2017 at 2:09 PM, Flavio Leitner <fbl@sysclose.org> wrote:\n> On Mon, 14 Aug 2017 16:18:14 -0400\n> Aaron Conole <aconole@redhat.com> wrote:\n>\n>> The upgrade from older Open vSwitch versions on RHEL will try, as much as\n>> possible, to preserve the system.  This means no new users or groups are\n>> created.  As an effect, it's possible for the chown to fail, because the\n>> hugetlbfs group may not exist.  While it did on my systems, it was not\n>> there on others.\n>>\n>> This change allows the ExecStartPre commands to fail.  In the case that the\n>> user doesn't use DPDK, it won't matter anyway.\n>>\n>> Fixes: e3e738a3d058 ('redhat: allow dpdk to also run as non-root user')\n>> Signed-off-by: Aaron Conole <aconole@redhat.com>\n>> Reported-by: Jean-Tsung Hsiao <jhsiao@redhat.com>\n>> Tested-by: Jean-Tsung Hsiao <jhsiao@redhat.com>\n>> ---\n>\n> Acked-by: Flavio Leitner <fbl@sysclose.org>\n\nThanks, applied to master and branch-2.8.","headers":{"Return-Path":"<ovs-dev-bounces@openvswitch.org>","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=<UNKNOWN>)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjLhC2QqCz9s7C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 31 Aug 2017 09:05:31 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id AF2E5B2F;\n\tWed, 30 Aug 2017 23:05:29 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 0A4E48A5\n\tfor <dev@openvswitch.org>; Wed, 30 Aug 2017 23:05:29 +0000 (UTC)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id EDAB41D7\n\tfor <dev@openvswitch.org>; Wed, 30 Aug 2017 23:05:27 +0000 (UTC)","from mail-qt0-f177.google.com (mail-qt0-f177.google.com\n\t[209.85.216.177]) (Authenticated sender: russell@ovn.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 85E9941C084\n\tfor <dev@openvswitch.org>; Thu, 31 Aug 2017 01:05:26 +0200 (CEST)","by mail-qt0-f177.google.com with SMTP id w42so33442170qtg.5\n\tfor <dev@openvswitch.org>; Wed, 30 Aug 2017 16:05:26 -0700 (PDT)","by 10.140.93.164 with HTTP; Wed, 30 Aug 2017 16:05:04 -0700 (PDT)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"209.85.216.177","X-Gm-Message-State":"AHPjjUgRmaO+hqCqZq7CJyMt4pBml0LoRRFcN/F6OEwMDzG/ZFpimWQa\n\toJ7AgDSeiI+3bdjmEw9CbYNdhdty4g==","X-Google-Smtp-Source":"ADKCNb6qJ02NMzkHPCu7J7FjWRT1YSm3DNmAPzDp+pI2PRedqNZ7EcOvFJFFbOGGWiUP5EaF/vQ4LVUtLOG/MmBC4Pw=","X-Received":"by 10.237.51.35 with SMTP id u32mr4242314qtd.169.1504134325290; \n\tWed, 30 Aug 2017 16:05:25 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170830150923.698a5ddb@plex.home>","References":"<20170814201814.15993-1-aconole@redhat.com>\n\t<20170830150923.698a5ddb@plex.home>","From":"Russell Bryant <russell@ovn.org>","Date":"Wed, 30 Aug 2017 19:05:04 -0400","X-Gmail-Original-Message-ID":"<CA+0q_Pi7psAO+Qw_Ww=31uEXHMQoYUjwJe9huYkzbft5_gVQQg@mail.gmail.com>","Message-ID":"<CA+0q_Pi7psAO+Qw_Ww=31uEXHMQoYUjwJe9huYkzbft5_gVQQg@mail.gmail.com>","To":"Flavio Leitner <fbl@sysclose.org>","X-Spam-Status":"No, score=-0.2 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"ovs dev <dev@openvswitch.org>","Subject":"Re: [ovs-dev] [PATCH] redhat: fix upgrades where group doesn't exist","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"<ovs-dev.openvswitch.org>","List-Unsubscribe":"<https://mail.openvswitch.org/mailman/options/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe>","List-Archive":"<http://mail.openvswitch.org/pipermail/ovs-dev/>","List-Post":"<mailto:ovs-dev@openvswitch.org>","List-Help":"<mailto:ovs-dev-request@openvswitch.org?subject=help>","List-Subscribe":"<https://mail.openvswitch.org/mailman/listinfo/ovs-dev>,\n\t<mailto:ovs-dev-request@openvswitch.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]