[{"id":1747306,"web_url":"http://patchwork.ozlabs.org/comment/1747306/","msgid":"<87shgtt6oc.fsf@concordia.ellerman.id.au>","list_archive_url":null,"date":"2017-08-15T11:24:35","subject":"Re: [PATCH v2 1/9] KVM: PPC: Book3S HV: Fix H_REGISTER_VPA VPA size\n\tvalidation","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"Nicholas Piggin writes:\n\n> KVM currently validates the size of the VPA registered by the client\n> against sizeof(struct lppaca), however we align (and therefore size)\n> that struct to 1kB to avoid crossing a 4kB boundary in the client.\n>\n> PAPR calls for sizes >= 640 bytes to be accepted. Hard code this with\n> a comment.\n>\n> Signed-off-by: Nicholas Piggin \n> ---\n> arch/powerpc/kvm/book3s_hv.c | 8 +++++++-\n> 1 file changed, 7 insertions(+), 1 deletion(-)\n\nThis one should go via Paul.\n\nHopefully he can just pick it up.\n\ncheers\n\n> diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c\n> index 359c79cdf0cc..1182cfd79857 100644\n> --- a/arch/powerpc/kvm/book3s_hv.c\n> +++ b/arch/powerpc/kvm/book3s_hv.c\n> @@ -485,7 +485,13 @@ static unsigned long do_h_register_vpa(struct kvm_vcpu *vcpu,\n> \n> \tswitch (subfunc) {\n> \tcase H_VPA_REG_VPA:\t\t/* register VPA */\n> -\t\tif (len < sizeof(struct lppaca))\n> +\t\t/*\n> +\t\t * The size of our lppaca is 1kB because of the way we align\n> +\t\t * it for the guest to avoid crossing a 4kB boundary. We only\n> +\t\t * use 640 bytes of the structure though, so we should accept\n> +\t\t * clients that set a size of 640.\n> +\t\t */\n> +\t\tif (len < 640)\n> \t\t\tbreak;\n> \t\tvpap = &tvcpu->arch.vpa;\n> \t\terr = 0;\n> -- \n> 2.13.3\n--\nTo unsubscribe from this list: send the line \"unsubscribe kvm-ppc\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=kvm-ppc-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xWqrT1FSRz9t45\n\tfor ;\n\tTue, 15 Aug 2017 21:24:41 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752092AbdHOLYj (ORCPT );\n\tTue, 15 Aug 2017 07:24:39 -0400","from ozlabs.org ([103.22.144.67]:51005 \"EHLO ozlabs.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752134AbdHOLYh (ORCPT );\n\tTue, 15 Aug 2017 07:24:37 -0400","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3xWqrN0Qp2z9t42;\n\tTue, 15 Aug 2017 21:24:36 +1000 (AEST)"],"From":"Michael Ellerman ","To":"Nicholas Piggin , linuxppc-dev@lists.ozlabs.org","Cc":"kvm-ppc@vger.kernel.org, Nicholas Piggin ","Subject":"Re: [PATCH v2 1/9] KVM: PPC: Book3S HV: Fix H_REGISTER_VPA VPA size\n\tvalidation","In-Reply-To":"<20170813013346.14002-1-npiggin@gmail.com>","References":"<20170812113416.15978-1-npiggin@gmail.com>\n\t<20170813013346.14002-1-npiggin@gmail.com>","User-Agent":"Notmuch/0.21 (https://notmuchmail.org)","Date":"Tue, 15 Aug 2017 21:24:35 +1000","Message-ID":"<87shgtt6oc.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"kvm-ppc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"kvm-ppc@vger.kernel.org"}},{"id":1760618,"web_url":"http://patchwork.ozlabs.org/comment/1760618/","msgid":"<20170831034139.GC22549@fergus.ozlabs.ibm.com>","list_archive_url":null,"date":"2017-08-31T03:41:39","subject":"Re: [PATCH v2 1/9] KVM: PPC: Book3S HV: Fix H_REGISTER_VPA VPA size\n\tvalidation","submitter":{"id":67079,"url":"http://patchwork.ozlabs.org/api/people/67079/","name":"Paul Mackerras","email":"paulus@ozlabs.org"},"content":"On Sun, Aug 13, 2017 at 11:33:38AM +1000, Nicholas Piggin wrote:\n> KVM currently validates the size of the VPA registered by the client\n> against sizeof(struct lppaca), however we align (and therefore size)\n> that struct to 1kB to avoid crossing a 4kB boundary in the client.\n> \n> PAPR calls for sizes >= 640 bytes to be accepted. Hard code this with\n> a comment.\n> \n> Signed-off-by: Nicholas Piggin \n\nThanks, patch applied to my kvm-ppc-next branch.\n\nPaul.\n--\nTo unsubscribe from this list: send the line \"unsubscribe kvm-ppc\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=kvm-ppc-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tsecure) header.d=ozlabs.org header.i=@ozlabs.org header.b=\"Enly7Y+p\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjSt00GR7z9t32\n\tfor ;\n\tThu, 31 Aug 2017 13:44:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751318AbdHaDoU (ORCPT );\n\tWed, 30 Aug 2017 23:44:20 -0400","from ozlabs.org ([103.22.144.67]:53403 \"EHLO ozlabs.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751286AbdHaDoM (ORCPT );\n\tWed, 30 Aug 2017 23:44:12 -0400","by ozlabs.org (Postfix, from userid 1003)\n\tid 3xjSsj3Slhz9sPm; Thu, 31 Aug 2017 13:44:09 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; \n\tt=1504151049; bh=rXvfTShLq20ppELIPXGCXIGUZb8GZMoEKKymk8vcKzw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Enly7Y+pZNXb+7cM0p+Fu+GpXKlUEG1+V5lW2A0AXbeIiNc4HfDRrhTZUwHV0YgGn\n\t5XTt+H2U5PtSyQlykwekduz/3S1FmGGMP0avJOYl7PDEJS9W861Pkc3NkTBzi559w3\n\tCkiV28RtV1fEOHANDsyKvfH8rsE+sTAIHSV4QQn2R/ISBwmohf8wyiUu9pXifMFcB5\n\t46lL4/ke908Z3+zbaEBP3jcm3H8LLdWOp4aIm/Uw9RRk9oeFTk5Lbeh8jtCiKvWTVv\n\t72Ys72M9FHQrRuH3aTUnfLpmv9HaKSDx0cxtUSJ9dG1MMj8QsVSoP5GEn0GwbxMilQ\n\tuggr72A485fbw==","Date":"Thu, 31 Aug 2017 13:41:39 +1000","From":"Paul Mackerras ","To":"Nicholas Piggin ","Cc":"linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org","Subject":"Re: [PATCH v2 1/9] KVM: PPC: Book3S HV: Fix H_REGISTER_VPA VPA size\n\tvalidation","Message-ID":"<20170831034139.GC22549@fergus.ozlabs.ibm.com>","References":"<20170812113416.15978-1-npiggin@gmail.com>\n\t<20170813013346.14002-1-npiggin@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170813013346.14002-1-npiggin@gmail.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"kvm-ppc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"kvm-ppc@vger.kernel.org"}}]