[{"id":1750779,"web_url":"http://patchwork.ozlabs.org/comment/1750779/","msgid":"<20170818055706.GT5509@umbus.fritz.box>","date":"2017-08-18T05:57:06","subject":"Re: [PATCH v2 4/8] powerpc/xive: introduce xive_esb_write()","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Fri, Aug 11, 2017 at 04:23:37PM +0200, Cédric Le Goater wrote:\n\nRationale in the commit message, maybe.\n\n> Signed-off-by: Cédric Le Goater \n\nReviewed-by: David Gibson \n\n> ---\n> arch/powerpc/sysdev/xive/common.c | 11 ++++++++++-\n> 1 file changed, 10 insertions(+), 1 deletion(-)\n> \n> diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c\n> index 8a58662ed793..ac5f18a66742 100644\n> --- a/arch/powerpc/sysdev/xive/common.c\n> +++ b/arch/powerpc/sysdev/xive/common.c\n> @@ -203,6 +203,15 @@ static u8 xive_esb_read(struct xive_irq_data *xd, u32 offset)\n> \treturn (u8)val;\n> }\n> \n> +static void xive_esb_write(struct xive_irq_data *xd, u32 offset, u64 data)\n> +{\n> +\t/* Handle HW errata */\n> +\tif (xd->flags & XIVE_IRQ_FLAG_SHIFT_BUG)\n> +\t\toffset |= offset << 4;\n> +\n> +\tout_be64(xd->eoi_mmio + offset, data);\n> +}\n> +\n> #ifdef CONFIG_XMON\n> static void xive_dump_eq(const char *name, struct xive_q *q)\n> {\n> @@ -297,7 +306,7 @@ void xive_do_source_eoi(u32 hw_irq, struct xive_irq_data *xd)\n> {\n> \t/* If the XIVE supports the new \"store EOI facility, use it */\n> \tif (xd->flags & XIVE_IRQ_FLAG_STORE_EOI)\n> -\t\tout_be64(xd->eoi_mmio + XIVE_ESB_STORE_EOI, 0);\n> +\t\txive_esb_write(xd, XIVE_ESB_STORE_EOI, 0);\n> \telse if (hw_irq && xd->flags & XIVE_IRQ_FLAG_EOI_FW) {\n> \t\t/*\n> \t\t * The FW told us to call it. This happens for some","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xYctS56Npz9t2y\n\tfor ;\n\tFri, 18 Aug 2017 19:17:36 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xYctS3xl1zDrKs\n\tfor ;\n\tFri, 18 Aug 2017 19:17:36 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xYcpG60P5zDrJR\n\tfor ;\n\tFri, 18 Aug 2017 19:13:58 +1000 (AEST)","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xYcpG4bPQz9t2W; Fri, 18 Aug 2017 19:13:58 +1000 (AEST)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"NAi53K+Q\"; \n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"NAi53K+Q\"; \n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au\n\theader.b=\"NAi53K+Q\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1503047638;\n\tbh=siJpzpXx0aClByarw0ShZT9Lh6UIcGvffiAsJnc/OTw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NAi53K+QJTZLoMFdusMbAyKyEcMpLNYKDTaugJHc6nw9W+fTeYZ9Xkzh0kl+hNNzo\n\t08MrtySooQBL5WbG4QIAzDLEGM7D4F/vdCxP2jAGrcYgJUQYb6P1ROmkg7hFpj7bn+\n\tlQytohGu8ocLEDXf4YWzl+MTzwda+x/6Mw6NMcdo=","Date":"Fri, 18 Aug 2017 15:57:06 +1000","From":"David Gibson ","To":"=?iso-8859-1?Q?C=E9dric?= Le Goater ","Subject":"Re: [PATCH v2 4/8] powerpc/xive: introduce xive_esb_write()","Message-ID":"<20170818055706.GT5509@umbus.fritz.box>","References":"<20170811142341.22715-1-clg@kaod.org>\n\t<20170811142341.22715-5-clg@kaod.org>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"9wW3yB/H9ZmnRBtb\"","Content-Disposition":"inline","In-Reply-To":"<20170811142341.22715-5-clg@kaod.org>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linuxppc-dev@lists.ozlabs.org, Paul Mackerras ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]