[{"id":1758012,"web_url":"http://patchwork.ozlabs.org/comment/1758012/","msgid":"","list_archive_url":null,"date":"2017-08-26T13:37:21","subject":"Re: [U-Boot] [PATCH v2 08/10] config: sandbox: Add unit tests","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 11 August 2017 at 02:52, Pantelis Antoniou\n wrote:\n> Add unit tests for sandbox default config.\n>\n> Signed-off-by: Pantelis Antoniou \n> ---\n> configs/sandbox_defconfig | 2 ++\n> 1 file changed, 2 insertions(+)\n\nI don't see any tests in this patch?\n\n>\n> diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig\n> index fd0b952..df8659a 100644\n> --- a/configs/sandbox_defconfig\n> +++ b/configs/sandbox_defconfig\n> @@ -187,7 +187,9 @@ CONFIG_CMD_DHRYSTONE=y\n> CONFIG_TPM=y\n> CONFIG_LZ4=y\n> CONFIG_ERRNO_STR=y\n> +CONFIG_OF_LIBFDT_OVERLAY=y\n> CONFIG_UNIT_TEST=y\n> CONFIG_UT_TIME=y\n> CONFIG_UT_DM=y\n> CONFIG_UT_ENV=y\n> +CONFIG_UT_OVERLAY=y\n> --\n> 2.1.4\n>\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"FDqioDGL\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"G+4Hno54\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xfff31BQJz9t4c\n\tfor ;\n\tSat, 26 Aug 2017 23:54:19 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid E3B86C220BD; Sat, 26 Aug 2017 13:41:04 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 489D1C22099;\n\tSat, 26 Aug 2017 13:40:42 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid CC551C22091; Sat, 26 Aug 2017 13:37:48 +0000 (UTC)","from mail-qk0-f174.google.com (mail-qk0-f174.google.com\n\t[209.85.220.174])\n\tby lists.denx.de (Postfix) with ESMTPS id B6C53C22099\n\tfor ; Sat, 26 Aug 2017 13:37:44 +0000 (UTC)","by mail-qk0-f174.google.com with SMTP id p67so10065830qkd.2\n\tfor ; Sat, 26 Aug 2017 06:37:44 -0700 (PDT)","by 10.200.52.117 with HTTP; Sat, 26 Aug 2017 06:37:21 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=17L49Fs8ra+m5ceh4RmPgDt2cac7CgtCYQsEr6wbklU=;\n\tb=FDqioDGLW2kjCr4j7x7av20nJ8K6rvbAtdW2GWhFlg9JaLCQJpo6Gsqhj3RkvGpag9\n\twhjwVmgjYS4aV32jFSsaDPOaD5z5zkrYmtpK6fZfclhNero8xAyBSBtTkq628oIz+ZkF\n\tQwupmujcsarU+wApJEtG645yARunp3J3Z+5BQ1dTfUjA6MbJnr8Ab45rXbF2a52XJ0Ho\n\tEEhCZdFObmjljEbtTl1eVURTM7iBCxC8KRK3q6SgD4TPVStDSJcntCo9r6sck/Ai62vy\n\tH5KX/v0KcHgsQaMc9EifHIQ+LjvNkBVJ7U18G+MqpntIJB5ZrReD+MBJ60I98xND6pUF\n\tPM5A==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=17L49Fs8ra+m5ceh4RmPgDt2cac7CgtCYQsEr6wbklU=;\n\tb=G+4Hno541rXD1GpCR3FGWIo0TANFC2v8ugLzQIaGWbcJa4+cyHJj+ZerprqDsfHlFW\n\tjtzJdg9ohbX+NetmzlFwJrfaA2Urgo3HWc5uSytSdIiwoN9UmuhdQ3wlyON2C6Zci+Md\n\t2FDqJBWqFruOc6fhIT61RwNLUV1CRbVVu5UoY="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=17L49Fs8ra+m5ceh4RmPgDt2cac7CgtCYQsEr6wbklU=;\n\tb=ewUlEt3l+oXYquIc+WOc/frd05kbeoj8P3RX+9FC0Rzz/N9hbjMguSrZmwkWwfNTFZ\n\tAEBUT0xk3ILnyrvDZPBZFC5+Zd0qiy/bLqCg2OCE6uUcr0P/e9AKWp0Vi105qk0m52Qu\n\t1y6LBrPTK/kWSaYfvrUcwEOlSpWkny3XTyiArDIZUi4q2qcY3RxW9k/Y5fudYzMnlxhY\n\thFYNqAl2Qf1XomYykwhZZT8acMzUQ4PkRPgIk+263HIf8z9bUqzxfp42Yx9Vk1tt1RKd\n\tcF+h215Ukv9bpD5P32+f8QKVfYGVDjJYpl8D8OzZ4iEYVKZjrhlgFzRdJMmdI1s/dkzp\n\tz6tQ==","X-Gm-Message-State":"AHYfb5hy9MkG2mtsYx9xclQTli4ztAVRtqnxhncYwA3j+oyZC25W//P5\n\twBJ2YGTsTsG9PRs5B2BX7pMEVX2026u7","X-Google-Smtp-Source":"ADKCNb6aOLzyflhys7x2g+57pG06QhLx5WtXf97xCTsTxmY3GkLRGLruqSLoRdTl4+89Xngp4rpT2D1K4hbrwAQBdqw=","X-Received":"by 10.55.189.5 with SMTP id n5mr2299435qkf.38.1503754663489; Sat,\n\t26 Aug 2017 06:37:43 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1502441568-22896-9-git-send-email-pantelis.antoniou@konsulko.com>","References":"<1502441568-22896-1-git-send-email-pantelis.antoniou@konsulko.com>\n\t<1502441568-22896-9-git-send-email-pantelis.antoniou@konsulko.com>","From":"Simon Glass ","Date":"Sat, 26 Aug 2017 07:37:21 -0600","X-Google-Sender-Auth":"r_o3S-mzlF1PtV_Lc6XMAHzOcZ4","Message-ID":"","To":"Pantelis Antoniou ","Cc":"Marek Vasut , Tom Rini ,\n\tTero Kristo ,\n\tU-Boot Mailing List , \n\tMaxime Ripard ,\n\tStefan Roese , Alan Ott ","Subject":"Re: [U-Boot] [PATCH v2 08/10] config: sandbox: Add unit tests","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1758567,"web_url":"http://patchwork.ozlabs.org/comment/1758567/","msgid":"<1503924899.4238.1.camel@hp800z>","list_archive_url":null,"date":"2017-08-28T12:54:59","subject":"Re: [U-Boot] [PATCH v2 08/10] config: sandbox: Add unit tests","submitter":{"id":64098,"url":"http://patchwork.ozlabs.org/api/people/64098/","name":"Pantelis Antoniou","email":"pantelis.antoniou@konsulko.com"},"content":"Hi Simon,\n\nOn Sat, 2017-08-26 at 07:37 -0600, Simon Glass wrote:\n> On 11 August 2017 at 02:52, Pantelis Antoniou\n> wrote:\n> > Add unit tests for sandbox default config.\n> >\n> > Signed-off-by: Pantelis Antoniou \n> > ---\n> > configs/sandbox_defconfig | 2 ++\n> > 1 file changed, 2 insertions(+)\n> \n> I don't see any tests in this patch?\n> \n\nErr, maybe the wording of the commit message needs to change.\nThere are no new tests, merely enabling overlays for the sandbox config\nmakes them available as unitests.\n\nI will reword.\n\n> >\n> > diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig\n> > index fd0b952..df8659a 100644\n> > --- a/configs/sandbox_defconfig\n> > +++ b/configs/sandbox_defconfig\n> > @@ -187,7 +187,9 @@ CONFIG_CMD_DHRYSTONE=y\n> > CONFIG_TPM=y\n> > CONFIG_LZ4=y\n> > CONFIG_ERRNO_STR=y\n> > +CONFIG_OF_LIBFDT_OVERLAY=y\n> > CONFIG_UNIT_TEST=y\n> > CONFIG_UT_TIME=y\n> > CONFIG_UT_DM=y\n> > CONFIG_UT_ENV=y\n> > +CONFIG_UT_OVERLAY=y\n> > --\n> > 2.1.4\n> >\n> \n> Regards,\n> Simon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"fFHN/osB\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xgsF86tc3z9sDB\n\tfor ;\n\tMon, 28 Aug 2017 22:55:24 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 620C3C224E6; Mon, 28 Aug 2017 12:55:07 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 90479C22495;\n\tMon, 28 Aug 2017 12:55:05 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 9EFA2C22495; Mon, 28 Aug 2017 12:55:04 +0000 (UTC)","from mail-wm0-f41.google.com (mail-wm0-f41.google.com\n\t[74.125.82.41])\n\tby lists.denx.de (Postfix) with ESMTPS id 3B99FC22430\n\tfor ; Mon, 28 Aug 2017 12:55:04 +0000 (UTC)","by mail-wm0-f41.google.com with SMTP id f13so12808537wme.1\n\tfor ; Mon, 28 Aug 2017 05:55:04 -0700 (PDT)","from [192.168.2.248] ([195.97.110.117])\n\tby smtp.gmail.com with ESMTPSA id\n\tj79sm313513wmd.20.2017.08.28.05.55.01\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 28 Aug 2017 05:55:02 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=sm4uhu2LCb2aMT3Cxqy5z0NeARgHc/H2SjU8qdH7VIo=;\n\tb=fFHN/osBBH7XMvS7MZZoalClnn4l/bzHnfbBt1hMW2kcy1mPRcE7y/Db1YsXw1BL27\n\tfdzo2o9pd+I+IAJSqebzNQe9BtgF3q+DH6JaoK7YgJg4he9BZsQHhgH0WEGDk7naxnPu\n\tWeeBfGR60+f1mckhxoTaaO+Et3gKSEVWr/UW0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=sm4uhu2LCb2aMT3Cxqy5z0NeARgHc/H2SjU8qdH7VIo=;\n\tb=FPR7NJrYLCBuM1y2g9y9OS1H8l1EQFiiY82Zo3p3kGdLv+5ItYFbUH+XJQRRMHE9dZ\n\tlr23K0E43Wc35toM0sL3B516gXT69y3eI0JnExZ56xRSs7Gk/sRHLWIqT5Lp1SlE8T8b\n\tYsQqF78k6Ws9m7vNM4zwZ4oxayyJn4r/FlXKXfvfwvjCGHYpGgfHxvHXcCJyNiEUbWUq\n\tbCyr2ccNVw493yFb69DkoEDVkC+OZPxuoMBj7GCATZm5jDZvRU0TJpSveY7oHapYccBy\n\t/uVoKwow+A70emENGOc/RF2F2hf/xPDtbdNCEZAsnBpVR7xFKrmz6YoKVkoIkTimZxVr\n\tMxtA==","X-Gm-Message-State":"AHYfb5hyiotvY8m/YeH1hJLFnL+Z/CouV4VMH4U6rDL2dB5l38z09bbQ\n\tmH/2h9SryV+eKWB/","X-Received":"by 10.28.69.67 with SMTP id s64mr20023wma.88.1503924903822;\n\tMon, 28 Aug 2017 05:55:03 -0700 (PDT)","Message-ID":"<1503924899.4238.1.camel@hp800z>","From":"Pantelis Antoniou ","To":"Simon Glass ","Date":"Mon, 28 Aug 2017 15:54:59 +0300","In-Reply-To":"","References":"<1502441568-22896-1-git-send-email-pantelis.antoniou@konsulko.com>\n\t<1502441568-22896-9-git-send-email-pantelis.antoniou@konsulko.com>\n\t","X-Mailer":"Evolution 3.10.4-0ubuntu2 ","Mime-Version":"1.0","Cc":"Marek Vasut , Tom Rini ,\n\tTero Kristo ,\n\tU-Boot Mailing List , \n\tMaxime Ripard ,\n\tStefan Roese , Alan Ott ","Subject":"Re: [U-Boot] [PATCH v2 08/10] config: sandbox: Add unit tests","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]