[{"id":1757995,"web_url":"http://patchwork.ozlabs.org/comment/1757995/","msgid":"","list_archive_url":null,"date":"2017-08-26T13:36:57","subject":"Re: [U-Boot] [PATCH v2 03/10] fit: Introduce methods for applying\n\toverlays on fit-load","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi,\n\nOn 11 August 2017 at 02:52, Pantelis Antoniou\n wrote:\n> Introduce an overlay based method for constructing a base DT blob\n> to pass to the kernel.\n>\n> Both canned and runtime feature selection is supported.\n>\n> Signed-off-by: Pantelis Antoniou \n> ---\n> common/image-fdt.c | 7 +-\n> common/image-fit.c | 216 ++++++++++++++++++++++++--\n> doc/uImage.FIT/command_syntax_extensions.txt | 12 +-\n> doc/uImage.FIT/overlay-fdt-boot.txt | 221 +++++++++++++++++++++++++++\n> doc/uImage.FIT/source_file_format.txt | 6 +-\n> include/image.h | 10 ++\n> 6 files changed, 454 insertions(+), 18 deletions(-)\n> create mode 100644 doc/uImage.FIT/overlay-fdt-boot.txt\n\nCan you please split this patch a bit?\n\nI see changes to the existing code and some stuff inside an #ifdef.\nCan you split out the refactoring from the new features?\n\nAlso please comment the functions you add to the header file.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"pT9CY6ez\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"hQjH5mfv\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xffK40XyTz9t5T\n\tfor ;\n\tSat, 26 Aug 2017 23:39:35 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid BE104C22091; Sat, 26 Aug 2017 13:38:02 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 0D2AFC22090;\n\tSat, 26 Aug 2017 13:37:48 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 875ADC22085; Sat, 26 Aug 2017 13:37:23 +0000 (UTC)","from mail-qt0-f180.google.com (mail-qt0-f180.google.com\n\t[209.85.216.180])\n\tby lists.denx.de (Postfix) with ESMTPS id 9EF25C22071\n\tfor ; Sat, 26 Aug 2017 13:37:19 +0000 (UTC)","by mail-qt0-f180.google.com with SMTP id d15so9752177qta.4\n\tfor ; Sat, 26 Aug 2017 06:37:19 -0700 (PDT)","by 10.200.52.117 with HTTP; Sat, 26 Aug 2017 06:36:57 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=pLGTtjCfF177CHUUkD6W0Y5efpxMjR8mnl2IU9Yr2fA=;\n\tb=pT9CY6ezo0SKH9Cv1ftUhh90NpY06A+41jfe1vSYW+fRExZ4rAYhHGZJTrbFjVZb9A\n\toRl8Y93AZ7kpZE7OUbKaO+mw9wH7lD8FWdEpU9uM3XZ+zpp2ljrsHlOJXFn5CIvlgwDZ\n\tf8f7cC3iI6e6HKCC8stVXbNfUgbUpc6AgxJ32S+6ku4TEmcsfPlnSS7C9VH11HRVgvd2\n\tupwRubgFZ+NnQhJ/SAuG9MYisSS0dMHUJelvQbNV5VusQEGie9CH/Q4vFiq0vRQL9QqB\n\t6E2i+Y28x5TGyw3DOkt/jZPWRZg0j9010P1cP1G+ortq6c6Kl1J+zZPUVE31pUip8TNm\n\tllUg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=pLGTtjCfF177CHUUkD6W0Y5efpxMjR8mnl2IU9Yr2fA=;\n\tb=hQjH5mfvQshnECMYinPPsMZ+8SeIZw0n3B1L3xrueVVZ8li19oFtxCIfzNhX2z34Sd\n\trKJb0Jw+KeKa8kBZMyd1sK+JPZ1iUpd/X31iPaCWsWeXin6sZkS/cJAXcWLHhir+j8f7\n\tbJWKFNz+D/bLSePwMODpqurnA5RCrHEjxsljo="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=pLGTtjCfF177CHUUkD6W0Y5efpxMjR8mnl2IU9Yr2fA=;\n\tb=LTKI5vSMbD4KvX7OMgJo/tnK2eDpncSDeDxv0JhpKcyceM8NHiU/T3PyYD3BJzHfnt\n\t48g60Eu8yTwkOZ8AZcg8Tb45XssqdcL3mdoWT/EQOUfC1UDGfmGSK2qGtrH561XZHARE\n\t7tKygLrtyMip2/gRBi9U5gzvHxBNfndgpNb9MLGWdeGUSzBovjUA74N4ieo7fMwYXxAN\n\thUeggrKfybHzo5pnJB5LS6DnNoEySdKJxc0Yfxfr9nvmWlwFg2hnWGaydkl9UqLX4aKc\n\t4OR6mWOvUHpALgqryJfuLHCjDWusnY008jBdn6+8BLDwM6HeLBLpKZCQpr7/yw6v2ddo\n\t/QzQ==","X-Gm-Message-State":"AHYfb5gfiT6yGHhN/FhVwcN1rOkc/6pXil/sXvwb3o/UzbR0CuZRoZDQ\n\tLx4Q/AUSP2EGeHgh8gOtYgq99Lj9TtwI","X-Google-Smtp-Source":"ADKCNb43jReOM2yfW2jOZNT2ZG6g8b6rmbh+t7v4m29hB7VtDfbV1eutAUCUVwOjG1K5ROZTG9QOxU/FUi+0blGHNDk=","X-Received":"by 10.200.2.172 with SMTP id p44mr2320279qtg.68.1503754638450;\n\tSat, 26 Aug 2017 06:37:18 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1502441568-22896-4-git-send-email-pantelis.antoniou@konsulko.com>","References":"<1502441568-22896-1-git-send-email-pantelis.antoniou@konsulko.com>\n\t<1502441568-22896-4-git-send-email-pantelis.antoniou@konsulko.com>","From":"Simon Glass ","Date":"Sat, 26 Aug 2017 07:36:57 -0600","X-Google-Sender-Auth":"nj-74a4uvgQBzQZpBH6lnGEJAPc","Message-ID":"","To":"Pantelis Antoniou ","Cc":"Marek Vasut , Tom Rini ,\n\tTero Kristo ,\n\tU-Boot Mailing List , \n\tMaxime Ripard ,\n\tStefan Roese , Alan Ott ","Subject":"Re: [U-Boot] [PATCH v2 03/10] fit: Introduce methods for applying\n\toverlays on fit-load","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]