[{"id":1745970,"web_url":"http://patchwork.ozlabs.org/comment/1745970/","msgid":"<CAPnjgZ2JW8OuRKtT=TajmHhFv+rkoe2YELsoLymmVb7Y88e3=A@mail.gmail.com>","list_archive_url":null,"date":"2017-08-13T21:36:44","subject":"Re: [U-Boot] [patch v2 10/13] power: pmic.h: include dm/ofnode.h","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 9 August 2017 at 06:52, Peng Fan <peng.fan@nxp.com> wrote:\n> Include dm/ofnode.h.\n>\n> Signed-off-by: Peng Fan <peng.fan@nxp.com>\n> Cc: Simon Glass <sjg@chromium.org>\n> Cc: Stefano Babic <sbabic@denx.de>\n> ---\n>  include/power/pmic.h | 1 +\n>  1 file changed, 1 insertion(+)\n\nReviewed-by: Simon Glass <sjg@chromium.org>\n\nPlease see below.\n\n>\n> diff --git a/include/power/pmic.h b/include/power/pmic.h\n> index 4b34316..f2fe537 100644\n> --- a/include/power/pmic.h\n> +++ b/include/power/pmic.h\n> @@ -11,6 +11,7 @@\n>  #ifndef __CORE_PMIC_H_\n>  #define __CORE_PMIC_H_\n>\n> +#include <dm/ofnode.h>\n>  #include <i2c.h>\n\nShould be under i2c.h I think\n\n>  #include <linux/list.h>\n>  #include <power/power_chrg.h>\n> --\n> 2.6.2\n>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"DqyRK/zP\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"AMP91bDP\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xVsp10pGfz9s7g\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 14 Aug 2017 07:49:13 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid CEEBEC21DBE; Sun, 13 Aug 2017 21:43:04 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E52C3C21D99;\n\tSun, 13 Aug 2017 21:41:20 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid A29D4C21DC1; Sun, 13 Aug 2017 21:37:10 +0000 (UTC)","from mail-vk0-f45.google.com (mail-vk0-f45.google.com\n\t[209.85.213.45])\n\tby lists.denx.de (Postfix) with ESMTPS id 8B7B3C21DA9\n\tfor <u-boot@lists.denx.de>; Sun, 13 Aug 2017 21:37:06 +0000 (UTC)","by mail-vk0-f45.google.com with SMTP id g189so26585762vke.5\n\tfor <u-boot@lists.denx.de>; Sun, 13 Aug 2017 14:37:06 -0700 (PDT)","by 10.176.85.207 with HTTP; Sun, 13 Aug 2017 14:36:44 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=HtNljrITU3qumPdEGZpoEF3qYACWgLAHDQkLtd6QeHI=;\n\tb=DqyRK/zP66tcYtCISoks26B+Ov6OCufCsSTIQl9FS/vPuqHCkKOu/eqI3NJMUDj7f4\n\tOa+uR9V1uJww0S1/zt9Y37Zn502rQ/IYFSLzSqBdRdf4HAhOZpksIADlwvnJDqwOp4z8\n\tQrccun+2HBzqLgsBVFvgoOertvc+DfofgXnbsfWqhbeLZqvuLerfJ7Oy04qIqndEryYe\n\tI37v9vb3RWJBWIqpYXz/vynx4Fz4m6kNZh/yK/5q66+1QBSu/F977Iy3P8n6zrd/NuH8\n\tvbArww9c1giJ0J2vb++bI395tWFSSvXHLJyF3O/8qeTiXPmtBVwGUcpm/7TKrKGpd1PY\n\tlBGg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=HtNljrITU3qumPdEGZpoEF3qYACWgLAHDQkLtd6QeHI=;\n\tb=AMP91bDPX0eqXU94jR1vKN5QAYyjLDKX62tiHo8oKGd7Dp1zOVYQlwOl9WdFiUIbsw\n\tUSg1o3d3PjflYZyNeoJe5DFXmEeGPY0ZZluYB2zC4/IxlyLFRX9fB4/WZkmZJglp0yik\n\tQhenG6kDpSV85xRyFZXoAqKzp5q7OcYBtCoBg="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=HtNljrITU3qumPdEGZpoEF3qYACWgLAHDQkLtd6QeHI=;\n\tb=T06d0FD3t2SGNRWJTl2h5Vt6QZ+81H/5VXo1fAYYD8AfApet4pVOlOoYF2lnxhcbHp\n\tKBWwOF9TdqRdUwOqqT/qmiWn9Zo6SxsHBekBO5Ie/UWSdTZyg+ARdhW6fsyyGFdyluU7\n\t5uAZHoHrDyq34DauW+ZKiTR+Y5p7bBOvWcpzU9LFRt5e2uikcmAjgecpFi40XMn4la4S\n\tSTIkF/jqs8HhM/B8rpaV5rtrfPj/QjPDYtTXcILX5hHizxAfgl6B8Gaorm6XvZqqJH9c\n\tTVcQ+hPkCpPVaYmCbqkX88hAg2g+b9wOTF36PyPHj6ac7nBTlHR8AB2sq911pqXLtylr\n\tUF8g==","X-Gm-Message-State":"AHYfb5jquo60zJSkz2jzWGfanQiPwXEO5stNHuGKbNQeUxfWlCxWVM0f\n\tg1EcfBtSAbsPCc88sFeLzTCe4RESnVe2","X-Received":"by 10.31.168.142 with SMTP id r136mr15295955vke.20.1502660225308;\n\tSun, 13 Aug 2017 14:37:05 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1502283127-21666-11-git-send-email-peng.fan@nxp.com>","References":"<1502283127-21666-1-git-send-email-peng.fan@nxp.com>\n\t<1502283127-21666-11-git-send-email-peng.fan@nxp.com>","From":"Simon Glass <sjg@chromium.org>","Date":"Sun, 13 Aug 2017 15:36:44 -0600","X-Google-Sender-Auth":"JESdRkl43de3jyRyMeysHOaupvQ","Message-ID":"<CAPnjgZ2JW8OuRKtT=TajmHhFv+rkoe2YELsoLymmVb7Y88e3=A@mail.gmail.com>","To":"Peng Fan <peng.fan@nxp.com>","Cc":"U-Boot Mailing List <u-boot@lists.denx.de>","Subject":"Re: [U-Boot] [patch v2 10/13] power: pmic.h: include dm/ofnode.h","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}}]