[{"id":1746792,"web_url":"http://patchwork.ozlabs.org/comment/1746792/","msgid":"<20170814195236.4miomp2omul5qikt@ninjato>","list_archive_url":null,"date":"2017-08-14T19:52:36","subject":"Re: [PATCH] i2c: slave-eeprom: Add an OF device ID table","submitter":{"id":22495,"url":"http://patchwork.ozlabs.org/api/people/22495/","name":"Wolfram Sang","email":"wsa@the-dreams.de"},"content":"On Wed, Aug 09, 2017 at 12:12:56PM +0200, Javier Martinez Canillas wrote:\n> The driver doesn't have a struct of_device_id table but supported devices\n> are registered via Device Trees as shown in the following DT binding doc:\n> \n> Documentation/devicetree/bindings/i2c/i2c-designware.txt\n\nUhhh, that needs to be fixed to something else! I don't think i2c slave\nfunctionality should be described in DT. The slave functionality is pure\nsoftware, so IMO it doesn't match the \"HW description\" requirement.\n\n> But this works on the assumption that a I2C device registered via OF will\n> always match a legacy I2C device ID and that the MODALIAS reported will\n> always be of the form i2c:.\n> \n> And this could change in the future so the correct approach is to have an\n> OF device ID table if the devices are registered via OF.\n> \n> Signed-off-by: Javier Martinez Canillas \n\nThanks for finding the issue, still NAK to this patch. Are you\ninterested in updating the docs?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xWR941cPnz9s78\n\tfor ;\n\tTue, 15 Aug 2017 05:52:40 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751565AbdHNTwi (ORCPT );\n\tMon, 14 Aug 2017 15:52:38 -0400","from sauhun.de ([88.99.104.3]:50622 \"EHLO pokefinder.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751551AbdHNTwi (ORCPT );\n\tMon, 14 Aug 2017 15:52:38 -0400","from localhost (p54B33755.dip0.t-ipconnect.de [84.179.55.85])\n\tby pokefinder.org (Postfix) with ESMTPSA id B99952C30E9;\n\tMon, 14 Aug 2017 21:52:36 +0200 (CEST)"],"Date":"Mon, 14 Aug 2017 21:52:36 +0200","From":"Wolfram Sang ","To":"Javier Martinez Canillas ","Cc":"linux-kernel@vger.kernel.org, Luis Oliveira ,\n\tlinux-i2c@vger.kernel.org","Subject":"Re: [PATCH] i2c: slave-eeprom: Add an OF device ID table","Message-ID":"<20170814195236.4miomp2omul5qikt@ninjato>","References":"<20170809101256.31204-1-javierm@redhat.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"axy4lceqhp2ztxms\"","Content-Disposition":"inline","In-Reply-To":"<20170809101256.31204-1-javierm@redhat.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1748252,"web_url":"http://patchwork.ozlabs.org/comment/1748252/","msgid":"<1b2335bb-50e5-5664-0e01-38902cf717f1@redhat.com>","list_archive_url":null,"date":"2017-08-16T09:36:25","subject":"Re: [PATCH] i2c: slave-eeprom: Add an OF device ID table","submitter":{"id":72132,"url":"http://patchwork.ozlabs.org/api/people/72132/","name":"Javier Martinez Canillas","email":"javierm@redhat.com"},"content":"Hello Wolfram,\n\nOn 08/14/2017 09:52 PM, Wolfram Sang wrote:\n> On Wed, Aug 09, 2017 at 12:12:56PM +0200, Javier Martinez Canillas wrote:\n>> The driver doesn't have a struct of_device_id table but supported devices\n>> are registered via Device Trees as shown in the following DT binding doc:\n>>\n>> Documentation/devicetree/bindings/i2c/i2c-designware.txt\n> \n> Uhhh, that needs to be fixed to something else! I don't think i2c slave\n> functionality should be described in DT. The slave functionality is pure\n> software, so IMO it doesn't match the \"HW description\" requirement.\n>\n\nRight, indeed.\n \n>> But this works on the assumption that a I2C device registered via OF will\n>> always match a legacy I2C device ID and that the MODALIAS reported will\n>> always be of the form i2c:.\n>>\n>> And this could change in the future so the correct approach is to have an\n>> OF device ID table if the devices are registered via OF.\n>>\n>> Signed-off-by: Javier Martinez Canillas \n> \n> Thanks for finding the issue, still NAK to this patch. Are you\n> interested in updating the docs?\n> \n\nWhat kind of change are you looking for? The example was introduced by commit\n04606ccc84e3 (\"i2c: designware: introducing I2C_SLAVE definitions\") that says:\n\n- A example was added to designware-core.txt Documentation that shows\n how the slave can be setup using DTS\n\nSo I could change this example to instead use a real EEPROM compatible (e.g:\n\"microchip,24c02\") instead of \"linux,slave-24c02\". Would that be correct?\n\nBest regards,","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=javierm@redhat.com"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xXPPB5rm2z9t5R\n\tfor ;\n\tWed, 16 Aug 2017 19:36:30 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751389AbdHPJg3 (ORCPT );\n\tWed, 16 Aug 2017 05:36:29 -0400","from mx1.redhat.com ([209.132.183.28]:54594 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751068AbdHPJg2 (ORCPT );\n\tWed, 16 Aug 2017 05:36:28 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 161E7CA39F;\n\tWed, 16 Aug 2017 09:36:28 +0000 (UTC)","from [10.36.117.7] (ovpn-117-7.ams2.redhat.com [10.36.117.7])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E46817DFCD;\n\tWed, 16 Aug 2017 09:36:25 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 161E7CA39F","Subject":"Re: [PATCH] i2c: slave-eeprom: Add an OF device ID table","To":"Wolfram Sang ","Cc":"linux-kernel@vger.kernel.org, Luis Oliveira ,\n\tlinux-i2c@vger.kernel.org","References":"<20170809101256.31204-1-javierm@redhat.com>\n\t<20170814195236.4miomp2omul5qikt@ninjato>","From":"Javier Martinez Canillas ","Message-ID":"<1b2335bb-50e5-5664-0e01-38902cf717f1@redhat.com>","Date":"Wed, 16 Aug 2017 11:36:25 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170814195236.4miomp2omul5qikt@ninjato>","Content-Type":"text/plain; charset=windows-1252","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 16 Aug 2017 09:36:28 +0000 (UTC)","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1748491,"web_url":"http://patchwork.ozlabs.org/comment/1748491/","msgid":"<20170816134112.GA1391@katana>","list_archive_url":null,"date":"2017-08-16T13:41:12","subject":"Re: [PATCH] i2c: slave-eeprom: Add an OF device ID table","submitter":{"id":22495,"url":"http://patchwork.ozlabs.org/api/people/22495/","name":"Wolfram Sang","email":"wsa@the-dreams.de"},"content":"> What kind of change are you looking for? The example was introduced by commit\n> 04606ccc84e3 (\"i2c: designware: introducing I2C_SLAVE definitions\") that says:\n> \n> - A example was added to designware-core.txt Documentation that shows\n> how the slave can be setup using DTS\n\nMy fault, I missed it :(\n\n> So I could change this example to instead use a real EEPROM compatible (e.g:\n> \"microchip,24c02\") instead of \"linux,slave-24c02\". Would that be correct?\n\nI think this is Luis call how he'd like this to be changed. Given the\ncurrent discussion, I'd think it must be dropped entirely.\n\nLuis?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xXVqc4slmz9t3R\n\tfor ;\n\tWed, 16 Aug 2017 23:41:16 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751969AbdHPNlP (ORCPT );\n\tWed, 16 Aug 2017 09:41:15 -0400","from www.zeus03.de ([194.117.254.33]:53638 \"EHLO mail.zeus03.de\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751530AbdHPNlO (ORCPT );\n\tWed, 16 Aug 2017 09:41:14 -0400","(qmail 5080 invoked from network); 16 Aug 2017 15:41:13 +0200","from p200300cf5bc34600021de0fffea0c865.dip0.t-ipconnect.de (HELO\n\tlocalhost) (l3s3148p1@2003:cf:5bc3:4600:21d:e0ff:fea0:c865)\n\tby mail.zeus03.de with ESMTPSA (ECDHE-RSA-AES256-GCM-SHA384\n\tencrypted, authenticated); 16 Aug 2017 15:41:13 +0200"],"Date":"Wed, 16 Aug 2017 15:41:12 +0200","From":"Wolfram Sang ","To":"Javier Martinez Canillas ","Cc":"linux-kernel@vger.kernel.org, Luis Oliveira ,\n\tlinux-i2c@vger.kernel.org","Subject":"Re: [PATCH] i2c: slave-eeprom: Add an OF device ID table","Message-ID":"<20170816134112.GA1391@katana>","References":"<20170809101256.31204-1-javierm@redhat.com>\n\t<20170814195236.4miomp2omul5qikt@ninjato>\n\t<1b2335bb-50e5-5664-0e01-38902cf717f1@redhat.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"LZvS9be/3tNcYl/X\"","Content-Disposition":"inline","In-Reply-To":"<1b2335bb-50e5-5664-0e01-38902cf717f1@redhat.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}}]