[{"id":1742577,"web_url":"http://patchwork.ozlabs.org/comment/1742577/","msgid":"","list_archive_url":null,"date":"2017-08-09T10:15:27","subject":"Re: [U-Boot] [PATCH v2] efi_loader: LocateHandle should return\n\tEFI_NOT_FOUND if none found","submitter":{"id":70394,"url":"http://patchwork.ozlabs.org/api/people/70394/","name":"Heinrich Schuchardt","email":"xypron.debian@gmx.de"},"content":"On 08/06/2017 08:10 PM, Rob Clark wrote:\n> Spotted this debugging OpenBSD's bootloader in qemu. (Wouldn't really\n> fix anything, the problem was not having any disks, but we should\n> probably return the correct error code.)\n> \n> Signed-off-by: Rob Clark \n> ---\n> v2: early-return in the EFI_NOT_FOUND case, as suggested by Heinrich\n> \n> lib/efi_loader/efi_boottime.c | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c\n> index 5ff2d2d4b0..93ca05f3ef 100644\n> --- a/lib/efi_loader/efi_boottime.c\n> +++ b/lib/efi_loader/efi_boottime.c\n> @@ -633,6 +633,10 @@ static efi_status_t EFIAPI efi_locate_handle(\n> \t\treturn EFI_BUFFER_TOO_SMALL;\n> \t}\n> \n> +\t*buffer_size = size;\n> +\tif (size == 0)\n> +\t\treturn EFI_NOT_FOUND;\n> +\n> \t/* Then fill the array */\n> \tlist_for_each(lhandle, &efi_obj_list) {\n> \t\tstruct efi_object *efiobj;\n> @@ -642,7 +646,6 @@ static efi_status_t EFIAPI efi_locate_handle(\n> \t\t}\n> \t}\n> \n> -\t*buffer_size = size;\n> \treturn EFI_SUCCESS;\n> }\n> \n> \n\n@Alex:\nThis can be directly merged into efi-next. It has no further prerequisites.\n\nReviewed-by: Heinrich Schuchardt ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xS6br4MPLz9s76\n\tfor ;\n\tWed, 9 Aug 2017 20:15:51 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 7B835C21EE5; Wed, 9 Aug 2017 10:15:40 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 5CDB9C21D56;\n\tWed, 9 Aug 2017 10:15:38 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 27259C21D56; Wed, 9 Aug 2017 10:15:37 +0000 (UTC)","from mout.gmx.net (mout.gmx.net [212.227.17.21])\n\tby lists.denx.de (Postfix) with ESMTPS id C5704C21C57\n\tfor ; Wed, 9 Aug 2017 10:15:36 +0000 (UTC)","from [192.168.123.55] ([84.118.154.110]) by mail.gmx.com (mrgmx103\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id\n\t0M5MIN-1dQdfE08BL-00zVGI; Wed, 09 Aug 2017 12:15:35 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","To":"Rob Clark ,\n\tU-Boot Mailing List ","References":"<20170806181009.30129-1-robdclark@gmail.com>","From":"Heinrich Schuchardt ","Message-ID":"","Date":"Wed, 9 Aug 2017 12:15:27 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170806181009.30129-1-robdclark@gmail.com>","Content-Language":"en-US","X-Provags-ID":"V03:K0:VsKa5dvK78p7tPNwMSSNoi44PglgDAH++9P9NrDDoTGiOwVdpdm\n\t8J70n3vhOYQQ7ippLf729/jZPWc8fQ/LgYV2UK1DPOk7qGfaazg5Fk7eBn3KQU+YK/AfGlb\n\tJfkNvKTfGGBjDxbGvCXShZCc3q0uQjclT6Rsqdxss0Jm9y9apaoIUxJqvS8e1KqvUh/MvZu\n\t/JhflOXgxooTOmGBQCF8g==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:Lip/SgO2eLU=:uI50A5gNCDeq8gaTVT46q2\n\tceiU6F3xoNuZWUOEPgF0EaTGnBNCr6pzidWRRPCPwCcCBQbzFsGncdI7PSgl5vLhbrDI74V0r\n\tNQDcDM4Xrs7R/x8+SY3D/u8fOmHK7TcrEfGXD9JAuk1mLIsKA1pfcCSxRXBjJPpLkJJXL3roB\n\tG8mqHu7kaGcN4J1ltNmpyz2JsWkocyU7Vb4YvHXc9r3PYmdSnon5EOTRMCgzb+wS/vzOI5mSu\n\tXb+YqEz2GWuPjZCDagxbTgmXTf6OsSCCBUWkjbX1WPdUa4VSNPhqEPY+zzq945GXta2yvq4Lp\n\teu/mwINGMCZ4wpBha3TsinYfrRKDU6Z10ZjXcoQ+s231a5T033g9SzOBFeweNLnNEqGL+97Cz\n\tT34X3sm24IMTzBJzAS0SdS05vsblKXsHzN2LJ36ZMHVWw7BhoMjFwofE5OTwWYU9hihRMUmm2\n\t57ITZ3URRvxEU/pnl8+P3RCtIzw//CQ+f7OG39/1odf0RPQkmkpj4llbm0SCerbBOgyUf3p6P\n\tBtylTnCoTkOHyyFtLOmIHDg8obZF+VkainuFnIaKiWYtxMYjqcBayjfLd86MGgT1eim8Twx9K\n\tGKi2o4y70ucilPDmdd7fwRniGL8wn7L7j+93//8bodmR8/4LBF8LEDtT40MPQ9fP4mgVygWBw\n\tnG4z+rtsfe3VG9FB9Xew7bOdE2YYMPOyU6mfpvvVzTmEYDA46usjZTBULCUsMJ/R5AKVRg+pH\n\t0+0yyi1UlFag1YXg/kTo7Wz62Le3LN6fx928mbAcjYUYg1jPtx1++rmg0k5YZQzficS3xAUQs\n\tMuS66dbPqc5poUCsxx/UnNHF569bu/1dLJaVomoK53dIJJO6RM=","Subject":"Re: [U-Boot] [PATCH v2] efi_loader: LocateHandle should return\n\tEFI_NOT_FOUND if none found","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1761159,"web_url":"http://patchwork.ozlabs.org/comment/1761159/","msgid":"<150419640830.87928.12140757485857848293@achrid.arch.suse.de>","list_archive_url":null,"date":"2017-08-31T16:20:09","subject":"Re: [U-Boot] [U-Boot,\n\tv2] efi_loader: LocateHandle should return EFI_NOT_FOUND if none\n\tfound","submitter":{"id":1212,"url":"http://patchwork.ozlabs.org/api/people/1212/","name":"Alexander Graf","email":"agraf@suse.de"},"content":"> Spotted this debugging OpenBSD's bootloader in qemu. (Wouldn't really\n> fix anything, the problem was not having any disks, but we should\n> probably return the correct error code.)\n> \n> Signed-off-by: Rob Clark \n> Reviewed-by: Heinrich Schuchardt \n\nThanks, applied to efi-next\n\nAlex","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjnfL4fmYz9sPm\n\tfor ;\n\tFri, 1 Sep 2017 02:20:25 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 4BCCFC21EAB; Thu, 31 Aug 2017 16:20:14 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id B2886C21D09;\n\tThu, 31 Aug 2017 16:20:12 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 7BE10C21D09; Thu, 31 Aug 2017 16:20:10 +0000 (UTC)","from mx1.suse.de (mx2.suse.de [195.135.220.15])\n\tby lists.denx.de (Postfix) with ESMTPS id 28FFBC21C40\n\tfor ; Thu, 31 Aug 2017 16:20:10 +0000 (UTC)","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id A8576AEBB;\n\tThu, 31 Aug 2017 16:20:09 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","From":"Alexander Graf ","To":"Rob Clark ","Date":"Thu, 31 Aug 2017 18:20:09 +0200","Message-Id":"<150419640830.87928.12140757485857848293@achrid.arch.suse.de>","X-Mailer":"git-send-email 2.12.3","In-Reply-To":"<20170806181009.30129-1-robdclark@gmail.com>","References":"<20170806181009.30129-1-robdclark@gmail.com>","MIME-Version":": 1.0","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [U-Boot,\n\tv2] efi_loader: LocateHandle should return EFI_NOT_FOUND if none\n\tfound","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]