[{"id":1736336,"web_url":"http://patchwork.ozlabs.org/comment/1736336/","msgid":"","date":"2017-08-02T18:54:58","subject":"RE: [PATCH] usb: gadget: fsl_qe_udc: constify qe_ep0_desc","submitter":{"id":68093,"url":"http://patchwork.ozlabs.org/api/people/68093/","name":"Leo Li","email":"leoyang.li@nxp.com"},"content":"> -----Original Message-----\n> From: Julia Lawall [mailto:Julia.Lawall@lip6.fr]\n> Sent: Wednesday, August 02, 2017 10:29 AM\n> To: Leo Li \n> Cc: kernel-janitors@vger.kernel.org; Felipe Balbi ; Greg\n> Kroah-Hartman ; linux-usb@vger.kernel.org;\n> linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Bhumika Goyal\n> \n> Subject: [PATCH] usb: gadget: fsl_qe_udc: constify qe_ep0_desc\n> \n> qe_ep0_desc is only passed as the second argument to qe_ep_init, which is\n> const, so qe_ep0_desc can be const too.\n> \n> Done with the help of Coccinelle.\n> \n> Signed-off-by: Julia Lawall \n\nAcked-by: Li Yang \n\n> \n> ---\n> I got a lot of warnings when compiling this file, but none seemed to be related\n> to the change.\n> \n> drivers/usb/gadget/udc/fsl_qe_udc.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c\n> b/drivers/usb/gadget/udc/fsl_qe_udc.c\n> index 303328ce..a3e72d6 100644\n> --- a/drivers/usb/gadget/udc/fsl_qe_udc.c\n> +++ b/drivers/usb/gadget/udc/fsl_qe_udc.c\n> @@ -62,7 +62,7 @@\n> \t\"ep3\",\n> };\n> \n> -static struct usb_endpoint_descriptor qe_ep0_desc = {\n> +static const struct usb_endpoint_descriptor qe_ep0_desc = {\n> \t.bLength =\t\tUSB_DT_ENDPOINT_SIZE,\n> \t.bDescriptorType =\tUSB_DT_ENDPOINT,\n>","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xN2WH4K0Bz9tWC\n\tfor ;\n\tThu, 3 Aug 2017 04:57:47 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xN2WH0KkvzDr5g\n\tfor ;\n\tThu, 3 Aug 2017 04:57:47 +1000 (AEST)","from EUR01-VE1-obe.outbound.protection.outlook.com\n\t(mail-ve1eur01on0083.outbound.protection.outlook.com [104.47.1.83])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xN2SB1J1TzDr5T\n\tfor ;\n\tThu, 3 Aug 2017 04:55:05 +1000 (AEST)","from AM4PR0401MB1699.eurprd04.prod.outlook.com (10.165.244.21) by\n\tAM4PR0401MB1698.eurprd04.prod.outlook.com (10.165.244.20) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.1.1304.22; Wed, 2 Aug 2017 18:54:58 +0000","from AM4PR0401MB1699.eurprd04.prod.outlook.com\n\t([fe80::a0c6:44e5:7e5c:cd49]) by\n\tAM4PR0401MB1699.eurprd04.prod.outlook.com\n\t([fe80::a0c6:44e5:7e5c:cd49%14]) with mapi id 15.01.1304.023;\n\tWed, 2 Aug 2017 18:54:58 +0000"],"Authentication-Results":["ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"QNYe5gk6\";\n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"QNYe5gk6\";\n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"QNYe5gk6\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=leoyang.li@nxp.com; "],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=MUMHjlkwbFYOKiHUoHvi0Nv0DjFxeX3Mld2ekCPKmcg=;\n\tb=QNYe5gk61/L6ehUL5REHuj5N0S6E/Mh04BsXEGERepoYo1DaEp8OtATCW2rf+419JyAmEEH0xFRoAcRZLw/jpfJeYSKyilXnyOQM7gwjTSR7q4Rk4lxZkmv+LQX2J904aUkAF7HWALpfjASM83jN6ISfuItwT2KKqIqD34CVHOQ=","From":"Leo Li ","To":"Julia Lawall ","Subject":"RE: [PATCH] usb: gadget: fsl_qe_udc: constify qe_ep0_desc","Thread-Topic":"[PATCH] usb: gadget: fsl_qe_udc: constify qe_ep0_desc","Thread-Index":"AQHTC6evtOqZI+fk4UOdyP+TiCw4L6Jxaigw","Date":"Wed, 2 Aug 2017 18:54:58 +0000","Message-ID":"","References":"<1501687767-12768-1-git-send-email-Julia.Lawall@lip6.fr>","In-Reply-To":"<1501687767-12768-1-git-send-email-Julia.Lawall@lip6.fr>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"QNYe5gk6\";\n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"QNYe5gk6\";\n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"QNYe5gk6\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=leoyang.li@nxp.com; "],"x-originating-ip":"[192.88.168.50]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; AM4PR0401MB1698;\n\t7:TNdwquSfGq+odI7BvpWalned1J1YWfrfebojJAZEAGewF9rQ40S8llPQAJCkW1vLDb/amgDI9+WJVYk7xO/mcKzK4YPh7HKTNxuc0yJBofviNJ02rQYc+cSmK/1st3iCFzHMWpI0ul1v/8GqkrkBPfY1FSF/reQtAUHJMqiXEDdM0MjFkCy5FPuL+RtQjNoMr+FOO+0FBmNhUPYraRF51Gwiz2rM8Cn1SRW3wjS+FUrifGcR4jdOmBV8bc3nTCJKb0cBsSaKQxHFgTvEEnJyYv+XW6ulgA+zNDexvNdXXFLIsneNIMQFP4F9tvdLhx/PmDdeaZfJ3ur1i5b1b8V8dyoLMB1qx9mApxPS0JuArz7XIuhdqX6bagiIH03OA6TDrOYH51r5lk3LbjhkpytJ48M8Ml5qWn6RHwPkMRNYgfYPfYhIugdtCeiV60q9f/gl2LavXDZircyy4QJJ/X1SXRUh/MY3OqsYEjWOidzQSFfNVxPGULok+C99V+vZTIMv4XVpSlb9mZhMxofK6oNFA3pgANcnd6aXyom65KzPXavk5DSsCo2E1dlX4Hz59U5JXyxsal9BI8Ugo+H67RRjv3qphpRuYBRp7qQ2KyTTR8l6yJMFJzkll6O34MyCg9qVWHjFyuyx6paMPrcXyysk3S5ZzCKKvkxhWb/Zyv9Ax3Bctohp9XAcf6MVqAbLcrVOHrVBpmLEmwvJKNtLKae2HzJT0NPsE2uzzS4Zm7ucrhewW0tDwngCu7f50NJ8v/PZQ2NT8P8R+UipYnr/hCWsEPLCLLfXwY3wERaG+PgDGn0=","x-ms-office365-filtering-correlation-id":"2931bd6f-dbe0-4f8e-948f-08d4d9d7f8e7","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:AM4PR0401MB1698; ","x-ms-traffictypediagnostic":"AM4PR0401MB1698:","x-exchange-antispam-report-test":"UriScan:(9452136761055)(65623756079841)(185117386973197); ","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123560025)(20161123555025)(20161123558100)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:AM4PR0401MB1698; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:AM4PR0401MB1698; ","x-forefront-prvs":"0387D64A71","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39410400002)(39400400002)(39450400003)(39860400002)(39840400002)(39850400002)(189002)(377454003)(199003)(13464003)(2906002)(14454004)(7736002)(97736004)(86362001)(3660700001)(305945005)(478600001)(2900100001)(99286003)(102836003)(6116002)(3280700002)(189998001)(54356999)(6506006)(25786009)(2950100002)(50986999)(6916009)(54906002)(3846002)(9686003)(76176999)(4326008)(68736007)(53936002)(55016002)(101416001)(229853002)(39060400002)(5250100002)(105586002)(106356001)(6246003)(38730400002)(110136004)(7696004)(53546010)(5660300001)(33656002)(81166006)(8676002)(74316002)(8936002)(81156014)(6436002)(66066001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0401MB1698;\n\tH:AM4PR0401MB1699.eurprd04.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"02 Aug 2017 18:54:58.2267\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM4PR0401MB1698","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Felipe Balbi ,\n\tGreg Kroah-Hartman ,\n\t\"linux-usb@vger.kernel.org\" ,\n\t\"kernel-janitors@vger.kernel.org\" , \n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"linuxppc-dev@lists.ozlabs.org\" ,\n\tBhumika Goyal ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]