[{"id":1725788,"web_url":"http://patchwork.ozlabs.org/comment/1725788/","msgid":"<20170721184848.GU18556@csclub.uwaterloo.ca>","list_archive_url":null,"date":"2017-07-21T18:48:48","subject":"Re: [Intel-wired-lan] [PATCH 5/5] e1000e: Avoid receiver overrun\n\tinterrupt bursts","submitter":{"id":936,"url":"http://patchwork.ozlabs.org/api/people/936/","name":"Lennart Sorensen","email":"lsorense@csclub.uwaterloo.ca"},"content":"On Fri, Jul 21, 2017 at 11:36:27AM -0700, Benjamin Poirier wrote:\n> When e1000e_poll() is not fast enough to keep up with incoming traffic, the\n> adapter (when operating in msix mode) raises the Other interrupt to signal\n> Receiver Overrun.\n> \n> This is a double problem because 1) at the moment e1000_msix_other()\n> assumes that it is only called in case of Link Status Change and 2) if the\n> condition persists, the interrupt is repeatedly raised again in quick\n> succession.\n> \n> Ideally we would configure the Other interrupt to not be raised in case of\n> receiver overrun but this doesn't seem possible on this adapter. Instead,\n> we handle the first part of the problem by reverting to the practice of\n> reading ICR in the other interrupt handler, like before commit 16ecba59bc33\n> (\"e1000e: Do not read ICR in Other interrupt\"). Thanks to commit\n> 0a8047ac68e5 (\"e1000e: Fix msi-x interrupt automask\") which cleared IAME\n> from CTRL_EXT, reading ICR doesn't interfere with RxQ0, TxQ0 interrupts\n> anymore. We handle the second part of the problem by not re-enabling the\n> Other interrupt right away when there is overrun. Instead, we wait until\n> traffic subsides, napi polling mode is exited and interrupts are\n> re-enabled.\n> \n> Reported-by: Lennart Sorensen \n> Fixes: 16ecba59bc33 (\"e1000e: Do not read ICR in Other interrupt\")\n> Signed-off-by: Benjamin Poirier \n\nAny chance of this fix hitting -stable? After all adapter reset under\nload is not nice.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xDftf3K1jz9s4s\n\tfor ;\n\tSat, 22 Jul 2017 04:48:58 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A3FDB8A1D8;\n\tFri, 21 Jul 2017 18:48:56 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id WJBjLnH2aSrV; Fri, 21 Jul 2017 18:48:54 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id AD9208A17A;\n\tFri, 21 Jul 2017 18:48:54 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 55A0E1C0964\n\tfor ;\n\tFri, 21 Jul 2017 18:48:53 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4829588110\n\tfor ;\n\tFri, 21 Jul 2017 18:48:53 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id laZesxYTDghf for ;\n\tFri, 21 Jul 2017 18:48:50 +0000 (UTC)","from caffeine.csclub.uwaterloo.ca (caffeine.csclub.uwaterloo.ca\n\t[129.97.134.17])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 930CD8810D\n\tfor ;\n\tFri, 21 Jul 2017 18:48:50 +0000 (UTC)","by caffeine.csclub.uwaterloo.ca (Postfix, from userid 20367)\n\tid 89AC2C006D; Fri, 21 Jul 2017 14:48:48 -0400 (EDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","Date":"Fri, 21 Jul 2017 14:48:48 -0400","To":"Benjamin Poirier ","Message-ID":"<20170721184848.GU18556@csclub.uwaterloo.ca>","References":"<20170721160937.GA22632@csclub.uwaterloo.ca>\n\t<20170721183627.13373-1-bpoirier@suse.com>\n\t<20170721183627.13373-5-bpoirier@suse.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170721183627.13373-5-bpoirier@suse.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","From":"lsorense@csclub.uwaterloo.ca (Lennart Sorensen)","Cc":"netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [Intel-wired-lan] [PATCH 5/5] e1000e: Avoid receiver overrun\n\tinterrupt bursts","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":1746248,"web_url":"http://patchwork.ozlabs.org/comment/1746248/","msgid":"","list_archive_url":null,"date":"2017-08-12T02:47:14","subject":"Re: [Intel-wired-lan] [PATCH 5/5] e1000e: Avoid receiver overrun\n\tinterrupt bursts","submitter":{"id":1599,"url":"http://patchwork.ozlabs.org/api/people/1599/","name":"Philip Prindeville","email":"philipp_subx@redfish-solutions.com"},"content":"> On Aug 11, 2017, at 8:13 PM, Philip Prindeville wrote:\n> \n>> \n>> On Jul 21, 2017, at 12:48 PM, Lennart Sorensen wrote:\n>> \n>> On Fri, Jul 21, 2017 at 11:36:27AM -0700, Benjamin Poirier wrote:\n>>> When e1000e_poll() is not fast enough to keep up with incoming traffic, the\n>>> adapter (when operating in msix mode) raises the Other interrupt to signal\n>>> Receiver Overrun.\n>>> \n>>> This is a double problem because 1) at the moment e1000_msix_other()\n>>> assumes that it is only called in case of Link Status Change and 2) if the\n>>> condition persists, the interrupt is repeatedly raised again in quick\n>>> succession.\n>>> \n>>> Ideally we would configure the Other interrupt to not be raised in case of\n>>> receiver overrun but this doesn't seem possible on this adapter. Instead,\n>>> we handle the first part of the problem by reverting to the practice of\n>>> reading ICR in the other interrupt handler, like before commit 16ecba59bc33\n>>> (\"e1000e: Do not read ICR in Other interrupt\"). Thanks to commit\n>>> 0a8047ac68e5 (\"e1000e: Fix msi-x interrupt automask\") which cleared IAME\n>>> from CTRL_EXT, reading ICR doesn't interfere with RxQ0, TxQ0 interrupts\n>>> anymore. We handle the second part of the problem by not re-enabling the\n>>> Other interrupt right away when there is overrun. Instead, we wait until\n>>> traffic subsides, napi polling mode is exited and interrupts are\n>>> re-enabled.\n>>> \n>>> Reported-by: Lennart Sorensen \n>>> Fixes: 16ecba59bc33 (\"e1000e: Do not read ICR in Other interrupt\")\n>>> Signed-off-by: Benjamin Poirier \n>> \n>> Any chance of this fix hitting -stable? After all adapter reset under\n>> load is not nice.\n>> \n> \n> \n> I tried this patch sequence and I’m seeing a 2% drop in throughput. CPU utilization at softIRQ is also about 8% higher. The previous single patch that went out to fix this problem had better performance.\n> \n> This is on an Atom D525 with an 82574L and running 2 GB streams across a pair of interfaces with iperf3.\n> \n> -Philip\n\n\nActually, after turning off MSI-X mode (and using MSI mode instead), and setting InterruptRateThrottle to “4” (conservative dynamic mode) across all interfaces, I’m actually seeing slightly better throughput than the earlier patch… with comparable overall CPU utilization and SoftIRQ utilization.\n\nSo setting the module parameters correctly for routing (and not end-system parameters) makes a big difference when routing.\n\n-Philip","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xW9xM08Fcz9s76\n\tfor ;\n\tMon, 14 Aug 2017 19:56:38 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0DBE5230DA;\n\tMon, 14 Aug 2017 09:56:37 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id L7RZAohpjHcw; Mon, 14 Aug 2017 09:56:36 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 930353013B;\n\tMon, 14 Aug 2017 09:56:35 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id C5AEA1C0670\n\tfor ;\n\tSat, 12 Aug 2017 02:47:21 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B923A88F65\n\tfor ;\n\tSat, 12 Aug 2017 02:47:21 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id I5PxurlrOUgc for ;\n\tSat, 12 Aug 2017 02:47:21 +0000 (UTC)","from mail.redfish-solutions.com (mail.redfish-solutions.com\n\t[66.232.79.143])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 199B988BDC\n\tfor ;\n\tSat, 12 Aug 2017 02:47:21 +0000 (UTC)","from macmini.redfish-solutions.com (macmini.redfish-solutions.com\n\t[192.168.1.38]) (authenticated bits=0)\n\tby mail.redfish-solutions.com (8.15.2/8.15.2) with ESMTPSA id\n\tv7C2lE2q029107\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NO); Fri, 11 Aug 2017 20:47:14 -0600"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","From":"Philip Prindeville ","In-Reply-To":"<49B1F3E9-2A99-4AD6-9574-FC3960E67A77@redfish-solutions.com>","Date":"Fri, 11 Aug 2017 20:47:14 -0600","Message-Id":"","References":"<20170721160937.GA22632@csclub.uwaterloo.ca>\n\t<20170721183627.13373-1-bpoirier@suse.com>\n\t<20170721183627.13373-5-bpoirier@suse.com>\n\t<20170721184848.GU18556@csclub.uwaterloo.ca>\n\t<49B1F3E9-2A99-4AD6-9574-FC3960E67A77@redfish-solutions.com>","To":"Lennart Sorensen ","X-Mailer":"Apple Mail (2.3273)","X-Scanned-By":"MIMEDefang 2.79 on 192.168.1.3","X-Mailman-Approved-At":"Mon, 14 Aug 2017 09:56:33 +0000","Cc":"Benjamin Poirier , netdev@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org","Subject":"Re: [Intel-wired-lan] [PATCH 5/5] e1000e: Avoid receiver overrun\n\tinterrupt bursts","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":1746249,"web_url":"http://patchwork.ozlabs.org/comment/1746249/","msgid":"<49B1F3E9-2A99-4AD6-9574-FC3960E67A77@redfish-solutions.com>","list_archive_url":null,"date":"2017-08-12T02:13:47","subject":"Re: [Intel-wired-lan] [PATCH 5/5] e1000e: Avoid receiver overrun\n\tinterrupt bursts","submitter":{"id":1599,"url":"http://patchwork.ozlabs.org/api/people/1599/","name":"Philip Prindeville","email":"philipp_subx@redfish-solutions.com"},"content":"> On Jul 21, 2017, at 12:48 PM, Lennart Sorensen wrote:\n> \n> On Fri, Jul 21, 2017 at 11:36:27AM -0700, Benjamin Poirier wrote:\n>> When e1000e_poll() is not fast enough to keep up with incoming traffic, the\n>> adapter (when operating in msix mode) raises the Other interrupt to signal\n>> Receiver Overrun.\n>> \n>> This is a double problem because 1) at the moment e1000_msix_other()\n>> assumes that it is only called in case of Link Status Change and 2) if the\n>> condition persists, the interrupt is repeatedly raised again in quick\n>> succession.\n>> \n>> Ideally we would configure the Other interrupt to not be raised in case of\n>> receiver overrun but this doesn't seem possible on this adapter. Instead,\n>> we handle the first part of the problem by reverting to the practice of\n>> reading ICR in the other interrupt handler, like before commit 16ecba59bc33\n>> (\"e1000e: Do not read ICR in Other interrupt\"). Thanks to commit\n>> 0a8047ac68e5 (\"e1000e: Fix msi-x interrupt automask\") which cleared IAME\n>> from CTRL_EXT, reading ICR doesn't interfere with RxQ0, TxQ0 interrupts\n>> anymore. We handle the second part of the problem by not re-enabling the\n>> Other interrupt right away when there is overrun. Instead, we wait until\n>> traffic subsides, napi polling mode is exited and interrupts are\n>> re-enabled.\n>> \n>> Reported-by: Lennart Sorensen \n>> Fixes: 16ecba59bc33 (\"e1000e: Do not read ICR in Other interrupt\")\n>> Signed-off-by: Benjamin Poirier \n> \n> Any chance of this fix hitting -stable? After all adapter reset under\n> load is not nice.\n> \n\n\nI tried this patch sequence and I’m seeing a 2% drop in throughput. CPU utilization at softIRQ is also about 8% higher. The previous single patch that went out to fix this problem had better performance.\n\nThis is on an Atom D525 with an 82574L and running 2 GB streams across a pair of interfaces with iperf3.\n\n-Philip","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xW9xM0MGKz9t2r\n\tfor ;\n\tMon, 14 Aug 2017 19:56:38 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1D1693013B;\n\tMon, 14 Aug 2017 09:56:37 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TYuE7tRvNHdX; Mon, 14 Aug 2017 09:56:35 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 30C8E300F4;\n\tMon, 14 Aug 2017 09:56:35 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id BDA9E1C02E8\n\tfor ;\n\tSat, 12 Aug 2017 02:13:54 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id AF04488D38\n\tfor ;\n\tSat, 12 Aug 2017 02:13:54 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id q5RcytDgxwQr for ;\n\tSat, 12 Aug 2017 02:13:54 +0000 (UTC)","from mail.redfish-solutions.com (mail.redfish-solutions.com\n\t[66.232.79.143])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 0252188C9F\n\tfor ;\n\tSat, 12 Aug 2017 02:13:53 +0000 (UTC)","from macmini.redfish-solutions.com (macmini.redfish-solutions.com\n\t[192.168.1.38]) (authenticated bits=0)\n\tby mail.redfish-solutions.com (8.15.2/8.15.2) with ESMTPSA id\n\tv7C2DliP028932\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NO); Fri, 11 Aug 2017 20:13:47 -0600"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","From":"Philip Prindeville ","In-Reply-To":"<20170721184848.GU18556@csclub.uwaterloo.ca>","Date":"Fri, 11 Aug 2017 20:13:47 -0600","Message-Id":"<49B1F3E9-2A99-4AD6-9574-FC3960E67A77@redfish-solutions.com>","References":"<20170721160937.GA22632@csclub.uwaterloo.ca>\n\t<20170721183627.13373-1-bpoirier@suse.com>\n\t<20170721183627.13373-5-bpoirier@suse.com>\n\t<20170721184848.GU18556@csclub.uwaterloo.ca>","To":"Lennart Sorensen ","X-Mailer":"Apple Mail (2.3273)","X-Scanned-By":"MIMEDefang 2.79 on 192.168.1.3","X-Mailman-Approved-At":"Mon, 14 Aug 2017 09:56:33 +0000","Cc":"Benjamin Poirier , netdev@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org","Subject":"Re: [Intel-wired-lan] [PATCH 5/5] e1000e: Avoid receiver overrun\n\tinterrupt bursts","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":1753137,"web_url":"http://patchwork.ozlabs.org/comment/1753137/","msgid":"<20170821171715.iutchfoz3ksutcvw@f1.synalogic.ca>","list_archive_url":null,"date":"2017-08-21T17:17:15","subject":"Re: [Intel-wired-lan] [PATCH 5/5] e1000e: Avoid receiver overrun\n\tinterrupt bursts","submitter":{"id":7049,"url":"http://patchwork.ozlabs.org/api/people/7049/","name":"Benjamin Poirier","email":"benjamin.poirier@gmail.com"},"content":"On 2017/07/21 11:36, Benjamin Poirier wrote:\n> When e1000e_poll() is not fast enough to keep up with incoming traffic, the\n> adapter (when operating in msix mode) raises the Other interrupt to signal\n> Receiver Overrun.\n> \n> This is a double problem because 1) at the moment e1000_msix_other()\n> assumes that it is only called in case of Link Status Change and 2) if the\n> condition persists, the interrupt is repeatedly raised again in quick\n> succession.\n> \n> Ideally we would configure the Other interrupt to not be raised in case of\n> receiver overrun but this doesn't seem possible on this adapter. Instead,\n> we handle the first part of the problem by reverting to the practice of\n> reading ICR in the other interrupt handler, like before commit 16ecba59bc33\n> (\"e1000e: Do not read ICR in Other interrupt\"). Thanks to commit\n> 0a8047ac68e5 (\"e1000e: Fix msi-x interrupt automask\") which cleared IAME\n> from CTRL_EXT, reading ICR doesn't interfere with RxQ0, TxQ0 interrupts\n> anymore. We handle the second part of the problem by not re-enabling the\n> Other interrupt right away when there is overrun. Instead, we wait until\n> traffic subsides, napi polling mode is exited and interrupts are\n> re-enabled.\n> \n> Reported-by: Lennart Sorensen \n> Fixes: 16ecba59bc33 (\"e1000e: Do not read ICR in Other interrupt\")\n> Signed-off-by: Benjamin Poirier \n\nWhat's the status on these patches please? One month later they still\nshow up as \"new\" in patchwork.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"eVdffjuY\"; dkim-atps=neutral"],"Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xbjgK4gHDz9s7v\n\tfor ;\n\tTue, 22 Aug 2017 05:00:13 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8517B86C53;\n\tMon, 21 Aug 2017 19:00:11 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id H6WrTTTeUQI0; Mon, 21 Aug 2017 19:00:09 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3EDB086CEC;\n\tMon, 21 Aug 2017 19:00:09 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id E2A631C0679\n\tfor ;\n\tMon, 21 Aug 2017 17:17:19 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id DB32386A90\n\tfor ;\n\tMon, 21 Aug 2017 17:17:19 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ECaJYiqWfGHG for ;\n\tMon, 21 Aug 2017 17:17:18 +0000 (UTC)","from mail-pg0-f65.google.com (mail-pg0-f65.google.com\n\t[74.125.83.65])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 963BA86A8E\n\tfor ;\n\tMon, 21 Aug 2017 17:17:18 +0000 (UTC)","by mail-pg0-f65.google.com with SMTP id n4so9766482pgn.0\n\tfor ;\n\tMon, 21 Aug 2017 10:17:18 -0700 (PDT)","from f1.synalogic.ca (96-67-208-254-static.hfc.comcastbusiness.net.\n\t[96.67.208.254]) by smtp.gmail.com with ESMTPSA id\n\ty9sm8992365pfb.50.2017.08.21.10.17.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 21 Aug 2017 10:17:17 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=P73JyGFmnfrhAale2TCRxzjU3cQjP+GvZLFq42qpWY4=;\n\tb=eVdffjuYlnn/+mcKRF0CIr120R3+ZVxeNca37eZ6q0nEu15d/4f1fZ6I7IB61PO/nz\n\tGcqZRMKhr9T6Z47/jukHNVhP6IkGD8lJ0OzrGM6iGs7W7ou5shFnWKOYkhiPz6S8THOR\n\tRgOrD0tkrYnuCLDP1YbZrdKtHq5ULSWkDg89ToMp3IW1meIGR+r+Ss8JbxmH8zIppl76\n\tbvPvnOrVpfdI+NT4EGtdeanrZBQtK+SwrZp5GH0RoWO42RCr0wi6wSywar1qa+BjEkDx\n\t7EDKq0w90fXgF/ihWAYl/YoglVxYzwhpKZzUl95xkVFK9N+6Cv+tcxbNlJrSEDe3d8zx\n\t9qpA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=P73JyGFmnfrhAale2TCRxzjU3cQjP+GvZLFq42qpWY4=;\n\tb=Y/asUSgV0fdG5IDH36McDCk68KDZcUB2iDXOT4tlBb65gc9GlX0gVi/blvHuEygY6V\n\tkJaHsgOthwM3Dh6Zn7+OmIYjc5ca78/T0f/dUk/rU+mNbXn9C5sCIm6qPJIqR2UAzaSe\n\tn0eQcjVv4DUOD0r/IpjYTFpL7FrLryYkVVDmqvD8477EYUMRx7XoDvUwl9U6442i625r\n\tJpdcYR0jpOw/j4qFD9zdd8pUc7tdFpPJT2G4ERepgjvrD2TXwxznB00w+m8aR+rUEQ2t\n\tVoQAbRrgajzsVGcdwmhpHB8/4Tq+b7wQt3J7uOHuX6SgCHPF6Hc7IkW7/aOI0IQ45iAg\n\tbMhQ==","X-Gm-Message-State":"AHYfb5gqNkKuGG36RttJArzGqbP8veUU58hj6p84rdDLgvxbQDyIbWdc\n\t0mv+4ftG1Cgq/A==","X-Received":"by 10.84.241.197 with SMTP id t5mr20516642plm.473.1503335838199; \n\tMon, 21 Aug 2017 10:17:18 -0700 (PDT)","Date":"Mon, 21 Aug 2017 10:17:15 -0700","From":"Benjamin Poirier ","To":"\"Neftin, Sasha\" ,\n\tJeff Kirsher ","Message-ID":"<20170821171715.iutchfoz3ksutcvw@f1.synalogic.ca>","References":"<20170721160937.GA22632@csclub.uwaterloo.ca>\n\t<20170721183627.13373-1-bpoirier@suse.com>\n\t<20170721183627.13373-5-bpoirier@suse.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170721183627.13373-5-bpoirier@suse.com>","User-Agent":"NeoMutt/20170421 (1.8.2)","X-Mailman-Approved-At":"Mon, 21 Aug 2017 19:00:08 +0000","Cc":"netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org,\n\tLennart Sorensen ","Subject":"Re: [Intel-wired-lan] [PATCH 5/5] e1000e: Avoid receiver overrun\n\tinterrupt bursts","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":1768888,"web_url":"http://patchwork.ozlabs.org/comment/1768888/","msgid":"<309B89C4C689E141A5FF6A0C5FB2118B8C6A05EC@ORSMSX101.amr.corp.intel.com>","list_archive_url":null,"date":"2017-09-15T00:38:22","subject":"Re: [Intel-wired-lan] [PATCH 5/5] e1000e: Avoid receiver\n\toverrun\tinterrupt bursts","submitter":{"id":37025,"url":"http://patchwork.ozlabs.org/api/people/37025/","name":"Brown, Aaron F","email":"aaron.f.brown@intel.com"},"content":"> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf\n> Of Benjamin Poirier\n> Sent: Friday, July 21, 2017 11:36 AM\n> To: Kirsher, Jeffrey T \n> Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-\n> kernel@vger.kernel.org; Lennart Sorensen \n> Subject: [Intel-wired-lan] [PATCH 5/5] e1000e: Avoid receiver overrun\n> interrupt bursts\n> \n> When e1000e_poll() is not fast enough to keep up with incoming traffic, the\n> adapter (when operating in msix mode) raises the Other interrupt to signal\n> Receiver Overrun.\n> \n> This is a double problem because 1) at the moment e1000_msix_other()\n> assumes that it is only called in case of Link Status Change and 2) if the\n> condition persists, the interrupt is repeatedly raised again in quick\n> succession.\n> \n> Ideally we would configure the Other interrupt to not be raised in case of\n> receiver overrun but this doesn't seem possible on this adapter. Instead,\n> we handle the first part of the problem by reverting to the practice of\n> reading ICR in the other interrupt handler, like before commit 16ecba59bc33\n> (\"e1000e: Do not read ICR in Other interrupt\"). Thanks to commit\n> 0a8047ac68e5 (\"e1000e: Fix msi-x interrupt automask\") which cleared IAME\n> from CTRL_EXT, reading ICR doesn't interfere with RxQ0, TxQ0 interrupts\n> anymore. We handle the second part of the problem by not re-enabling the\n> Other interrupt right away when there is overrun. Instead, we wait until\n> traffic subsides, napi polling mode is exited and interrupts are\n> re-enabled.\n> \n> Reported-by: Lennart Sorensen \n> Fixes: 16ecba59bc33 (\"e1000e: Do not read ICR in Other interrupt\")\n> Signed-off-by: Benjamin Poirier \n> ---\n> drivers/net/ethernet/intel/e1000e/defines.h | 1 +\n> drivers/net/ethernet/intel/e1000e/netdev.c | 33\n> +++++++++++++++++++++++------\n> 2 files changed, 27 insertions(+), 7 deletions(-)\n> \n\nI get an error and a few warnings out of checkpatch from this, but I think the error is false (thinking the reference to a commit in the description is this commit, a fixes commit or something like that) and I'm more concerned with the fix than the warnings, so...\n\nTested-by: Aaron Brown \n\nHere is the checkpatch output in case anyone has a different opinion on the severity:\n-------------\nu1484:[0]/usr/src/kernels/next-queue> git format-patch d81d1e6 -1 --stdout|./scripts/checkpatch.pl -\nERROR: Please use git commit description style 'commit <12+ chars of sha1> (\"\")' - ie: 'commit 0a8047ac68e5 (\"e1000e: Fix msi-x interrupt automask\")'\n#20:\n0a8047ac68e5 (\"e1000e: Fix msi-x interrupt automask\") which cleared IAME\n\nWARNING: braces {} are not necessary for single statement blocks\n#73: FILE: drivers/net/ethernet/intel/e1000e/netdev.c:1931:\n+ if (!test_bit(__E1000_DOWN, &adapter->state)) {\n+ mod_timer(&adapter->watchdog_timer, jiffies + 1);\n+ }\n\nWARNING: braces {} are not necessary for single statement blocks\n#83: FILE: drivers/net/ethernet/intel/e1000e/netdev.c:1936:\n+ if (enable && !test_bit(__E1000_DOWN, &adapter->state)) {\n ew32(IMS, E1000_IMS_OTHER);\n }\n\ntotal: 1 errors, 2 warnings, 0 checks, 59 lines checked\n\nNOTE: For some of the reported defects, checkpatch may be able to\n mechanically convert to the typical style using --fix or --fix-inplace.\n\nYour patch has style problems, please review.\n\nNOTE: If any of the errors are false positives, please report\n them to the maintainer, see CHECKPATCH in MAINTAINERS.\nu1484:[0]/usr/src/kernels/next-queue>","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtc2b4YWVz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 15 Sep 2017 10:38:31 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1F33B30BBC;\n\tFri, 15 Sep 2017 00:38:30 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rKzE3QUQOSWd; Fri, 15 Sep 2017 00:38:27 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id CD82A30A64;\n\tFri, 15 Sep 2017 00:38:27 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7B8D91CEB94\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 15 Sep 2017 00:38:26 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 73A5989695\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 15 Sep 2017 00:38:26 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id U1UAGlruvoDL for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 15 Sep 2017 00:38:25 +0000 (UTC)","from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 532F189079\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 15 Sep 2017 00:38:25 +0000 (UTC)","from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Sep 2017 17:38:24 -0700","from orsmsx109.amr.corp.intel.com ([10.22.240.7])\n\tby FMSMGA003.fm.intel.com with ESMTP; 14 Sep 2017 17:38:24 -0700","from orsmsx115.amr.corp.intel.com (10.22.240.11) by\n\tORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server\n\t(TLS) id 14.3.319.2; Thu, 14 Sep 2017 17:38:24 -0700","from orsmsx101.amr.corp.intel.com ([169.254.8.156]) by\n\tORSMSX115.amr.corp.intel.com ([169.254.4.109]) with mapi id\n\t14.03.0319.002; Thu, 14 Sep 2017 17:38:23 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,395,1500966000\"; d=\"scan'208\";a=\"900413150\"","From":"\"Brown, Aaron F\" <aaron.f.brown@intel.com>","To":"Benjamin Poirier <bpoirier@suse.com>, \"Kirsher, Jeffrey T\"\n\t<jeffrey.t.kirsher@intel.com>","Thread-Topic":"[Intel-wired-lan] [PATCH 5/5] e1000e: Avoid receiver overrun\n\tinterrupt bursts","Thread-Index":"AQHTAlBgiiBGsopI5UWY2irVVUE0xaK1b4RQ","Date":"Fri, 15 Sep 2017 00:38:22 +0000","Message-ID":"<309B89C4C689E141A5FF6A0C5FB2118B8C6A05EC@ORSMSX101.amr.corp.intel.com>","References":"<20170721160937.GA22632@csclub.uwaterloo.ca>\n\t<20170721183627.13373-1-bpoirier@suse.com>\n\t<20170721183627.13373-5-bpoirier@suse.com>","In-Reply-To":"<20170721183627.13373-5-bpoirier@suse.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.139]","MIME-Version":"1.0","Cc":"\"netdev@vger.kernel.org\" <netdev@vger.kernel.org>,\n\t\"intel-wired-lan@lists.osuosl.org\" <intel-wired-lan@lists.osuosl.org>,\n\t\"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>, Lennart\n\tSorensen <lsorense@csclub.uwaterloo.ca>","Subject":"Re: [Intel-wired-lan] [PATCH 5/5] e1000e: Avoid receiver\n\toverrun\tinterrupt bursts","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}},{"id":1771284,"web_url":"http://patchwork.ozlabs.org/comment/1771284/","msgid":"<DDD41C67-CDF2-4443-9F49-0DC5489D9243@redfish-solutions.com>","list_archive_url":null,"date":"2017-09-19T18:38:02","subject":"Re: [Intel-wired-lan] [5/5] e1000e: Avoid receiver overrun\n\tinterrupt bursts","submitter":{"id":1599,"url":"http://patchwork.ozlabs.org/api/people/1599/","name":"Philip Prindeville","email":"philipp_subx@redfish-solutions.com"},"content":"Hi.\n\nWe’ve been running this patchset (all 5) for about as long as they’ve been under review… about 2 months. And in a burn-in lab with heavy traffic.\n\nWe’ve not seen a single link-flap in hundreds of ours of saturated traffic.\n\nWould love to see some resolution soon on this as we don’t want to ship a release with unsanctioned patches.\n\nIs there an estimate on when that might be?\n\nThanks,\n\n-Philip\n\n\n\n> On Jul 21, 2017, at 12:36 PM, Benjamin Poirier <bpoirier@suse.com> wrote:\n> \n> When e1000e_poll() is not fast enough to keep up with incoming traffic, the\n> adapter (when operating in msix mode) raises the Other interrupt to signal\n> Receiver Overrun.\n> \n> This is a double problem because 1) at the moment e1000_msix_other()\n> assumes that it is only called in case of Link Status Change and 2) if the\n> condition persists, the interrupt is repeatedly raised again in quick\n> succession.\n> \n> Ideally we would configure the Other interrupt to not be raised in case of\n> receiver overrun but this doesn't seem possible on this adapter. Instead,\n> we handle the first part of the problem by reverting to the practice of\n> reading ICR in the other interrupt handler, like before commit 16ecba59bc33\n> (\"e1000e: Do not read ICR in Other interrupt\"). Thanks to commit\n> 0a8047ac68e5 (\"e1000e: Fix msi-x interrupt automask\") which cleared IAME\n> from CTRL_EXT, reading ICR doesn't interfere with RxQ0, TxQ0 interrupts\n> anymore. We handle the second part of the problem by not re-enabling the\n> Other interrupt right away when there is overrun. Instead, we wait until\n> traffic subsides, napi polling mode is exited and interrupts are\n> re-enabled.\n> \n> Reported-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>\n> Fixes: 16ecba59bc33 (\"e1000e: Do not read ICR in Other interrupt\")\n> Signed-off-by: Benjamin Poirier <bpoirier@suse.com>\n> Tested-by: Aaron Brown <aaron.f.brown@intel.com>\n> ---\n> drivers/net/ethernet/intel/e1000e/defines.h | 1 +\n> drivers/net/ethernet/intel/e1000e/netdev.c | 33 +++++++++++++++++++++++------\n> 2 files changed, 27 insertions(+), 7 deletions(-)\n> \n> diff --git a/drivers/net/ethernet/intel/e1000e/defines.h b/drivers/net/ethernet/intel/e1000e/defines.h\n> index 0641c0098738..afb7ebe20b24 100644\n> --- a/drivers/net/ethernet/intel/e1000e/defines.h\n> +++ b/drivers/net/ethernet/intel/e1000e/defines.h\n> @@ -398,6 +398,7 @@\n> #define E1000_ICR_LSC 0x00000004 /* Link Status Change */\n> #define E1000_ICR_RXSEQ 0x00000008 /* Rx sequence error */\n> #define E1000_ICR_RXDMT0 0x00000010 /* Rx desc min. threshold (0) */\n> +#define E1000_ICR_RXO 0x00000040 /* Receiver Overrun */\n> #define E1000_ICR_RXT0 0x00000080 /* Rx timer intr (ring 0) */\n> #define E1000_ICR_ECCER 0x00400000 /* Uncorrectable ECC Error */\n> /* If this bit asserted, the driver should claim the interrupt */\n> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\n> index 5a8ab1136566..803edd1a6401 100644\n> --- a/drivers/net/ethernet/intel/e1000e/netdev.c\n> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n> @@ -1910,12 +1910,30 @@ static irqreturn_t e1000_msix_other(int __always_unused irq, void *data)\n> \tstruct net_device *netdev = data;\n> \tstruct e1000_adapter *adapter = netdev_priv(netdev);\n> \tstruct e1000_hw *hw = &adapter->hw;\n> +\tu32 icr;\n> +\tbool enable = true;\n> +\n> +\ticr = er32(ICR);\n> +\tif (icr & E1000_ICR_RXO) {\n> +\t\tew32(ICR, E1000_ICR_RXO);\n> +\t\tenable = false;\n> +\t\t/* napi poll will re-enable Other, make sure it runs */\n> +\t\tif (napi_schedule_prep(&adapter->napi)) {\n> +\t\t\tadapter->total_rx_bytes = 0;\n> +\t\t\tadapter->total_rx_packets = 0;\n> +\t\t\t__napi_schedule(&adapter->napi);\n> +\t\t}\n> +\t}\n> +\tif (icr & E1000_ICR_LSC) {\n> +\t\tew32(ICR, E1000_ICR_LSC);\n> +\t\thw->mac.get_link_status = true;\n> +\t\t/* guard against interrupt when we're going down */\n> +\t\tif (!test_bit(__E1000_DOWN, &adapter->state)) {\n> +\t\t\tmod_timer(&adapter->watchdog_timer, jiffies + 1);\n> +\t\t}\n> +\t}\n> \n> -\thw->mac.get_link_status = true;\n> -\n> -\t/* guard against interrupt when we're going down */\n> -\tif (!test_bit(__E1000_DOWN, &adapter->state)) {\n> -\t\tmod_timer(&adapter->watchdog_timer, jiffies + 1);\n> +\tif (enable && !test_bit(__E1000_DOWN, &adapter->state)) {\n> \t\tew32(IMS, E1000_IMS_OTHER);\n> \t}\n> \n> @@ -2687,7 +2705,8 @@ static int e1000e_poll(struct napi_struct *napi, int weight)\n> \t\tnapi_complete_done(napi, work_done);\n> \t\tif (!test_bit(__E1000_DOWN, &adapter->state)) {\n> \t\t\tif (adapter->msix_entries)\n> -\t\t\t\tew32(IMS, adapter->rx_ring->ims_val);\n> +\t\t\t\tew32(IMS, adapter->rx_ring->ims_val |\n> +\t\t\t\t E1000_IMS_OTHER);\n> \t\t\telse\n> \t\t\t\te1000_irq_enable(adapter);\n> \t\t}\n> @@ -4204,7 +4223,7 @@ static void e1000e_trigger_lsc(struct e1000_adapter *adapter)\n> \tstruct e1000_hw *hw = &adapter->hw;\n> \n> \tif (adapter->msix_entries)\n> -\t\tew32(ICS, E1000_ICS_OTHER);\n> +\t\tew32(ICS, E1000_ICS_LSC | E1000_ICS_OTHER);\n> \telse\n> \t\tew32(ICS, E1000_ICS_LSC);\n> }","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxWpc2f1Bz9sBZ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 04:38:15 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id AB6DC2E484;\n\tTue, 19 Sep 2017 18:38:13 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id yzPB6gFCygAz; Tue, 19 Sep 2017 18:38:11 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4BB432E46B;\n\tTue, 19 Sep 2017 18:38:11 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id A94071C0F41\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Sep 2017 18:38:09 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 9FF9687252\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Sep 2017 18:38:09 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4cBT_9pcpZ2L for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Sep 2017 18:38:08 +0000 (UTC)","from mail.redfish-solutions.com (mail.redfish-solutions.com\n\t[66.232.79.143])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id AB99C8723A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Sep 2017 18:38:08 +0000 (UTC)","from macmini.redfish-solutions.com (macmini.redfish-solutions.com\n\t[192.168.1.38]) (authenticated bits=0)\n\tby mail.redfish-solutions.com (8.15.2/8.15.2) with ESMTPSA id\n\tv8JIc2W5010284\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NO); Tue, 19 Sep 2017 12:38:02 -0600"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","From":"Philip Prindeville <philipp_subx@redfish-solutions.com>","In-Reply-To":"<20170721183627.13373-5-bpoirier@suse.com>","Date":"Tue, 19 Sep 2017 12:38:02 -0600","Message-Id":"<DDD41C67-CDF2-4443-9F49-0DC5489D9243@redfish-solutions.com>","References":"<20170721183627.13373-5-bpoirier@suse.com>","To":"Jeff Kirsher <jeffrey.t.kirsher@intel.com>","X-Mailer":"Apple Mail (2.3273)","X-Scanned-By":"MIMEDefang 2.81","Cc":"Benjamin Poirier <bpoirier@suse.com>, netdev@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org,\n\tLennart Sorensen <lsorense@csclub.uwaterloo.ca>","Subject":"Re: [Intel-wired-lan] [5/5] e1000e: Avoid receiver overrun\n\tinterrupt bursts","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}},{"id":1771324,"web_url":"http://patchwork.ozlabs.org/comment/1771324/","msgid":"<20170919194102.h2nu72evbqhpu765@f1.synalogic.ca>","list_archive_url":null,"date":"2017-09-19T19:41:02","subject":"Re: [Intel-wired-lan] [5/5] e1000e: Avoid receiver overrun\n\tinterrupt bursts","submitter":{"id":67008,"url":"http://patchwork.ozlabs.org/api/people/67008/","name":"Benjamin Poirier","email":"bpoirier@suse.com"},"content":"On 2017/09/19 12:38, Philip Prindeville wrote:\n> Hi.\n> \n> We’ve been running this patchset (all 5) for about as long as they’ve been under review… about 2 months. And in a burn-in lab with heavy traffic.\n> \n> We’ve not seen a single link-flap in hundreds of ours of saturated traffic.\n> \n> Would love to see some resolution soon on this as we don’t want to ship a release with unsanctioned patches.\n> \n> Is there an estimate on when that might be?\n\nThe patches have been added to Jeff Kirsher's next-queue tree. I guess\nthey will be submitted for v4.15 which might be released in early\n2018...\nhttp://phb-crystal-ball.org/","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxYCF6N4Kz9rxm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 05:41:13 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 728192E573;\n\tTue, 19 Sep 2017 19:41:11 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 7SdXhbFqqJsu; Tue, 19 Sep 2017 19:41:09 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id E75CE2E3E9;\n\tTue, 19 Sep 2017 19:41:09 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6D91F1C1FCF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Sep 2017 19:41:08 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 659B388AC3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Sep 2017 19:41:08 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bk0daA8FtVIN for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Sep 2017 19:41:07 +0000 (UTC)","from mx1.suse.de (mx2.suse.de [195.135.220.15])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 7967F88AC0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Sep 2017 19:41:07 +0000 (UTC)","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id 51B92AF41;\n\tTue, 19 Sep 2017 19:41:04 +0000 (UTC)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org","by amavisd-new at test-mx.suse.de"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Tue, 19 Sep 2017 21:41:02 +0200","From":"Benjamin Poirier <bpoirier@suse.com>","To":"Philip Prindeville <philipp_subx@redfish-solutions.com>","Message-ID":"<20170919194102.h2nu72evbqhpu765@f1.synalogic.ca>","References":"<20170721183627.13373-5-bpoirier@suse.com>\n\t<DDD41C67-CDF2-4443-9F49-0DC5489D9243@redfish-solutions.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<DDD41C67-CDF2-4443-9F49-0DC5489D9243@redfish-solutions.com>","User-Agent":"NeoMutt/20170421 (1.8.2)","Cc":"netdev@vger.kernel.org, Lennart Sorensen <lsorense@csclub.uwaterloo.ca>, \n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org","Subject":"Re: [Intel-wired-lan] [5/5] e1000e: Avoid receiver overrun\n\tinterrupt bursts","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}},{"id":1793334,"web_url":"http://patchwork.ozlabs.org/comment/1793334/","msgid":"<20171024172027.onfcusdcicxqnfjp@csclub.uwaterloo.ca>","list_archive_url":null,"date":"2017-10-24T17:20:27","subject":"Re: [Intel-wired-lan] [5/5] e1000e: Avoid receiver overrun\n\tinterrupt bursts","submitter":{"id":936,"url":"http://patchwork.ozlabs.org/api/people/936/","name":"Lennart Sorensen","email":"lsorense@csclub.uwaterloo.ca"},"content":"On Tue, Sep 19, 2017 at 09:41:02PM +0200, Benjamin Poirier wrote:\n> On 2017/09/19 12:38, Philip Prindeville wrote:\n> > Hi.\n> > \n> > We’ve been running this patchset (all 5) for about as long as they’ve been under review… about 2 months. And in a burn-in lab with heavy traffic.\n> > \n> > We’ve not seen a single link-flap in hundreds of ours of saturated traffic.\n> > \n> > Would love to see some resolution soon on this as we don’t want to ship a release with unsanctioned patches.\n> > \n> > Is there an estimate on when that might be?\n> \n> The patches have been added to Jeff Kirsher's next-queue tree. I guess\n> they will be submitted for v4.15 which might be released in early\n> 2018...\n> http://phb-crystal-ball.org/\n\nAnd then they will be submitted to linux-stable so this long standing\nregression can be fixed, right?","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yM0YL4tP7z9t3Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 25 Oct 2017 04:26:13 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 717958802C;\n\tTue, 24 Oct 2017 17:26:11 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ooWmrkJPCH9C; Tue, 24 Oct 2017 17:26:09 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1D58987FAA;\n\tTue, 24 Oct 2017 17:26:09 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id CC4C21BFBC2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 24 Oct 2017 17:26:07 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C447F88A8A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 24 Oct 2017 17:26:07 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OIPoJMbQARcX for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 24 Oct 2017 17:26:06 +0000 (UTC)","from caffeine.csclub.uwaterloo.ca (caffeine.csclub.uwaterloo.ca\n\t[129.97.134.17])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id A856A874CF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 24 Oct 2017 17:26:06 +0000 (UTC)","by caffeine.csclub.uwaterloo.ca (Postfix, from userid 20367)\n\tid 86968C0037; Tue, 24 Oct 2017 13:20:27 -0400 (EDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"delayed 00:05:36 by SQLgrey-1.7.6","Date":"Tue, 24 Oct 2017 13:20:27 -0400","To":"Benjamin Poirier <bpoirier@suse.com>","Message-ID":"<20171024172027.onfcusdcicxqnfjp@csclub.uwaterloo.ca>","References":"<20170721183627.13373-5-bpoirier@suse.com>\n\t<DDD41C67-CDF2-4443-9F49-0DC5489D9243@redfish-solutions.com>\n\t<20170919194102.h2nu72evbqhpu765@f1.synalogic.ca>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170919194102.h2nu72evbqhpu765@f1.synalogic.ca>","User-Agent":"NeoMutt/20170113 (1.7.2)","From":"lsorense@csclub.uwaterloo.ca (Lennart Sorensen)","Cc":"netdev@vger.kernel.org,\n\tPhilip Prindeville <philipp_subx@redfish-solutions.com>,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org","Subject":"Re: [Intel-wired-lan] [5/5] e1000e: Avoid receiver overrun\n\tinterrupt bursts","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}},{"id":1793344,"web_url":"http://patchwork.ozlabs.org/comment/1793344/","msgid":"<238D36BF-473B-4F9A-BDCF-97544F2FDF3F@redfish-solutions.com>","list_archive_url":null,"date":"2017-10-24T17:39:10","subject":"Re: [Intel-wired-lan] [5/5] e1000e: Avoid receiver overrun\n\tinterrupt bursts","submitter":{"id":1599,"url":"http://patchwork.ozlabs.org/api/people/1599/","name":"Philip Prindeville","email":"philipp_subx@redfish-solutions.com"},"content":"> On Oct 24, 2017, at 11:20 AM, Lennart Sorensen <lsorense@csclub.uwaterloo.ca> wrote:\n> \n> On Tue, Sep 19, 2017 at 09:41:02PM +0200, Benjamin Poirier wrote:\n>> On 2017/09/19 12:38, Philip Prindeville wrote:\n>>> Hi.\n>>> \n>>> We’ve been running this patchset (all 5) for about as long as they’ve been under review… about 2 months. And in a burn-in lab with heavy traffic.\n>>> \n>>> We’ve not seen a single link-flap in hundreds of ours of saturated traffic.\n>>> \n>>> Would love to see some resolution soon on this as we don’t want to ship a release with unsanctioned patches.\n>>> \n>>> Is there an estimate on when that might be?\n>> \n>> The patches have been added to Jeff Kirsher's next-queue tree. I guess\n>> they will be submitted for v4.15 which might be released in early\n>> 2018...\n>> http://phb-crystal-ball.org/\n> \n> And then they will be submitted to linux-stable so this long standing\n> regression can be fixed, right?\n> \n\n\nLet’s hope!\n\n-Philip","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yM0rT5qbZz9s8J\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 25 Oct 2017 04:39:21 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 575FE896C9;\n\tTue, 24 Oct 2017 17:39:20 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gcQjYJ-vgSvn; Tue, 24 Oct 2017 17:39:19 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1D2FC88CC9;\n\tTue, 24 Oct 2017 17:39:19 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 270311BFBC2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 24 Oct 2017 17:39:18 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1D10F8865C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 24 Oct 2017 17:39:18 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id PqEXV-ZWrhjl for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 24 Oct 2017 17:39:16 +0000 (UTC)","from mail.redfish-solutions.com (mail.redfish-solutions.com\n\t[66.232.79.143])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 6F8CC88652\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 24 Oct 2017 17:39:16 +0000 (UTC)","from macmini.redfish-solutions.com (macmini.redfish-solutions.com\n\t[192.168.1.38]) (authenticated bits=0)\n\tby mail.redfish-solutions.com (8.15.2/8.15.2) with ESMTPSA id\n\tv9OHdBrA024634\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NO); Tue, 24 Oct 2017 11:39:11 -0600"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","From":"Philip Prindeville <philipp_subx@redfish-solutions.com>","In-Reply-To":"<20171024172027.onfcusdcicxqnfjp@csclub.uwaterloo.ca>","Date":"Tue, 24 Oct 2017 11:39:10 -0600","Message-Id":"<238D36BF-473B-4F9A-BDCF-97544F2FDF3F@redfish-solutions.com>","References":"<20170721183627.13373-5-bpoirier@suse.com>\n\t<DDD41C67-CDF2-4443-9F49-0DC5489D9243@redfish-solutions.com>\n\t<20170919194102.h2nu72evbqhpu765@f1.synalogic.ca>\n\t<20171024172027.onfcusdcicxqnfjp@csclub.uwaterloo.ca>","To":"Lennart Sorensen <lsorense@csclub.uwaterloo.ca>","X-Mailer":"Apple Mail (2.3273)","X-Scanned-By":"MIMEDefang 2.82 on 192.168.1.3","Cc":"Benjamin Poirier <bpoirier@suse.com>, netdev@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org","Subject":"Re: [Intel-wired-lan] [5/5] e1000e: Avoid receiver overrun\n\tinterrupt bursts","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}}]