[{"id":1768879,"web_url":"http://patchwork.ozlabs.org/comment/1768879/","msgid":"<309B89C4C689E141A5FF6A0C5FB2118B8C6A059F@ORSMSX101.amr.corp.intel.com>","list_archive_url":null,"date":"2017-09-15T00:18:47","subject":"Re: [Intel-wired-lan] [PATCH 1/5] e1000e: Fix error path in\n\tlink\tdetection","submitter":{"id":37025,"url":"http://patchwork.ozlabs.org/api/people/37025/","name":"Brown, Aaron F","email":"aaron.f.brown@intel.com"},"content":"> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf\n> Of Benjamin Poirier\n> Sent: Friday, July 21, 2017 11:36 AM\n> To: Kirsher, Jeffrey T \n> Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-\n> kernel@vger.kernel.org; Lennart Sorensen \n> Subject: [Intel-wired-lan] [PATCH 1/5] e1000e: Fix error path in link detection\n> \n> In case of error from e1e_rphy(), the loop will exit early and \"success\"\n> will be set to true erroneously.\n> \n> Signed-off-by: Benjamin Poirier \n> ---\n> drivers/net/ethernet/intel/e1000e/phy.c | 7 ++++---\n> 1 file changed, 4 insertions(+), 3 deletions(-)\n> \n\nTested-by: Aaron Brown ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtbbx6NF4z9sRm\n\tfor ;\n\tFri, 15 Sep 2017 10:18:53 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 414BF310D0;\n\tFri, 15 Sep 2017 00:18:52 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ztY6YFb5VolT; Fri, 15 Sep 2017 00:18:51 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 991E430A64;\n\tFri, 15 Sep 2017 00:18:51 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 963981C26AA\n\tfor ;\n\tFri, 15 Sep 2017 00:18:50 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8C90D30A64\n\tfor ;\n\tFri, 15 Sep 2017 00:18:50 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id otI08mFtAMod for ;\n\tFri, 15 Sep 2017 00:18:49 +0000 (UTC)","from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby silver.osuosl.org (Postfix) with ESMTPS id D2AC82F96B\n\tfor ;\n\tFri, 15 Sep 2017 00:18:49 +0000 (UTC)","from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga105.jf.intel.com with ESMTP; 14 Sep 2017 17:18:48 -0700","from orsmsx103.amr.corp.intel.com ([10.22.225.130])\n\tby fmsmga006.fm.intel.com with ESMTP; 14 Sep 2017 17:18:48 -0700","from orsmsx157.amr.corp.intel.com (10.22.240.23) by\n\tORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Thu, 14 Sep 2017 17:18:48 -0700","from orsmsx101.amr.corp.intel.com ([169.254.8.156]) by\n\tORSMSX157.amr.corp.intel.com ([169.254.9.28]) with mapi id\n\t14.03.0319.002; Thu, 14 Sep 2017 17:18:48 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,395,1500966000\"; d=\"scan'208\";a=\"152048483\"","From":"\"Brown, Aaron F\" ","To":"Benjamin Poirier , \"Kirsher, Jeffrey T\"\n\t","Thread-Topic":"[Intel-wired-lan] [PATCH 1/5] e1000e: Fix error path in link\n\tdetection","Thread-Index":"AQHTAlBgr6t4yTAAvUyVEVuZ4CBN/KK1a6CA","Date":"Fri, 15 Sep 2017 00:18:47 +0000","Message-ID":"<309B89C4C689E141A5FF6A0C5FB2118B8C6A059F@ORSMSX101.amr.corp.intel.com>","References":"<20170721160937.GA22632@csclub.uwaterloo.ca>\n\t<20170721183627.13373-1-bpoirier@suse.com>","In-Reply-To":"<20170721183627.13373-1-bpoirier@suse.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.139]","MIME-Version":"1.0","Cc":"\"netdev@vger.kernel.org\" ,\n\t\"intel-wired-lan@lists.osuosl.org\" ,\n\t\"linux-kernel@vger.kernel.org\" , Lennart\n\tSorensen ","Subject":"Re: [Intel-wired-lan] [PATCH 1/5] e1000e: Fix error path in\n\tlink\tdetection","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]