[{"id":1770590,"web_url":"http://patchwork.ozlabs.org/comment/1770590/","msgid":"<309B89C4C689E141A5FF6A0C5FB2118B8C6A191C@ORSMSX101.amr.corp.intel.com>","list_archive_url":null,"date":"2017-09-19T00:13:41","subject":"Re: [Intel-wired-lan] [PATCH 2/5] e1000e: Fix wrong comment related\n\tto\tlink detection","submitter":{"id":37025,"url":"http://patchwork.ozlabs.org/api/people/37025/","name":"Brown, Aaron F","email":"aaron.f.brown@intel.com"},"content":"> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf\n> Of Benjamin Poirier\n> Sent: Friday, July 21, 2017 11:36 AM\n> To: Kirsher, Jeffrey T \n> Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-\n> kernel@vger.kernel.org; Lennart Sorensen \n> Subject: [Intel-wired-lan] [PATCH 2/5] e1000e: Fix wrong comment related to\n> link detection\n> \n> Reading e1000e_check_for_copper_link() shows that get_link_status is set to\n> false after link has been detected. Therefore, it stays TRUE until then.\n> \n> Signed-off-by: Benjamin Poirier \n> ---\n> drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n\nTested-by: Aaron Brown ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xx3JK0XGTz9s0Z\n\tfor ;\n\tTue, 19 Sep 2017 10:13:51 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5D1D58945A;\n\tTue, 19 Sep 2017 00:13:49 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id r-uXpNK3tnTW; Tue, 19 Sep 2017 00:13:47 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0791F8936F;\n\tTue, 19 Sep 2017 00:13:47 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 5F7201CEBBF\n\tfor ;\n\tTue, 19 Sep 2017 00:13:45 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5230F87E76\n\tfor ;\n\tTue, 19 Sep 2017 00:13:45 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YhLORMSLvDxf for ;\n\tTue, 19 Sep 2017 00:13:43 +0000 (UTC)","from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id D609487E40\n\tfor ;\n\tTue, 19 Sep 2017 00:13:43 +0000 (UTC)","from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Sep 2017 17:13:43 -0700","from orsmsx103.amr.corp.intel.com ([10.22.225.130])\n\tby fmsmga001.fm.intel.com with ESMTP; 18 Sep 2017 17:13:42 -0700","from orsmsx161.amr.corp.intel.com (10.22.240.84) by\n\tORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Mon, 18 Sep 2017 17:13:42 -0700","from orsmsx101.amr.corp.intel.com ([169.254.8.156]) by\n\tORSMSX161.amr.corp.intel.com ([169.254.4.13]) with mapi id\n\t14.03.0319.002; Mon, 18 Sep 2017 17:13:42 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.42,415,1500966000\"; d=\"scan'208\";\n\ta=\"1196507968\"","From":"\"Brown, Aaron F\" ","To":"Benjamin Poirier , \"Kirsher, Jeffrey T\"\n\t","Thread-Topic":"[Intel-wired-lan] [PATCH 2/5] e1000e: Fix wrong comment\n\trelated to\tlink detection","Thread-Index":"AQHTAlBdyOfsBNWUbU+rFubu4Vo2e6K7s39A","Date":"Tue, 19 Sep 2017 00:13:41 +0000","Message-ID":"<309B89C4C689E141A5FF6A0C5FB2118B8C6A191C@ORSMSX101.amr.corp.intel.com>","References":"<20170721160937.GA22632@csclub.uwaterloo.ca>\n\t<20170721183627.13373-1-bpoirier@suse.com>\n\t<20170721183627.13373-2-bpoirier@suse.com>","In-Reply-To":"<20170721183627.13373-2-bpoirier@suse.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.138]","MIME-Version":"1.0","Cc":"\"netdev@vger.kernel.org\" ,\n\t\"intel-wired-lan@lists.osuosl.org\" ,\n\t\"linux-kernel@vger.kernel.org\" , Lennart\n\tSorensen ","Subject":"Re: [Intel-wired-lan] [PATCH 2/5] e1000e: Fix wrong comment related\n\tto\tlink detection","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]