[{"id":1733361,"web_url":"http://patchwork.ozlabs.org/comment/1733361/","msgid":"<20170731060340.yw45r7dewrdvocx3@oak.ozlabs.ibm.com>","list_archive_url":null,"date":"2017-07-31T06:03:40","subject":"Re: [PATCH 1/2] KVM: PPC: e500: fix some NULL dereferences on error","submitter":{"id":67079,"url":"http://patchwork.ozlabs.org/api/people/67079/","name":"Paul Mackerras","email":"paulus@ozlabs.org"},"content":"On Thu, Jul 13, 2017 at 10:38:29AM +0300, Dan Carpenter wrote:\n> There are some error paths in kvmppc_core_vcpu_create_e500() where we\n> forget to set the error code. It means that we return ERR_PTR(0) which\n> is NULL and it results in a NULL pointer dereference in the caller.\n> \n> Signed-off-by: Dan Carpenter \n\nAre these user-triggerable, and therefore needing to go into 4.13\nand be back-ported to the stable trees? Or can they wait for 4.14?\n\nPaul.\n--\nTo unsubscribe from this list: send the line \"unsubscribe kvm-ppc\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=kvm-ppc-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tsecure) header.d=ozlabs.org header.i=@ozlabs.org header.b=\"MVhfn4lp\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xLTRK567Kz9tWD\n\tfor ;\n\tMon, 31 Jul 2017 16:03:57 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751606AbdGaGD4 (ORCPT );\n\tMon, 31 Jul 2017 02:03:56 -0400","from ozlabs.org ([103.22.144.67]:35219 \"EHLO ozlabs.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751599AbdGaGDz (ORCPT );\n\tMon, 31 Jul 2017 02:03:55 -0400","by ozlabs.org (Postfix, from userid 1003)\n\tid 3xLTRG0Jl3z9sRg; Mon, 31 Jul 2017 16:03:53 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; \n\tt=1501481034; bh=hsmzvqShHCjDZTgf/GDu6TviLUyB/8SO8ovdT5YuqXY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MVhfn4lpYFdCBYX14TaG+a2Xb76rwdpZ9Mq+8dQBziMZw+LrV5tUvB+Mp5r+YVXpG\n\tHK8QX0GCD6jnH4ed+gFZ/CseNfYSnwp2EqQMY3Q56mwkHzMLvgz0YUgdHiFqhISKIx\n\tvVwoc1GvJirF/DpXBuhIobkVnXgQsHZuy/QPqZZStwYlpmnKaf0qsgtzYK+BqSauXU\n\tdPny0aC8WphKV5+kk2AOAZ/v1nFAYgrmZY5q6IuOaIBd508rLPZiLXwuz7joyXlp9o\n\t84fQFowsG2/0JXAJNCVnrn64aJW0PGhBFmOSocJS4eVstbOF9ORUssCvd8DXWdlBnT\n\tAHmp8fsaMrrHw==","Date":"Mon, 31 Jul 2017 16:03:40 +1000","From":"Paul Mackerras ","To":"Dan Carpenter ","Cc":"Alexander Graf , Scott Wood ,\n\tPaolo Bonzini ,\n\tRadim =?utf-8?B?S3LEjW3DocWZ?= ,\n\tBenjamin Herrenschmidt ,\n\tMichael Ellerman , kvm-ppc@vger.kernel.org,\n\tkvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n\tkernel-janitors@vger.kernel.org","Subject":"Re: [PATCH 1/2] KVM: PPC: e500: fix some NULL dereferences on error","Message-ID":"<20170731060340.yw45r7dewrdvocx3@oak.ozlabs.ibm.com>","References":"<20170713073829.dqjahnakxqvpne7x@mwanda>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170713073829.dqjahnakxqvpne7x@mwanda>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"kvm-ppc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"kvm-ppc@vger.kernel.org"}},{"id":1733455,"web_url":"http://patchwork.ozlabs.org/comment/1733455/","msgid":"<20170731075446.5rdxjcir4jmsed7q@mwanda>","list_archive_url":null,"date":"2017-07-31T07:54:46","subject":"Re: [PATCH 1/2] KVM: PPC: e500: fix some NULL dereferences on error","submitter":{"id":9327,"url":"http://patchwork.ozlabs.org/api/people/9327/","name":"Dan Carpenter","email":"dan.carpenter@oracle.com"},"content":"On Mon, Jul 31, 2017 at 04:03:40PM +1000, Paul Mackerras wrote:\n> On Thu, Jul 13, 2017 at 10:38:29AM +0300, Dan Carpenter wrote:\n> > There are some error paths in kvmppc_core_vcpu_create_e500() where we\n> > forget to set the error code. It means that we return ERR_PTR(0) which\n> > is NULL and it results in a NULL pointer dereference in the caller.\n> > \n> > Signed-off-by: Dan Carpenter \n> \n> Are these user-triggerable, and therefore needing to go into 4.13\n> and be back-ported to the stable trees? Or can they wait for 4.14?\n> \n\nThese are static checker fixes... I imagine that they might be user\ntriggerable with quite a bit of work but it's a only NULL derefence.\n\nregards,\ndan carpenter\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe kvm-ppc\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=kvm-ppc-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xLWw21kX1z9s4s\n\tfor ;\n\tMon, 31 Jul 2017 17:55:30 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750807AbdGaHz3 (ORCPT );\n\tMon, 31 Jul 2017 03:55:29 -0400","from userp1040.oracle.com ([156.151.31.81]:41625 \"EHLO\n\tuserp1040.oracle.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750764AbdGaHz2 (ORCPT\n\t); Mon, 31 Jul 2017 03:55:28 -0400","from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233])\n\tby userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2)\n\twith ESMTP id v6V7t0o2002723\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Mon, 31 Jul 2017 07:55:00 GMT","from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72])\n\tby aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v6V7sxKW022364\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Mon, 31 Jul 2017 07:55:00 GMT","from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16])\n\tby userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id\n\tv6V7swgG019662; Mon, 31 Jul 2017 07:54:58 GMT","from mwanda (/197.254.35.146)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Mon, 31 Jul 2017 00:54:57 -0700"],"Date":"Mon, 31 Jul 2017 10:54:46 +0300","From":"Dan Carpenter ","To":"Paul Mackerras ","Cc":"Alexander Graf , Scott Wood ,\n\tPaolo Bonzini ,\n\tRadim =?utf-8?B?S3LEjW3DocWZ?= ,\n\tBenjamin Herrenschmidt ,\n\tMichael Ellerman , kvm-ppc@vger.kernel.org,\n\tkvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n\tkernel-janitors@vger.kernel.org","Subject":"Re: [PATCH 1/2] KVM: PPC: e500: fix some NULL dereferences on error","Message-ID":"<20170731075446.5rdxjcir4jmsed7q@mwanda>","References":"<20170713073829.dqjahnakxqvpne7x@mwanda>\n\t<20170731060340.yw45r7dewrdvocx3@oak.ozlabs.ibm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170731060340.yw45r7dewrdvocx3@oak.ozlabs.ibm.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-Source-IP":"aserv0021.oracle.com [141.146.126.233]","Sender":"kvm-ppc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"kvm-ppc@vger.kernel.org"}},{"id":1760614,"web_url":"http://patchwork.ozlabs.org/comment/1760614/","msgid":"<20170831034019.GA22549@fergus.ozlabs.ibm.com>","list_archive_url":null,"date":"2017-08-31T03:40:19","subject":"Re: [PATCH 1/2] KVM: PPC: e500: fix some NULL dereferences on error","submitter":{"id":67079,"url":"http://patchwork.ozlabs.org/api/people/67079/","name":"Paul Mackerras","email":"paulus@ozlabs.org"},"content":"On Thu, Jul 13, 2017 at 10:38:29AM +0300, Dan Carpenter wrote:\n> There are some error paths in kvmppc_core_vcpu_create_e500() where we\n> forget to set the error code. It means that we return ERR_PTR(0) which\n> is NULL and it results in a NULL pointer dereference in the caller.\n> \n> Signed-off-by: Dan Carpenter \n\nThanks, both patches applied to my kvm-ppc-next branch.\n\nPaul.\n--\nTo unsubscribe from this list: send the line \"unsubscribe kvm-ppc\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=kvm-ppc-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tsecure) header.d=ozlabs.org header.i=@ozlabs.org header.b=\"G5T0nxS8\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xjSsp2z77z9sNc\n\tfor ;\n\tThu, 31 Aug 2017 13:44:14 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751363AbdHaDoN (ORCPT );\n\tWed, 30 Aug 2017 23:44:13 -0400","from ozlabs.org ([103.22.144.67]:41405 \"EHLO ozlabs.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750948AbdHaDoK (ORCPT );\n\tWed, 30 Aug 2017 23:44:10 -0400","by ozlabs.org (Postfix, from userid 1003)\n\tid 3xjSsh73n5z9s2G; Thu, 31 Aug 2017 13:44:08 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; \n\tt=1504151048; bh=eRKhzuKtAlGTXRgNKoWnk5JPTjdiuDRCsIH3LH3R8Bw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=G5T0nxS877rlFTsaIh//+CrB1Y4epxpyrzIxDibK7e2RQz9wx027TXzTfs+wie0Yp\n\tgyk4gYMjsrM8TEVjm+H6AQnWXKTT8zYjB0lbYomjDXGpWLzuvXacYppXCGyD4ox8Qn\n\tJJcgkcRN8EIiqbiVb1LuNnp/k+zmt6nAFzHt4PL9Xe/hS5yGmy2cwgT+MP12JYluqD\n\tYSntcTmb94jkEd2D3o1srb6IiXi/mlZlwcFUT/YEjKIcZ6iesj2sp48HE8DLrga3Ok\n\t4YGB2RPwy9xrYYFg0u82DdN1ylyo+JJd3qL77phiFUeL9IUryacxMzI4IZIJt9jtYS\n\tc1nzlgZ9Jqeeg==","Date":"Thu, 31 Aug 2017 13:40:19 +1000","From":"Paul Mackerras ","To":"Dan Carpenter ","Cc":"Alexander Graf , Scott Wood ,\n\tPaolo Bonzini , Radim =?utf-8?b?S3LEjW3DocWZ?=\n\t, Benjamin Herrenschmidt , \n\tMichael Ellerman , kvm-ppc@vger.kernel.org, \n\tkvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, \n\tkernel-janitors@vger.kernel.org","Subject":"Re: [PATCH 1/2] KVM: PPC: e500: fix some NULL dereferences on error","Message-ID":"<20170831034019.GA22549@fergus.ozlabs.ibm.com>","References":"<20170713073829.dqjahnakxqvpne7x@mwanda>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170713073829.dqjahnakxqvpne7x@mwanda>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"kvm-ppc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"kvm-ppc@vger.kernel.org"}}]