[{"id":1714766,"web_url":"http://patchwork.ozlabs.org/comment/1714766/","msgid":"<87a84asr2s.fsf@dell.be.48ers.dk>","list_archive_url":null,"date":"2017-07-11T19:37:15","subject":"Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support","submitter":{"id":42365,"url":"http://patchwork.ozlabs.org/api/people/42365/","name":"Peter Korsgaard","email":"peter@korsgaard.com"},"content":">>>>> \"Bernd\" == Bernd Kuhls writes:\n\n > Gtk support is controlled by ARG_WITH since\n > https://github.com/transmission/transmission/commit/2ccc2bbbfe2e4a26dfeaa13b56c412ea0af4ebe4\n\n > Fixes a build error if libgtk2/3 was built before transmission:\n > http://autobuild.buildroot.net/results/6b6/6b6ce352a9edfe3aaba82be143092a878e7715ed/\n\n > Signed-off-by: Bernd Kuhls \n\nSo this has been broken since (atleast) the version bump in early 2016?\nWow.\n\nCommitted, thanks.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x6XRC1Ygvz9rvt\n\tfor ;\n\tWed, 12 Jul 2017 05:37:27 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A20A888320;\n\tTue, 11 Jul 2017 19:37:22 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id U5OsBALd9uC9; Tue, 11 Jul 2017 19:37:21 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 1AF0E819B9;\n\tTue, 11 Jul 2017 19:37:21 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 13E741C07B7\n\tfor ;\n\tTue, 11 Jul 2017 19:37:20 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0EE3386E90\n\tfor ;\n\tTue, 11 Jul 2017 19:37:20 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id n10d0hZJPupy for ;\n\tTue, 11 Jul 2017 19:37:18 +0000 (UTC)","from mail-wr0-f176.google.com (mail-wr0-f176.google.com\n\t[209.85.128.176])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id A2FD286E6E\n\tfor ; Tue, 11 Jul 2017 19:37:18 +0000 (UTC)","by mail-wr0-f176.google.com with SMTP id r103so3020777wrb.0\n\tfor ; Tue, 11 Jul 2017 12:37:18 -0700 (PDT)","from dell.be.48ers.dk (d51A5BC31.access.telenet.be.\n\t[81.165.188.49])\n\tby smtp.gmail.com with ESMTPSA id 4sm74293eds.48.2017.07.11.12.37.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 11 Jul 2017 12:37:16 -0700 (PDT)","from peko by dell.be.48ers.dk with local (Exim 4.88)\n\t(envelope-from )\n\tid 1dV0yB-0006Rl-Nh; Tue, 11 Jul 2017 21:37:15 +0200"],"Authentication-Results":"ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"WeiPwlpC\"; dkim-atps=neutral","X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:references:date:in-reply-to:message-id\n\t:user-agent:mime-version;\n\tbh=yCpPvz9E3Yz3iQoIuRNXn97IicLxuhlgNu1Y9Dwo13I=;\n\tb=WeiPwlpCiexaJmInSgBnGdQsXKA43Oow8yrt2fQrRoNGLx1kLizh2Qe9P2cM73Nk7r\n\tkbNCplgrlcordI7+nISUJuQWencrz9dw29iXX/eKRWX7XkT8JLx32Rouzqt/ccBPfL50\n\tmH/YiGNFW06pIUKJyNZz7Ua6h9l0BT1EO3LIk9oyKkj1u7lbQZdhPtSjS+igEacDK2qk\n\tkkMhO9EHf3zYnWV73GtGR+T8xmi+LilQJThs6yGqDU2ixybGYM35gcLQhBisTMoEom8E\n\tZkn7qwp3ZRVE9v8WwmojsKOG/mbfNbi6TNYGPKGI7Asdk0Rk5zgjltlK3h0G7uOIMRGb\n\tOfyA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:references:date\n\t:in-reply-to:message-id:user-agent:mime-version;\n\tbh=yCpPvz9E3Yz3iQoIuRNXn97IicLxuhlgNu1Y9Dwo13I=;\n\tb=IIbe1SP99vQYCXZwXYeuNLfFkCpSsiExUF76/mYpXOfolH+0XTLqOerg3sdUHtTtrX\n\tDFWzqKo9ATCIOvAwXGzxh/DbTIZRclePOKK19OKKpHlhN8sNElv4DWGQ/udSUrju8VZg\n\tOB2xIX/Byyb2lTSOGQJBFld7YGruNWGo/mrnGWJwoMxfUppFGiUH1gGkSzWc++zRue41\n\tM0fyhbcgnzA6Etx6c48S2+xrXOlEZvL6+7QJ00jyyQw8nDSOLZlhM/ugwkFxSR2FfNi2\n\tf2HAQesCmV4T2gBZ7Mpuu8vZDER1ayWROh9wRiT1GAGuNHpleWD3N1Xt/yjjJI3jgWAN\n\t5N+Q==","X-Gm-Message-State":"AIVw112IX81alRoKPrzMalKFIvo5OgTgfCRq30s6GZBnRWEq8AywobWs\n\t2rS/vDD5iJjPvf8teyI=","X-Received":"by 10.80.214.85 with SMTP id c21mr3560986edj.40.1499801837213;\n\tTue, 11 Jul 2017 12:37:17 -0700 (PDT)","From":"Peter Korsgaard ","To":"Bernd Kuhls ","References":"<20170710175137.1402-1-bernd.kuhls@t-online.de>","Date":"Tue, 11 Jul 2017 21:37:15 +0200","In-Reply-To":"<20170710175137.1402-1-bernd.kuhls@t-online.de> (Bernd Kuhls's\n\tmessage of \"Mon, 10 Jul 2017 19:51:37 +0200\")","Message-ID":"<87a84asr2s.fsf@dell.be.48ers.dk>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)","MIME-Version":"1.0","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1714863,"web_url":"http://patchwork.ozlabs.org/comment/1714863/","msgid":"<20170711231701.3850d479@windsurf.lan>","list_archive_url":null,"date":"2017-07-11T21:17:01","subject":"Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nOn Tue, 11 Jul 2017 21:37:15 +0200, Peter Korsgaard wrote:\n\n> > Gtk support is controlled by ARG_WITH since\n> > https://github.com/transmission/transmission/commit/2ccc2bbbfe2e4a26dfeaa13b56c412ea0af4ebe4 \n> \n> > Fixes a build error if libgtk2/3 was built before transmission:\n> > http://autobuild.buildroot.net/results/6b6/6b6ce352a9edfe3aaba82be143092a878e7715ed/ \n> \n> > Signed-off-by: Bernd Kuhls \n> \n> So this has been broken since (atleast) the version bump in early 2016?\n> Wow.\n\nMaybe not:\n\nconfigure: error: \"The gtk client cannot be built without nls support. Try adding either --enable-nls or --without-gtk\" \n\nUntil the recent gettext revamp we were passing --disable-nls only when\nBR2_ENABLE_LOCALE was disabled. However, the transmission-gtk support has:\n\n\tdepends on BR2_PACKAGE_LIBGTK2 && BR2_ENABLE_LOCALE\n\nTherefore, we were never building transmission with --disable-nls. With\nthe gettext revamp, we now pass --disable-nls to all packages, unless\nBR2_SYSTEM_ENABLE_NLS is enabled (which it isn't by default).\n\nSo I am not sure the fix is complete. Indeed the error says that the\ngtk client cannot be built without nls support. So I guess that if you\nhave BR2_PACKCAGE_TRANSMISSION_GTK=y, but BR2_SYSTEM_ENABLE_NLS\ndisabled it still fails to build.\n\nBest regards,\n\nThomas","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x6ZfS1sbnz9s78\n\tfor ;\n\tWed, 12 Jul 2017 07:17:20 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B520387383;\n\tTue, 11 Jul 2017 21:17:18 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id w_5luWPra2Vr; Tue, 11 Jul 2017 21:17:17 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2DEC086F97;\n\tTue, 11 Jul 2017 21:17:17 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 49B511C0E5B\n\tfor ;\n\tTue, 11 Jul 2017 21:17:14 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 459F48736C\n\tfor ;\n\tTue, 11 Jul 2017 21:17:14 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FfzPxUdMyAXr for ;\n\tTue, 11 Jul 2017 21:17:13 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2B88486F97\n\tfor ; Tue, 11 Jul 2017 21:17:13 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 8651521DFE; Tue, 11 Jul 2017 23:17:10 +0200 (CEST)","from windsurf.lan (LFbn-1-10680-2.w90-89.abo.wanadoo.fr\n\t[90.89.33.2])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 528F821DFB;\n\tTue, 11 Jul 2017 23:17:00 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Tue, 11 Jul 2017 23:17:01 +0200","From":"Thomas Petazzoni ","To":"Peter Korsgaard ","Message-ID":"<20170711231701.3850d479@windsurf.lan>","In-Reply-To":"<87a84asr2s.fsf@dell.be.48ers.dk>","References":"<20170710175137.1402-1-bernd.kuhls@t-online.de>\n\t<87a84asr2s.fsf@dell.be.48ers.dk>","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"Bernd Kuhls , buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1714890,"web_url":"http://patchwork.ozlabs.org/comment/1714890/","msgid":"","list_archive_url":null,"date":"2017-07-11T21:42:24","subject":"Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support","submitter":{"id":11809,"url":"http://patchwork.ozlabs.org/api/people/11809/","name":"Arnout Vandecappelle","email":"arnout@mind.be"},"content":"On 11-07-17 23:17, Thomas Petazzoni wrote:\n> Hello,\n> \n> On Tue, 11 Jul 2017 21:37:15 +0200, Peter Korsgaard wrote:\n> \n>> > Gtk support is controlled by ARG_WITH since\n>> > https://github.com/transmission/transmission/commit/2ccc2bbbfe2e4a26dfeaa13b56c412ea0af4ebe4 \n>>\n>> > Fixes a build error if libgtk2/3 was built before transmission:\n>> > http://autobuild.buildroot.net/results/6b6/6b6ce352a9edfe3aaba82be143092a878e7715ed/ \n>>\n>> > Signed-off-by: Bernd Kuhls \n>>\n>> So this has been broken since (atleast) the version bump in early 2016?\n>> Wow.\n> \n> Maybe not:\n> \n> configure: error: \"The gtk client cannot be built without nls support. Try adding either --enable-nls or --without-gtk\" \n> \n> Until the recent gettext revamp we were passing --disable-nls only when\n> BR2_ENABLE_LOCALE was disabled. However, the transmission-gtk support has:\n> \n> \tdepends on BR2_PACKAGE_LIBGTK2 && BR2_ENABLE_LOCALE\n\n So in fact this dependency on LOCALE is wrong now. Indeed, the commit message\nthat added it (d6dfc2109c7149a795f7bda963a9a583685dec3f) says:\n\n Otherwise configure errors out with:\n\n configure: error: \"The gtk client cannot be built without nls support.\n Try adding either --enable-nls or --disable-gtk\"\n\n> Therefore, we were never building transmission with --disable-nls. With\n> the gettext revamp, we now pass --disable-nls to all packages, unless\n> BR2_SYSTEM_ENABLE_NLS is enabled (which it isn't by default).\n> \n> So I am not sure the fix is complete. Indeed the error says that the\n> gtk client cannot be built without nls support. So I guess that if you\n> have BR2_PACKCAGE_TRANSMISSION_GTK=y, but BR2_SYSTEM_ENABLE_NLS\n> disabled it still fails to build.\n\n But only because we pass --disable-nls. I expect that passing --enable-nls\nshould be sufficient to fix the build again. Indeed, all libcs not have libintl\nstubs built in so there is no reason why it shouldn't just work when you pass\n--enable-nls.\n\n Regards,\n Arnout","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x6bCr2Jqfz9s7m\n\tfor ;\n\tWed, 12 Jul 2017 07:42:48 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C4F80893FA;\n\tTue, 11 Jul 2017 21:42:45 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5s7Ci0tHWIUk; Tue, 11 Jul 2017 21:42:42 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id BE96C8928D;\n\tTue, 11 Jul 2017 21:42:42 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 02C2E1C0E5B\n\tfor ;\n\tTue, 11 Jul 2017 21:42:41 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id F1D7C8928D\n\tfor ;\n\tTue, 11 Jul 2017 21:42:40 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id L+vQXUouOjkz for ;\n\tTue, 11 Jul 2017 21:42:40 +0000 (UTC)","from exchange.essensium.com (220.77.144.195.ipv4.evonet.be\n\t[195.144.77.220])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id E0EA689233\n\tfor ; Tue, 11 Jul 2017 21:42:39 +0000 (UTC)","from [10.8.0.14] (10.3.7.11) by beleexch01.local.ess-mail.com\n\t(10.3.7.8) with Microsoft SMTP Server (TLS) id 15.0.847.32;\n\tTue, 11 Jul 2017 23:42:26 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","To":"Thomas Petazzoni , Peter Korsgaard\n\t","References":"<20170710175137.1402-1-bernd.kuhls@t-online.de>\n\t<87a84asr2s.fsf@dell.be.48ers.dk>\n\t<20170711231701.3850d479@windsurf.lan>","From":"Arnout Vandecappelle ","Organization":"Essensium/Mind","Message-ID":"","Date":"Tue, 11 Jul 2017 23:42:24 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<20170711231701.3850d479@windsurf.lan>","X-Originating-IP":"[10.3.7.11]","X-ClientProxiedBy":"beleexch01.local.ess-mail.com (10.3.7.8) To\n\tbeleexch01.local.ess-mail.com (10.3.7.8)","Cc":"Bernd Kuhls , buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1714914,"web_url":"http://patchwork.ozlabs.org/comment/1714914/","msgid":"<87zicaprft.fsf@dell.be.48ers.dk>","list_archive_url":null,"date":"2017-07-11T21:57:42","subject":"Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support","submitter":{"id":42365,"url":"http://patchwork.ozlabs.org/api/people/42365/","name":"Peter Korsgaard","email":"peter@korsgaard.com"},"content":">>>>> \"Arnout\" == Arnout Vandecappelle writes:\n\nHi,\n\n >> So I am not sure the fix is complete. Indeed the error says that the\n >> gtk client cannot be built without nls support. So I guess that if you\n >> have BR2_PACKCAGE_TRANSMISSION_GTK=y, but BR2_SYSTEM_ENABLE_NLS\n >> disabled it still fails to build.\n\n > But only because we pass --disable-nls. I expect that passing --enable-nls\n > should be sufficient to fix the build again. Indeed, all libcs not have libintl\n > stubs built in so there is no reason why it shouldn't just work when you pass\n > --enable-nls.\n\nYes, makes sense with the latest changes. Care to give it a try / send a\npatch?","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x6bYD0w1mz9s7v\n\tfor ;\n\tWed, 12 Jul 2017 07:57:52 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2C53988318;\n\tTue, 11 Jul 2017 21:57:49 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id s+NHaNjIxYh6; Tue, 11 Jul 2017 21:57:47 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7245488303;\n\tTue, 11 Jul 2017 21:57:47 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 34D1F1C0E5B\n\tfor ;\n\tTue, 11 Jul 2017 21:57:46 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 2C03E88303\n\tfor ;\n\tTue, 11 Jul 2017 21:57:46 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CCeHtF9vr2ka for ;\n\tTue, 11 Jul 2017 21:57:45 +0000 (UTC)","from mail-wr0-f176.google.com (mail-wr0-f176.google.com\n\t[209.85.128.176])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 5880E882FE\n\tfor ; Tue, 11 Jul 2017 21:57:45 +0000 (UTC)","by mail-wr0-f176.google.com with SMTP id c11so7577836wrc.3\n\tfor ; Tue, 11 Jul 2017 14:57:45 -0700 (PDT)","from dell.be.48ers.dk (d51A5BC31.access.telenet.be.\n\t[81.165.188.49]) by smtp.gmail.com with ESMTPSA id\n\tg24sm173684edh.20.2017.07.11.14.57.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 11 Jul 2017 14:57:43 -0700 (PDT)","from peko by dell.be.48ers.dk with local (Exim 4.88)\n\t(envelope-from )\n\tid 1dV3A6-0004H9-Gy; Tue, 11 Jul 2017 23:57:42 +0200"],"Authentication-Results":"ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"RBb0lOVe\"; dkim-atps=neutral","X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:references:date:in-reply-to:message-id\n\t:user-agent:mime-version;\n\tbh=sX8P4FlE8rLAxjdJ/Lcoa8IhdwIvjEBYGzcH0FNhuAQ=;\n\tb=RBb0lOVe7DgK/F+oRCO0Qs8zlimZzDSmy/M6aSA6e7+uiY4z83lNZYCIXtplTeP4Kg\n\t75sTjZDstRYuAP+FGU6rBlEMoHXfA9n3XS+mZF35FqAovakMcFMqh1GUTe7wNdYfiPZq\n\tSFc8JoiV7GKxBCKXppUZ2ihJHJPNWkdiB8DrvNPcAGKu+ryC5DF6oiuS5N851N+fiXX6\n\t0e7tS+wPmJRr+IstWH2cXV/eYL85CAxkzUrKsbR4Jq67fyAeCe5bLODPMs35HfIWQ3Je\n\tRfOVrLrcguT2DF4ldi9jhF7Pbe7DsDX8mFHxbzKgQrcQgczT3bbTUZVhGyVr32yB1cWe\n\tSIYA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:references:date\n\t:in-reply-to:message-id:user-agent:mime-version;\n\tbh=sX8P4FlE8rLAxjdJ/Lcoa8IhdwIvjEBYGzcH0FNhuAQ=;\n\tb=PagFjEJd+wxs5USJ39f3tZSwjRMH6LFTPKpD0R/VU5tdfHClCpYN9V9j2FXiQGbzZJ\n\tyi0xeEtpJlncjrpgAhfWR7Ki7EGbBTqEvS0MdZX+knJiF3ZZhQRD0lX4XpGtMEZl+rNX\n\tMzWIIkl0Il1ePvwgpkvJjUfPthTvph4egCpkjlfsIdY9qTbi5C26b17yhGozF/6CIwOH\n\tYQloZz8tuaXwa+fVRUrWsMvPgv1xSQK2UmiKB/8libXEmNHIctBbC5zsxoS3PJ4Fk2Xp\n\tWchpnT1O55LcEVJ2Lz82p49e4b6D9KEsHb9G8FlIOKh00VyLuXhIY/JShqzu5e+snbfh\n\t0hug==","X-Gm-Message-State":"AIVw111H9XrvR6arN4W7PVKGT+i7gwuOw0ggo8wYOHsLPZNPaf85gTrI\n\tcXCpCuMMFwWZJw==","X-Received":"by 10.80.151.49 with SMTP id c46mr3971842edb.30.1499810263914;\n\tTue, 11 Jul 2017 14:57:43 -0700 (PDT)","From":"Peter Korsgaard ","To":"Arnout Vandecappelle ","References":"<20170710175137.1402-1-bernd.kuhls@t-online.de>\n\t<87a84asr2s.fsf@dell.be.48ers.dk>\n\t<20170711231701.3850d479@windsurf.lan>\n\t","Date":"Tue, 11 Jul 2017 23:57:42 +0200","In-Reply-To":" (Arnout\n\tVandecappelle's message of \"Tue, 11 Jul 2017 23:42:24 +0200\")","Message-ID":"<87zicaprft.fsf@dell.be.48ers.dk>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)","MIME-Version":"1.0","Cc":"Thomas Petazzoni ,\n\tBernd Kuhls , buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1715222,"web_url":"http://patchwork.ozlabs.org/comment/1715222/","msgid":"<20170712094924.435a5c54@windsurf.lan>","list_archive_url":null,"date":"2017-07-12T07:49:24","subject":"Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nOn Tue, 11 Jul 2017 23:42:24 +0200, Arnout Vandecappelle wrote:\n\n> > configure: error: \"The gtk client cannot be built without nls support. Try adding either --enable-nls or --without-gtk\" \n> > \n> > Until the recent gettext revamp we were passing --disable-nls only when\n> > BR2_ENABLE_LOCALE was disabled. However, the transmission-gtk support has:\n> > \n> > \tdepends on BR2_PACKAGE_LIBGTK2 && BR2_ENABLE_LOCALE \n> \n> So in fact this dependency on LOCALE is wrong now. Indeed, the commit message\n> that added it (d6dfc2109c7149a795f7bda963a9a583685dec3f) says:\n\nAgreed, the BR2_ENABLE_LOCALE dependency is now wrong.\n\n> > Therefore, we were never building transmission with --disable-nls. With\n> > the gettext revamp, we now pass --disable-nls to all packages, unless\n> > BR2_SYSTEM_ENABLE_NLS is enabled (which it isn't by default).\n> > \n> > So I am not sure the fix is complete. Indeed the error says that the\n> > gtk client cannot be built without nls support. So I guess that if you\n> > have BR2_PACKCAGE_TRANSMISSION_GTK=y, but BR2_SYSTEM_ENABLE_NLS\n> > disabled it still fails to build. \n> \n> But only because we pass --disable-nls. I expect that passing --enable-nls\n> should be sufficient to fix the build again. Indeed, all libcs not have libintl\n\n\"not -> now\" I guess, correct?\n\n> stubs built in so there is no reason why it shouldn't just work when you pass\n> --enable-nls.\n\nWhy should we randomly pass --enable-nls to some packages? Why should\nthis package depends on BR2_SYSTEM_ENABLE_NLS, if it needs NLS support?\n\nThomas","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x6rgz6704z9s81\n\tfor ;\n\tWed, 12 Jul 2017 17:49:35 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 9075387E24;\n\tWed, 12 Jul 2017 07:49:31 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aoZvhrAR1Br7; Wed, 12 Jul 2017 07:49:30 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D215687DCB;\n\tWed, 12 Jul 2017 07:49:29 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3BA321C4128\n\tfor ;\n\tWed, 12 Jul 2017 07:49:28 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3680A88F0D\n\tfor ;\n\tWed, 12 Jul 2017 07:49:28 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lD1INEMXR2wA for ;\n\tWed, 12 Jul 2017 07:49:27 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3328788ED5\n\tfor ; Wed, 12 Jul 2017 07:49:27 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid B99BA207A1; Wed, 12 Jul 2017 09:49:23 +0200 (CEST)","from windsurf.lan (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 90CAC20773;\n\tWed, 12 Jul 2017 09:49:23 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Wed, 12 Jul 2017 09:49:24 +0200","From":"Thomas Petazzoni ","To":"Arnout Vandecappelle ","Message-ID":"<20170712094924.435a5c54@windsurf.lan>","In-Reply-To":"","References":"<20170710175137.1402-1-bernd.kuhls@t-online.de>\n\t<87a84asr2s.fsf@dell.be.48ers.dk>\n\t<20170711231701.3850d479@windsurf.lan>\n\t","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"Bernd Kuhls , buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1715306,"web_url":"http://patchwork.ozlabs.org/comment/1715306/","msgid":"<20170712110354.0627faa1@windsurf.lan>","list_archive_url":null,"date":"2017-07-12T09:03:54","subject":"Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nOn Wed, 12 Jul 2017 09:49:24 +0200, Thomas Petazzoni wrote:\n\n> Why should we randomly pass --enable-nls to some packages? Why should\n> this package depends on BR2_SYSTEM_ENABLE_NLS, if it needs NLS support?\n\nI meant to say:\n\n==\nWhy *shouldn't* this package depends on BR2_SYSTEM_ENABLE_NLS, if it\nneeds NLS support?\n==\n\nThomas","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x6tKy1DySz9s78\n\tfor ;\n\tWed, 12 Jul 2017 19:04:06 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id CC0E5893A4;\n\tWed, 12 Jul 2017 09:04:01 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3PU2gPq4MZyj; Wed, 12 Jul 2017 09:04:00 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E3FF7893D2;\n\tWed, 12 Jul 2017 09:03:59 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id CE9421C0E3B\n\tfor ;\n\tWed, 12 Jul 2017 09:03:58 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C745587C09\n\tfor ;\n\tWed, 12 Jul 2017 09:03:58 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FWsD09ZS7ycH for ;\n\tWed, 12 Jul 2017 09:03:57 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C5AA586238\n\tfor ; Wed, 12 Jul 2017 09:03:57 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 0BBD921DF9; Wed, 12 Jul 2017 11:03:53 +0200 (CEST)","from windsurf.lan (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id D378C207A1;\n\tWed, 12 Jul 2017 11:03:52 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Wed, 12 Jul 2017 11:03:54 +0200","From":"Thomas Petazzoni ","To":"Arnout Vandecappelle ","Message-ID":"<20170712110354.0627faa1@windsurf.lan>","In-Reply-To":"<20170712094924.435a5c54@windsurf.lan>","References":"<20170710175137.1402-1-bernd.kuhls@t-online.de>\n\t<87a84asr2s.fsf@dell.be.48ers.dk>\n\t<20170711231701.3850d479@windsurf.lan>\n\t\n\t<20170712094924.435a5c54@windsurf.lan>","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"Bernd Kuhls , buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1715382,"web_url":"http://patchwork.ozlabs.org/comment/1715382/","msgid":"<5fe9c108-7a04-ca7c-9bd8-aed7ac639026@mind.be>","list_archive_url":null,"date":"2017-07-12T10:04:42","subject":"Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support","submitter":{"id":11809,"url":"http://patchwork.ozlabs.org/api/people/11809/","name":"Arnout Vandecappelle","email":"arnout@mind.be"},"content":"On 12-07-17 09:49, Thomas Petazzoni wrote:\n> Hello,\n> \n> On Tue, 11 Jul 2017 23:42:24 +0200, Arnout Vandecappelle wrote:\n> \n>>> configure: error: \"The gtk client cannot be built without nls support. Try adding either --enable-nls or --without-gtk\" \n>>>\n>>> Until the recent gettext revamp we were passing --disable-nls only when\n>>> BR2_ENABLE_LOCALE was disabled. However, the transmission-gtk support has:\n>>>\n>>> \tdepends on BR2_PACKAGE_LIBGTK2 && BR2_ENABLE_LOCALE \n>>\n>> So in fact this dependency on LOCALE is wrong now. Indeed, the commit message\n>> that added it (d6dfc2109c7149a795f7bda963a9a583685dec3f) says:\n> \n> Agreed, the BR2_ENABLE_LOCALE dependency is now wrong.\n> \n>>> Therefore, we were never building transmission with --disable-nls. With\n>>> the gettext revamp, we now pass --disable-nls to all packages, unless\n>>> BR2_SYSTEM_ENABLE_NLS is enabled (which it isn't by default).\n>>>\n>>> So I am not sure the fix is complete. Indeed the error says that the\n>>> gtk client cannot be built without nls support. So I guess that if you\n>>> have BR2_PACKCAGE_TRANSMISSION_GTK=y, but BR2_SYSTEM_ENABLE_NLS\n>>> disabled it still fails to build. \n>>\n>> But only because we pass --disable-nls. I expect that passing --enable-nls\n>> should be sufficient to fix the build again. Indeed, all libcs not have libintl\n> \n> \"not -> now\" I guess, correct?\n\n Yes of course.\n\n> \n>> stubs built in so there is no reason why it shouldn't just work when you pass\n>> --enable-nls.\n> \n> Why should we randomly pass --enable-nls to some packages? Why should\n> this package depends on BR2_SYSTEM_ENABLE_NLS, if it needs NLS support?\n\n Because BR2_SYSTEM_ENABLE_NLS does not really say that NLS *support* is\nenabled, it says that NLS *installation* is enabled. NLS support is always\n\"enabled\" through the stubs in musl/uClibc.\n\n As far as I understand, the configure error is just there because the\ntransmission guys are too lazy to have conditional use of the intl functions. I\ndon't see how there could be a hard requirement on non-stub implementations of\nthe intl functions - except if they start calling internals. So the better\nsolution, actually, would be to patch out this check in configure and instead\ncheck for intl and error out if that is not available, independent on the\n--enable-nls option - just like most packages do, I think.\n\n If you're not actually interested in translations, there is no reason really\nwhy you should pull them in just because this package is calling gettext stuff\nunconditionally.\n\n That said, probably nobody really cares, we're just fixing build failures here.\nSo in the end I don't really mind if we depend on BR2_SYSTEM_ENABLE_NLS as the\neasy way out. Though then the commit message should at least provide the full\nstory, as a hint for future contributors who want to fix it properly.\n\n Regards,\n Arnout","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x6vhV5zTpz9s0g\n\tfor ;\n\tWed, 12 Jul 2017 20:05:14 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id DF006303A7;\n\tWed, 12 Jul 2017 10:05:07 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nxUInR0YCaj8; Wed, 12 Jul 2017 10:05:05 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 98B733039F;\n\tWed, 12 Jul 2017 10:05:05 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id B88031C2562\n\tfor ;\n\tWed, 12 Jul 2017 10:05:04 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A080C891CA\n\tfor ;\n\tWed, 12 Jul 2017 10:05:04 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id XZ3KCXSs0Rgt for ;\n\tWed, 12 Jul 2017 10:05:03 +0000 (UTC)","from exchange.essensium.com (220.77.144.195.ipv4.evonet.be\n\t[195.144.77.220])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 054FC89158\n\tfor ; Wed, 12 Jul 2017 10:05:02 +0000 (UTC)","from [10.8.0.14] (10.3.7.11) by beleexch01.local.ess-mail.com\n\t(10.3.7.8) with Microsoft SMTP Server (TLS) id 15.0.847.32;\n\tWed, 12 Jul 2017 12:04:49 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","To":"Thomas Petazzoni ","References":"<20170710175137.1402-1-bernd.kuhls@t-online.de>\n\t<87a84asr2s.fsf@dell.be.48ers.dk>\n\t<20170711231701.3850d479@windsurf.lan>\n\t\n\t<20170712094924.435a5c54@windsurf.lan>","From":"Arnout Vandecappelle ","Organization":"Essensium/Mind","Message-ID":"<5fe9c108-7a04-ca7c-9bd8-aed7ac639026@mind.be>","Date":"Wed, 12 Jul 2017 12:04:42 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<20170712094924.435a5c54@windsurf.lan>","X-Originating-IP":"[10.3.7.11]","X-ClientProxiedBy":"beleexch01.local.ess-mail.com (10.3.7.8) To\n\tbeleexch01.local.ess-mail.com (10.3.7.8)","Cc":"Bernd Kuhls , buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1762032,"web_url":"http://patchwork.ozlabs.org/comment/1762032/","msgid":"<877exiqa9l.fsf@dell.be.48ers.dk>","list_archive_url":null,"date":"2017-09-01T23:17:26","subject":"Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support","submitter":{"id":42365,"url":"http://patchwork.ozlabs.org/api/people/42365/","name":"Peter Korsgaard","email":"peter@korsgaard.com"},"content":">>>>> \"Bernd\" == Bernd Kuhls writes:\n\n > Gtk support is controlled by ARG_WITH since\n > https://github.com/transmission/transmission/commit/2ccc2bbbfe2e4a26dfeaa13b56c412ea0af4ebe4\n\n > Fixes a build error if libgtk2/3 was built before transmission:\n > http://autobuild.buildroot.net/results/6b6/6b6ce352a9edfe3aaba82be143092a878e7715ed/\n\n > Signed-off-by: Bernd Kuhls \n > ---\n > package/transmission/transmission.mk | 4 ++--\n > 1 file changed, 2 insertions(+), 2 deletions(-)\n\n > diff --git a/package/transmission/transmission.mk b/package/transmission/transmission.mk\n > index f8abb2b8b..d84e5cb77 100644\n > --- a/package/transmission/transmission.mk\n > +++ b/package/transmission/transmission.mk\n > @@ -82,10 +82,10 @@ TRANSMISSION_CONF_OPTS += --disable-remote\n > endif\n \n > ifeq ($(BR2_PACKAGE_TRANSMISSION_GTK),y)\n > -TRANSMISSION_CONF_OPTS += --enable-gtk\n > +TRANSMISSION_CONF_OPTS += --with-gtk\n > TRANSMISSION_DEPENDENCIES += libgtk2\n\nCommitted, thanks. I also pushed two followup patches to actually get it\nto build:\n\n- transmission-gtk needs libgtk3 instead of libgtk2 since 2.61\n (E.G. your version bump in 2013)\n\n- Adjusted NLS dependencies after the recent NLS rework\n (BR2_SYSTEM_ENABLE_NLS).","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"r26KZDax\"; dkim-atps=neutral"],"Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkZsQ2pp3z9sMN\n\tfor ;\n\tSat, 2 Sep 2017 09:17:45 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 293638A339;\n\tFri, 1 Sep 2017 23:17:38 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id RAfy07SzGnDN; Fri, 1 Sep 2017 23:17:35 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id CCD058A338;\n\tFri, 1 Sep 2017 23:17:35 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 370211C2738\n\tfor ;\n\tFri, 1 Sep 2017 23:17:34 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2AE7C882E8\n\tfor ;\n\tFri, 1 Sep 2017 23:17:34 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Vo0cBfOZNmrY for ;\n\tFri, 1 Sep 2017 23:17:33 +0000 (UTC)","from mail-wm0-f67.google.com (mail-wm0-f67.google.com\n\t[74.125.82.67])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id DE460882E7\n\tfor ; Fri, 1 Sep 2017 23:17:32 +0000 (UTC)","by mail-wm0-f67.google.com with SMTP id 187so1185182wmn.0\n\tfor ; Fri, 01 Sep 2017 16:17:32 -0700 (PDT)","from dell.be.48ers.dk (d51a5bc31.access.telenet.be.\n\t[81.165.188.49]) by smtp.gmail.com with ESMTPSA id\n\t93sm438983edi.77.2017.09.01.16.17.27\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 01 Sep 2017 16:17:29 -0700 (PDT)","from peko by dell.be.48ers.dk with local (Exim 4.88)\n\t(envelope-from )\n\tid 1dnvBm-0001Or-W3; Sat, 02 Sep 2017 01:17:27 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:references:date:in-reply-to:message-id\n\t:user-agent:mime-version;\n\tbh=pTDjLmxzaA4b1KDvM6o+dl8OCWYBumMRmWIWJg/xV8c=;\n\tb=r26KZDaxiS7VEk2uXb5dh6Wof/HfDwElsei8q1UmccwhE97gji8HQjw3lefqI4rEs9\n\tBEhzQtrturCngUXOy1xR2x8nnUmgx4TqmrDzecpZdEX/PydADmDIcJmDbtyVYTdtsBtK\n\tFbVUIPoX0jWsNX5zQBOhAN8s+Gu0XLehy6vZO0MGpqEuKUDX/N1UcdPxTRvc41XjdcGE\n\tkeIZZql+XlvypMwneQE8x93ZFsD2agziqmlPiaZfF6MVtHGb4BrJ8wontZFPDQ2/U/8O\n\tf16iLcPVnJzKwbvSGxPoyw5wJXNde5wTFA8NemtUffBXm6OJ0056RB/uRPj52pRHk8ll\n\tsEdA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:references:date\n\t:in-reply-to:message-id:user-agent:mime-version;\n\tbh=pTDjLmxzaA4b1KDvM6o+dl8OCWYBumMRmWIWJg/xV8c=;\n\tb=UGMFlIuwPyAjM5URbZ7SLEEG77dKEoLkKBK721Io9Br5IQ9+R8GM3hD/rR3DJ2miPP\n\t0GtPdaExzB5tEXk/EuxtiDfnWjW11LDTfKSH7kc05II+XijSogGLRzt9Kinoz029gCce\n\taOtjDpjLSdWcsTee9e9Qo1crXJFvyoe63GYcHiIQ7+YU2t61QmVCu9kIq2ZFZ5vJq5VN\n\tqB+zPtgo9syuEHDs2SY04z0mkObf6DCZJPAtE2LiLJVEVPKt4Jx4mpbz2L8jB0sHwO2J\n\tY9YXoyMUwFvOLMwCku7xhshfW/Wa6IbXP9if7XQhxi3EibD86Y+LXbZ0y7diHysqPET4\n\tHoZA==","X-Gm-Message-State":"AHPjjUhdCHOy/BO8Uh9O8RcZxcG8BhN587ARx0I1E2/WYOPze0z+7ljQ\n\tfesRDroOgb2+2g==","X-Google-Smtp-Source":"ADKCNb7mJejGsqmN6PjAsyNNxfG4zLUqihhio8ieqBwr/33sRcXTOfPbaVTfOCq/+Za/ap1JRkj0/Q==","X-Received":"by 10.80.153.157 with SMTP id m29mr2060173edb.271.1504307851357; \n\tFri, 01 Sep 2017 16:17:31 -0700 (PDT)","From":"Peter Korsgaard ","To":"Bernd Kuhls ","References":"<20170710175137.1402-1-bernd.kuhls@t-online.de>","Date":"Sat, 02 Sep 2017 01:17:26 +0200","In-Reply-To":"<20170710175137.1402-1-bernd.kuhls@t-online.de> (Bernd Kuhls's\n\tmessage of \"Mon, 10 Jul 2017 19:51:37 +0200\")","Message-ID":"<877exiqa9l.fsf@dell.be.48ers.dk>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)","MIME-Version":"1.0","Cc":"buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1762033,"web_url":"http://patchwork.ozlabs.org/comment/1762033/","msgid":"<873786qa77.fsf@dell.be.48ers.dk>","list_archive_url":null,"date":"2017-09-01T23:18:52","subject":"Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support","submitter":{"id":42365,"url":"http://patchwork.ozlabs.org/api/people/42365/","name":"Peter Korsgaard","email":"peter@korsgaard.com"},"content":">>>>> \"Arnout\" == Arnout Vandecappelle writes:\n\nHi,\n\n >> Why should we randomly pass --enable-nls to some packages? Why should\n >> this package depends on BR2_SYSTEM_ENABLE_NLS, if it needs NLS support?\n\n > Because BR2_SYSTEM_ENABLE_NLS does not really say that NLS *support* is\n > enabled, it says that NLS *installation* is enabled. NLS support is always\n > \"enabled\" through the stubs in musl/uClibc.\n\n > As far as I understand, the configure error is just there because the\n > transmission guys are too lazy to have conditional use of the intl functions. I\n > don't see how there could be a hard requirement on non-stub implementations of\n > the intl functions - except if they start calling internals. So the better\n > solution, actually, would be to patch out this check in configure and instead\n > check for intl and error out if that is not available, independent on the\n > --enable-nls option - just like most packages do, I think.\n\n > If you're not actually interested in translations, there is no reason really\n > why you should pull them in just because this package is calling gettext stuff\n > unconditionally.\n\n > That said, probably nobody really cares, we're just fixing build failures here.\n > So in the end I don't really mind if we depend on BR2_SYSTEM_ENABLE_NLS as the\n > easy way out. Though then the commit message should at least provide the full\n > story, as a hint for future contributors who want to fix it properly.\n\nCorrect. I went with depending on BR2_SYSTEM_ENABLE_NLS, but I added a\ncomment explaining that we could also explictly pass --enable-nls.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"JuuhmHBf\"; dkim-atps=neutral"],"Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkZtz1wXhz9sMN\n\tfor ;\n\tSat, 2 Sep 2017 09:19:07 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 06B9B30BD2;\n\tFri, 1 Sep 2017 23:19:02 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 89Oje4-2zgXa; Fri, 1 Sep 2017 23:18:58 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id BB5E730BCD;\n\tFri, 1 Sep 2017 23:18:58 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 074341C2738\n\tfor ;\n\tFri, 1 Sep 2017 23:18:58 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 01DD88A34E\n\tfor ;\n\tFri, 1 Sep 2017 23:18:58 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FxIMhGowdOcU for ;\n\tFri, 1 Sep 2017 23:18:57 +0000 (UTC)","from mail-wm0-f66.google.com (mail-wm0-f66.google.com\n\t[74.125.82.66])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 3161C8A34D\n\tfor ; Fri, 1 Sep 2017 23:18:57 +0000 (UTC)","by mail-wm0-f66.google.com with SMTP id p17so1403307wmd.3\n\tfor ; Fri, 01 Sep 2017 16:18:57 -0700 (PDT)","from dell.be.48ers.dk (d51a5bc31.access.telenet.be.\n\t[81.165.188.49]) by smtp.gmail.com with ESMTPSA id\n\tj93sm14233edc.12.2017.09.01.16.18.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 01 Sep 2017 16:18:54 -0700 (PDT)","from peko by dell.be.48ers.dk with local (Exim 4.88)\n\t(envelope-from )\n\tid 1dnvDA-0001yP-9G; Sat, 02 Sep 2017 01:18:53 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:references:date:in-reply-to:message-id\n\t:user-agent:mime-version;\n\tbh=TeH05XhKFKsmR80AyNYJ3DLsU/UGOr62qNijnh9c8wQ=;\n\tb=JuuhmHBf469eO/ndH6UgI3YNKsrLRrqIE8ugHm7Wp0iQergHjij8yEKdonzy362FA+\n\t3EpZ0MEv9Nbm6V1AK9Cymz6x5+57/TS+mJEP9xUTt5ItaTTtIJTs6zsrfjd0ziqmPOdQ\n\tOmyr82bK/FUN65jIlQNp71ROxKsQaDPZxkS4v0oadEeUmRKFv5AB90LM2H4oeuohWhXb\n\tu+A1VSFBYjTTELEVBs4s1nV2w3RBwycxcPmRYSly+VV+qQorEal0uQkkLmIMVIWkBwQi\n\tfkxMv2edAQTAz2dqAcNAwQuxhdjYLqhJu7sqCxVg73QfOX+qdAKYHccS8HrN3Cy0wQRh\n\t+DiA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:references:date\n\t:in-reply-to:message-id:user-agent:mime-version;\n\tbh=TeH05XhKFKsmR80AyNYJ3DLsU/UGOr62qNijnh9c8wQ=;\n\tb=Jzq/zVtDgpvnrcBWcGy4E+Yv/YQWwQ9tOCIWmQcI4g7t/aIBAw9UwxeshXm/LpRFd2\n\twOIDp7WbbMCNaGKLJgNzcPn5yG5ZPdAXaSmP0n2zAA18IfMsGrb4aP8Hn8ITYbBVv5nh\n\tg8JEM0tyExNdvGax+dsycpp7BZWl/W5uT2u4BAI0+lK4HRXoaONLBKwguy9ZInM6reuc\n\tKlk3U51XL+2qJVjOyb00q0Y2e45PDjv1jzsOvPAopnqbn1k78pOPbNGyCoUVFPcmBjUf\n\t8PAnjhu4hdXsVqT0wkOkIa/Df/vFfMmkkdWfUBF7PTW4gdi03Ha4AOYL8HxBqToDPej8\n\tpf+Q==","X-Gm-Message-State":"AHPjjUjovSkHcVWb/uGwS3/+S/HW+R0ygQPFAxHjJtqUGkZwPJiyBnSD\n\tUjfAjYOKpcUZ9Q==","X-Google-Smtp-Source":"ADKCNb7Wvowj+s7ffu2+WhiZJ0UAxS0qYxxBvaeCBhC8koINJCEJd2DMKD3WwmPqPp+k42VZNBDFkg==","X-Received":"by 10.80.171.133 with SMTP id u5mr2821100edc.205.1504307935747; \n\tFri, 01 Sep 2017 16:18:55 -0700 (PDT)","From":"Peter Korsgaard ","To":"Arnout Vandecappelle ","References":"<20170710175137.1402-1-bernd.kuhls@t-online.de>\n\t<87a84asr2s.fsf@dell.be.48ers.dk>\n\t<20170711231701.3850d479@windsurf.lan>\n\t\n\t<20170712094924.435a5c54@windsurf.lan>\n\t<5fe9c108-7a04-ca7c-9bd8-aed7ac639026@mind.be>","Date":"Sat, 02 Sep 2017 01:18:52 +0200","In-Reply-To":"<5fe9c108-7a04-ca7c-9bd8-aed7ac639026@mind.be> (Arnout\n\tVandecappelle's message of \"Wed, 12 Jul 2017 12:04:42 +0200\")","Message-ID":"<873786qa77.fsf@dell.be.48ers.dk>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)","MIME-Version":"1.0","Cc":"Thomas Petazzoni ,\n\tBernd Kuhls , buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]