[{"id":1713133,"web_url":"http://patchwork.ozlabs.org/comment/1713133/","msgid":"<878tjwva0l.fsf@concordia.ellerman.id.au>","date":"2017-07-10T10:52:58","subject":"Re: [PATCH] powerpc/powernv/idle: Put pnv_cpu_offline behind\n\tHOTPLUG_CPU","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"Joel Stanley writes:\n> In commit 900612315788 (\"powerpc/powernv/smp: Add busy-wait loop as fall back\n> for CPU-Hotplug\") the idle code uses generic_check_cpu_restart(), but that\n> function is not available when CONFIG_HOTPLUG_CPU is disabled.\n>\n> arch/powerpc/platforms/powernv/idle.c: In function ‘pnv_cpu_offline’:\n> arch/powerpc/platforms/powernv/idle.c:286:11: error: implicit declaration of\n> function ‘generic_check_cpu_restart’ [-Werror=implicit-function-declaration]\n> while (!generic_check_cpu_restart(cpu)) {\n> ^~~~~~~~~~~~~~~~~~~~~~~~~\n>\n> The callers of pnv_cpu_offline are behind CONFIG_HOTPLUG_CPU, so fix the build\n> error by putting this code behind the same gard.\n>\n> Fixes: 900612315788 (\"powerpc/powernv/smp: Add busy-wait loop as fall back for CPU-Hotplug\").\n> Cc: # 4.12\n> Signed-off-by: Joel Stanley \n\nThis was fixed upstream in commit 67d204180886, but I forgot to tag it\nfor stable.\n\nhttps://git.kernel.org/torvalds/c/67d204180886\n\n\nI've just sent mail to stable asking for it to be backported to 4.12.\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x5hsd65J5z9s03\n\tfor ;\n\tMon, 10 Jul 2017 20:53:57 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3x5hsd5GNTzDqgR\n\tfor ;\n\tMon, 10 Jul 2017 20:53:57 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3x5hrW1g3tzDq6W\n\tfor ;\n\tMon, 10 Jul 2017 20:52:59 +1000 (AEST)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3x5hrV6QFPz9s0g;\n\tMon, 10 Jul 2017 20:52:58 +1000 (AEST)"],"From":"Michael Ellerman ","To":"Joel Stanley ,\n\t\"Gautham R . Shenoy\" ","Subject":"Re: [PATCH] powerpc/powernv/idle: Put pnv_cpu_offline behind\n\tHOTPLUG_CPU","In-Reply-To":"<20170703040152.5144-1-joel@jms.id.au>","References":"<20170703040152.5144-1-joel@jms.id.au>","User-Agent":"Notmuch/0.21 (https://notmuchmail.org)","Date":"Mon, 10 Jul 2017 20:52:58 +1000","Message-ID":"<878tjwva0l.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,\n\tstable@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]