[{"id":1704070,"web_url":"http://patchwork.ozlabs.org/comment/1704070/","msgid":"<87bmp7bc09.fsf@concordia.ellerman.id.au>","date":"2017-06-29T05:26:14","subject":"Re: [PATCH] powerpc: remapping too much memory","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"Dan Carpenter writes:\n\n> There is a cut and paste error here so we use \"sizeof(struct mpc83xx_pmc)\"\n> to remap the memory for \"clock_regs\". That sizeof() is 20 bytes and we\n> only need to remap 12 bytes. It presumably doesn't affect run time too\n> much...\n\nI don't know 83xx well, but I suspect mappings occur on a 4K granularity\nat a minimum :)\n\n> I changed them to both use \"sizeof(*variable_name)\" because that's the\n> prefered kernel style these days.\n\nThanks.\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wyp7d585Cz9s0m\n\tfor ;\n\tThu, 29 Jun 2017 15:27:09 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3wyp7d4VTHzDr77\n\tfor ;\n\tThu, 29 Jun 2017 15:27:09 +1000 (AEST)","from ozlabs.org (ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3wyp6b01x0zDr4g\n\tfor ;\n\tThu, 29 Jun 2017 15:26:15 +1000 (AEST)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3wyp6Z60Xjz9s0m;\n\tThu, 29 Jun 2017 15:26:14 +1000 (AEST)"],"From":"Michael Ellerman ","To":"Dan Carpenter , Scott Wood ","Subject":"Re: [PATCH] powerpc: remapping too much memory","In-Reply-To":"<20170628114907.kf3t65mrdbq7rsfm@mwanda>","References":"<20170628114907.kf3t65mrdbq7rsfm@mwanda>","User-Agent":"Notmuch/0.21 (https://notmuchmail.org)","Date":"Thu, 29 Jun 2017 15:26:14 +1000","Message-ID":"<87bmp7bc09.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kernel-janitors@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n\tPaul Mackerras ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1760887,"web_url":"http://patchwork.ozlabs.org/comment/1760887/","msgid":"<3xjgLF5Q9Lz9t2W@ozlabs.org>","date":"2017-08-31T11:36:05","subject":"Re: powerpc: remapping too much memory","submitter":{"id":69509,"url":"http://patchwork.ozlabs.org/api/people/69509/","name":"Michael Ellerman","email":"patch-notifications@ellerman.id.au"},"content":"On Wed, 2017-06-28 at 11:49:07 UTC, Dan Carpenter wrote:\n> There is a cut and paste error here so we use \"sizeof(struct mpc83xx_pmc)\"\n> to remap the memory for \"clock_regs\". That sizeof() is 20 bytes and we\n> only need to remap 12 bytes. It presumably doesn't affect run time too\n> much...\n> \n> I changed them to both use \"sizeof(*variable_name)\" because that's the\n> prefered kernel style these days.\n> \n> Fixes: d49747bdfb2d (\"powerpc/mpc83xx: Power Management support\")\n> Signed-off-by: Dan Carpenter \n\nApplied to powerpc next, thanks.\n\nhttps://git.kernel.org/powerpc/c/c65540453e150844367ffe98e45d51\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjgrW1nRsz9t16\n\tfor ;\n\tThu, 31 Aug 2017 21:58:51 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjgrW0t0szDqZ9\n\tfor ;\n\tThu, 31 Aug 2017 21:58:51 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjgLF6JG3zDqV5\n\tfor ;\n\tThu, 31 Aug 2017 21:36:05 +1000 (AEST)","by ozlabs.org (Postfix, from userid 1034)\n\tid 3xjgLF5Q9Lz9t2W; Thu, 31 Aug 2017 21:36:05 +1000 (AEST)"],"X-powerpc-patch-notification":"thanks","X-powerpc-patch-commit":"c65540453e150844367ffe98e45d5175181b2ec1","In-Reply-To":"<20170628114907.kf3t65mrdbq7rsfm@mwanda>","To":"Dan Carpenter , Scott Wood ","From":"Michael Ellerman ","Subject":"Re: powerpc: remapping too much memory","Message-Id":"<3xjgLF5Q9Lz9t2W@ozlabs.org>","Date":"Thu, 31 Aug 2017 21:36:05 +1000 (AEST)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paul Mackerras , kernel-janitors@vger.kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]