[{"id":1703057,"web_url":"http://patchwork.ozlabs.org/comment/1703057/","msgid":"<20170628095232.GA27785@lst.de>","date":"2017-06-28T09:52:32","subject":"Re: [PATCH] powerpc: conditionally compile platform-specific\n\tserial drivers","submitter":{"id":2722,"url":"http://patchwork.ozlabs.org/api/people/2722/","name":"Torsten Duwe","email":"duwe@lst.de"},"content":"On Tue, Jun 27, 2017 at 04:29:51PM +0200, Hannes Reinecke wrote:\n> mpsc.c and mpc52xx-psc.c are platform-specific serial drivers, and\n> should be compiled for the respective platforms only.\n\nYes, this is really dead code that gets compiled and copied needlessly,\non all PPCs apart from those embedded platforms.\n\n> Signed-off-by: Hannes Reinecke \n\nReviewed-by: Torsten Duwe \n\n> ---\n> arch/powerpc/boot/Makefile | 7 ++++---\n> arch/powerpc/boot/serial.c | 4 ++++\n> 2 files changed, 8 insertions(+), 3 deletions(-)\n> \n> diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile\n> index e82f333..1a4609c 100644\n> --- a/arch/powerpc/boot/Makefile\n> +++ b/arch/powerpc/boot/Makefile\n> @@ -99,14 +99,15 @@ src-wlib-y := string.S crt0.S crtsavres.S stdio.c decompress.c main.c \\\n> \t\t$(libfdt) libfdt-wrapper.c \\\n> \t\tns16550.c serial.c simple_alloc.c div64.S util.S \\\n> \t\telf_util.c $(zlib-y) devtree.c stdlib.c \\\n> -\t\toflib.c ofconsole.c cuboot.c mpsc.c cpm-serial.c \\\n> -\t\tuartlite.c mpc52xx-psc.c opal.c\n> +\t\toflib.c ofconsole.c cuboot.c cpm-serial.c \\\n> +\t\tuartlite.c opal.c\n> +src-wlib-$(CONFIG_PPC_MPC52XX) += mpc52xx-psc.c\n> src-wlib-$(CONFIG_PPC64_BOOT_WRAPPER) += opal-calls.S\n> src-wlib-$(CONFIG_40x) += 4xx.c planetcore.c\n> src-wlib-$(CONFIG_44x) += 4xx.c ebony.c bamboo.c\n> src-wlib-$(CONFIG_8xx) += mpc8xx.c planetcore.c fsl-soc.c\n> src-wlib-$(CONFIG_PPC_82xx) += pq2.c fsl-soc.c planetcore.c\n> -src-wlib-$(CONFIG_EMBEDDED6xx) += mv64x60.c mv64x60_i2c.c ugecon.c fsl-soc.c\n> +src-wlib-$(CONFIG_EMBEDDED6xx) += mpsc.c mv64x60.c mv64x60_i2c.c ugecon.c fsl-soc.c\n> \n> src-plat-y := of.c epapr.c\n> src-plat-$(CONFIG_40x) += fixed-head.S ep405.c cuboot-hotfoot.c \\\n> diff --git a/arch/powerpc/boot/serial.c b/arch/powerpc/boot/serial.c\n> index e04c1e4..7b5c02b 100644\n> --- a/arch/powerpc/boot/serial.c\n> +++ b/arch/powerpc/boot/serial.c\n> @@ -120,15 +120,19 @@ int serial_console_init(void)\n> \tif (dt_is_compatible(devp, \"ns16550\") ||\n> \t dt_is_compatible(devp, \"pnpPNP,501\"))\n> \t\trc = ns16550_console_init(devp, &serial_cd);\n> +#ifdef CONFIG_EMBEDDED6xx\n> \telse if (dt_is_compatible(devp, \"marvell,mv64360-mpsc\"))\n> \t\trc = mpsc_console_init(devp, &serial_cd);\n> +#endif\n> \telse if (dt_is_compatible(devp, \"fsl,cpm1-scc-uart\") ||\n> \t dt_is_compatible(devp, \"fsl,cpm1-smc-uart\") ||\n> \t dt_is_compatible(devp, \"fsl,cpm2-scc-uart\") ||\n> \t dt_is_compatible(devp, \"fsl,cpm2-smc-uart\"))\n> \t\trc = cpm_console_init(devp, &serial_cd);\n> +#ifdef CONFIG_PPC_MPC52XX\n> \telse if (dt_is_compatible(devp, \"fsl,mpc5200-psc-uart\"))\n> \t\trc = mpc5200_psc_console_init(devp, &serial_cd);\n> +#endif\n> \telse if (dt_is_compatible(devp, \"xlnx,opb-uartlite-1.00.b\") ||\n> \t\t dt_is_compatible(devp, \"xlnx,xps-uartlite-1.00.a\"))\n> \t\trc = uartlite_console_init(devp, &serial_cd);\n> -- \n> 1.8.5.6\n>","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wyJFz11msz9s5L\n\tfor ;\n\tWed, 28 Jun 2017 20:00:55 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3wyJFz0CqfzDr4Z\n\tfor ;\n\tWed, 28 Jun 2017 20:00:55 +1000 (AEST)","from newverein.lst.de (verein.lst.de [213.95.11.211])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3wyJDf078bzDr3h\n\tfor ;\n\tWed, 28 Jun 2017 19:59:45 +1000 (AEST)","by newverein.lst.de (Postfix, from userid 2005)\n\tid 3BD1168B03; Wed, 28 Jun 2017 11:52:32 +0200 (CEST)"],"X-Greylist":"delayed 429 seconds by postgrey-1.36 at bilbo;\n\tWed, 28 Jun 2017 19:59:46 AEST","Date":"Wed, 28 Jun 2017 11:52:32 +0200","From":"Torsten Duwe ","To":"Hannes Reinecke ","Subject":"Re: [PATCH] powerpc: conditionally compile platform-specific\n\tserial drivers","Message-ID":"<20170628095232.GA27785@lst.de>","References":"<1498573791-6781-1-git-send-email-hare@suse.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1498573791-6781-1-git-send-email-hare@suse.de>","User-Agent":"Mutt/1.5.17 (2007-11-01)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Hannes Reinecke , linuxppc-dev@lists.ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1760883,"web_url":"http://patchwork.ozlabs.org/comment/1760883/","msgid":"<3xjgLD6XBkz9t2Q@ozlabs.org>","date":"2017-08-31T11:36:02","subject":"Re: powerpc: conditionally compile platform-specific serial drivers","submitter":{"id":69509,"url":"http://patchwork.ozlabs.org/api/people/69509/","name":"Michael Ellerman","email":"patch-notifications@ellerman.id.au"},"content":"On Tue, 2017-06-27 at 14:29:51 UTC, Hannes Reinecke wrote:\n> mpsc.c and mpc52xx-psc.c are platform-specific serial drivers, and\n> should be compiled for the respective platforms only.\n> \n> Signed-off-by: Hannes Reinecke \n> Reviewed-by: Torsten Duwe \n\nApplied to powerpc next, thanks.\n\nhttps://git.kernel.org/powerpc/c/866bfc75f40e4f8a00d268f73f3a02\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjgph0XCnz9s72\n\tfor ;\n\tThu, 31 Aug 2017 21:57:16 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjgpg6swYzDqYw\n\tfor ;\n\tThu, 31 Aug 2017 21:57:15 +1000 (AEST)","from ozlabs.org (bilbo.ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjgLF0J7rzDqT0\n\tfor ;\n\tThu, 31 Aug 2017 21:36:05 +1000 (AEST)","by ozlabs.org (Postfix, from userid 1034)\n\tid 3xjgLD6XBkz9t2Q; Thu, 31 Aug 2017 21:36:02 +1000 (AEST)"],"X-powerpc-patch-notification":"thanks","X-powerpc-patch-commit":"866bfc75f40e4f8a00d268f73f3a02f572e6c082","In-Reply-To":"<1498573791-6781-1-git-send-email-hare@suse.de>","To":"Hannes Reinecke ,\n\tBenjamin Herrenschmidt ","From":"Michael Ellerman ","Subject":"Re: powerpc: conditionally compile platform-specific serial drivers","Message-Id":"<3xjgLD6XBkz9t2Q@ozlabs.org>","Date":"Thu, 31 Aug 2017 21:36:02 +1000 (AEST)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Hannes Reinecke , linuxppc-dev@lists.ozlabs.org,\n\tHannes Reinecke , Torsten Duwe ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]