[{"id":1705073,"web_url":"http://patchwork.ozlabs.org/comment/1705073/","msgid":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10DAC1C9@ORSMSX104.amr.corp.intel.com>","list_archive_url":null,"date":"2017-06-29T20:47:20","subject":"Re: [Intel-wired-lan] [next PATCH S74-V2 08/10] i40e/i40evf:\n\torganize\tand re-number feature flags","submitter":{"id":66945,"url":"http://patchwork.ozlabs.org/api/people/66945/","name":"Bowers, AndrewX","email":"andrewx.bowers@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On\n> Behalf Of Alice Michael\n> Sent: Friday, June 23, 2017 1:25 AM\n> To: Michael, Alice ; intel-wired-\n> lan@lists.osuosl.org\n> Subject: [Intel-wired-lan] [next PATCH S74-V2 08/10] i40e/i40evf: organize\n> and re-number feature flags\n> \n> From: Jacob Keller \n> \n> Now that we've reduced the number of flags, organize similar flags together\n> and re-number them accordingly.\n> \n> Also ensure that the flags variable is actually a u64 to guarantee 64bits of\n> space on all architectures.\n> \n> One alternative approach considered, but not implemented here, was to use\n> an enumeration for the flag variables, and create a macro\n> I40E_FLAG() which used string concatenation to generate BIT_ULL values.\n> This has the advantage of making the actual bit values compile-time dynamic\n> so that we do not need to worry about matching the order to the bit value.\n> However, this does produce a high level of code churn, and makes it more\n> difficult to read a dumped flags value when debugging.\n> \n> Signed-off-by: Jacob Keller \n> Reviewed-by: Williams, Mitch A \n> Change-ID: I8653fff69453cd547d6fe98d29dfa9d8710387d1\n> ---\n> drivers/net/ethernet/intel/i40e/i40e.h | 57 +++++++++++++++-------------\n> --\n> drivers/net/ethernet/intel/i40evf/i40evf.h | 30 ++++++++--------\n> 2 files changed, 44 insertions(+), 43 deletions(-)\n\nTested-by: Andrew Bowers ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3wzBYV68Xwz9s74\n\tfor ;\n\tFri, 30 Jun 2017 06:47:26 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 1A4C430A5A;\n\tThu, 29 Jun 2017 20:47:25 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id GDaxVhi0Wcge; Thu, 29 Jun 2017 20:47:24 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id F3438309C3;\n\tThu, 29 Jun 2017 20:47:23 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 76B3A1C274B\n\tfor ;\n\tThu, 29 Jun 2017 20:47:23 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6D3A68857E\n\tfor ;\n\tThu, 29 Jun 2017 20:47:23 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id q3t8OKMiT+Ri for ;\n\tThu, 29 Jun 2017 20:47:22 +0000 (UTC)","from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 8E18281651\n\tfor ;\n\tThu, 29 Jun 2017 20:47:22 +0000 (UTC)","from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga104.jf.intel.com with ESMTP; 29 Jun 2017 13:47:22 -0700","from orsmsx110.amr.corp.intel.com ([10.22.240.8])\n\tby orsmga001.jf.intel.com with ESMTP; 29 Jun 2017 13:47:22 -0700","from orsmsx111.amr.corp.intel.com (10.22.240.12) by\n\tORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server\n\t(TLS) id 14.3.319.2; Thu, 29 Jun 2017 13:47:21 -0700","from orsmsx104.amr.corp.intel.com ([169.254.4.9]) by\n\tORSMSX111.amr.corp.intel.com ([10.22.240.12]) with mapi id\n\t14.03.0319.002; Thu, 29 Jun 2017 13:47:21 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.40,282,1496127600\"; d=\"scan'208\";\n\ta=\"1146232103\"","From":"\"Bowers, AndrewX\" ","To":"\"intel-wired-lan@lists.osuosl.org\" ","Thread-Topic":"[Intel-wired-lan] [next PATCH S74-V2 08/10] i40e/i40evf:\n\torganize\tand re-number feature flags","Thread-Index":"AQHS7D3fqqfFN6S/JkSh+m3kJBtEe6I8WT6w","Date":"Thu, 29 Jun 2017 20:47:20 +0000","Message-ID":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10DAC1C9@ORSMSX104.amr.corp.intel.com>","References":"<20170623082451.32671-1-alice.michael@intel.com>\n\t<20170623082451.32671-8-alice.michael@intel.com>","In-Reply-To":"<20170623082451.32671-8-alice.michael@intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGEzNWI2YTMtNzYzMi00ODY1LWFmMmEtNGU0N2RjMzcwZjg0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkZTbXMxRzQwYzNISHZEQVZ2alk1WmRuaUM2Qjd3dDNxbXNHd0tFWUdaMjA9In0=","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"10.0.102.7","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.140]","MIME-Version":"1.0","Subject":"Re: [Intel-wired-lan] [next PATCH S74-V2 08/10] i40e/i40evf:\n\torganize\tand re-number feature flags","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]