[{"id":1737224,"web_url":"http://patchwork.ozlabs.org/comment/1737224/","msgid":"<9ecbcdf1d8de4cde8f5bebbdf76c5420@SFHDAG6NODE3.st.com>","list_archive_url":null,"date":"2017-08-03T13:25:30","subject":"Re: [U-Boot] [PATCH] cmd: usb: check usb_stor_curr_dev in usb dev\n\twith no parameter","submitter":{"id":70437,"url":"http://patchwork.ozlabs.org/api/people/70437/","name":"Patrick DELAUNAY","email":"patrick.delaunay@st.com"},"content":"Hi Marek,\n\nDo think that this minor patch could be integrated in v2017.09 ?\n\nhttp://patchwork.ozlabs.org/patch/762328/\n\n\nRegards\nPatrick\n\n> -----Original Message-----\n> From: Patrick DELAUNAY\n> Sent: lundi 15 mai 2017 11:16\n> To: u-boot@lists.denx.de\n> Cc: Yann GAUTIER ; Patrick DELAUNAY\n> ; Michal Simek ;\n> Simon Glass ; Peng Fan ;\n> Hans de Goede \n> Subject: [PATCH] cmd: usb: check usb_stor_curr_dev in usb dev with no\n> parameter\n> Importance: High\n> \n> If 'usb start' does not find devices, the command 'usb dev'\n> without parameter will lead to error= USB device -1: data abort A check on\n> usb_stor_curr_dev avoid the issue\n> \n> Signed-off-by: Patrick Delaunay \n> ---\n> \n> cmd/usb.c | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/cmd/usb.c b/cmd/usb.c\n> index 4fa456e..bc90553 100644\n> --- a/cmd/usb.c\n> +++ b/cmd/usb.c\n> @@ -803,6 +803,10 @@ static int do_usb(cmd_tbl_t *cmdtp, int flag, int argc,\n> char * const argv[])\n> \t\t\tprintf(\"... is now current device\\n\");\n> \t\t\treturn 0;\n> \t\t} else {\n> +\t\t\tif (usb_stor_curr_dev < 0) {\n> +\t\t\t\tprintf(\"no current device selected\\n\");\n> +\t\t\t\treturn 1;\n> +\t\t\t}\n> \t\t\tprintf(\"\\nUSB device %d: \", usb_stor_curr_dev);\n> \t\t\tstor_dev = blk_get_devnum_by_type(IF_TYPE_USB,\n> \t\t\t\t\t\t\t usb_stor_curr_dev);\n> --\n> 1.9.1","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xNW5n4784z9s78\n\tfor ;\n\tThu, 3 Aug 2017 23:25:49 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 815F8C21D86; Thu, 3 Aug 2017 13:25:42 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 824A0C21D09;\n\tThu, 3 Aug 2017 13:25:40 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid CE973C21D09; Thu, 3 Aug 2017 13:25:38 +0000 (UTC)","from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com\n\t[62.209.51.94]) by lists.denx.de (Postfix) with ESMTPS id BEE4AC21C2F\n\tfor ; Thu, 3 Aug 2017 13:25:36 +0000 (UTC)","from pps.filterd (m0046037.ppops.net [127.0.0.1])\n\tby mx07-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv73DOQ5W026010; Thu, 3 Aug 2017 15:25:32 +0200","from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35])\n\tby mx07-.pphosted.com with ESMTP id 2c40schcma-1\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT);\n\tThu, 03 Aug 2017 15:25:32 +0200","from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9])\n\tby beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 8951531;\n\tThu, 3 Aug 2017 13:25:31 +0000 (GMT)","from Webmail-eu.st.com (sfhdag6node3.st.com [10.75.127.18])\n\tby zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 45D851BEB;\n\tThu, 3 Aug 2017 13:25:31 +0000 (GMT)","from SFHDAG6NODE3.st.com (10.75.127.18) by SFHDAG6NODE3.st.com\n\t(10.75.127.18) with Microsoft SMTP Server (TLS) id 15.0.1178.4;\n\tThu, 3 Aug 2017 15:25:31 +0200","from SFHDAG6NODE3.st.com ([fe80::d04:5337:ab17:b6f6]) by\n\tSFHDAG6NODE3.st.com ([fe80::d04:5337:ab17:b6f6%20]) with mapi id\n\t15.00.1178.000; Thu, 3 Aug 2017 15:25:30 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=unavailable autolearn_force=no version=3.4.0","From":"Patrick DELAUNAY ","To":"\"u-boot@lists.denx.de\" ,\n\tMarek Vasut ","Thread-Topic":"[PATCH] cmd: usb: check usb_stor_curr_dev in usb dev with no\n\tparameter","Thread-Index":"AQHSzVvXZV02oU/9cUGuZaPuqKgD6KJzHKDA","Date":"Thu, 3 Aug 2017 13:25:30 +0000","Message-ID":"<9ecbcdf1d8de4cde8f5bebbdf76c5420@SFHDAG6NODE3.st.com>","References":"<1494839745-20351-1-git-send-email-patrick.delaunay@st.com>","In-Reply-To":"<1494839745-20351-1-git-send-email-patrick.delaunay@st.com>","Accept-Language":"fr-FR, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-exchange-transport-fromentityheader":"Hosted","x-originating-ip":"[10.75.127.50]","MIME-Version":"1.0","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-08-03_06:, , signatures=0","Cc":"Yann GAUTIER ,\n\tMichal Simek , \n\tHans de Goede ","Subject":"Re: [U-Boot] [PATCH] cmd: usb: check usb_stor_curr_dev in usb dev\n\twith no parameter","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1738486,"web_url":"http://patchwork.ozlabs.org/comment/1738486/","msgid":"","list_archive_url":null,"date":"2017-08-04T13:21:58","subject":"Re: [U-Boot] [PATCH] cmd: usb: check usb_stor_curr_dev in usb dev\n\twith no parameter","submitter":{"id":12009,"url":"http://patchwork.ozlabs.org/api/people/12009/","name":"Marek Vasut","email":"marex@denx.de"},"content":"On 08/03/2017 03:25 PM, Patrick DELAUNAY wrote:\n> Hi Marek,\n\nHi,\n\nplease stop top-posting.\n\n> Do think that this minor patch could be integrated in v2017.09 ?\n> \n> http://patchwork.ozlabs.org/patch/762328/\n\nFix up the commit message, detail a bit more how to trigger the issue\nand use errno.h return value (-ENODEV ?) in the new code . Send V2 and\nI'll pick it.\n\n> Regards\n> Patrick\n> \n>> -----Original Message-----\n>> From: Patrick DELAUNAY\n>> Sent: lundi 15 mai 2017 11:16\n>> To: u-boot@lists.denx.de\n>> Cc: Yann GAUTIER ; Patrick DELAUNAY\n>> ; Michal Simek ;\n>> Simon Glass ; Peng Fan ;\n>> Hans de Goede \n>> Subject: [PATCH] cmd: usb: check usb_stor_curr_dev in usb dev with no\n>> parameter\n>> Importance: High\n>>\n>> If 'usb start' does not find devices, the command 'usb dev'\n>> without parameter will lead to error= USB device -1: data abort A check on\n>> usb_stor_curr_dev avoid the issue\n>>\n>> Signed-off-by: Patrick Delaunay \n>> ---\n>>\n>> cmd/usb.c | 4 ++++\n>> 1 file changed, 4 insertions(+)\n>>\n>> diff --git a/cmd/usb.c b/cmd/usb.c\n>> index 4fa456e..bc90553 100644\n>> --- a/cmd/usb.c\n>> +++ b/cmd/usb.c\n>> @@ -803,6 +803,10 @@ static int do_usb(cmd_tbl_t *cmdtp, int flag, int argc,\n>> char * const argv[])\n>> \t\t\tprintf(\"... is now current device\\n\");\n>> \t\t\treturn 0;\n>> \t\t} else {\n>> +\t\t\tif (usb_stor_curr_dev < 0) {\n>> +\t\t\t\tprintf(\"no current device selected\\n\");\n>> +\t\t\t\treturn 1;\n>> +\t\t\t}\n>> \t\t\tprintf(\"\\nUSB device %d: \", usb_stor_curr_dev);\n>> \t\t\tstor_dev = blk_get_devnum_by_type(IF_TYPE_USB,\n>> \t\t\t\t\t\t\t usb_stor_curr_dev);\n>> --\n>> 1.9.1\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xP7Wv2W4Dz9rxj\n\tfor ;\n\tFri, 4 Aug 2017 23:47:07 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 00784C21EDE; Fri, 4 Aug 2017 13:46:56 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id B8762C21ECE;\n\tFri, 4 Aug 2017 13:46:53 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 6BB0FC21E05; Fri, 4 Aug 2017 13:46:43 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9])\n\tby lists.denx.de (Postfix) with ESMTPS id B5570C21EDD\n\tfor ; Fri, 4 Aug 2017 13:46:39 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xP7WM1BBtz1qsDx;\n\tFri, 4 Aug 2017 15:46:39 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xP7WL6r9rz3hhV3;\n\tFri, 4 Aug 2017 15:46:38 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id kzSBo4zZyh37; Fri, 4 Aug 2017 15:46:37 +0200 (CEST)","from [IPv6:::1] (unknown [195.140.253.167])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tFri, 4 Aug 2017 15:46:37 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"IPhbzzcGYVLCEEBzs0uut6zWo5zKGzxFqKHx/n5ardE=","To":"Patrick DELAUNAY ,\n\t\"u-boot@lists.denx.de\" ","References":"<1494839745-20351-1-git-send-email-patrick.delaunay@st.com>\n\t<9ecbcdf1d8de4cde8f5bebbdf76c5420@SFHDAG6NODE3.st.com>","From":"Marek Vasut ","Message-ID":"","Date":"Fri, 4 Aug 2017 15:21:58 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<9ecbcdf1d8de4cde8f5bebbdf76c5420@SFHDAG6NODE3.st.com>","Content-Language":"en-US","Cc":"Yann GAUTIER ,\n\tMichal Simek , \n\tHans de Goede ","Subject":"Re: [U-Boot] [PATCH] cmd: usb: check usb_stor_curr_dev in usb dev\n\twith no parameter","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1766748,"web_url":"http://patchwork.ozlabs.org/comment/1766748/","msgid":"<07c775c5f6a34cd49dd228b373f54899@SFHDAG6NODE3.st.com>","list_archive_url":null,"date":"2017-09-12T08:22:39","subject":"Re: [U-Boot] [PATCH] cmd: usb: check usb_stor_curr_dev in usb dev\n\twith no parameter","submitter":{"id":70437,"url":"http://patchwork.ozlabs.org/api/people/70437/","name":"Patrick DELAUNAY","email":"patrick.delaunay@st.com"},"content":"Hi Marek,\r\n\r\n> \r\n> On 08/03/2017 03:25 PM, Patrick DELAUNAY wrote:\r\n> > Hi Marek,\r\n> \r\n> Hi,\r\n> \r\n> please stop top-posting.\r\n> \r\n\r\nSorry, bad habit\r\n\r\n\r\n> > Do think that this minor patch could be integrated in v2017.09 ?\r\n> >\r\n> > http://patchwork.ozlabs.org/patch/762328/\r\n> \r\n> Fix up the commit message, detail a bit more how to trigger the issue and use\r\n> errno.h return value (-ENODEV ?) in the new code . Send V2 and I'll pick it.\r\n\r\nOk, I will send a V2 version today after a long delay due to holiday and other task.\r\n\r\nFor the result, I can't use errno.h because it is a command result, so I use CMD_RET_FAILURE is V2\r\n\r\n> > Regards\r\n> > Patrick\r\n> >\r\n> \r\n> --\r\n> Best regards,\r\n> Marek Vasut\r\n\r\n\r\nBest regards\r\nPatrick","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xryTv7427z9s7F\n\tfor ;\n\tTue, 12 Sep 2017 18:22:59 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid A4E07C21F3F; Tue, 12 Sep 2017 08:22:53 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 60767C21DBC;\n\tTue, 12 Sep 2017 08:22:47 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid C0F07C21DBC; Tue, 12 Sep 2017 08:22:45 +0000 (UTC)","from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com\n\t[91.207.212.93])\n\tby lists.denx.de (Postfix) with ESMTPS id 628E4C21C57\n\tfor ; Tue, 12 Sep 2017 08:22:44 +0000 (UTC)","from pps.filterd (m0046660.ppops.net [127.0.0.1])\n\tby mx08-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8C8JXXb031639; Tue, 12 Sep 2017 10:22:41 +0200","from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35])\n\tby mx08-00178001.pphosted.com with ESMTP id 2cv5e4rhpf-1\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT);\n\tTue, 12 Sep 2017 10:22:41 +0200","from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9])\n\tby beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 57C1238;\n\tTue, 12 Sep 2017 08:22:40 +0000 (GMT)","from Webmail-eu.st.com (sfhdag6node2.st.com [10.75.127.17])\n\tby zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id E233C164C;\n\tTue, 12 Sep 2017 08:22:39 +0000 (GMT)","from SFHDAG6NODE3.st.com (10.75.127.18) by SFHDAG6NODE2.st.com\n\t(10.75.127.17) with Microsoft SMTP Server (TLS) id 15.0.1178.4;\n\tTue, 12 Sep 2017 10:22:39 +0200","from SFHDAG6NODE3.st.com ([fe80::d04:5337:ab17:b6f6]) by\n\tSFHDAG6NODE3.st.com ([fe80::d04:5337:ab17:b6f6%20]) with mapi id\n\t15.00.1178.000; Tue, 12 Sep 2017 10:22:39 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=unavailable autolearn_force=no version=3.4.0","From":"Patrick DELAUNAY ","To":"Marek Vasut ,\n\t\"u-boot@lists.denx.de\" ","Thread-Topic":"[PATCH] cmd: usb: check usb_stor_curr_dev in usb dev with no\n\tparameter","Thread-Index":"AQHSzVvXZV02oU/9cUGuZaPuqKgD6KJzHKDAgAFwbQCAPRSWQA==","Date":"Tue, 12 Sep 2017 08:22:39 +0000","Message-ID":"<07c775c5f6a34cd49dd228b373f54899@SFHDAG6NODE3.st.com>","References":"<1494839745-20351-1-git-send-email-patrick.delaunay@st.com>\n\t<9ecbcdf1d8de4cde8f5bebbdf76c5420@SFHDAG6NODE3.st.com>\n\t","In-Reply-To":"","Accept-Language":"fr-FR, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-exchange-transport-fromentityheader":"Hosted","x-originating-ip":"[10.75.127.48]","MIME-Version":"1.0","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-12_03:, , signatures=0","Cc":"Yann GAUTIER ,\n\tMichal Simek , \n\tHans de Goede ","Subject":"Re: [U-Boot] [PATCH] cmd: usb: check usb_stor_curr_dev in usb dev\n\twith no parameter","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]