[{"id":1643765,"web_url":"http://patchwork.ozlabs.org/comment/1643765/","msgid":"<20170425155257.s6m4wgrzxxsxcggo@sirena.org.uk>","list_archive_url":null,"date":"2017-04-25T15:52:57","subject":"Re: [PATCH v2 15/18] dt-bindings: sound: Add bindings for Cirrus\n\tLogic Madera codecs","submitter":{"id":24878,"url":"http://patchwork.ozlabs.org/api/people/24878/","name":"Mark Brown","email":"broonie@kernel.org"},"content":"On Mon, Apr 24, 2017 at 05:08:41PM +0100, Richard Fitzgerald wrote:\n> The Cirrus Logic Madera codecs are a family of related codecs with\n> extensive digital and analogue I/O, digital mixing and routing,\n> signal processing and programmable DSPs.\n\nPlease submit patches using subject lines reflecting the style for the\nsubsystem. This makes it easier for people to identify relevant\npatches. Look at what existing commits in the area you're changing are\ndoing and make sure your subject lines visually resemble what they're\ndoing.\n\n> +Required properties:\n> + - compatible : One of the following chip-specific strings:\n> + \"cirrus,cs47l35-codec\"\n> + \"cirrus,cs47l85-codec\"\n> + \"cirrus,cs47l90-codec\"\n\nYou shouldn't have compatible strings for subfunctions of a MFD unless\nthese represent meaningful reusable IPs that can exist separately from\nthe parent chip, that's clearly not the case here. All you're doing\nhere is encoding Linux internal abstractions which aren't OS neutral and\nmight change in future (for example clocking might move more into the\nclock API).","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3wC76l6DY0z9s8G\n\tfor ;\n\tWed, 26 Apr 2017 01:53:51 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1951052AbdDYPxg (ORCPT\n\t);\n\tTue, 25 Apr 2017 11:53:36 -0400","from mezzanine.sirena.org.uk ([106.187.55.193]:33846 \"EHLO\n\tmezzanine.sirena.org.uk\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1951147AbdDYPxW (ORCPT\n\t); Tue, 25 Apr 2017 11:53:22 -0400","from [2001:470:1f1d:6b5::3] (helo=debutante)\n\tby mezzanine.sirena.org.uk with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1d32lv-0000xN-T1; Tue, 25 Apr 2017 15:53:02 +0000","from broonie by debutante with local (Exim 4.89)\n\t(envelope-from )\n\tid 1d32lt-0002tz-3h; Tue, 25 Apr 2017 16:52:57 +0100"],"Date":"Tue, 25 Apr 2017 16:52:57 +0100","From":"Mark Brown ","To":"Richard Fitzgerald ","Cc":"lee.jones@linaro.org, linus.walleij@linaro.org, gnurou@gmail.com,\n\trobh+dt@kernel.org, tglx@linutronix.de, jason@lakedaemon.net,\n\talsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,\n\tlinux-gpio@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Message-ID":"<20170425155257.s6m4wgrzxxsxcggo@sirena.org.uk>","References":"<1493050124-5970-1-git-send-email-rf@opensource.wolfsonmicro.com>\n\t<1493050124-5970-16-git-send-email-rf@opensource.wolfsonmicro.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"ibw4kwd45lk3fi6z\"","Content-Disposition":"inline","In-Reply-To":"<1493050124-5970-16-git-send-email-rf@opensource.wolfsonmicro.com>","X-Cookie":"panic: can't find /","User-Agent":"NeoMutt/20170306 (1.8.0)","X-SA-Exim-Connect-IP":"2001:470:1f1d:6b5::3","X-SA-Exim-Mail-From":"broonie@sirena.org.uk","Subject":"Re: [PATCH v2 15/18] dt-bindings: sound: Add bindings for Cirrus\n\tLogic Madera codecs","X-SA-Exim-Version":"4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)","X-SA-Exim-Scanned":"No (on mezzanine.sirena.org.uk); Unknown failure","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1643805,"web_url":"http://patchwork.ozlabs.org/comment/1643805/","msgid":"<1493137664.4826.75.camel@rf-debian.wolfsonmicro.main>","list_archive_url":null,"date":"2017-04-25T16:27:44","subject":"Re: [PATCH v2 15/18] dt-bindings: sound: Add bindings for Cirrus\n\tLogic Madera codecs","submitter":{"id":65141,"url":"http://patchwork.ozlabs.org/api/people/65141/","name":"Richard Fitzgerald","email":"rf@opensource.wolfsonmicro.com"},"content":"On Tue, 2017-04-25 at 16:52 +0100, Mark Brown wrote:\n> On Mon, Apr 24, 2017 at 05:08:41PM +0100, Richard Fitzgerald wrote:\n> > The Cirrus Logic Madera codecs are a family of related codecs with\n> > extensive digital and analogue I/O, digital mixing and routing,\n> > signal processing and programmable DSPs.\n> \n> Please submit patches using subject lines reflecting the style for the\n> subsystem. This makes it easier for people to identify relevant\n> patches. Look at what existing commits in the area you're changing are\n> doing and make sure your subject lines visually resemble what they're\n> doing.\n> \n> > +Required properties:\n> > + - compatible : One of the following chip-specific strings:\n> > + \"cirrus,cs47l35-codec\"\n> > + \"cirrus,cs47l85-codec\"\n> > + \"cirrus,cs47l90-codec\"\n> \n> You shouldn't have compatible strings for subfunctions of a MFD unless\n> these represent meaningful reusable IPs that can exist separately from\n> the parent chip, that's clearly not the case here. All you're doing\n> here is encoding Linux internal abstractions which aren't OS neutral and\n> might change in future (for example clocking might move more into the\n> clock API).\n\nWhile that's nice, the of_node doesn't get populated if there isn't a\ncompatible string. And people don't like workarounds for the missing\nof_node.\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3wC7tV0lJ4z9s8Q\n\tfor ;\n\tWed, 26 Apr 2017 02:28:18 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1172235AbdDYQ2F (ORCPT\n\t);\n\tTue, 25 Apr 2017 12:28:05 -0400","from mx0b-001ae601.pphosted.com ([67.231.152.168]:48011 \"EHLO\n\tmx0b-001ae601.pphosted.com\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1170578AbdDYQ2E (ORCPT\n\t); Tue, 25 Apr 2017 12:28:04 -0400","from pps.filterd (m0077474.ppops.net [127.0.0.1])\n\tby mx0b-001ae601.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv3PGOwaF008030; Tue, 25 Apr 2017 11:27:46 -0500","from mail3.cirrus.com ([87.246.76.56])\n\tby mx0b-001ae601.pphosted.com with ESMTP id 2a03kmmdte-1;\n\tTue, 25 Apr 2017 11:27:46 -0500","from EX17.ad.cirrus.com (ex17.ad.cirrus.com [172.20.9.81])\n\tby mail3.cirrus.com (Postfix) with ESMTP id 49123611CE7D;\n\tTue, 25 Apr 2017 11:29:38 -0500 (CDT)","from imbe.wolfsonmicro.main (198.61.95.81) by EX17.ad.cirrus.com\n\t(172.20.9.81) with Microsoft SMTP Server id 14.3.301.0;\n\tTue, 25 Apr 2017 17:27:45 +0100","from [198.90.223.7] (rf-debian.ad.cirrus.com [198.90.223.7]) by\n\timbe.wolfsonmicro.main (8.14.4/8.14.4) with ESMTP id v3PGQt3t018747;\n\tTue, 25 Apr 2017 17:26:55 +0100"],"Authentication-Results":"ppops.net;\n\tspf=none smtp.mailfrom=rf@opensource.wolfsonmicro.com","Message-ID":"<1493137664.4826.75.camel@rf-debian.wolfsonmicro.main>","Subject":"Re: [PATCH v2 15/18] dt-bindings: sound: Add bindings for Cirrus\n\tLogic Madera codecs","From":"Richard Fitzgerald ","To":"Mark Brown ","CC":", ,\n\t, , ,\n\t, ,\n\t,\n\t, ,\n\t","Date":"Tue, 25 Apr 2017 17:27:44 +0100","In-Reply-To":"<20170425155257.s6m4wgrzxxsxcggo@sirena.org.uk>","References":"<1493050124-5970-1-git-send-email-rf@opensource.wolfsonmicro.com>\n\t<1493050124-5970-16-git-send-email-rf@opensource.wolfsonmicro.com>\n\t<20170425155257.s6m4wgrzxxsxcggo@sirena.org.uk>","Content-Type":"text/plain; charset=\"us-ascii\"","X-Mailer":"Evolution 3.4.4-3 ","MIME-Version":"1.0","Content-Transfer-Encoding":"7bit","X-Proofpoint-Spam-Details":"rule=notspam policy=default score=0\n\tpriorityscore=1501 malwarescore=0\n\tsuspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015\n\tlowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam\n\tadjust=0\n\treason=mlx scancount=1 engine=8.0.1-1703280000\n\tdefinitions=main-1704250295","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1647383,"web_url":"http://patchwork.ozlabs.org/comment/1647383/","msgid":"<20170428180652.5fb6gagdtrtlgfdy@rob-hp-laptop>","list_archive_url":null,"date":"2017-04-28T18:06:52","subject":"Re: [PATCH v2 15/18] dt-bindings: sound: Add bindings for Cirrus\n\tLogic Madera codecs","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Tue, Apr 25, 2017 at 04:52:57PM +0100, Mark Brown wrote:\n> On Mon, Apr 24, 2017 at 05:08:41PM +0100, Richard Fitzgerald wrote:\n> > The Cirrus Logic Madera codecs are a family of related codecs with\n> > extensive digital and analogue I/O, digital mixing and routing,\n> > signal processing and programmable DSPs.\n> \n> Please submit patches using subject lines reflecting the style for the\n> subsystem. This makes it easier for people to identify relevant\n> patches. Look at what existing commits in the area you're changing are\n> doing and make sure your subject lines visually resemble what they're\n> doing.\n> \n> > +Required properties:\n> > + - compatible : One of the following chip-specific strings:\n> > + \"cirrus,cs47l35-codec\"\n> > + \"cirrus,cs47l85-codec\"\n> > + \"cirrus,cs47l90-codec\"\n> \n> You shouldn't have compatible strings for subfunctions of a MFD unless\n> these represent meaningful reusable IPs that can exist separately from\n> the parent chip, that's clearly not the case here. All you're doing\n> here is encoding Linux internal abstractions which aren't OS neutral and\n> might change in future (for example clocking might move more into the\n> clock API).\n\ns/compatible strings/child nodes/ and I agree. If you have child nodes, \nthen they need to have compatible strings so we can tell what child is \nwhich. Node name can be used, but there's no way to version node names. \nA compatible implies what properties are valid.\n\nRob\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3wF1x12LPlz9s89\n\tfor ;\n\tSat, 29 Apr 2017 04:07:01 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S642287AbdD1SG5 (ORCPT );\n\tFri, 28 Apr 2017 14:06:57 -0400","from mail-io0-f194.google.com ([209.85.223.194]:36795 \"EHLO\n\tmail-io0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S642262AbdD1SGy (ORCPT\n\t); Fri, 28 Apr 2017 14:06:54 -0400","by mail-io0-f194.google.com with SMTP id x86so12987894ioe.3;\n\tFri, 28 Apr 2017 11:06:54 -0700 (PDT)","from localhost (66-90-148-125.dyn.grandenetworks.net.\n\t[66.90.148.125]) by smtp.gmail.com with ESMTPSA id\n\t32sm1182327oto.11.2017.04.28.11.06.53\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 28 Apr 2017 11:06:53 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=Xsy2JcqzZiUYXBNvja+iZCCtaMSG+8yT5PiGXWxHX0M=;\n\tb=SM4jyz5J1HHkJSWWvKsE44C60uYnvg+/cCuktDmcrhUxTlTXRhCidR20pTPVFfMm26\n\t8z30RgH9hDCKdWqMj/t54mmZSv4kpnPKtTXfwS5nsIMnK93UXFSJKSqt+Jq+ja6e7zq/\n\t2n15ouHWqz95UtAPuB/CEru/86qOgqjmzUuz0iQsb3Pvh6Hvve2Y+SdVWL0Zcr6f2usE\n\tBdi64L7HTttxcOgHm/SatX++p3zv13te7f6SMsyYfDaNN+2JSQaT3N6/7vmOZcgTjZg+\n\tr7bW3zPjNnv0PCQA5qXSmRiLEkLKGIKwpc7JGA06R0bbc1WWjBWz9Vb3l2ZzvED6tbVK\n\tN4UQ==","X-Gm-Message-State":"AN3rC/7pBnIUxtb4ja9zatdWWZmvK0brq7NCnXImidshI3wlpFSPe3kx\n\ttlHZbaHe1DNqKA==","X-Received":"by 10.202.172.66 with SMTP id v63mr4497353oie.84.1493402813900; \n\tFri, 28 Apr 2017 11:06:53 -0700 (PDT)","Date":"Fri, 28 Apr 2017 13:06:52 -0500","From":"Rob Herring ","To":"Mark Brown ","Cc":"Richard Fitzgerald ,\n\tlee.jones@linaro.org, linus.walleij@linaro.org, gnurou@gmail.com,\n\ttglx@linutronix.de, jason@lakedaemon.net,\n\talsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,\n\tlinux-gpio@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH v2 15/18] dt-bindings: sound: Add bindings for Cirrus\n\tLogic Madera codecs","Message-ID":"<20170428180652.5fb6gagdtrtlgfdy@rob-hp-laptop>","References":"<1493050124-5970-1-git-send-email-rf@opensource.wolfsonmicro.com>\n\t<1493050124-5970-16-git-send-email-rf@opensource.wolfsonmicro.com>\n\t<20170425155257.s6m4wgrzxxsxcggo@sirena.org.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170425155257.s6m4wgrzxxsxcggo@sirena.org.uk>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1660346,"web_url":"http://patchwork.ozlabs.org/comment/1660346/","msgid":"<20170514100403.nocjlb77q5r3nvo2@sirena.org.uk>","list_archive_url":null,"date":"2017-05-14T10:04:03","subject":"Re: [PATCH v2 15/18] dt-bindings: sound: Add bindings for Cirrus\n\tLogic Madera codecs","submitter":{"id":24878,"url":"http://patchwork.ozlabs.org/api/people/24878/","name":"Mark Brown","email":"broonie@kernel.org"},"content":"On Tue, Apr 25, 2017 at 05:27:44PM +0100, Richard Fitzgerald wrote:\n> On Tue, 2017-04-25 at 16:52 +0100, Mark Brown wrote:\n\n> > > +Required properties:\n> > > + - compatible : One of the following chip-specific strings:\n> > > + \"cirrus,cs47l35-codec\"\n> > > + \"cirrus,cs47l85-codec\"\n> > > + \"cirrus,cs47l90-codec\"\n\n> > You shouldn't have compatible strings for subfunctions of a MFD unless\n> > these represent meaningful reusable IPs that can exist separately from\n> > the parent chip, that's clearly not the case here. All you're doing\n> > here is encoding Linux internal abstractions which aren't OS neutral and\n> > might change in future (for example clocking might move more into the\n> > clock API).\n\n> While that's nice, the of_node doesn't get populated if there isn't a\n> compatible string. And people don't like workarounds for the missing\n> of_node.\n\nWhat workarounds are you referring to? Why would this need any kind of\nworkaround, there is no requirement for magic broken nodes like this in\nthe subsystem and if there is we should fix that rather than bodge the\nABI.","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3wRCcS12rcz9s75\n\tfor ;\n\tMon, 15 May 2017 17:58:00 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1759911AbdEOH4r (ORCPT\n\t);\n\tMon, 15 May 2017 03:56:47 -0400","from mezzanine.sirena.org.uk ([106.187.55.193]:48630 \"EHLO\n\tmezzanine.sirena.org.uk\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1759903AbdEOH4p (ORCPT\n\t); Mon, 15 May 2017 03:56:45 -0400","from [2001:470:1f1d:6b5:7e7a:91ff:fede:4a45] (helo=finisterre)\n\tby mezzanine.sirena.org.uk with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dAArn-0001bZ-PQ; Mon, 15 May 2017 07:56:34 +0000","from broonie by finisterre with local (Exim 4.89)\n\t(envelope-from )\n\tid 1d9qNf-0001Jm-Om; Sun, 14 May 2017 19:04:03 +0900"],"Date":"Sun, 14 May 2017 19:04:03 +0900","From":"Mark Brown ","To":"Richard Fitzgerald ","Cc":"lee.jones@linaro.org, linus.walleij@linaro.org, gnurou@gmail.com,\n\trobh+dt@kernel.org, tglx@linutronix.de, jason@lakedaemon.net,\n\talsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,\n\tlinux-gpio@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Message-ID":"<20170514100403.nocjlb77q5r3nvo2@sirena.org.uk>","References":"<1493050124-5970-1-git-send-email-rf@opensource.wolfsonmicro.com>\n\t<1493050124-5970-16-git-send-email-rf@opensource.wolfsonmicro.com>\n\t<20170425155257.s6m4wgrzxxsxcggo@sirena.org.uk>\n\t<1493137664.4826.75.camel@rf-debian.wolfsonmicro.main>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"cza46krmerc4eir5\"","Content-Disposition":"inline","In-Reply-To":"<1493137664.4826.75.camel@rf-debian.wolfsonmicro.main>","X-Cookie":"Dealer prices may vary.","User-Agent":"NeoMutt/20170306 (1.8.0)","X-SA-Exim-Connect-IP":"2001:470:1f1d:6b5:7e7a:91ff:fede:4a45","X-SA-Exim-Mail-From":"broonie@sirena.org.uk","Subject":"Re: [PATCH v2 15/18] dt-bindings: sound: Add bindings for Cirrus\n\tLogic Madera codecs","X-SA-Exim-Version":"4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)","X-SA-Exim-Scanned":"No (on mezzanine.sirena.org.uk); Unknown failure","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]