[{"id":1611486,"web_url":"http://patchwork.ozlabs.org/comment/1611486/","msgid":"<20170320042047.GA29814@umbus.fritz.box>","date":"2017-03-20T04:20:47","subject":"Re: [patch] KVM: PPC: Book3S HV: check for kmalloc errors in ioctl","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Fri, Mar 17, 2017 at 11:41:14PM +0300, Dan Carpenter wrote:\n> kzalloc() won't actually fail because sizeof(*resize) is small, but\n> static checkers complain.\n> \n> Signed-off-by: Dan Carpenter \n\nOops, that's an embarrassing mistake.\n\nAcked-by: David Gibson \n\n> \n> diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c\n> index 8c68145ba1bd..710e491206ed 100644\n> --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c\n> +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c\n> @@ -1487,6 +1487,10 @@ long kvm_vm_ioctl_resize_hpt_prepare(struct kvm *kvm,\n> \t/* start new resize */\n> \n> \tresize = kzalloc(sizeof(*resize), GFP_KERNEL);\n> +\tif (!resize) {\n> +\t\tret = -ENOMEM;\n> +\t\tgoto out;\n> +\t}\n> \tresize->order = shift;\n> \tresize->kvm = kvm;\n> \tINIT_WORK(&resize->work, resize_hpt_prepare_work);\n>","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vmlP95mwGz9s3l\n\tfor ;\n\tMon, 20 Mar 2017 16:48:45 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3vmlP94jz9zDqZQ\n\tfor ;\n\tMon, 20 Mar 2017 16:48:45 +1100 (AEDT)","from ozlabs.org (ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3vmlMb4y70zDq5g\n\tfor ;\n\tMon, 20 Mar 2017 16:47:23 +1100 (AEDT)","by ozlabs.org (Postfix, from userid 1007)\n\tid 3vmlMb3s6Rz9s73; Mon, 20 Mar 2017 16:47:23 +1100 (AEDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"lXUCDfeC\"; \n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"lXUCDfeC\"; \n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au\n\theader.b=\"lXUCDfeC\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1489988843;\n\tbh=d1mRfyTqXQjcZM8Ymnkic/ytgWS66L1Rmth2Ji0ACKQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lXUCDfeC9hvO0c08cDmwGhzzgt+Vl23Yr0ggkNmfKfO+DZk5weUx4Iisto0EHc8bc\n\t4SLOX7vDDsM8bo95/KDONMPDbRMm6FqtaTZQgJlLps99wLs1Vl2lqWLwDdtEts8oIP\n\tTXD5sxjtbiTMXH16ojShov3oIeEmuSEzE7hQ8noM=","Date":"Mon, 20 Mar 2017 15:20:47 +1100","From":"David Gibson ","To":"Dan Carpenter ","Subject":"Re: [patch] KVM: PPC: Book3S HV: check for kmalloc errors in ioctl","Message-ID":"<20170320042047.GA29814@umbus.fritz.box>","References":"<20170317204113.GA16505@mwanda>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"PNTmBPCT7hxwcZjr\"","Content-Disposition":"inline","In-Reply-To":"<20170317204113.GA16505@mwanda>","User-Agent":"Mutt/1.8.0 (2017-02-23)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kvm@vger.kernel.org, Radim =?utf-8?B?S3LEjW3DocWZ?= ,\n\tkernel-janitors@vger.kernel.org, kvm-ppc@vger.kernel.org,\n\tPaul Mackerras , Paolo Bonzini ,\n\tlinuxppc-dev@lists.ozlabs.org, Alexander Graf ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]