[{"id":1603597,"web_url":"http://patchwork.ozlabs.org/comment/1603597/","msgid":"<87o9xa3sd7.fsf@possimpible.ozlabs.ibm.com>","date":"2017-03-10T00:09:08","subject":"Re: [PATCH] powerpc: asm: convert directive .llong to .8byte","submitter":{"id":65792,"url":"http://patchwork.ozlabs.org/api/people/65792/","name":"Daniel Axtens","email":"dja@axtens.net"},"content":"Hi Tobin,\n\n> .llong is an undocumented PPC specific directive. The generic\n> equivalent is .quad, but even better (because it's self describing) is\n> .8byte.\n>\n> Convert directives .llong -> .8byte\n>\n> Signed-off-by: Tobin C. Harding \n> ---\n>\n> Fixes: issue #33 (github)\n\nThanks for tackling these!\n\nI have applied your patch to my local tree. I ran `git grep '\\.llong'`,\nand found:\n\ntools/testing/selftests/powerpc/switch_endian/switch_endian_test.S: .llong 0x5555AAAA5555AAAA\n\nThat file is also handled by mpe and the powerpc tree even though it\ndoesn't live in arch/powerpc - could you please change that one as well?\n\nApart from that, the patch looks good!\n\nRegards,\nDaniel\n\n> Patch is not tested. Has been built on Power8\n>\n> scripts/get_maintainer.pl throws warning:\n> Bad divisor in main::vcs_assign: 0\n>\n> arch/powerpc/boot/crt0.S | 20 ++++++++++----------\n> arch/powerpc/include/asm/asm-compat.h | 2 +-\n> arch/powerpc/include/asm/feature-fixups.h | 6 +++---\n> arch/powerpc/include/asm/reg.h | 12 ++++++------\n> arch/powerpc/kernel/entry_64.S | 2 +-\n> arch/powerpc/kernel/head_64.S | 8 ++++----\n> arch/powerpc/kernel/reloc_64.S | 6 +++---\n> arch/powerpc/kernel/systbl.S | 14 +++++++-------\n> arch/powerpc/platforms/powernv/opal-wrappers.S | 2 +-\n> arch/powerpc/platforms/pseries/hvCall.S | 2 +-\n> arch/powerpc/purgatory/trampoline.S | 4 ++--\n> 11 files changed, 39 insertions(+), 39 deletions(-)\n>\n> diff --git a/arch/powerpc/boot/crt0.S b/arch/powerpc/boot/crt0.S\n> index 12866cc..dcf2f15 100644\n> --- a/arch/powerpc/boot/crt0.S\n> +++ b/arch/powerpc/boot/crt0.S\n> @@ -26,17 +26,17 @@ _zimage_start_opd:\n> \n> #ifdef __powerpc64__\n> .balign 8\n> -p_start:\t.llong\t_start\n> -p_etext:\t.llong\t_etext\n> -p_bss_start:\t.llong\t__bss_start\n> -p_end:\t\t.llong\t_end\n> -\n> -p_toc:\t\t.llong\t__toc_start + 0x8000 - p_base\n> -p_dyn:\t\t.llong\t__dynamic_start - p_base\n> -p_rela:\t\t.llong\t__rela_dyn_start - p_base\n> -p_prom:\t\t.llong\t0\n> +p_start:\t.8byte\t_start\n> +p_etext:\t.8byte\t_etext\n> +p_bss_start:\t.8byte\t__bss_start\n> +p_end:\t\t.8byte\t_end\n> +\n> +p_toc:\t\t.8byte\t__toc_start + 0x8000 - p_base\n> +p_dyn:\t\t.8byte\t__dynamic_start - p_base\n> +p_rela:\t\t.8byte\t__rela_dyn_start - p_base\n> +p_prom:\t\t.8byte\t0\n> \t.weak\t_platform_stack_top\n> -p_pstack:\t.llong\t_platform_stack_top\n> +p_pstack:\t.8byte\t_platform_stack_top\n> #else\n> p_start:\t.long\t_start\n> p_etext:\t.long\t_etext\n> diff --git a/arch/powerpc/include/asm/asm-compat.h b/arch/powerpc/include/asm/asm-compat.h\n> index cee3aa0..7f2a770 100644\n> --- a/arch/powerpc/include/asm/asm-compat.h\n> +++ b/arch/powerpc/include/asm/asm-compat.h\n> @@ -25,7 +25,7 @@\n> #define PPC_LCMPI\tstringify_in_c(cmpdi)\n> #define PPC_LCMPLI\tstringify_in_c(cmpldi)\n> #define PPC_LCMP\tstringify_in_c(cmpd)\n> -#define PPC_LONG\tstringify_in_c(.llong)\n> +#define PPC_LONG\tstringify_in_c(.8byte)\n> #define PPC_LONG_ALIGN\tstringify_in_c(.balign 8)\n> #define PPC_TLNEI\tstringify_in_c(tdnei)\n> #define PPC_LLARX(t, a, b, eh)\tPPC_LDARX(t, a, b, eh)\n> diff --git a/arch/powerpc/include/asm/feature-fixups.h b/arch/powerpc/include/asm/feature-fixups.h\n> index ddf54f5..78d1f9e 100644\n> --- a/arch/powerpc/include/asm/feature-fixups.h\n> +++ b/arch/powerpc/include/asm/feature-fixups.h\n> @@ -19,11 +19,11 @@\n> */\n> #if defined(CONFIG_PPC64) && !defined(__powerpc64__)\n> /* 64 bits kernel, 32 bits code (ie. vdso32) */\n> -#define FTR_ENTRY_LONG\t\t.llong\n> +#define FTR_ENTRY_LONG\t\t.8byte\n> #define FTR_ENTRY_OFFSET\t.long 0xffffffff; .long\n> #elif defined(CONFIG_PPC64)\n> -#define FTR_ENTRY_LONG\t\t.llong\n> -#define FTR_ENTRY_OFFSET\t.llong\n> +#define FTR_ENTRY_LONG\t\t.8byte\n> +#define FTR_ENTRY_OFFSET\t.8byte\n> #else\n> #define FTR_ENTRY_LONG\t\t.long\n> #define FTR_ENTRY_OFFSET\t.long\n> diff --git a/arch/powerpc/include/asm/reg.h b/arch/powerpc/include/asm/reg.h\n> index fc879fd..465b577 100644\n> --- a/arch/powerpc/include/asm/reg.h\n> +++ b/arch/powerpc/include/asm/reg.h\n> @@ -1290,12 +1290,12 @@ static inline void msr_check_and_clear(unsigned long bits)\n> \t\t\t\t\".section __ftr_fixup,\\\"a\\\"\\n\"\t\t\\\n> \t\t\t\t\".align 3\\n\"\t\t\t\t\\\n> \t\t\t\t\"98:\\n\"\t\t\t\t\t\\\n> -\t\t\t\t\"\t.llong %1\\n\"\t\t\t\\\n> -\t\t\t\t\"\t.llong %1\\n\"\t\t\t\\\n> -\t\t\t\t\"\t.llong 97b-98b\\n\"\t\t\\\n> -\t\t\t\t\"\t.llong 99b-98b\\n\"\t\t\\\n> -\t\t\t\t\"\t.llong 0\\n\"\t\t\t\\\n> -\t\t\t\t\"\t.llong 0\\n\"\t\t\t\\\n> +\t\t\t\t\"\t.8byte %1\\n\"\t\t\t\\\n> +\t\t\t\t\"\t.8byte %1\\n\"\t\t\t\\\n> +\t\t\t\t\"\t.8byte 97b-98b\\n\"\t\t\\\n> +\t\t\t\t\"\t.8byte 99b-98b\\n\"\t\t\\\n> +\t\t\t\t\"\t.8byte 0\\n\"\t\t\t\\\n> +\t\t\t\t\"\t.8byte 0\\n\"\t\t\t\\\n> \t\t\t\t\".previous\"\t\t\t\t\\\n> \t\t\t: \"=r\" (rval) \\\n> \t\t\t: \"i\" (CPU_FTR_CELL_TB_BUG), \"i\" (SPRN_TBRL)); \\\n> diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S\n> index 6432d4b..0dca640 100644\n> --- a/arch/powerpc/kernel/entry_64.S\n> +++ b/arch/powerpc/kernel/entry_64.S\n> @@ -1078,7 +1078,7 @@ rtas_return_loc:\n> \tb\t.\t/* prevent speculative execution */\n> \n> \t.align\t3\n> -1:\t.llong\trtas_restore_regs\n> +1:\t.8byte\trtas_restore_regs\n> \n> rtas_restore_regs:\n> \t/* relocation is on at this point */\n> diff --git a/arch/powerpc/kernel/head_64.S b/arch/powerpc/kernel/head_64.S\n> index 1dc5eae..31b3ebc 100644\n> --- a/arch/powerpc/kernel/head_64.S\n> +++ b/arch/powerpc/kernel/head_64.S\n> @@ -92,13 +92,13 @@ END_FTR_SECTION(0, 1)\n> \t.balign 8\n> \t.globl __secondary_hold_spinloop\n> __secondary_hold_spinloop:\n> -\t.llong\t0x0\n> +\t.8byte\t0x0\n> \n> \t/* Secondary processors write this value with their cpu # */\n> \t/* after they enter the spin loop immediately below.\t */\n> \t.globl\t__secondary_hold_acknowledge\n> __secondary_hold_acknowledge:\n> -\t.llong\t0x0\n> +\t.8byte\t0x0\n> \n> #ifdef CONFIG_RELOCATABLE\n> \t/* This flag is set to 1 by a loader if the kernel should run\n> @@ -650,7 +650,7 @@ __after_prom_start:\n> \tbctr\n> \n> .balign 8\n> -p_end: .llong _end - copy_to_here\n> +p_end: .8byte _end - copy_to_here\n> \n> 4:\n> \t/*\n> @@ -892,7 +892,7 @@ _GLOBAL(relative_toc)\n> \tblr\n> \n> .balign 8\n> -p_toc:\t.llong\t__toc_start + 0x8000 - 0b\n> +p_toc:\t.8byte\t__toc_start + 0x8000 - 0b\n> \n> /*\n> * This is where the main kernel code starts.\n> diff --git a/arch/powerpc/kernel/reloc_64.S b/arch/powerpc/kernel/reloc_64.S\n> index d88736f..e8cfc69 100644\n> --- a/arch/powerpc/kernel/reloc_64.S\n> +++ b/arch/powerpc/kernel/reloc_64.S\n> @@ -82,7 +82,7 @@ _GLOBAL(relocate)\n> 6:\tblr\n> \n> .balign 8\n> -p_dyn:\t.llong\t__dynamic_start - 0b\n> -p_rela:\t.llong\t__rela_dyn_start - 0b\n> -p_st:\t.llong\t_stext - 0b\n> +p_dyn:\t.8byte\t__dynamic_start - 0b\n> +p_rela:\t.8byte\t__rela_dyn_start - 0b\n> +p_st:\t.8byte\t_stext - 0b\n> \n> diff --git a/arch/powerpc/kernel/systbl.S b/arch/powerpc/kernel/systbl.S\n> index 4d6b1d3..7ccb7f8 100644\n> --- a/arch/powerpc/kernel/systbl.S\n> +++ b/arch/powerpc/kernel/systbl.S\n> @@ -17,13 +17,13 @@\n> #include \n> \n> #ifdef CONFIG_PPC64\n> -#define SYSCALL(func)\t\t.llong\tDOTSYM(sys_##func),DOTSYM(sys_##func)\n> -#define COMPAT_SYS(func)\t.llong\tDOTSYM(sys_##func),DOTSYM(compat_sys_##func)\n> -#define PPC_SYS(func)\t\t.llong\tDOTSYM(ppc_##func),DOTSYM(ppc_##func)\n> -#define OLDSYS(func)\t\t.llong\tDOTSYM(sys_ni_syscall),DOTSYM(sys_ni_syscall)\n> -#define SYS32ONLY(func)\t\t.llong\tDOTSYM(sys_ni_syscall),DOTSYM(compat_sys_##func)\n> -#define PPC64ONLY(func)\t\t.llong\tDOTSYM(ppc_##func),DOTSYM(sys_ni_syscall)\n> -#define SYSX(f, f3264, f32)\t.llong\tDOTSYM(f),DOTSYM(f3264)\n> +#define SYSCALL(func)\t\t.8byte\tDOTSYM(sys_##func),DOTSYM(sys_##func)\n> +#define COMPAT_SYS(func)\t.8byte\tDOTSYM(sys_##func),DOTSYM(compat_sys_##func)\n> +#define PPC_SYS(func)\t\t.8byte\tDOTSYM(ppc_##func),DOTSYM(ppc_##func)\n> +#define OLDSYS(func)\t\t.8byte\tDOTSYM(sys_ni_syscall),DOTSYM(sys_ni_syscall)\n> +#define SYS32ONLY(func)\t\t.8byte\tDOTSYM(sys_ni_syscall),DOTSYM(compat_sys_##func)\n> +#define PPC64ONLY(func)\t\t.8byte\tDOTSYM(ppc_##func),DOTSYM(sys_ni_syscall)\n> +#define SYSX(f, f3264, f32)\t.8byte\tDOTSYM(f),DOTSYM(f3264)\n> #else\n> #define SYSCALL(func)\t\t.long\tsys_##func\n> #define COMPAT_SYS(func)\t.long\tsys_##func\n> diff --git a/arch/powerpc/platforms/powernv/opal-wrappers.S b/arch/powerpc/platforms/powernv/opal-wrappers.S\n> index da8a0f7..c007647 100644\n> --- a/arch/powerpc/platforms/powernv/opal-wrappers.S\n> +++ b/arch/powerpc/platforms/powernv/opal-wrappers.S\n> @@ -27,7 +27,7 @@\n> \n> \t.globl opal_tracepoint_refcount\n> opal_tracepoint_refcount:\n> -\t.llong\t0\n> +\t.8byte\t0\n> \n> \t.section\t\".text\"\n> \n> diff --git a/arch/powerpc/platforms/pseries/hvCall.S b/arch/powerpc/platforms/pseries/hvCall.S\n> index 74b5b8e..c511a17 100644\n> --- a/arch/powerpc/platforms/pseries/hvCall.S\n> +++ b/arch/powerpc/platforms/pseries/hvCall.S\n> @@ -23,7 +23,7 @@\n> \n> \t.globl hcall_tracepoint_refcount\n> hcall_tracepoint_refcount:\n> -\t.llong\t0\n> +\t.8byte\t0\n> \n> \t.section\t\".text\"\n> #endif\n> diff --git a/arch/powerpc/purgatory/trampoline.S b/arch/powerpc/purgatory/trampoline.S\n> index f9760cc..c8fcefd 100644\n> --- a/arch/powerpc/purgatory/trampoline.S\n> +++ b/arch/powerpc/purgatory/trampoline.S\n> @@ -104,13 +104,13 @@ master:\n> \t.balign 8\n> \t.globl kernel\n> kernel:\n> -\t.llong 0x0\n> +\t.8byte 0x0\n> \t.size kernel, . - kernel\n> \n> \t.balign 8\n> \t.globl dt_offset\n> dt_offset:\n> -\t.llong 0x0\n> +\t.8byte 0x0\n> \t.size dt_offset, . - dt_offset\n> \n> \n> -- \n> 2.7.4","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vfSMc234rz9s1y\n\tfor ;\n\tFri, 10 Mar 2017 11:10:36 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3vfSMc11YWzDqXn\n\tfor ;\n\tFri, 10 Mar 2017 11:10:36 +1100 (AEDT)","from mail-pf0-x241.google.com (mail-pf0-x241.google.com\n\t[IPv6:2607:f8b0:400e:c00::241])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3vfSL22VM9zDqC0\n\tfor ;\n\tFri, 10 Mar 2017 11:09:14 +1100 (AEDT)","by mail-pf0-x241.google.com with SMTP id 67so8820215pfg.2\n\tfor ;\n\tThu, 09 Mar 2017 16:09:13 -0800 (PST)","from localhost ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id\n\tr4sm14628039pgr.53.2017.03.09.16.09.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 09 Mar 2017 16:09:11 -0800 (PST)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"UMnskAjt\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"UMnskAjt\"; dkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"UMnskAjt\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google;\n\th=from:to:cc:subject:in-reply-to:references:user-agent:date\n\t:message-id:mime-version;\n\tbh=obuohi1GLaD13MglmbGvA+rBfwSYTWwCbJMDxZmbbpg=;\n\tb=UMnskAjtKP9eCP+mkuah4/4iLqQi4gvRb53Dgr+/CZGze1bXpoDeLfjmXtBOAehTWi\n\tB6QgTrTyYonAkdBETjsz0sOzgEJIzOwpM8Orf/IQb/AJFMcjon+GvZpTXW9DYRQ8kLRZ\n\tLB9PXmZu+iA2RRmjsbcDnPv90ATvDzEa6bM0s=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:in-reply-to:references\n\t:user-agent:date:message-id:mime-version;\n\tbh=obuohi1GLaD13MglmbGvA+rBfwSYTWwCbJMDxZmbbpg=;\n\tb=LPqRfQBhFPyUbSzAxDdvQ/+6SlJvGYwTFXf+sO8EzbHnKxPfxZpsDQ/zEifxCetGBe\n\txPvjv1Bm87+UaaAdnPkmEfU2dXk+1DlV4OtsoHjIfuoDqmbYLu6DsqrWtDKyqEIwUOlI\n\tPXS4G0kuMgeEQzT+XDoh62ckrcfjZj7ciZ7kHVE4E89oX07yxFyeiLLAE/uM73a2HPRu\n\tYjW+1CVUqPZ43u+xE0fNua3uq+7Segg735aF2AehKeicx/DA0wfWyFBYf53hyliVyaC5\n\t+GoN1V8uQ83UNwr65Gi97m1fx1/6ik9kg0P/PQcQMsXxhtzZqxc725b/l8pwBxZBxAGA\n\txzJA==","X-Gm-Message-State":"AMke39mW8fEAzFtuVbEwH2ApL7Tbs6joyodzb4IHIAcanlI9gEkGxYQXNn2u+YppHe+5mA==","X-Received":"by 10.99.109.14 with SMTP id i14mr17040921pgc.102.1489104552169; \n\tThu, 09 Mar 2017 16:09:12 -0800 (PST)","From":"Daniel Axtens ","To":"\"Tobin C. Harding\" , linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH] powerpc: asm: convert directive .llong to .8byte","In-Reply-To":"<1489038132-3523-1-git-send-email-me@tobin.cc>","References":"<1489038132-3523-1-git-send-email-me@tobin.cc>","User-Agent":"Notmuch/0.22.1 (http://notmuchmail.org) Emacs/24.5.1\n\t(x86_64-pc-linux-gnu)","Date":"Fri, 10 Mar 2017 11:09:08 +1100","Message-ID":"<87o9xa3sd7.fsf@possimpible.ozlabs.ibm.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"Tobin C. Harding\" , Paul Mackerras ,\n\tlinux-kernel@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1603852,"web_url":"http://patchwork.ozlabs.org/comment/1603852/","msgid":"<87d1dplgtx.fsf@concordia.ellerman.id.au>","date":"2017-03-10T07:40:58","subject":"Re: [PATCH] powerpc: asm: convert directive .llong to .8byte","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"Daniel Axtens writes:\n\n> Hi Tobin,\n>\n>> .llong is an undocumented PPC specific directive. The generic\n>> equivalent is .quad, but even better (because it's self describing) is\n>> .8byte.\n>>\n>> Convert directives .llong -> .8byte\n>>\n>> Signed-off-by: Tobin C. Harding \n>> ---\n>>\n>> Fixes: issue #33 (github)\n>\n> Thanks for tackling these!\n>\n> I have applied your patch to my local tree. I ran `git grep '\\.llong'`,\n> and found:\n>\n> tools/testing/selftests/powerpc/switch_endian/switch_endian_test.S: .llong 0x5555AAAA5555AAAA\n>\n> That file is also handled by mpe and the powerpc tree even though it\n> doesn't live in arch/powerpc - could you please change that one as well?\n\nI can do that one when I apply it.\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vffNM37DJz9s7y\n\tfor ;\n\tFri, 10 Mar 2017 18:41:55 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3vffNM2M6VzDqZ0\n\tfor ;\n\tFri, 10 Mar 2017 18:41:55 +1100 (AEDT)","from ozlabs.org (ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3vffMJ0115zDqXh\n\tfor ;\n\tFri, 10 Mar 2017 18:40:59 +1100 (AEDT)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3vffMH4rzdz9s7y;\n\tFri, 10 Mar 2017 18:40:59 +1100 (AEDT)"],"From":"Michael Ellerman ","To":"Daniel Axtens , \"Tobin C. Harding\" ,\n\tlinuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH] powerpc: asm: convert directive .llong to .8byte","In-Reply-To":"<87o9xa3sd7.fsf@possimpible.ozlabs.ibm.com>","References":"<1489038132-3523-1-git-send-email-me@tobin.cc>\n\t<87o9xa3sd7.fsf@possimpible.ozlabs.ibm.com>","User-Agent":"Notmuch/0.21 (https://notmuchmail.org)","Date":"Fri, 10 Mar 2017 18:40:58 +1100","Message-ID":"<87d1dplgtx.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paul Mackerras , linux-kernel@vger.kernel.org,\n\t\"Tobin C. Harding\" ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1603885,"web_url":"http://patchwork.ozlabs.org/comment/1603885/","msgid":"<20170310081929.GA23154@eros>","date":"2017-03-10T08:19:29","subject":"Re: [PATCH] powerpc: asm: convert directive .llong to .8byte","submitter":{"id":68963,"url":"http://patchwork.ozlabs.org/api/people/68963/","name":"Tobin C. Harding","email":"me@tobin.cc"},"content":"On Fri, Mar 10, 2017 at 11:09:08AM +1100, Daniel Axtens wrote:\n> Hi Tobin,\n> \n> > .llong is an undocumented PPC specific directive. The generic\n> > equivalent is .quad, but even better (because it's self describing) is\n> > .8byte.\n> >\n> > Convert directives .llong -> .8byte\n> >\n> > Signed-off-by: Tobin C. Harding \n> > ---\n> >\n> > Fixes: issue #33 (github)\n> \n> Thanks for tackling these!\n> \n> I have applied your patch to my local tree. I ran `git grep '\\.llong'`,\n> and found:\n> \n> tools/testing/selftests/powerpc/switch_endian/switch_endian_test.S: .llong 0x5555AAAA5555AAAA\n> \n> That file is also handled by mpe and the powerpc tree even though it\n> doesn't live in arch/powerpc - could you please change that one as well?\n\nAwesome, thanks Daniel. I did not know to look there. Will re submit.\n\nthanks,\nTobin.","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vfgFP5Dnzz9s80\n\tfor ;\n\tFri, 10 Mar 2017 19:20:57 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3vfgFP46yrzDqY0\n\tfor ;\n\tFri, 10 Mar 2017 19:20:57 +1100 (AEDT)","from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n\t[66.111.4.25])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3vfgCr3ySHzDqXh\n\tfor ;\n\tFri, 10 Mar 2017 19:19:36 +1100 (AEDT)","from compute5.internal (compute5.nyi.internal [10.202.2.45])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 07F6520D70;\n\tFri, 10 Mar 2017 03:19:34 -0500 (EST)","from frontend2 ([10.202.2.161])\n\tby compute5.internal (MEProxy); Fri, 10 Mar 2017 03:19:34 -0500","from localhost (202-159-157-99.dyn.iinet.net.au [202.159.157.99])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 2F78D241ED;\n\tFri, 10 Mar 2017 03:19:32 -0500 (EST)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=tobin.cc header.i=@tobin.cc header.b=\"GU26T7D9\";\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"PoLbzrdQ\"; \n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=tobin.cc header.i=@tobin.cc header.b=\"GU26T7D9\";\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"PoLbzrdQ\"; \n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=tobin.cc header.i=@tobin.cc header.b=\"GU26T7D9\";\n\tdkim=pass (1024-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"PoLbzrdQ\"; dkim-atps=neutral"],"DKIM-Signature":["v=1; a=rsa-sha1; c=relaxed/relaxed; d=tobin.cc; h=cc\n\t:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc\n\t:x-sasl-enc; s=mesmtp; bh=HVLKlWdTMp+vu3Ezn+FrPSZGJTE=; b=GU26T7\n\tD9KvTjhHaEDBbmZpSIR7br1/KQfY4QbjNLHOf7Zz/DzhqrUCYB6eFVwsBShqgym8\n\theWEZtoACWpU6brWWJ+X6GJ2T2NCC5eAZ0NlceXRtEj7IbtcBtD9Q1ddxNgUYA0Q\n\tzBYKbhK0FVcQzoH8c4zwGg54TROOM7KFgUSlA=","v=1; a=rsa-sha1; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=HVLKlWdTMp+vu3\n\tEzn+FrPSZGJTE=; b=PoLbzrdQ7KqLpyv3xuaJOpsv5YPVso9izT0rkTfQ0YlC3F\n\tV38W5m8V5JY86RsuvWFmIn+1ol4JOaNI4ha87v2rDDbXx0u25qEAskpcfoiyArhC\n\tHFRR6QD1SNHMc3K3VhoHAm6h/LMPjED0Ffrwk6WqPmmZh2ey538EdONJUN2cE="],"X-ME-Sender":"","X-Sasl-enc":"SWwYdHgfSKiW7mWuzJQFiQxdrHLEjMwEWFDvYYmYyUlj 1489133973","Date":"Fri, 10 Mar 2017 19:19:29 +1100","From":"\"Tobin C. Harding\" ","To":"Daniel Axtens ","Subject":"Re: [PATCH] powerpc: asm: convert directive .llong to .8byte","Message-ID":"<20170310081929.GA23154@eros>","References":"<1489038132-3523-1-git-send-email-me@tobin.cc>\n\t<87o9xa3sd7.fsf@possimpible.ozlabs.ibm.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<87o9xa3sd7.fsf@possimpible.ozlabs.ibm.com>","X-Mailer":"Mutt 1.5.24 (2015-08-30)","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,\n\tPaul Mackerras ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1603886,"web_url":"http://patchwork.ozlabs.org/comment/1603886/","msgid":"<20170310082057.GB23154@eros>","date":"2017-03-10T08:20:57","subject":"Re: [PATCH] powerpc: asm: convert directive .llong to .8byte","submitter":{"id":68963,"url":"http://patchwork.ozlabs.org/api/people/68963/","name":"Tobin C. Harding","email":"me@tobin.cc"},"content":"On Fri, Mar 10, 2017 at 06:40:58PM +1100, Michael Ellerman wrote:\n> Daniel Axtens writes:\n> \n> > Hi Tobin,\n> >\n> >> .llong is an undocumented PPC specific directive. The generic\n> >> equivalent is .quad, but even better (because it's self describing) is\n> >> .8byte.\n> >>\n> >> Convert directives .llong -> .8byte\n> >>\n> >> Signed-off-by: Tobin C. Harding \n> >> ---\n> >>\n> >> Fixes: issue #33 (github)\n> >\n> > Thanks for tackling these!\n> >\n> > I have applied your patch to my local tree. I ran `git grep '\\.llong'`,\n> > and found:\n> >\n> > tools/testing/selftests/powerpc/switch_endian/switch_endian_test.S: .llong 0x5555AAAA5555AAAA\n> >\n> > That file is also handled by mpe and the powerpc tree even though it\n> > doesn't live in arch/powerpc - could you please change that one as well?\n> \n> I can do that one when I apply it.\n\nExcellent.\n\nthanks,\nTobin.","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vfgHF3prYz9s7x\n\tfor ;\n\tFri, 10 Mar 2017 19:22:33 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3vfgHF2lsCzDqYx\n\tfor ;\n\tFri, 10 Mar 2017 19:22:33 +1100 (AEDT)","from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n\t[66.111.4.25])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3vfgFW4KC6zDqZP\n\tfor ;\n\tFri, 10 Mar 2017 19:21:03 +1100 (AEDT)","from compute5.internal (compute5.nyi.internal [10.202.2.45])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 421DE20DC2;\n\tFri, 10 Mar 2017 03:21:01 -0500 (EST)","from frontend2 ([10.202.2.161])\n\tby compute5.internal (MEProxy); Fri, 10 Mar 2017 03:21:01 -0500","from localhost (202-159-157-99.dyn.iinet.net.au [202.159.157.99])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 603AB241ED;\n\tFri, 10 Mar 2017 03:21:00 -0500 (EST)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=tobin.cc header.i=@tobin.cc header.b=\"Jro6f+s7\";\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"FBXPppOs\"; \n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=tobin.cc header.i=@tobin.cc header.b=\"Jro6f+s7\";\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"FBXPppOs\"; \n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=tobin.cc header.i=@tobin.cc header.b=\"Jro6f+s7\";\n\tdkim=pass (1024-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com\n\theader.b=\"FBXPppOs\"; dkim-atps=neutral"],"DKIM-Signature":["v=1; a=rsa-sha1; c=relaxed/relaxed; d=tobin.cc; h=cc\n\t:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc\n\t:x-sasl-enc; s=mesmtp; bh=fRYJFYuaH9TvITk2NvBuaWmmnFY=; b=Jro6f+\n\ts7EGlJu/RcVwYAlsnlyYSw/aBgltuT0dJH+Af83ICUHqTosIO7CPlPOwtcHe8XGj\n\tAZELhpMvK4kBaK6yz2gV+nqq6WEXMW0bE3e9xI6XHaFYJHkE+bXUsmlbj/MfVlx6\n\tsU7oUhFtrLiYVAIhaviN8Fqr/lJddqvPAT8KY=","v=1; a=rsa-sha1; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=fRYJFYuaH9TvIT\n\tk2NvBuaWmmnFY=; b=FBXPppOs9G+KBDk8hNB2aHoWB2GBgsPsToswgtsrFPo2Il\n\t1krK/gF6aH7sQYzn3BG7s2rHknw9v82KRwJA9c6vIC4FBGIY5puSvwcLHlC9vpJH\n\tMTUfneKlPIfyrZ08crnTqBfZ+PTnRogYY9brELQw3RnTqvnzBJlSiQohjxn3o="],"X-ME-Sender":"","X-Sasl-enc":"Wetmqx4WlX7fKWM45RVoA1I8qS4pXUTujcVJORII3vLn 1489134060","Date":"Fri, 10 Mar 2017 19:20:57 +1100","From":"\"Tobin C. Harding\" ","To":"Michael Ellerman ","Subject":"Re: [PATCH] powerpc: asm: convert directive .llong to .8byte","Message-ID":"<20170310082057.GB23154@eros>","References":"<1489038132-3523-1-git-send-email-me@tobin.cc>\n\t<87o9xa3sd7.fsf@possimpible.ozlabs.ibm.com>\n\t<87d1dplgtx.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<87d1dplgtx.fsf@concordia.ellerman.id.au>","X-Mailer":"Mutt 1.5.24 (2015-08-30)","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,\n\tPaul Mackerras , Daniel Axtens ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1760859,"web_url":"http://patchwork.ozlabs.org/comment/1760859/","msgid":"<3xjgKy5bPMz9t2M@ozlabs.org>","date":"2017-08-31T11:35:50","subject":"Re: powerpc: asm: convert directive .llong to .8byte","submitter":{"id":69509,"url":"http://patchwork.ozlabs.org/api/people/69509/","name":"Michael Ellerman","email":"patch-notifications@ellerman.id.au"},"content":"On Thu, 2017-03-09 at 05:42:12 UTC, \"Tobin C. Harding\" wrote:\n> .llong is an undocumented PPC specific directive. The generic\n> equivalent is .quad, but even better (because it's self describing) is\n> .8byte.\n> \n> Convert directives .llong -> .8byte\n> \n> Signed-off-by: Tobin C. Harding \n\nApplied to powerpc next, thanks.\n\nhttps://git.kernel.org/powerpc/c/eb039161da2ff388cc30d076badd8e\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xjgRg6szdz9sQl\n\tfor ;\n\tThu, 31 Aug 2017 21:40:47 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xjgRg5zxczDqGZ\n\tfor ;\n\tThu, 31 Aug 2017 21:40:47 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xjgKz05VlzDqGZ\n\tfor ;\n\tThu, 31 Aug 2017 21:35:51 +1000 (AEST)","by ozlabs.org (Postfix, from userid 1034)\n\tid 3xjgKy5bPMz9t2M; Thu, 31 Aug 2017 21:35:50 +1000 (AEST)"],"X-powerpc-patch-notification":"thanks","X-powerpc-patch-commit":"eb039161da2ff388cc30d076badd8e06fb015f33","In-Reply-To":"<1489038132-3523-1-git-send-email-me@tobin.cc>","To":"\"Tobin C. Harding\" , linuxppc-dev@lists.ozlabs.org","From":"Michael Ellerman ","Subject":"Re: powerpc: asm: convert directive .llong to .8byte","Message-Id":"<3xjgKy5bPMz9t2M@ozlabs.org>","Date":"Thu, 31 Aug 2017 21:35:50 +1000 (AEST)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paul Mackerras , linux-kernel@vger.kernel.org,\n\t\"Tobin C. Harding\" ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]