[{"id":1597494,"web_url":"http://patchwork.ozlabs.org/comment/1597494/","msgid":"<87varsj6qc.fsf@concordia.ellerman.id.au>","date":"2017-03-02T10:47:07","subject":"Re: [PATCH] module: set __jump_table alignment to 8","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"David Daney writes:\n\n> For powerpc the __jump_table section in modules is not aligned, this\n> causes a WARN_ON() splat when loading a module containing a __jump_table.\n\nThanks for doing the patch.\n\nIf it helps:\n\nAcked-by: Michael Ellerman (powerpc)\n\n> Strict alignment became necessary with commit 3821fd35b58d\n> (\"jump_label: Reduce the size of struct static_key\"), currently in\n> linux-next, which uses the two least significant bits of pointers to\n> __jump_table elements.\n\nIt would obviously be nice if this could go in before the commit that\nexposes the breakage, but I guess that's problematic because Steve\ndoesn't want to rebase the tracing tree.\n\nSteve I think you've already sent your pull request for this cycle? So I\nguess if this can go in your first batch of fixes?\n\nOr we could just send it directly to Linus?\n\ncheers\n\n> Fix by forcing __jump_table to 8, which is the same alignment used for\n> this section in the kernel proper.\n>\n> Signed-off-by: David Daney \n> Tested-by: Sachin Sant \n> ---\n> scripts/module-common.lds | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/scripts/module-common.lds b/scripts/module-common.lds\n> index 73a2c7d..53234e8 100644\n> --- a/scripts/module-common.lds\n> +++ b/scripts/module-common.lds\n> @@ -19,4 +19,6 @@ SECTIONS {\n> \n> \t. = ALIGN(8);\n> \t.init_array\t\t0 : { *(SORT(.init_array.*)) *(.init_array) }\n> +\n> +\t__jump_table\t\t0 : ALIGN(8) { KEEP(*(__jump_table)) }\n> }\n> -- \n> 2.9.3","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vYptt375wz9s7n\n\tfor ;\n\tThu, 2 Mar 2017 21:48:06 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3vYptt2MnZzDqKq\n\tfor ;\n\tThu, 2 Mar 2017 21:48:06 +1100 (AEDT)","from ozlabs.org (ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3vYpsm2WjnzDq66\n\tfor ;\n\tThu, 2 Mar 2017 21:47:08 +1100 (AEDT)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3vYpsm00CJz9s7Z;\n\tThu, 2 Mar 2017 21:47:07 +1100 (AEDT)"],"From":"Michael Ellerman ","To":"David Daney , Jason Baron ,\n\tSteven Rostedt ,\n\tSachin Sant , linux-kernel@vger.kernel.org","Subject":"Re: [PATCH] module: set __jump_table alignment to 8","In-Reply-To":"<20170301220453.4756-1-david.daney@cavium.com>","References":"<20170301220453.4756-1-david.daney@cavium.com>","User-Agent":"Notmuch/0.21 (https://notmuchmail.org)","Date":"Thu, 02 Mar 2017 21:47:07 +1100","Message-ID":"<87varsj6qc.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-mips@linux-mips.org, Chris Metcalf ,\n\tDavid Daney ,\n\tRussell King , \n\tRalf Baechle , Rabin Vincent ,\n\tPaul Mackerras , Anton Blanchard , \n\tlinuxppc-dev@lists.ozlabs.org, Ingo Molnar ,\n\tlinux-arm-kernel@lists.infradead.org, Zhigang Lu ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1597536,"web_url":"http://patchwork.ozlabs.org/comment/1597536/","msgid":"<8737ewexkp.fsf@concordia.ellerman.id.au>","date":"2017-03-02T11:18:30","subject":"Re: [PATCH] module: set __jump_table alignment to 8","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"Michael Ellerman writes:\n> David Daney writes:\n>> Strict alignment became necessary with commit 3821fd35b58d\n>> (\"jump_label: Reduce the size of struct static_key\"), currently in\n>> linux-next, which uses the two least significant bits of pointers to\n>> __jump_table elements.\n>\n> It would obviously be nice if this could go in before the commit that\n> exposes the breakage, but I guess that's problematic because Steve\n> doesn't want to rebase the tracing tree.\n>\n> Steve I think you've already sent your pull request for this cycle? So I\n> guess if this can go in your first batch of fixes?\n\nUgh. Was looking at the wrong tree - Linus has already merged the commit\nin question, so the above is all moot.\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vYqb45pG3z9s7n\n\tfor ;\n\tThu, 2 Mar 2017 22:19:28 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3vYqb44sc2zDqHq\n\tfor ;\n\tThu, 2 Mar 2017 22:19:28 +1100 (AEDT)","from ozlabs.org (ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3vYqZ00Bz9zDq66\n\tfor ;\n\tThu, 2 Mar 2017 22:18:32 +1100 (AEDT)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3vYqYz54HVz9s7j;\n\tThu, 2 Mar 2017 22:18:31 +1100 (AEDT)"],"From":"Michael Ellerman ","To":"David Daney , Jason Baron ,\n\tSteven Rostedt ,\n\tSachin Sant , linux-kernel@vger.kernel.org","Subject":"Re: [PATCH] module: set __jump_table alignment to 8","In-Reply-To":"<87varsj6qc.fsf@concordia.ellerman.id.au>","References":"<20170301220453.4756-1-david.daney@cavium.com>\n\t<87varsj6qc.fsf@concordia.ellerman.id.au>","User-Agent":"Notmuch/0.21 (https://notmuchmail.org)","Date":"Thu, 02 Mar 2017 22:18:30 +1100","Message-ID":"<8737ewexkp.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-mips@linux-mips.org, Chris Metcalf ,\n\tDavid Daney ,\n\tRussell King , \n\tRalf Baechle , Rabin Vincent ,\n\tPaul Mackerras , Anton Blanchard , \n\tlinuxppc-dev@lists.ozlabs.org, Ingo Molnar ,\n\tlinux-arm-kernel@lists.infradead.org, Zhigang Lu ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1597694,"web_url":"http://patchwork.ozlabs.org/comment/1597694/","msgid":"<7bc6b5af-85e0-5b06-f979-368b8b840a16@akamai.com>","date":"2017-03-02T15:30:50","subject":"Re: [PATCH] module: set __jump_table alignment to 8","submitter":{"id":28024,"url":"http://patchwork.ozlabs.org/api/people/28024/","name":"Jason Baron","email":"jbaron@akamai.com"},"content":"On 03/01/2017 05:04 PM, David Daney wrote:\n> For powerpc the __jump_table section in modules is not aligned, this\n> causes a WARN_ON() splat when loading a module containing a __jump_table.\n>\n> Strict alignment became necessary with commit 3821fd35b58d\n> (\"jump_label: Reduce the size of struct static_key\"), currently in\n> linux-next, which uses the two least significant bits of pointers to\n> __jump_table elements.\n>\n> Fix by forcing __jump_table to 8, which is the same alignment used for\n> this section in the kernel proper.\n>\n> Signed-off-by: David Daney \n> Tested-by: Sachin Sant \n> ---\n\nLooks good to me.\n\nReviewed-by: Jason Baron \n\nThanks,\n\n-Jason","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vYxBq5GCSz9s7m\n\tfor ;\n\tFri, 3 Mar 2017 02:32:19 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3vYxBq3vJ4zDqGh\n\tfor ;\n\tFri, 3 Mar 2017 02:32:19 +1100 (AEDT)","from prod-mail-xrelay07.akamai.com (prod-mail-xrelay07.akamai.com\n\t[23.79.238.175])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3vYx99677mzDq66\n\tfor ;\n\tFri, 3 Mar 2017 02:30:52 +1100 (AEDT)","from prod-mail-xrelay07.akamai.com (localhost.localdomain\n\t[127.0.0.1]) by postfix.imss70 (Postfix) with ESMTP id 0FCDC433419;\n\tThu, 2 Mar 2017 15:30:51 +0000 (GMT)","from prod-mail-relay10.akamai.com (prod-mail-relay10.akamai.com\n\t[172.27.118.251])\n\tby prod-mail-xrelay07.akamai.com (Postfix) with ESMTP id EB1D3433407; \n\tThu, 2 Mar 2017 15:30:50 +0000 (GMT)","from [172.28.13.148] (bos-lpjec.kendall.corp.akamai.com\n\t[172.28.13.148])\n\tby prod-mail-relay10.akamai.com (Postfix) with ESMTP id C08BF1FC86;\n\tThu, 2 Mar 2017 15:30:50 +0000 (GMT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tsecure) header.d=akamai.com header.i=@akamai.com header.b=\"OtL1Jmzp\";\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tsecure) header.d=akamai.com header.i=@akamai.com header.b=\"OtL1Jmzp\";\n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=akamai.com header.i=@akamai.com header.b=\"OtL1Jmzp\"; \n\tdkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=akamai.com; s=a1;\n\tt=1488468650; bh=SXSsAriYwKxbm7pdjEbv8+7sPijbUhjeRzhJD6AaqHQ=;\n\tl=751; h=To:References:Cc:From:Date:In-Reply-To:From;\n\tb=OtL1JmzpsheQS2FlXYAtkK3IiyX04N3/URVWETi/1h60A6aP341ZT4eABD29cJMyi\n\tstvltuSJfyBDDKmi+NMdfgY7f2FNvXnT4QCBtLFjZCT91511+8Or9yb2kuEllxLu9e\n\tUHlfyRPeQTsDeRHloqbKJCjSf2QEtv5Lp1DjDHt4=","Subject":"Re: [PATCH] module: set __jump_table alignment to 8","To":"David Daney , Steven Rostedt\n\t, Michael Ellerman ,\n\tSachin Sant , linux-kernel@vger.kernel.org","References":"<20170301220453.4756-1-david.daney@cavium.com>","From":"Jason Baron ","Message-ID":"<7bc6b5af-85e0-5b06-f979-368b8b840a16@akamai.com>","Date":"Thu, 2 Mar 2017 10:30:50 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.7.0","MIME-Version":"1.0","In-Reply-To":"<20170301220453.4756-1-david.daney@cavium.com>","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-mips@linux-mips.org, Chris Metcalf ,\n\tRussell King ,\n\tRalf Baechle , \n\tRabin Vincent , Paul Mackerras ,\n\tAnton Blanchard , linuxppc-dev@lists.ozlabs.org,\n\tIngo Molnar , linux-arm-kernel@lists.infradead.org, \n\tZhigang Lu ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1597843,"web_url":"http://patchwork.ozlabs.org/comment/1597843/","msgid":"<20170302124441.0e2634e0@gandalf.local.home>","date":"2017-03-02T17:44:41","subject":"Re: [PATCH] module: set __jump_table alignment to 8","submitter":{"id":112,"url":"http://patchwork.ozlabs.org/api/people/112/","name":"Steven Rostedt","email":"rostedt@goodmis.org"},"content":"On Thu, 02 Mar 2017 22:18:30 +1100\nMichael Ellerman wrote:\n\n> Michael Ellerman writes:\n> > David Daney writes: \n> >> Strict alignment became necessary with commit 3821fd35b58d\n> >> (\"jump_label: Reduce the size of struct static_key\"), currently in\n> >> linux-next, which uses the two least significant bits of pointers to\n> >> __jump_table elements. \n> >\n> > It would obviously be nice if this could go in before the commit that\n> > exposes the breakage, but I guess that's problematic because Steve\n> > doesn't want to rebase the tracing tree.\n> >\n> > Steve I think you've already sent your pull request for this cycle? So I\n> > guess if this can go in your first batch of fixes? \n> \n> Ugh. Was looking at the wrong tree - Linus has already merged the commit\n> in question, so the above is all moot.\n\nNo problem. I've got some other \"fixes\" to push to Linus. That's what\nthe -rc releases are for. To fix up breakage from the merge window ;-)\n\nI'll pull this into my tree.\n\nThanks!\n\n-- Steve","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vZ0933wdkz9s7k\n\tfor ;\n\tFri, 3 Mar 2017 04:45:59 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3vZ09339MPzDqRf\n\tfor ;\n\tFri, 3 Mar 2017 04:45:59 +1100 (AEDT)","from mail.kernel.org (mail.kernel.org [198.145.29.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3vZ07k1X9czDqC0\n\tfor ;\n\tFri, 3 Mar 2017 04:44:49 +1100 (AEDT)","from mail.kernel.org (localhost [127.0.0.1])\n\tby mail.kernel.org (Postfix) with ESMTP id 0A0B520383;\n\tThu, 2 Mar 2017 17:44:46 +0000 (UTC)","from gandalf.local.home (cpe-67-246-153-56.stny.res.rr.com\n\t[67.246.153.56])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 5BDD82037F;\n\tThu, 2 Mar 2017 17:44:43 +0000 (UTC)"],"Date":"Thu, 2 Mar 2017 12:44:41 -0500","From":"Steven Rostedt ","To":"Michael Ellerman ","Subject":"Re: [PATCH] module: set __jump_table alignment to 8","Message-ID":"<20170302124441.0e2634e0@gandalf.local.home>","In-Reply-To":"<8737ewexkp.fsf@concordia.ellerman.id.au>","References":"<20170301220453.4756-1-david.daney@cavium.com>\n\t<87varsj6qc.fsf@concordia.ellerman.id.au>\n\t<8737ewexkp.fsf@concordia.ellerman.id.au>","X-Mailer":"Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY\n\tautolearn=ham version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org","X-Virus-Scanned":"ClamAV using ClamSMTP","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Sachin Sant , linux-mips@linux-mips.org,\n\tChris Metcalf ,\n\tDavid Daney , \n\tlinux-kernel@vger.kernel.org, Ralf Baechle ,\n\tRussell King , Rabin Vincent ,\n\tJason Baron , Paul Mackerras ,\n\tAnton Blanchard , linuxppc-dev@lists.ozlabs.org,\n\tIngo Molnar , linux-arm-kernel@lists.infradead.org, \n\tZhigang Lu ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1597864,"web_url":"http://patchwork.ozlabs.org/comment/1597864/","msgid":"<20170302131119.6f52203f@gandalf.local.home>","date":"2017-03-02T18:11:19","subject":"Re: [PATCH] module: set __jump_table alignment to 8","submitter":{"id":112,"url":"http://patchwork.ozlabs.org/api/people/112/","name":"Steven Rostedt","email":"rostedt@goodmis.org"},"content":"Can I get an Ack from a module maintainer?\n\nThanks!\n\n-- Steve\n\n\nOn Wed, 1 Mar 2017 14:04:53 -0800\nDavid Daney wrote:\n\n> For powerpc the __jump_table section in modules is not aligned, this\n> causes a WARN_ON() splat when loading a module containing a __jump_table.\n> \n> Strict alignment became necessary with commit 3821fd35b58d\n> (\"jump_label: Reduce the size of struct static_key\"), currently in\n> linux-next, which uses the two least significant bits of pointers to\n> __jump_table elements.\n> \n> Fix by forcing __jump_table to 8, which is the same alignment used for\n> this section in the kernel proper.\n> \n> Signed-off-by: David Daney \n> Tested-by: Sachin Sant \n> ---\n> scripts/module-common.lds | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/scripts/module-common.lds b/scripts/module-common.lds\n> index 73a2c7d..53234e8 100644\n> --- a/scripts/module-common.lds\n> +++ b/scripts/module-common.lds\n> @@ -19,4 +19,6 @@ SECTIONS {\n> \n> \t. = ALIGN(8);\n> \t.init_array\t\t0 : { *(SORT(.init_array.*)) *(.init_array) }\n> +\n> +\t__jump_table\t\t0 : ALIGN(8) { KEEP(*(__jump_table)) }\n> }","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vZ0mN3X4Gz9s7c\n\tfor ;\n\tFri, 3 Mar 2017 05:13:08 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3vZ0mM4SfCzDqHl\n\tfor ;\n\tFri, 3 Mar 2017 05:13:07 +1100 (AEDT)","from mail.kernel.org (mail.kernel.org [198.145.29.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3vZ0kQ6WgHzDqGj\n\tfor ;\n\tFri, 3 Mar 2017 05:11:26 +1100 (AEDT)","from mail.kernel.org (localhost [127.0.0.1])\n\tby mail.kernel.org (Postfix) with ESMTP id 8224B20303;\n\tThu, 2 Mar 2017 18:11:23 +0000 (UTC)","from gandalf.local.home (cpe-67-246-153-56.stny.res.rr.com\n\t[67.246.153.56])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id DE5782035E;\n\tThu, 2 Mar 2017 18:11:20 +0000 (UTC)"],"Date":"Thu, 2 Mar 2017 13:11:19 -0500","From":"Steven Rostedt ","To":"Jessica Yu , Rusty Russell ","Subject":"Re: [PATCH] module: set __jump_table alignment to 8","Message-ID":"<20170302131119.6f52203f@gandalf.local.home>","In-Reply-To":"<20170301220453.4756-1-david.daney@cavium.com>","References":"<20170301220453.4756-1-david.daney@cavium.com>","X-Mailer":"Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY\n\tautolearn=ham version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org","X-Virus-Scanned":"ClamAV using ClamSMTP","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Sachin Sant , linux-mips@linux-mips.org,\n\tChris Metcalf ,\n\tDavid Daney , \n\tlinux-kernel@vger.kernel.org, Ralf Baechle ,\n\tRussell King , Rabin Vincent ,\n\tJason Baron , Paul Mackerras ,\n\tAnton Blanchard , linuxppc-dev@lists.ozlabs.org,\n\tIngo Molnar , linux-arm-kernel@lists.infradead.org, \n\tZhigang Lu ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1597873,"web_url":"http://patchwork.ozlabs.org/comment/1597873/","msgid":"<20170302182625.GB13268@packer-debian-8-amd64.digitalocean.com>","date":"2017-03-02T18:26:25","subject":"Re: [PATCH] module: set __jump_table alignment to 8","submitter":{"id":68191,"url":"http://patchwork.ozlabs.org/api/people/68191/","name":"Jessica Yu","email":"jeyu@redhat.com"},"content":"+++ Steven Rostedt [02/03/17 13:11 -0500]:\n>\n>Can I get an Ack from a module maintainer?\n\nAcked-by: Jessica Yu \n\nThanks!\n\nJessica\n\n>On Wed, 1 Mar 2017 14:04:53 -0800\n>David Daney wrote:\n>\n>> For powerpc the __jump_table section in modules is not aligned, this\n>> causes a WARN_ON() splat when loading a module containing a __jump_table.\n>>\n>> Strict alignment became necessary with commit 3821fd35b58d\n>> (\"jump_label: Reduce the size of struct static_key\"), currently in\n>> linux-next, which uses the two least significant bits of pointers to\n>> __jump_table elements.\n>>\n>> Fix by forcing __jump_table to 8, which is the same alignment used for\n>> this section in the kernel proper.\n>>\n>> Signed-off-by: David Daney \n>> Tested-by: Sachin Sant \n>> ---\n>> scripts/module-common.lds | 2 ++\n>> 1 file changed, 2 insertions(+)\n>>\n>> diff --git a/scripts/module-common.lds b/scripts/module-common.lds\n>> index 73a2c7d..53234e8 100644\n>> --- a/scripts/module-common.lds\n>> +++ b/scripts/module-common.lds\n>> @@ -19,4 +19,6 @@ SECTIONS {\n>>\n>> \t. = ALIGN(8);\n>> \t.init_array\t\t0 : { *(SORT(.init_array.*)) *(.init_array) }\n>> +\n>> +\t__jump_table\t\t0 : ALIGN(8) { KEEP(*(__jump_table)) }\n>> }\n>","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vZ14w2Ybfz9s7F\n\tfor ;\n\tFri, 3 Mar 2017 05:27:28 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3vZ14w1l4szDqM0\n\tfor ;\n\tFri, 3 Mar 2017 05:27:28 +1100 (AEDT)","from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3vZ13p1GpNzDqGr\n\tfor ;\n\tFri, 3 Mar 2017 05:26:30 +1100 (AEDT)","from int-mx10.intmail.prod.int.phx2.redhat.com\n\t(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 7F95980486;\n\tThu, 2 Mar 2017 18:26:28 +0000 (UTC)","from packer-debian-8-amd64.digitalocean.com\n\t(vpn-234-230.phx2.redhat.com [10.3.234.230])\n\tby int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tSMTP id v22IQQNa011150; Thu, 2 Mar 2017 13:26:26 -0500"],"Date":"Thu, 2 Mar 2017 13:26:25 -0500","From":"Jessica Yu ","To":"Steven Rostedt ","Subject":"Re: [PATCH] module: set __jump_table alignment to 8","Message-ID":"<20170302182625.GB13268@packer-debian-8-amd64.digitalocean.com>","References":"<20170301220453.4756-1-david.daney@cavium.com>\n\t<20170302131119.6f52203f@gandalf.local.home>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii; format=flowed","Content-Disposition":"inline","In-Reply-To":"<20170302131119.6f52203f@gandalf.local.home>","X-OS":"Linux eisen.io 3.16.0-4-amd64 x86_64","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Scanned-By":"MIMEDefang 2.68 on 10.5.11.23","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]); Thu, 02 Mar 2017 18:26:29 +0000 (UTC)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Sachin Sant , linux-mips@linux-mips.org,\n\tChris Metcalf ,\n\tDavid Daney , \n\tRusty Russell , linux-kernel@vger.kernel.org, \n\tRalf Baechle ,\n\tRussell King , \n\tRabin Vincent , Jason Baron ,\n\tPaul Mackerras , Anton Blanchard , \n\tlinuxppc-dev@lists.ozlabs.org, Ingo Molnar ,\n\tlinux-arm-kernel@lists.infradead.org, Zhigang Lu ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1597942,"web_url":"http://patchwork.ozlabs.org/comment/1597942/","msgid":"","date":"2017-03-02T19:24:23","subject":"Re: [PATCH] module: set __jump_table alignment to 8","submitter":{"id":721,"url":"http://patchwork.ozlabs.org/api/people/721/","name":"David Daney","email":"ddaney@caviumnetworks.com"},"content":"On 03/02/2017 10:26 AM, Jessica Yu wrote:\n> +++ Steven Rostedt [02/03/17 13:11 -0500]:\n>>\n>> Can I get an Ack from a module maintainer?\n>\n> Acked-by: Jessica Yu \n>\n> Thanks!\n>\n> Jessica\n\nThanks Jessica,\n\nCan you also add scripts/module-common.lds to MAINTAINERS so that \nget_maintainers.pl will indicate that Jessica Yu and Rusty Russell be \nCCed on things like this in the future?\n\n\n>\n>> On Wed, 1 Mar 2017 14:04:53 -0800\n>> David Daney wrote:\n>>\n>>> For powerpc the __jump_table section in modules is not aligned, this\n>>> causes a WARN_ON() splat when loading a module containing a\n>>> __jump_table.\n>>>\n>>> Strict alignment became necessary with commit 3821fd35b58d\n>>> (\"jump_label: Reduce the size of struct static_key\"), currently in\n>>> linux-next, which uses the two least significant bits of pointers to\n>>> __jump_table elements.\n>>>\n>>> Fix by forcing __jump_table to 8, which is the same alignment used for\n>>> this section in the kernel proper.\n>>>\n>>> Signed-off-by: David Daney \n>>> Tested-by: Sachin Sant \n>>> ---\n>>> scripts/module-common.lds | 2 ++\n>>> 1 file changed, 2 insertions(+)\n>>>\n>>> diff --git a/scripts/module-common.lds b/scripts/module-common.lds\n>>> index 73a2c7d..53234e8 100644\n>>> --- a/scripts/module-common.lds\n>>> +++ b/scripts/module-common.lds\n>>> @@ -19,4 +19,6 @@ SECTIONS {\n>>>\n>>> . = ALIGN(8);\n>>> .init_array 0 : { *(SORT(.init_array.*)) *(.init_array) }\n>>> +\n>>> + __jump_table 0 : ALIGN(8) { KEEP(*(__jump_table)) }\n>>> }\n>>","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vZ2NM6QmBz9s7j\n\tfor ;\n\tFri, 3 Mar 2017 06:25:55 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3vZ2NM5H8hzDqJ7\n\tfor ;\n\tFri, 3 Mar 2017 06:25:55 +1100 (AEDT)","from NAM02-SN1-obe.outbound.protection.outlook.com\n\t(mail-sn1nam02on0089.outbound.protection.outlook.com [104.47.36.89])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3vZ2Lm6RmLzDqGj\n\tfor ;\n\tFri, 3 Mar 2017 06:24:32 +1100 (AEDT)","from ddl.caveonetworks.com (50.233.148.156) by\n\tBY2PR07MB2423.namprd07.prod.outlook.com (10.166.115.15) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id\n\t15.1.933.12; Thu, 2 Mar 2017 19:24:27 +0000"],"Authentication-Results":["ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com\n\theader.i=@CAVIUMNETWORKS.onmicrosoft.com header.b=\"hGU52g1F\"; \n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com\n\theader.i=@CAVIUMNETWORKS.onmicrosoft.com header.b=\"hGU52g1F\"; \n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com\n\theader.i=@CAVIUMNETWORKS.onmicrosoft.com header.b=\"hGU52g1F\"; \n\tdkim-atps=neutral","ezchip.com; dkim=none (message not signed)\n\theader.d=none;ezchip.com; dmarc=none action=none\n\theader.from=caviumnetworks.com;"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=b6IrOx/FnPRvuwSpHs4SadYl8hvGq6AwOkPcEAZkHGE=;\n\tb=hGU52g1F/AOB9mLNJHxlGGLjHMpTNcIoDc7Xr7dnNZv6bo1eh2+mR9zncS8qzNwnzQpo7n2kVHIjNwjno3wMpEZQr7Ksll5x+62NpA6cGVeXFuQ311lcOdnjCqM3vL1nQQtPDF7cijEHQRJKELyT20Iy36/ehgOzx/GUx9Jtwc4=","Subject":"Re: [PATCH] module: set __jump_table alignment to 8","To":"Jessica Yu , Steven Rostedt ","References":"<20170301220453.4756-1-david.daney@cavium.com>\n\t<20170302131119.6f52203f@gandalf.local.home>\n\t<20170302182625.GB13268@packer-debian-8-amd64.digitalocean.com>","From":"David Daney ","Message-ID":"","Date":"Thu, 2 Mar 2017 11:24:23 -0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.7.0","MIME-Version":"1.0","In-Reply-To":"<20170302182625.GB13268@packer-debian-8-amd64.digitalocean.com>","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[50.233.148.156]","X-ClientProxiedBy":"SN1PR07CA0032.namprd07.prod.outlook.com (10.162.170.170)\n\tTo BY2PR07MB2423.namprd07.prod.outlook.com (10.166.115.15)","X-MS-Office365-Filtering-Correlation-Id":"35ff7306-a1e0-4ffa-0af3-08d461a1bf4b","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0; RULEID:(22001);\n\tSRVR:BY2PR07MB2423; ","X-Microsoft-Exchange-Diagnostics":["1; BY2PR07MB2423;\n\t3:pP5IO98ph341xDipMFR/KqeV28DVWHfaq6ME6g3J/ue9mWWyZOGHLpYuT0K++fvBIkTmxrLYBLuPthZiQS+m+32n2+JBH3pwuQ+VX73BzWzZYZamlfCX54gyXeU2XO9fDQ1e2/CNkoCl7qvo7muAkORd3pAZ+RgxSXwCU5+N0c08cuFYzYmTsmRIJjf6CI89otlxDdAdPYMFvPzYmh3+ewkkWmEHxm3aCAqgxp4dqf3+xxp+k70mEvnoYoxUzLVrLvsKt5H0I/bSw7b8nfpRZg==;\n\t25:jPH3pV8mKjA2hAUX2y6mSqWERcDLi1AfRncUgpB64xlOu9aNURay3HnZilsx8EfbXD7iHBw7T1+apXQD/8p0Ds3OPsBaiB1VqFn0U2UL9P4F2CbVbC78CVvIa0r/fOuyiw0fXuN/n8DIUz8JzSYa01s9aaYqSN19Odn8V5ui8D8pWLzJqlwX1XnZJtF0zJBH+n4PY7rdMNIJRFEZ36g/iO657iFfqG6vNLs8+r3KU2e6R7jzRcRb+Dbe+ypI+XLto8hpymBL/6AqugYQPjsvHnUSFy396+GkgakvT3Yf0ZsYQ/i18KFBQsVT+TtlxGqLtF5rFIidllbV3xwRJ8ZKUwt2UVQ1+EUA/6NMRrpPQGFcPGud0uRZCvFAUvhlNn23QKSB+Be1E+C097djsv/hWAv7X8z1QRE1zcuRMN4oWm4cn3ozhWg9Mi/zclqX0Xzuc55kH9wLJ/j8YcqV/5DMmw==","1; BY2PR07MB2423;\n\t31:YE8NaWC7kpp7UUxBefUDIthKpZ0YJzy6aBysDPkaYKLVYBKp1r88BqyCo4aJ0jsRPQDu7DKpoiFL1+0L53hdh7dHHs3oWQ0F6orG0DA9vrgL+vSiaLUHf6oMH0o+wkp/N2j/dB1Rr79JZzvZOmqRq8CHofA88ydNIgNMegshLNRiwjkb7V4SVO6rg7bRAnBn3qs24/s1TqfuRei5l/8dy5EOCH/B1PGK+azlo0ZgtS4=;\n\t20:srdgtfGNeAL1f/HZ9Os1MFPr5ENXnp5H0tcmN9nAIP13w6deOzMObSvTGkN6Lzdv1ww7m2jUcKhvUlezBY1Fn16CKBdbLJcDPLcLwyQtgJgRE2xnSj8Or0X7y3regXA6WjwdgpV4OXm9kIqCAvQ6ZyCz7ljAu5HK5hEtV0A6IDS6w903gKeqRniEwkFNifMvesuKgdYlcOMMSu4B5yBzQnn2oOO/lUVFkSDALkizJbCJdoqlg9cyBJAAu7cLdaz8a4PrGE+idpz+P5UBDQ4Ig5zr7pXI0JTVV4vZjizZYLAB4SWknQeK/H0h1CfpVpxVogId+bh4ZvVYs6rMWYgTGvWisW7r7jR4aO6VY5pPt2eXxByF+03VFer0ZCmzYgxh3mIJyoMAoAyVrj7D5ih01adZ3jd1fiWzT+18TDkrQMxH/Tv/afF6bly6Zs+kUEhbMZVsfOUJnLNoQidvxvY7tUZ3XA5mzX+h7UhprbtmoSC7XZWiQ6pg4DReC2TKqg8+qloUlVApeIPRicwh9qTNCi8Iom/2XpCvfCa7ji5CLgXCc2LrWLLxIP96X2GKR7DYmXekun7YYWcGwdb5BI9m8LfkiPaK7qJymTt8keLncTY=","1; BY2PR07MB2423;\n\t4:ctfdWi+p2y/dSSGLl/E4oQKvfGSyrMCPjc1dyq/LgsgFewzJGNUmCkrhBGASTUIE3ZdqcdqHUrfkMilfBlNcV/7WFEyBccp6EhL5QkF1IHFebv/eGmacqaesOTQs5j9Nwd2EVtPB8CC3rjSDgjMQ0w5CZyM/a8Uc0Zway9ya2imRDQAgFIy+iOxeFuVko1mccKgKudrGgtx5xJcHqOI+A2JpX86VuP+uqzAYCAfZIs9RGZLHQoUpVxy19bQBJfur8uj0yxgh3lj3OSrELGs9zFBdFIBT9Vf9w21mD/iCsTD34O8Lhf65/8EJP18v8WZK5ooa8GQSopHuS6nDv63KXelt9KuTIJMDBHZ/3k9VEep7e0ZzfloOyKRlLI1MgkMKMmmw+N5gUc6l6W+dF26AVoYQoJClEClBbZJrWC8ttgn8gZuLjiaJHDgz6QgFv2YcJ8uP/fGjrSeoT28PB0oRdK0SZi3y8+tzzIiFoOfSLOxDCAQQ5wKJAryfbNpgjqy8ccWek3YYldjMgOtMuVSZB7KrBKk1si8JZobapjCWsOlE9ujmBgSwiYNW5MAYMU2ru+kFQlSIk6ZPTKHTOVqmUDLE1dJiKqrNyC7dpzLSM7S9oxSqj2ptMntRteI6PpZu14VMcdzp1yqE40/g/zpVBQ==","=?Windows-1252?Q?1; BY2PR07MB2423;\n\t23:GHZtEPSq1qpG4MBJDUsLYoiaDehiYBAUl5URO?=\n\t=?Windows-1252?Q?IKNSpvPDVnftA9OJEReaUnfEqODjwPBuZbfie2w4kdDO29dtgaV3PSa6?=\n\t=?Windows-1252?Q?AocYIGd6fLRSfqr3uxF5u9aUZtqaOCgf4WCuokiQJWxYLI+Xja/M6b63?=\n\t=?Windows-1252?Q?Rer6VEuFKR1BKnvRvo8Gi1O4tbX/vg1HeLyEDMB6lStejbalgLBCwS59?=\n\t=?Windows-1252?Q?xhkQRdVzLsOaXC42zz75e/GDMmnR0JDMLkxSwl7fHgZHq0Qtwt4PSlfC?=\n\t=?Windows-1252?Q?REXn4cVCZKILVjJxel+vhjz619sjXINa76BGdHEd2kraGghLxR7zE0FD?=\n\t=?Windows-1252?Q?DLVOKXe1IOEBwxcsuNSNTTASWaJj9cLG07xnlqXWKl3oqWReq1A0rj7z?=\n\t=?Windows-1252?Q?G392PzLt5GKlbRipGFeyspkzlpGnfVUB2NK2G5Mz3qQnPdce0iXAGPCD?=\n\t=?Windows-1252?Q?AeaBua4bqS5yjWeJ/us8WSRyiojtidJuWkt1ShVsTdJKbm/H85dMqibO?=\n\t=?Windows-1252?Q?xZFtTqJtNAhQEaRSwhQSnXE3//D0oBP6w/Vgb9FnV4cJFlNCIHvyBSNT?=\n\t=?Windows-1252?Q?VG88WB0gjyzYaro5EJmuIFtnMFhx14lYh4Vdc7RPXPsKZPme0LqkSao2?=\n\t=?Windows-1252?Q?hSF2XPPVxCLUJPldeiqk1UDyo8VyGruM/fhbBBYUrC1htnrAQFL1Ugm0?=\n\t=?Windows-1252?Q?88s+ugOCM5SCe4Pz7q6lt4erPrUV3YjJK39ilKWprYqlND99WOfsl/Md?=\n\t=?Windows-1252?Q?5+RivkXFB82mSeMNW+PORCfjsKwpqhbIKN7HHIDTznduVPS2/0hwPhB4?=\n\t=?Windows-1252?Q?xj+w4QROF2ZP/Xq80Zx8WirxNzMrCI1eogxCpJO/+pe6RwSMLZ1QkRvy?=\n\t=?Windows-1252?Q?ALk9NXBmASFjySDY05sLTu4h9a42j/eGIvXLtBB4FZ5CbndmUA9hpEsL?=\n\t=?Windows-1252?Q?aPJrO6foLMyLuz5Lrrxe+C/Rx802jXXMbFkdaOs8lnOoeaXsso/bAcs5?=\n\t=?Windows-1252?Q?06gtqgWzI23vEW+kTaxdRk23Lp+GllPd2BlUlnNISmrswwKOESK4WsOj?=\n\t=?Windows-1252?Q?kci01k0u9+/l+zSTY4o8KopVDeBDHv/FiqNeBUCifEhM3SDRRTP2jedR?=\n\t=?Windows-1252?Q?z4ciPc9ubDNZdqKAjuaE9Cp9l1UZenluqQPFiQPAz4F1x3KiB8LxeH5D?=\n\t=?Windows-1252?Q?biGzAvg4I+QZURBZELaeGQRbFXLeygjVUMPuj+PFXNigjgvLXgBvNYIn?=\n\t=?Windows-1252?Q?h6zFGZ0tpVYpCmW591NMNXEINi2k7LZsvj2+pGTRRnxuG+jUnYnXA4Sr?=\n\t=?Windows-1252?Q?X0z?=","1; BY2PR07MB2423;\n\t6:9qWzE/zUgrJbLMYLN6TLBKrt6/BsENprG6K/kZ5EAbSaWzEkoFReo/4LD+311nJfamTvpJaxub89n+HE7jUx+sPsef6NAq1ICUaAVw4wDCzVXbXxW8V+qpicbeEO05McRQciyNuNDMI5ECF7p1oudK7dRjmM8JoSXO97TEXuWVYPKzLPhtsvAOWUHisi0tuwfccbzCa4IC5UD96B/cx32uhmYKmAi8b7SFCZ/xFJpYrZgr/5BHfXA1nDO/WVP9+/1FGzFabsVnj92FT4jrjPR1/HjoycF9gJT6bHtna8feS1rP5NfVXQt9eKS3bET1La2lGE+IFG/WwiFkI7jOMCEN06qB0foQIniUmsiHH/bPL70yPbJCMcoFjzgYDHD9W5YzjwOlihf6xAHHPdmid/6g==;\n\t5:0lznaq9ukmwbgDJ7Wl8gCMgZj0SB9zuNnEKgO6Q2rCa927or20HP/aTCcv2+ZcnzADkhJNdPGrsY3LnvxWyFo1w8hDNUbqUGaNclELiqx8rUA6Kd9u5zQZgJQ9tUp9R6JppuRVxXu0y6g2GDd6IqVA==;\n\t24:pgAMIWD/GADK4Ccq40M26gN0E2V1TmccO5v4Qq004Z5mkss1teB1nSPAOVel27rUbsknHf1SA+GS4Q4/ax/N8FHZxm8Ifl95sPrQZiWxe/4=","1; BY2PR07MB2423;\n\t7:Z6hFXa6NbYjVrm3v/jJ5ARUWVuAUkY7aoAI2eDjAsP9AqcjtkrTWrwzHouPL3InLwNcomEtU+CJxpoWlMakQzxCJSCmBpQqFNXFIRGcuFa0REfX5Q1oCgZjeYvw3oUn9IQ9gJI3o6Gxbq7gmNPWJTcaZ3IEPlRjrGlHWBMrqNQxF9PfESWZizMITuj/bUBX/5LqjRbOGh4VEbhcMHjC58jxJ32A4TBGWgSsMo7r7WlvoaGN2ugMSeWHOmR6nHshTIycjeVrJkDioQlwOYrtCy02jEIa/ahCoUFB7qc9k38lfkJaUK3F13+e7yFQLScdMa/m9Y5RiNSUr46dF7/Talw=="],"X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-Test":"UriScan:(104084551191319);","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123562025)(20161123560025)(20161123555025)(20161123564025)(20161123558025)(6072148);\n\tSRVR:BY2PR07MB2423; BCL:0; PCL:0; RULEID:; SRVR:BY2PR07MB2423; ","X-Forefront-PRVS":"023495660C","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(377454003)(24454002)(230700001)(229853002)(6512007)(54906002)(3846002)(66066001)(6116002)(38730400002)(47776003)(8676002)(5660300001)(4001350100001)(7416002)(36756003)(65956001)(65806001)(6506006)(6486002)(6246003)(53546006)(25786008)(23746002)(81166006)(4326008)(42882006)(305945005)(31696002)(33646002)(54356999)(53936002)(50986999)(7736002)(64126003)(189998001)(50466002)(76176999)(31686004)(2950100002)(83506001)(6666003)(92566002)(2906002)(53416004)(42186005);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR07MB2423; H:ddl.caveonetworks.com;\n\tFPR:; SPF:None; MLV:sfv; LANG:en; ","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"caviumnetworks.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"02 Mar 2017 19:24:27.5421\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BY2PR07MB2423","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Sachin Sant , linux-mips@linux-mips.org,\n\tChris Metcalf ,\n\tDavid Daney , \n\tRusty Russell , linux-kernel@vger.kernel.org, \n\tRalf Baechle ,\n\tRussell King , \n\tRabin Vincent , Jason Baron ,\n\tPaul Mackerras , Anton Blanchard , \n\tlinuxppc-dev@lists.ozlabs.org, Ingo Molnar ,\n\tlinux-arm-kernel@lists.infradead.org, Zhigang Lu ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1598144,"web_url":"http://patchwork.ozlabs.org/comment/1598144/","msgid":"<20170302224957.GC13268@packer-debian-8-amd64.digitalocean.com>","date":"2017-03-02T22:49:57","subject":"Re: [PATCH] module: set __jump_table alignment to 8","submitter":{"id":68191,"url":"http://patchwork.ozlabs.org/api/people/68191/","name":"Jessica Yu","email":"jeyu@redhat.com"},"content":"+++ David Daney [02/03/17 11:24 -0800]:\n>On 03/02/2017 10:26 AM, Jessica Yu wrote:\n>>+++ Steven Rostedt [02/03/17 13:11 -0500]:\n>>>\n>>>Can I get an Ack from a module maintainer?\n>>\n>>Acked-by: Jessica Yu \n>>\n>>Thanks!\n>>\n>>Jessica\n>\n>Thanks Jessica,\n>\n>Can you also add scripts/module-common.lds to MAINTAINERS so that \n>get_maintainers.pl will indicate that Jessica Yu and Rusty Russell be \n>CCed on things like this in the future?\n\nSure thing. Thanks for the heads up!\n\nJessica\n\n>>>On Wed, 1 Mar 2017 14:04:53 -0800\n>>>David Daney wrote:\n>>>\n>>>>For powerpc the __jump_table section in modules is not aligned, this\n>>>>causes a WARN_ON() splat when loading a module containing a\n>>>>__jump_table.\n>>>>\n>>>>Strict alignment became necessary with commit 3821fd35b58d\n>>>>(\"jump_label: Reduce the size of struct static_key\"), currently in\n>>>>linux-next, which uses the two least significant bits of pointers to\n>>>>__jump_table elements.\n>>>>\n>>>>Fix by forcing __jump_table to 8, which is the same alignment used for\n>>>>this section in the kernel proper.\n>>>>\n>>>>Signed-off-by: David Daney \n>>>>Tested-by: Sachin Sant \n>>>>---\n>>>> scripts/module-common.lds | 2 ++\n>>>> 1 file changed, 2 insertions(+)\n>>>>\n>>>>diff --git a/scripts/module-common.lds b/scripts/module-common.lds\n>>>>index 73a2c7d..53234e8 100644\n>>>>--- a/scripts/module-common.lds\n>>>>+++ b/scripts/module-common.lds\n>>>>@@ -19,4 +19,6 @@ SECTIONS {\n>>>>\n>>>> . = ALIGN(8);\n>>>> .init_array 0 : { *(SORT(.init_array.*)) *(.init_array) }\n>>>>+\n>>>>+ __jump_table 0 : ALIGN(8) { KEEP(*(__jump_table)) }\n>>>> }\n>>>\n>","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vZ6wz0tJ1z9s7n\n\tfor ;\n\tFri, 3 Mar 2017 09:50:59 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3vZ6wy6xRQzDqLh\n\tfor ;\n\tFri, 3 Mar 2017 09:50:58 +1100 (AEDT)","from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3vZ6vr6CfZzDqGh\n\tfor ;\n\tFri, 3 Mar 2017 09:50:00 +1100 (AEDT)","from smtp.corp.redhat.com\n\t(int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 42A89C073D55;\n\tThu, 2 Mar 2017 22:49:59 +0000 (UTC)","from packer-debian-8-amd64.digitalocean.com\n\t(vpn-234-230.phx2.redhat.com [10.3.234.230])\n\tby smtp.corp.redhat.com (Postfix) with SMTP id ED7A02D5C2;\n\tThu, 2 Mar 2017 22:49:57 +0000 (UTC)"],"Date":"Thu, 2 Mar 2017 17:49:57 -0500","From":"Jessica Yu ","To":"David Daney ","Subject":"Re: [PATCH] module: set __jump_table alignment to 8","Message-ID":"<20170302224957.GC13268@packer-debian-8-amd64.digitalocean.com>","References":"<20170301220453.4756-1-david.daney@cavium.com>\n\t<20170302131119.6f52203f@gandalf.local.home>\n\t<20170302182625.GB13268@packer-debian-8-amd64.digitalocean.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii; format=flowed","Content-Disposition":"inline","In-Reply-To":"","X-OS":"Linux eisen.io 3.16.0-4-amd64 x86_64","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Scanned-By":"MIMEDefang 2.74 on 10.5.11.28","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]); Thu, 02 Mar 2017 22:49:59 +0000 (UTC)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Sachin Sant , linux-mips@linux-mips.org,\n\tZhigang Lu , Chris Metcalf ,\n\tDavid Daney ,\n\tRusty Russell , \n\tlinux-kernel@vger.kernel.org, Steven Rostedt ,\n\tRussell King , Rabin Vincent ,\n\tJason Baron , Paul Mackerras ,\n\tRalf Baechle , linuxppc-dev@lists.ozlabs.org,\n\tIngo Molnar , linux-arm-kernel@lists.infradead.org, \n\tAnton Blanchard ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1598308,"web_url":"http://patchwork.ozlabs.org/comment/1598308/","msgid":"<87innrhw2l.fsf@concordia.ellerman.id.au>","date":"2017-03-03T03:34:58","subject":"Re: [PATCH] module: set __jump_table alignment to 8","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"Steven Rostedt writes:\n> On Thu, 02 Mar 2017 22:18:30 +1100\n> Michael Ellerman wrote:\n>> Michael Ellerman writes:\n>> > David Daney writes: \n>> >> Strict alignment became necessary with commit 3821fd35b58d\n>> >> (\"jump_label: Reduce the size of struct static_key\"), currently in\n>> >> linux-next, which uses the two least significant bits of pointers to\n>> >> __jump_table elements. \n>> >\n>> > It would obviously be nice if this could go in before the commit that\n>> > exposes the breakage, but I guess that's problematic because Steve\n>> > doesn't want to rebase the tracing tree.\n>> >\n>> > Steve I think you've already sent your pull request for this cycle? So I\n>> > guess if this can go in your first batch of fixes? \n>> \n>> Ugh. Was looking at the wrong tree - Linus has already merged the commit\n>> in question, so the above is all moot.\n>\n> No problem. I've got some other \"fixes\" to push to Linus. That's what\n> the -rc releases are for. To fix up breakage from the merge window ;-)\n\nYep, no drama.\n\n> I'll pull this into my tree.\n\nThanks.\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3vZFG36s2Jz9s81\n\tfor ;\n\tFri, 3 Mar 2017 14:36:11 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3vZFG35qSszDqK1\n\tfor ;\n\tFri, 3 Mar 2017 14:36:11 +1100 (AEDT)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3vZFDj4ctmzDq5x\n\tfor ;\n\tFri, 3 Mar 2017 14:35:01 +1100 (AEDT)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3vZFDj33jbz9s7s;\n\tFri, 3 Mar 2017 14:35:01 +1100 (AEDT)"],"From":"Michael Ellerman ","To":"Steven Rostedt ","Subject":"Re: [PATCH] module: set __jump_table alignment to 8","In-Reply-To":"<20170302124441.0e2634e0@gandalf.local.home>","References":"<20170301220453.4756-1-david.daney@cavium.com>\n\t<87varsj6qc.fsf@concordia.ellerman.id.au>\n\t<8737ewexkp.fsf@concordia.ellerman.id.au>\n\t<20170302124441.0e2634e0@gandalf.local.home>","User-Agent":"Notmuch/0.21 (https://notmuchmail.org)","Date":"Fri, 03 Mar 2017 14:34:58 +1100","Message-ID":"<87innrhw2l.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Sachin Sant , linux-mips@linux-mips.org,\n\tChris Metcalf ,\n\tDavid Daney , \n\tlinux-kernel@vger.kernel.org, Ralf Baechle ,\n\tRussell King , Rabin Vincent ,\n\tJason Baron , Paul Mackerras ,\n\tAnton Blanchard , linuxppc-dev@lists.ozlabs.org,\n\tIngo Molnar , linux-arm-kernel@lists.infradead.org, \n\tZhigang Lu ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]