[{"id":1759940,"web_url":"http://patchwork.ozlabs.org/comment/1759940/","msgid":"<20170830075252.bska2yik2tnxq25y@piout.net>","list_archive_url":null,"date":"2017-08-30T07:52:52","subject":"Re: [rtc-linux] [PATCH 1/2] rtc: pcf2127: add support for pcf2127\n\twatchdog functionality","submitter":{"id":26276,"url":"http://patchwork.ozlabs.org/api/people/26276/","name":"Alexandre Belloni","email":"alexandre.belloni@free-electrons.com"},"content":"On 30/08/2017 at 09:45:06 +0200, Sean Nyekjær wrote:\n> \n> \n> On 2017-08-29 17:07, Alexandre Belloni wrote:\n> > Hi Sean,\n> > \n> > I know this patch is 7 months old but I never had the time to write a\n> > proper reply.\n> > \n> > This is using a pretty old API. Can you register a proper watchdog using\n> > the watchdog subsystem (see drivers/watchdog)? Also, please copy the\n> > watchdog maintainers.\n> > \n> > I understand this will require a significant rewrite effort but the\n> > final code will be quite cleaner.\n> Hi Alexandre\n> \n> I unfortunately don't have access to the hardware anymore...\n> I think it would be very risky to rewrite the whole code without testing it\n> :-)\n> \n\nOk, too bad. :(\n\n> Yes this driver is quite hacky in some ways. It could be nice if the\n> watchdog part for this could be in the driver/watchdog and the rtc part\n> here. Maybe we could have 2 entries in the devicetree that shared the same\n> i2c device address.\n> \n\nIf you want to go that route, the proper way is to use the MFD\nsubsystem.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhyRP2Fknz9sQl\n\tfor ;\n\tWed, 30 Aug 2017 17:53:05 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751316AbdH3HxE (ORCPT );\n\tWed, 30 Aug 2017 03:53:04 -0400","from mail.free-electrons.com ([62.4.15.54]:57202 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751302AbdH3HxE (ORCPT\n\t); Wed, 30 Aug 2017 03:53:04 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid DB6E3209DD; Wed, 30 Aug 2017 09:53:01 +0200 (CEST)","from localhost (unknown [88.191.26.124])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id B01D6209C9;\n\tWed, 30 Aug 2017 09:52:51 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Wed, 30 Aug 2017 09:52:52 +0200","From":"Alexandre Belloni ","To":"Sean =?iso-8859-1?q?Nyekj=E6r?= ","Cc":"linux-rtc@vger.kernel.org","Subject":"Re: [rtc-linux] [PATCH 1/2] rtc: pcf2127: add support for pcf2127\n\twatchdog functionality","Message-ID":"<20170830075252.bska2yik2tnxq25y@piout.net>","References":"<20170120123644.118612-1-sean.nyekjaer@prevas.dk>\n\t<20170829150739.apyt4lxguypebkbm@piout.net>\n\t<4294cb1e-a01f-66db-8b64-eb4d5e68569e@prevas.dk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<4294cb1e-a01f-66db-8b64-eb4d5e68569e@prevas.dk>","User-Agent":"NeoMutt/20170609 (1.8.3)","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}},{"id":1759944,"web_url":"http://patchwork.ozlabs.org/comment/1759944/","msgid":"<4294cb1e-a01f-66db-8b64-eb4d5e68569e@prevas.dk>","list_archive_url":null,"date":"2017-08-30T07:45:06","subject":"Re: [rtc-linux] [PATCH 1/2] rtc: pcf2127: add support for pcf2127\n\twatchdog functionality","submitter":{"id":64902,"url":"http://patchwork.ozlabs.org/api/people/64902/","name":"Sean Nyekjær","email":"sean.nyekjaer@prevas.dk"},"content":"On 2017-08-29 17:07, Alexandre Belloni wrote:\n> Hi Sean,\n>\n> I know this patch is 7 months old but I never had the time to write a\n> proper reply.\n>\n> This is using a pretty old API. Can you register a proper watchdog using\n> the watchdog subsystem (see drivers/watchdog)? Also, please copy the\n> watchdog maintainers.\n>\n> I understand this will require a significant rewrite effort but the\n> final code will be quite cleaner.\nHi Alexandre\n\nI unfortunately don't have access to the hardware anymore...\nI think it would be very risky to rewrite the whole code without testing \nit :-)\n\nYes this driver is quite hacky in some ways. It could be nice if the \nwatchdog part for this could be in the driver/watchdog and the rtc part \nhere. Maybe we could have 2 entries in the devicetree that shared the \nsame i2c device address.\n\n/Sean","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=prevas.dk header.i=@prevas.dk\n\theader.b=\"s1itnhlM\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhyWF6ZqVz9sQl\n\tfor ;\n\tWed, 30 Aug 2017 17:56:25 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751039AbdH3H4Z (ORCPT );\n\tWed, 30 Aug 2017 03:56:25 -0400","from mail02.prevas.se ([62.95.78.10]:49196 \"EHLO mail02.prevas.se\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750839AbdH3H4Y (ORCPT );\n\tWed, 30 Aug 2017 03:56:24 -0400","from vmprevas4.prevas.se (HELO smtp.prevas.se) ([172.16.8.104])\n\tby ironport2.prevas.se with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t30 Aug 2017 09:45:06 +0200","from [172.16.11.15] (172.16.8.31) by smtp.prevas.se (172.16.8.104)\n\twith Microsoft SMTP Server (TLS) id 14.2.347.0;\n\tWed, 30 Aug 2017 09:45:05 +0200"],"X-Greylist":"delayed 667 seconds by postgrey-1.27 at vger.kernel.org;\n\tWed, 30 Aug 2017 03:56:24 EDT","DKIM-Signature":"v=1; a=rsa-sha256; c=simple/simple;\n\td=prevas.dk; i=@prevas.dk; l=858; q=dns/txt;\n\ts=ironport2; t=1504079784; x=1535615784;\n\th=subject:to:cc:references:from:message-id:date:\n\tmime-version:in-reply-to:content-transfer-encoding;\n\tbh=mfh9aygn/uGHmoCangsRP/rbg3W3ni4wOoFNSlou5jk=;\n\tb=s1itnhlMla42c9YDF3YoXyZ2r9PCFoE+bjXaV7L8rtqIYJ21S8+9S6eB\n\tgWrjdqH/4xYonNiu+voTbobLJyRDBlGv3sdxv98ksxKmByt2fLACQ+CHP\n\t7R9wW2ao75AL/qrKMlsLg4DJpfnC9aNcwmizo/0/1ghNaYcR9vHPJq1uR w=;","X-IronPort-AV":"E=Sophos;i=\"5.41,448,1498514400\"; d=\"scan'208\";a=\"2432772\"","Subject":"Re: [rtc-linux] [PATCH 1/2] rtc: pcf2127: add support for pcf2127\n\twatchdog functionality","To":"Alexandre Belloni ","CC":"","References":"<20170120123644.118612-1-sean.nyekjaer@prevas.dk>\n\t<20170829150739.apyt4lxguypebkbm@piout.net>","From":"=?utf-8?q?Sean_Nyekj=C3=A6r?= ","Message-ID":"<4294cb1e-a01f-66db-8b64-eb4d5e68569e@prevas.dk>","Date":"Wed, 30 Aug 2017 09:45:06 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170829150739.apyt4lxguypebkbm@piout.net>","Content-Type":"text/plain; charset=\"utf-8\"; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","X-Originating-IP":"[172.16.8.31]","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"}}]