[{"id":1525353,"web_url":"http://patchwork.ozlabs.org/comment/1525353/","msgid":"<87d1hb855c.fsf@concordia.ellerman.id.au>","date":"2016-12-02T01:57:03","subject":"Re: [PATCH] KVM: PPC: Book3S: Move prototypes for KVM functions into\n\tkvm_ppc.h","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"Paul Mackerras writes:\n\n> This moves the prototypes for functions that are only called from\n> assembler code out of asm/asm-prototypes.h into asm/kvm_ppc.h.\n> The prototypes were added in commit ebe4535fbe7a (\"KVM: PPC:\n> Book3S HV: sparse: prototypes for functions called from assembler\",\n> 2016-10-10), but given that the functions are KVM functions,\n> having them in a KVM header will be better for long-term\n> maintenance.\n>\n> Signed-off-by: Paul Mackerras \n> ---\n> [For information; I intend to merge this through the KVM tree.]\n>\n> arch/powerpc/include/asm/asm-prototypes.h | 44 -------------------------------\n> arch/powerpc/include/asm/kvm_ppc.h | 42 +++++++++++++++++++++++++++++\n> arch/powerpc/kvm/book3s_64_vio_hv.c | 1 -\n> arch/powerpc/kvm/book3s_hv_builtin.c | 1 -\n> arch/powerpc/kvm/book3s_hv_ras.c | 2 +-\n> arch/powerpc/kvm/book3s_hv_rm_mmu.c | 1 -\n> arch/powerpc/kvm/book3s_hv_rm_xics.c | 1 -\n> 7 files changed, 43 insertions(+), 49 deletions(-)\n\nLGTM.\n\nNone of these are EXPORT_SYMBOL'ed, so moving them out of\nasm-prototypes.h is safe from that POV.\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tVHNr5N6Rz9t1B\n\tfor ;\n\tFri, 2 Dec 2016 12:58:04 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3tVHNr4dH5zDw5k\n\tfor ;\n\tFri, 2 Dec 2016 12:58:04 +1100 (AEDT)","from ozlabs.org (ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3tVHMk4kHkzDw1w\n\tfor ;\n\tFri, 2 Dec 2016 12:57:06 +1100 (AEDT)","by ozlabs.org (Postfix)\n\tid 3tVHMk3yXnz9vFX; Fri, 2 Dec 2016 12:57:06 +1100 (AEDT)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3tVHMk2ll6z9vF3;\n\tFri, 2 Dec 2016 12:57:06 +1100 (AEDT)"],"From":"Michael Ellerman ","To":"Paul Mackerras , linuxppc-dev@ozlabs.org","Subject":"Re: [PATCH] KVM: PPC: Book3S: Move prototypes for KVM functions into\n\tkvm_ppc.h","In-Reply-To":"<20161201033004.2yh4txylpayxzmpu@oak.ozlabs.ibm.com>","References":"<20161201033004.2yh4txylpayxzmpu@oak.ozlabs.ibm.com>","User-Agent":"Notmuch/0.21 (https://notmuchmail.org)","Date":"Fri, 02 Dec 2016 12:57:03 +1100","Message-ID":"<87d1hb855c.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1525368,"web_url":"http://patchwork.ozlabs.org/comment/1525368/","msgid":"<87zikfgi7i.fsf@possimpible.ozlabs.ibm.com>","date":"2016-12-02T02:47:45","subject":"Re: [PATCH] KVM: PPC: Book3S: Move prototypes for KVM functions into\n\tkvm_ppc.h","submitter":{"id":65792,"url":"http://patchwork.ozlabs.org/api/people/65792/","name":"Daniel Axtens","email":"dja@axtens.net"},"content":">> This moves the prototypes for functions that are only called from\n>> assembler code out of asm/asm-prototypes.h into asm/kvm_ppc.h.\n>> The prototypes were added in commit ebe4535fbe7a (\"KVM: PPC:\n>> Book3S HV: sparse: prototypes for functions called from assembler\",\n>> 2016-10-10), but given that the functions are KVM functions,\n>> having them in a KVM header will be better for long-term\n>> maintenance.\n>>\n>> Signed-off-by: Paul Mackerras \n>> ---\n>> [For information; I intend to merge this through the KVM tree.]\n>>\n>> arch/powerpc/include/asm/asm-prototypes.h | 44 -------------------------------\n>> arch/powerpc/include/asm/kvm_ppc.h | 42 +++++++++++++++++++++++++++++\n>> arch/powerpc/kvm/book3s_64_vio_hv.c | 1 -\n>> arch/powerpc/kvm/book3s_hv_builtin.c | 1 -\n>> arch/powerpc/kvm/book3s_hv_ras.c | 2 +-\n>> arch/powerpc/kvm/book3s_hv_rm_mmu.c | 1 -\n>> arch/powerpc/kvm/book3s_hv_rm_xics.c | 1 -\n>> 7 files changed, 43 insertions(+), 49 deletions(-)\n>\n> LGTM.\n>\n> None of these are EXPORT_SYMBOL'ed, so moving them out of\n> asm-prototypes.h is safe from that POV.\n>\n> cheers\n\nLooks good to me too.\n\nRegards,\nDaniel","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tVJWq6WLxz9t0J\n\tfor ;\n\tFri, 2 Dec 2016 13:49:11 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3tVJWq56tZzDw3H\n\tfor ;\n\tFri, 2 Dec 2016 13:49:11 +1100 (AEDT)","from ozlabs.org (ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3tVJVJ4RLnzDvxk\n\tfor ;\n\tFri, 2 Dec 2016 13:47:52 +1100 (AEDT)","by ozlabs.org (Postfix)\n\tid 3tVJVJ3whGz9vDS; Fri, 2 Dec 2016 13:47:52 +1100 (AEDT)","from mail-pg0-x244.google.com (mail-pg0-x244.google.com\n\t[IPv6:2607:f8b0:400e:c05::244])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3tVJVH39lNz9tB1\n\tfor ; Fri, 2 Dec 2016 13:47:51 +1100 (AEDT)","by mail-pg0-x244.google.com with SMTP id x23so6393718pgx.3\n\tfor ; Thu, 01 Dec 2016 18:47:51 -0800 (PST)","from localhost ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id\n\tw17sm3083462pgm.18.2016.12.01.18.47.48\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 01 Dec 2016 18:47:49 -0800 (PST)"],"Authentication-Results":["ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"KEVeJqzP\"; dkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"KEVeJqzP\"; dkim-atps=neutral","lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"KEVeJqzP\"; dkim-atps=neutral","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"KEVeJqzP\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google;\n\th=from:to:subject:in-reply-to:references:user-agent:date:message-id\n\t:mime-version; bh=jfURp1Nkdc+yhsZyycTDJuBxqh72xfFtPNtFiilIOcw=;\n\tb=KEVeJqzPhQdX9w+sXSLt4K66SbAsQS3Kn+2GOycWKnis2L2HjsVq8oLDt90p1XIBNh\n\tVTSRQA8gLzse8vzWcCy7JTEsiyj22ygBQYFTC2qEtqD3z2p+BmG/zcGXeRioLhp/SkH+\n\tf2ZdNaL6fIFPr/4ls7sQz1BqD2qiQK9Qlsl7Y=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:in-reply-to:references\n\t:user-agent:date:message-id:mime-version;\n\tbh=jfURp1Nkdc+yhsZyycTDJuBxqh72xfFtPNtFiilIOcw=;\n\tb=mmSkrZWQkh1TyivyFcvGFAge1+6fkpAlyrEWkc7FwmT96G4ovTgaF0hfgT2CMW2Or/\n\tWN7KD+35O8nkCQYtlEEqjknB6PHj+cv/hii/7RcQCZV0UMnXXXBPES1wqlzNoevrwatb\n\tODK6kCh6T4TUb3nHbS00bk03P8VhBYaQ2Mxp1ookBgc7wQ9ANqannrAZF5nvhsx1sfAj\n\tI/onDNYpnpMRLTwX+GopP9Uss1hDwLN16Qidrn1khlY0I4JGjU4au6y4azPJwDXrQ1DF\n\t12yvo7zaEvdOR5k7eGE2O4ewxs6UppUVOlVD5T2fflc6vK2Nsh5eQvzAJyues18hi0Je\n\tM4xw==","X-Gm-Message-State":"AKaTC03hOKx5cuA4iqCGVtYG+7Ea8FQhAUFNBDoCTgWatkKTgHSE4tcPKlWCrCNwPoswYA==","X-Received":"by 10.99.99.195 with SMTP id x186mr76087241pgb.100.1480646869671;\n\tThu, 01 Dec 2016 18:47:49 -0800 (PST)","From":"Daniel Axtens ","To":"Michael Ellerman , Paul Mackerras ,\n\tlinuxppc-dev@ozlabs.org","Subject":"Re: [PATCH] KVM: PPC: Book3S: Move prototypes for KVM functions into\n\tkvm_ppc.h","In-Reply-To":"<87d1hb855c.fsf@concordia.ellerman.id.au>","References":"<20161201033004.2yh4txylpayxzmpu@oak.ozlabs.ibm.com>\n\t<87d1hb855c.fsf@concordia.ellerman.id.au>","User-Agent":"Notmuch/0.22.1 (http://notmuchmail.org) Emacs/24.5.1\n\t(x86_64-pc-linux-gnu)","Date":"Fri, 02 Dec 2016 13:47:45 +1100","Message-ID":"<87zikfgi7i.fsf@possimpible.ozlabs.ibm.com>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]