[{"id":1424054,"web_url":"http://patchwork.ozlabs.org/comment/1424054/","msgid":"<20160804140133.edf295b8263845e50c185fc2@linux-foundation.org>","date":"2016-08-04T21:01:33","subject":"Re: [PATCH V2 2/2] fadump: Register the memory reserved by fadump","submitter":{"id":107,"url":"http://patchwork.ozlabs.org/api/people/107/","name":"Andrew Morton","email":"akpm@linux-foundation.org"},"content":"On Thu, 4 Aug 2016 22:42:09 +0530 Srikar Dronamraju wrote:\n\n> Fadump kernel reserves large chunks of memory even before the pages are\n> initialized. This could mean memory that corresponds to several nodes might\n> fall in memblock reserved regions.\n> \n> Kernels compiled with CONFIG_DEFERRED_STRUCT_PAGE_INIT will initialize\n> only certain size memory per node. The certain size takes into account\n> the dentry and inode cache sizes. Currently the cache sizes are\n> calculated based on the total system memory including the reserved\n> memory. However such a kernel when booting the same kernel as fadump\n> kernel will not be able to allocate the required amount of memory to\n> suffice for the dentry and inode caches. This results in crashes like\n> the below on large systems such as 32 TB systems.\n> \n> Dentry cache hash table entries: 536870912 (order: 16, 4294967296 bytes)\n> vmalloc: allocation failure, allocated 4097114112 of 17179934720 bytes\n> swapper/0: page allocation failure: order:0, mode:0x2080020(GFP_ATOMIC)\n> CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.6-master+ #3\n> Call Trace:\n> [c00000000108fb10] [c0000000007fac88] dump_stack+0xb0/0xf0 (unreliable)\n> [c00000000108fb50] [c000000000235264] warn_alloc_failed+0x114/0x160\n> [c00000000108fbf0] [c000000000281484] __vmalloc_node_range+0x304/0x340\n> [c00000000108fca0] [c00000000028152c] __vmalloc+0x6c/0x90\n> [c00000000108fd40] [c000000000aecfb0]\n> alloc_large_system_hash+0x1b8/0x2c0\n> [c00000000108fe00] [c000000000af7240] inode_init+0x94/0xe4\n> [c00000000108fe80] [c000000000af6fec] vfs_caches_init+0x8c/0x13c\n> [c00000000108ff00] [c000000000ac4014] start_kernel+0x50c/0x578\n> [c00000000108ff90] [c000000000008c6c] start_here_common+0x20/0xa8\n> \n> Register the memory reserved by fadump, so that the cache sizes are\n> calculated based on the free memory (i.e Total memory - reserved\n> memory).\n\nLooks harmless enough to me. I'll schedule the patches for 4.8. But\nit sounds like they should be backported into older kernels?","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3s52Ss3lgzz9t1H\n\tfor ;\n\tFri, 5 Aug 2016 07:02:37 +1000 (AEST)","from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3s52Ss396QzDqdm\n\tfor ;\n\tFri, 5 Aug 2016 07:02:37 +1000 (AEST)","from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3s52Rh75TzzDqQs\n\tfor ;\n\tFri, 5 Aug 2016 07:01:36 +1000 (AEST)","from akpm3.mtv.corp.google.com (unknown [104.132.1.73])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPSA id 5CCD0958;\n\tThu, 4 Aug 2016 21:01:34 +0000 (UTC)"],"Date":"Thu, 4 Aug 2016 14:01:33 -0700","From":"Andrew Morton ","To":"Srikar Dronamraju ","Subject":"Re: [PATCH V2 2/2] fadump: Register the memory reserved by fadump","Message-Id":"<20160804140133.edf295b8263845e50c185fc2@linux-foundation.org>","In-Reply-To":"<1470330729-6273-2-git-send-email-srikar@linux.vnet.ibm.com>","References":"<1470330729-6273-1-git-send-email-srikar@linux.vnet.ibm.com>\n\t<1470330729-6273-2-git-send-email-srikar@linux.vnet.ibm.com>","X-Mailer":"Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu)","Mime-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.22","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Dave Hansen ,\n\tMel Gorman ,\n\tMichal Hocko , \n\tMahesh Salgaonkar , linux-mm@kvack.org,\n\tHari Bathini ,\n\tlinuxppc-dev@lists.ozlabs.org, Vlastimil Babka ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1441189,"web_url":"http://patchwork.ozlabs.org/comment/1441189/","msgid":"<20160829131246.GA2505@linux.vnet.ibm.com>","date":"2016-08-29T13:12:46","subject":"Re: [PATCH V2 2/2] fadump: Register the memory reserved by fadump","submitter":{"id":11795,"url":"http://patchwork.ozlabs.org/api/people/11795/","name":"Srikar Dronamraju","email":"srikar@linux.vnet.ibm.com"},"content":"* Andrew Morton [2016-08-04 14:01:33]:\n\n> > Register the memory reserved by fadump, so that the cache sizes are\n> > calculated based on the free memory (i.e Total memory - reserved\n> > memory).\n> \n> Looks harmless enough to me. I'll schedule the patches for 4.8. But\n> it sounds like they should be backported into older kernels?\n> \n\nBased on the v2 feedback, I just posted a v3 at\nhttp://lkml.kernel.org/r/1472476010-4709-1-git-send-email-srikar@linux.vnet.ibm.com\nthat tries to reduce the large system hash based on tha reserved memory.\nHence please drop the v2 patches.","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sNBtb6PmDz9sf6\n\tfor ;\n\tMon, 29 Aug 2016 23:13:59 +1000 (AEST)","from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3sNBtb565VzDsb5\n\tfor ;\n\tMon, 29 Aug 2016 23:13:59 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3sNBsQ2PC7zDsWr\n\tfor ;\n\tMon, 29 Aug 2016 23:12:58 +1000 (AEST)","from pps.filterd (m0098394.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id\n\tu7TDC8CG055747\n\tfor ; Mon, 29 Aug 2016 09:12:56 -0400","from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com [202.81.31.148])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2537caeu6p-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 29 Aug 2016 09:12:56 -0400","from localhost\n\tby e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ; \n\tMon, 29 Aug 2016 23:12:53 +1000","from d23dlp03.au.ibm.com (202.81.31.214)\n\tby e23smtp06.au.ibm.com (202.81.31.212) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 29 Aug 2016 23:12:52 +1000","from d23relay10.au.ibm.com (d23relay10.au.ibm.com [9.190.26.77])\n\tby d23dlp03.au.ibm.com (Postfix) with ESMTP id B654D3578052\n\tfor ;\n\tMon, 29 Aug 2016 23:12:51 +1000 (EST)","from d23av05.au.ibm.com (d23av05.au.ibm.com [9.190.234.119])\n\tby d23relay10.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tu7TDCppr64946380\n\tfor ; Mon, 29 Aug 2016 23:12:51 +1000","from d23av05.au.ibm.com (localhost [127.0.0.1])\n\tby d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tu7TDCoGd018017\n\tfor ; Mon, 29 Aug 2016 23:12:51 +1000","from linux.vnet.ibm.com (srdronam.in.ibm.com [9.124.31.34])\n\tby d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id\n\tu7TDClJt017981; Mon, 29 Aug 2016 23:12:47 +1000"],"X-IBM-Helo":"d23dlp03.au.ibm.com","X-IBM-MailFrom":"srikar@linux.vnet.ibm.com","X-IBM-RcptTo":"linuxppc-dev@lists.ozlabs.org","Date":"Mon, 29 Aug 2016 18:42:46 +0530","From":"Srikar Dronamraju ","To":"Andrew Morton ","Subject":"Re: [PATCH V2 2/2] fadump: Register the memory reserved by fadump","References":"<1470330729-6273-1-git-send-email-srikar@linux.vnet.ibm.com>\n\t<1470330729-6273-2-git-send-email-srikar@linux.vnet.ibm.com>\n\t<20160804140133.edf295b8263845e50c185fc2@linux-foundation.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","In-Reply-To":"<20160804140133.edf295b8263845e50c185fc2@linux-foundation.org>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-TM-AS-MML":"disable","X-Content-Scanned":"Fidelis XPS MAILER","x-cbid":"16082913-0040-0000-0000-000001D34EE9","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"16082913-0041-0000-0000-00000A5F301F","Message-Id":"<20160829131246.GA2505@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2016-08-29_06:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000\n\tdefinitions=main-1608290133","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.22","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"Srikar Dronamraju ","Cc":"Dave Hansen ,\n\tMel Gorman ,\n\tMichal Hocko , \n\tMahesh Salgaonkar , linux-mm@kvack.org,\n\tHari Bathini ,\n\tlinuxppc-dev@lists.ozlabs.org, Vlastimil Babka ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]