[{"id":1422608,"web_url":"http://patchwork.ozlabs.org/comment/1422608/","msgid":"<87popqullq.fsf@concordia.ellerman.id.au>","date":"2016-08-03T11:40:17","subject":"Re: linker tables on powerpc - build issues","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"\"Luis R. Rodriguez\" <mcgrof@do-not-panic.com> writes:\n\n> I've run into a few compilation issues with linker tables support [0]\n> [1] on only a few architectures:\n>\n> blackfin - compiler issue it seems, I have a work around now in place\n> arm  - some alignment issue - still need to iron this out\n> powerpc - issue with including <asm/sections.h> on <asm/jump_labels.h>\n>\n> The issue with powerpc can be replicated easily with the patch below,\n> and compilation fails even on a 'make defconfig' configuration, the\n> issues are recurring include header ordering issues. I've given this\n> some tries to fix but am still a bit bewildered how to best do this\n> without affecting non-powerpc compilations.  The patch below\n> replicates the changes in question, it does not include the linker\n> table work at all, it just includes <asm/sections.h> instead of\n> <asm/tables.h> to reduce and provide an example of the issues\n> observed. The list of errors are also pretty endless... so was hoping\n> some power folks might be able to take a glance if possible. If you\n> have any ideas, please let me know.\n\nWhat is the end goal?\n\nYou want to be able to include asm/sections.h in asm/jump_labels.h? So\nthat you can get some macros to wrap the pushsection etc, am I right?\n\nThe biggest problem I see is dereference_function_descriptor(), which\nuses probe_kernel(), which pulls in uaccess.h.\n\nBut it doesn't really make sense for dereference_function_descriptor()\nto be in sections.h AFAICS.\n\nI'll see if I can unstitch it tomorrow.\n\ncheers","headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3s4B3r2xBTz9sXx\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed,  3 Aug 2016 21:41:28 +1000 (AEST)","from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3s4B3r21k9zDqV6\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed,  3 Aug 2016 21:41:28 +1000 (AEST)","from ozlabs.org (ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3s4B2V5RbmzDqQ5\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tWed,  3 Aug 2016 21:40:18 +1000 (AEST)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3s4B2V3dd8z9sXx;\n\tWed,  3 Aug 2016 21:40:18 +1000 (AEST)"],"From":"Michael Ellerman <mpe@ellerman.id.au>","To":"\"Luis R. Rodriguez\" <mcgrof@do-not-panic.com>,\n\tBenjamin Herrenschmidt <benh@kernel.crashing.org>,\n\tPaul Mackerras <paulus@samba.org>","Subject":"Re: linker tables on powerpc - build issues","In-Reply-To":"<CAB=NE6Xu2t7JYUfvZcPSpX_Yt2yN9ooWgzctZFMr3LZGG1hVzw@mail.gmail.com>","References":"<CAB=NE6Xu2t7JYUfvZcPSpX_Yt2yN9ooWgzctZFMr3LZGG1hVzw@mail.gmail.com>","User-Agent":"Notmuch/0.21 (https://notmuchmail.org)","Date":"Wed, 03 Aug 2016 21:40:17 +1000","Message-ID":"<87popqullq.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.22","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>","Cc":"Fengguang Wu <fengguang.wu@intel.com>, linuxppc-dev@lists.ozlabs.org,\n\t\"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>,\n\tGuenter Roeck <linux@roeck-us.net>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>"}}]