[{"id":1407028,"web_url":"http://patchwork.ozlabs.org/comment/1407028/","msgid":"<57877315.5060903@suse.de>","date":"2016-07-14T11:10:13","subject":"Re: [patch] KVM: PPC: fix a sanity check","submitter":{"id":1212,"url":"http://patchwork.ozlabs.org/api/people/1212/","name":"Alexander Graf","email":"agraf@suse.de"},"content":"On 07/14/2016 12:15 PM, Dan Carpenter wrote:\n> We use logical negate where bitwise negate was intended.  It means that\n> we never return -EINVAL here.\n>\n> Fixes: ce11e48b7fdd ('KVM: PPC: E500: Add userspace debug stub support')\n> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n\nOops :).\n\nReviewed-by: Alexander Graf <agraf@suse.de>\n\n\nAlex","headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rqtLX51P7z9sDG\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 14 Jul 2016 21:11:32 +1000 (AEST)","from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3rqtLX3ZYMzDr02\n\tfor <patchwork-incoming@ozlabs.org>;\n\tThu, 14 Jul 2016 21:11:32 +1000 (AEST)","from mx2.suse.de (mx2.suse.de [195.135.220.15])\n\t(using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3rqtKD5hgFzDqxj\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tThu, 14 Jul 2016 21:10:24 +1000 (AEST)","from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx2.suse.de (Postfix) with ESMTP id 84F8BAD29;\n\tThu, 14 Jul 2016 11:10:16 +0000 (UTC)"],"X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","Subject":"Re: [patch] KVM: PPC: fix a sanity check","To":"Dan Carpenter <dan.carpenter@oracle.com>,\n\tBharat Bhushan <r65777@freescale.com>","References":"<20160714101545.GB18175@mwanda>","From":"Alexander Graf <agraf@suse.de>","Message-ID":"<57877315.5060903@suse.de>","Date":"Thu, 14 Jul 2016 13:10:13 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101\n\tThunderbird/38.3.0","MIME-Version":"1.0","In-Reply-To":"<20160714101545.GB18175@mwanda>","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.22","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>","Cc":"kvm@vger.kernel.org, rkrcmar@redhat.com, kernel-janitors@vger.kernel.org,\n\tkvm-ppc@vger.kernel.org, Paul Mackerras <paulus@samba.org>,\n\tPaolo Bonzini <pbonzini@redhat.com>, linuxppc-dev@lists.ozlabs.org","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>"}},{"id":1466985,"web_url":"http://patchwork.ozlabs.org/comment/1466985/","msgid":"<20160927054652.gikspz75ilmluecz@oak.ozlabs.ibm.com>","date":"2016-09-27T05:46:52","subject":"Re: [patch] KVM: PPC: fix a sanity check","submitter":{"id":67079,"url":"http://patchwork.ozlabs.org/api/people/67079/","name":"Paul Mackerras","email":"paulus@ozlabs.org"},"content":"On Thu, Jul 14, 2016 at 01:15:46PM +0300, Dan Carpenter wrote:\n> We use logical negate where bitwise negate was intended.  It means that\n> we never return -EINVAL here.\n> \n> Fixes: ce11e48b7fdd ('KVM: PPC: E500: Add userspace debug stub support')\n> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n\nThanks, applied to kvm-ppc-next.\n\nPaul.","headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3sjqg72LsCz9srZ\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 27 Sep 2016 15:50:11 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3sjqg71TjTzDrLw\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 27 Sep 2016 15:50:11 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3sjqc52wJczDrSx\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tTue, 27 Sep 2016 15:47:33 +1000 (AEST)","by ozlabs.org (Postfix, from userid 1003)\n\tid 3sjqc51b6Nz9sdg; Tue, 27 Sep 2016 15:47:33 +1000 (AEST)"],"Date":"Tue, 27 Sep 2016 15:46:52 +1000","From":"Paul Mackerras <paulus@ozlabs.org>","To":"Dan Carpenter <dan.carpenter@oracle.com>","Subject":"Re: [patch] KVM: PPC: fix a sanity check","Message-ID":"<20160927054652.gikspz75ilmluecz@oak.ozlabs.ibm.com>","References":"<20160714101545.GB18175@mwanda>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20160714101545.GB18175@mwanda>","User-Agent":"Mutt/1.6.2-neo (2016-07-23)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>","Cc":"kvm@vger.kernel.org, Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>,\n\tBharat Bhushan <r65777@freescale.com>, kernel-janitors@vger.kernel.org,\n\tkvm-ppc@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,\n\tlinuxppc-dev@lists.ozlabs.org, Alexander Graf <agraf@suse.com>","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>"}}]