[{"id":1386305,"web_url":"http://patchwork.ozlabs.org/comment/1386305/","msgid":"<20160621212238.GA5809@piout.net>","list_archive_url":null,"date":"2016-06-21T21:22:38","subject":"[rtc-linux] Re: [PATCH v2 13/17] RTC: ds1307: Report oscillator\n\tproblems more intelligently","submitter":{"id":26276,"url":"http://patchwork.ozlabs.org/api/people/26276/","name":"Alexandre Belloni","email":"alexandre.belloni@free-electrons.com"},"content":"On 21/06/2016 at 00:22:46 -0700, Andrey Smirnov wrote :\n> Report oscillator problems more intelligently, by printing more\n> information about what cause the issue and not yelling \"SET TIME!\" at\n> the user.\n> \n\nWell, the proper way of doing that is to ensure that -EINVAL is returned\nwhen reading the time until it has been set once instead of starting the\noscillator and forgetting about that useful information.\n\n> Signed-off-by: Andrey Smirnov \n> ---\n> drivers/rtc/rtc-ds1307.c | 28 +++++++++++++++++++++++-----\n> 1 file changed, 23 insertions(+), 5 deletions(-)\n> \n> diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c\n> index 2af9c00..2169e5b 100644\n> --- a/drivers/rtc/rtc-ds1307.c\n> +++ b/drivers/rtc/rtc-ds1307.c\n> @@ -1424,6 +1424,19 @@ static int ds1307_chip_configure(const struct ds1307 *ds1307)\n> \treturn 0;\n> }\n> \n> +static void ds1307_report_clock_halt(const struct ds1307 *ds1307)\n> +{\n> +\tdev_warn(&ds1307->client->dev, \"RTC's oscillator is turned off. \"\n> +\t\t \"Turning it on. Please set time\");\n> +}\n> +\n> +static void ds1307_report_oscillator_fault(const struct ds1307 *ds1307)\n> +{\n> +\tdev_warn(&ds1307->client->dev, \"RTC's reported oscillator fault. \"\n> +\t\t \"Clearing the fault flag and re-reading RTC status. \"\n> +\t\t \"Please set time\");\n> +}\n> +\n> static int ds1307_chip_sanity_check(const struct ds1307 *ds1307)\n> {\n> \tint tmp, retries;\n> @@ -1453,7 +1466,7 @@ static int ds1307_chip_sanity_check(const struct ds1307 *ds1307)\n> \t\t\tif (tmp & DS1307_BIT_CH) {\n> \t\t\t\ti2c_smbus_write_byte_data(client,\n> \t\t\t\t\t\t\t DS1307_REG_SECS, 0);\n> -\t\t\t\tdev_warn(&client->dev, \"SET TIME!\\n\");\n> +\t\t\t\tds1307_report_clock_halt(ds1307);\n> \t\t\t\tcontinue;\n> \t\t\t}\n> \t\t\tbreak;\n> @@ -1469,15 +1482,17 @@ static int ds1307_chip_sanity_check(const struct ds1307 *ds1307)\n> \t\t\t\t\t\t\t DS1307_REG_CONTROL,\n> \t\t\t\t\t\t\t regs[DS1307_REG_CONTROL]\n> \t\t\t\t\t\t\t & ~DS1338_BIT_OSF);\n> -\t\t\t\tdev_warn(&client->dev, \"SET TIME!\\n\");\n> +\t\t\t\tds1307_report_oscillator_fault(ds1307);\n> \t\t\t\tcontinue;\n> \t\t\t}\n> \t\t\tbreak;\n> \t\tcase ds_1340:\n> \t\t\t/* clock halted? turn it on, so clock can tick. */\n> -\t\t\tif (tmp & DS1340_BIT_nEOSC)\n> +\t\t\tif (tmp & DS1340_BIT_nEOSC) {\n> \t\t\t\ti2c_smbus_write_byte_data(client,\n> \t\t\t\t\t\t\t DS1307_REG_SECS, 0);\n> +\t\t\t\tds1307_report_clock_halt(ds1307);\n> +\t\t\t}\n> \n> \t\t\ttmp = i2c_smbus_read_byte_data(client, DS1340_REG_FLAG);\n> \t\t\tif (tmp < 0) {\n> @@ -1489,7 +1504,7 @@ static int ds1307_chip_sanity_check(const struct ds1307 *ds1307)\n> \t\t\tif (tmp & DS1340_BIT_OSF) {\n> \t\t\t\ti2c_smbus_write_byte_data(client,\n> \t\t\t\t\t\t\t DS1340_REG_FLAG, 0);\n> -\t\t\t\tdev_warn(&client->dev, \"SET TIME!\\n\");\n> +\t\t\t\tds1307_report_oscillator_fault(ds1307);\n> \t\t\t}\n> \t\t\treturn 0;\n> \n> @@ -1500,6 +1515,9 @@ static int ds1307_chip_sanity_check(const struct ds1307 *ds1307)\n> \t\t\t\t\t\t\t DS1307_REG_WDAY,\n> \t\t\t\t\t\t\t regs[DS1307_REG_WDAY]\n> \t\t\t\t\t\t\t | MCP794XX_BIT_VBATEN);\n> +\t\t\t\tdev_warn(&client->dev,\n> +\t\t\t\t\t \"battery backup was disabled. \"\n> +\t\t\t\t\t \"Re-enabling it\\n\");\n> \t\t\t}\n> \n> \t\t\t/* clock halted? turn it on, so clock can tick. */\n> @@ -1507,7 +1525,7 @@ static int ds1307_chip_sanity_check(const struct ds1307 *ds1307)\n> \t\t\t\ti2c_smbus_write_byte_data(client,\n> \t\t\t\t\t\t\t DS1307_REG_SECS,\n> \t\t\t\t\t\t\t MCP794XX_BIT_ST);\n> -\t\t\t\tdev_warn(&client->dev, \"SET TIME!\\n\");\n> +\t\t\t\tds1307_report_clock_halt(ds1307);\n> \t\t\t\tcontinue;\n> \t\t\t}\n> \n> -- \n> 2.5.5\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Received":["from mail-lf0-x23a.google.com (mail-lf0-x23a.google.com\n\t[IPv6:2a00:1450:4010:c07::23a])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rZ10M1N2tz9sR8\n\tfor ;\n\tWed, 22 Jun 2016 07:22:42 +1000 (AEST)","by mail-lf0-x23a.google.com with SMTP id a4sf13136385lfa.0\n\tfor ;\n\tTue, 21 Jun 2016 14:22:42 -0700 (PDT)","by 10.28.133.68 with SMTP id h65ls209227wmd.19.canary; Tue, 21 Jun\n\t2016 14:22:39 -0700 (PDT)","from mail.free-electrons.com (down.free-electrons.com.\n\t[37.187.137.238]) by gmr-mx.google.com with ESMTP id\n\tf4si207768wmg.0.2016.06.21.14.22.39\n\tfor ;\n\tTue, 21 Jun 2016 14:22:39 -0700 (PDT)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 967772B0; Tue, 21 Jun 2016 23:22:38 +0200 (CEST)","from localhost (unknown [88.191.26.124])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 69D9C202;\n\tTue, 21 Jun 2016 23:22:38 +0200 (CEST)"],"Authentication-Results":"ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=ntp94tXz; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20120806;\n\th=sender:date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent:x-original-sender\n\t:x-original-authentication-results:reply-to:precedence:mailing-list\n\t:list-id:x-spam-checked-in-group:list-post:list-help:list-archive\n\t:list-subscribe:list-unsubscribe;\n\tbh=ZoE5xdMYheQBkXNlMijb7Lcw0oQZHwoz7YOxRPDzy+c=;\n\tb=ntp94tXz9aTfoHb3DuMqizArEbq0RSGc5akOF+GWhw5xdt6ephCr+JuZixo/31bFzu\n\toTf+FL0Uwp3InaT3wDkrVER/DRDglHoujXv9rrXAfiz+n+yd7Tu/gSddmigI+hGTE41C\n\tOx5Y1KovFQn3DO7JA+e7CRJ9vWuadB1p1UGhIQ1szW2XSft3mDEpbd3tKRNhdfuMSYGd\n\tax6Ne5pCfdlrnQU3YADd0EuzGgoaluYb4IoRCwik1v4yacuz8ABwzdd6LjMWqjZBOt0n\n\tEjAWTtSMnfmrAtvWS2PBPZ6jIqsx0wa3w/HR+8jVPbpeb+ClTHAT1Ho3BwPTfzlRb3qj\n\tP4Zg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=sender:x-gm-message-state:date:from:to:cc:subject:message-id\n\t:references:mime-version:content-disposition:in-reply-to:user-agent\n\t:x-original-sender:x-original-authentication-results:reply-to\n\t:precedence:mailing-list:list-id:x-spam-checked-in-group:list-post\n\t:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=ZoE5xdMYheQBkXNlMijb7Lcw0oQZHwoz7YOxRPDzy+c=;\n\tb=BVi8UjBqwV1fmtccD17ygMWYPizn3PGDEe+27lCjF5bgy6lkDIO43wx2w+n4m5AqZ+\n\tJ+GCBQq4lP6MygI0Ar4GTIz6Di790v+LvjiQWW6BqKGR6FepsSaG3j1nPwL1WGRJ4FaA\n\tZlwHQGhzF57RS0kcP5+0QEnC+X63j0qCiC+PlPybv9E9E0RKhh2fUUFZqPeniGoJVTEN\n\tpuJOclqH+wHCVGXvweCIvhizuL1Ijyomv5W/sjfUYwli+8+9NOOSPeDVyuUzgbgW5Bbh\n\tOa1wKjIPzsNg6Tl8KegWXcXEnFt6uaZPsWugiK2/uT6rc4tCvwzKC/NxUXxwLLz1tUtB\n\t5R9g==","Sender":"rtc-linux@googlegroups.com","X-Gm-Message-State":"ALyK8tJ6eO6OF7mk+H+84qRUq9s8BgK6BD/XBXz+cHZJnhoackOluzEZQRshf3ISZfcHgw==","X-Received":["by 10.28.29.15 with SMTP id d15mr40252wmd.10.1466544159736;\n\tTue, 21 Jun 2016 14:22:39 -0700 (PDT)","by 10.28.25.66 with SMTP id 63mr1016149wmz.4.1466544159345;\n\tTue, 21 Jun 2016 14:22:39 -0700 (PDT)"],"X-BeenThere":"rtc-linux@googlegroups.com","Received-SPF":"pass (google.com: domain of\n\talexandre.belloni@free-electrons.com designates\n\t37.187.137.238 as permitted sender) client-ip=37.187.137.238; ","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT\n\tshortcircuit=ham autolearn=disabled version=3.4.0","Date":"Tue, 21 Jun 2016 23:22:38 +0200","From":"Alexandre Belloni ","To":"Andrey Smirnov ","Cc":"rtc-linux@googlegroups.com, Alessandro Zummo ,\n\tlinux-kernel@vger.kernel.org, cphealy@gmail.com","Subject":"[rtc-linux] Re: [PATCH v2 13/17] RTC: ds1307: Report oscillator\n\tproblems more intelligently","Message-ID":"<20160621212238.GA5809@piout.net>","References":"<1466493770-11895-1-git-send-email-andrew.smirnov@gmail.com>\n\t<1466493770-11895-12-git-send-email-andrew.smirnov@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Disposition":"inline","In-Reply-To":"<1466493770-11895-12-git-send-email-andrew.smirnov@gmail.com>","User-Agent":"Mutt/1.6.0 (2016-04-01)","X-Original-Sender":"alexandre.belloni@free-electrons.com","X-Original-Authentication-Results":"gmr-mx.google.com; spf=pass\n\t(google.com: domain of alexandre.belloni@free-electrons.com\n\tdesignates\n\t37.187.137.238 as permitted sender)\n\tsmtp.mailfrom=alexandre.belloni@free-electrons.com","Reply-To":"rtc-linux@googlegroups.com","Precedence":"list","Mailing-list":"list rtc-linux@googlegroups.com;\n\tcontact rtc-linux+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"rtc-linux@googlegroups.com","X-Google-Group-Id":"712029733259","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"}},{"id":1386393,"web_url":"http://patchwork.ozlabs.org/comment/1386393/","msgid":"","list_archive_url":null,"date":"2016-06-21T23:06:11","subject":"[rtc-linux] Re: [PATCH v2 13/17] RTC: ds1307: Report oscillator\n\tproblems more intelligently","submitter":{"id":67013,"url":"http://patchwork.ozlabs.org/api/people/67013/","name":"Andrey Smirnov","email":"andrew.smirnov@gmail.com"},"content":"On Tue, Jun 21, 2016 at 2:22 PM, Alexandre Belloni\n wrote:\n> On 21/06/2016 at 00:22:46 -0700, Andrey Smirnov wrote :\n>> Report oscillator problems more intelligently, by printing more\n>> information about what cause the issue and not yelling \"SET TIME!\" at\n>> the user.\n>>\n>\n> Well, the proper way of doing that is to ensure that -EINVAL is returned\n> when reading the time until it has been set once instead of starting the\n> oscillator and forgetting about that useful information.\n\nAgreed, will change in v3.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Received":["from mail-pa0-x23b.google.com (mail-pa0-x23b.google.com\n\t[IPv6:2607:f8b0:400e:c03::23b])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rZ3Hp4R4gz9sCp\n\tfor ;\n\tWed, 22 Jun 2016 09:06:14 +1000 (AEST)","by mail-pa0-x23b.google.com with SMTP id ts6sf13560008pac.1\n\tfor ;\n\tTue, 21 Jun 2016 16:06:13 -0700 (PDT)","by 10.157.14.213 with SMTP id 79ls4466004otj.38.gmail; Tue, 21 Jun\n\t2016 16:06:11 -0700 (PDT)","from mail-yw0-x22a.google.com (mail-yw0-x22a.google.com.\n\t[2607:f8b0:4002:c05::22a]) by gmr-mx.google.com with ESMTPS id\n\th76si1156958ywc.7.2016.06.21.16.06.11\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 21 Jun 2016 16:06:11 -0700 (PDT)","by mail-yw0-x22a.google.com with SMTP id v77so28010195ywg.0\n\tfor ;\n\tTue, 21 Jun 2016 16:06:11 -0700 (PDT)","by 10.83.35.205 with HTTP; Tue, 21 Jun 2016 16:06:11 -0700 (PDT)"],"Authentication-Results":"ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=tOgvg2i8; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=hRytYfFI;\n\tdkim-atps=neutral","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20120806;\n\th=sender:mime-version:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:x-original-sender:x-original-authentication-results\n\t:reply-to:precedence:mailing-list:list-id:x-spam-checked-in-group\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=ofogmKGpHI0paOex1zePV5Umb8t99Qb+ToSJnxs2Ecg=;\n\tb=tOgvg2i8Ui9OqvbH7eEgHiOxzTaUM+3D7/h8IShe6aXyTnpsE3lkjNTGkOHSBX3l4b\n\t704O2gc+LGWvS3QJwDAzplvL+ny6xMx+ZB1ABVjGUCdVhUlC/0n49jKEZF3YMBC3HQB0\n\tB3k8zO7hnKQVxeBanPYd3OX/N7QaRnZeWLZatx7jSgK0Z1velnI1+kLaX/3dXS/m6no9\n\tFVyJ0MFymTvgXq2K1MnUmWEKaNGQqrMlqfHv0lXtLVb/R5lekg1b4jayl5zkUgVq4BxW\n\tpG69LOj1rJ73hUfAGf9tV5hc/UHqy0Bz1WzC3UXGls3EKkK3TOPJJVH3SeOk3YnV1BXB\n\tnKIQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20120113;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:x-original-sender:x-original-authentication-results:reply-to\n\t:precedence:mailing-list:list-id:x-spam-checked-in-group:list-post\n\t:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=ofogmKGpHI0paOex1zePV5Umb8t99Qb+ToSJnxs2Ecg=;\n\tb=hRytYfFIRX5N2rjT3kKRNrVI8YOS7cTI5ODEYggxGwIPwIWVBg9PDqcTQJ0l6tGXGB\n\tFYXMBgUelVW7qfpiu06Gu4u4xE5Vcu6UbEnPleCkpIlCrBfh/XY5R2Ozb8fcAfXdnrFn\n\tSTkMPGA9nBAKZgjGywcJ9C7bsaKEMSLKtO9qEaRJhY01xR8n32ybNZgIcFmg9yNl3XAu\n\tpjNM4W+0V6RyzgwbX9pxtPHmqY4368YJwXtfKjfeCR5ZDUFJUfuJKTqtNdtx6I7cLMQZ\n\tMLd3MsxM6yuwBCUIkvpjcjG/d8yBUDGgVWZPPGkOUfFlMQEsXBi7mmGR4Wc7/1h+uH/C\n\tBsjg=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=sender:x-gm-message-state:mime-version:in-reply-to:references:from\n\t:date:message-id:subject:to:cc:x-original-sender\n\t:x-original-authentication-results:reply-to:precedence:mailing-list\n\t:list-id:x-spam-checked-in-group:list-post:list-help:list-archive\n\t:list-subscribe:list-unsubscribe;\n\tbh=ofogmKGpHI0paOex1zePV5Umb8t99Qb+ToSJnxs2Ecg=;\n\tb=B/uN0+NoZOn6BLbtByJUiNIluLLXbAtIXFLuCimrOjUesmnz1FxvS4s8Bq6rdtxxfY\n\tHlH0IV+EXlPlf/p/1hmMQVY+Si8t04zkOmx0dkeGmvJiU/wQvqEkc+6JapS3E2amHC1c\n\tlSOwVPCwnQrTu9WhJtmtL7vAMJbwEtH3ZPZe+8G6Bne62XuYPZAqAVs52j7SWw0RRjg1\n\tZ4beRST4W0m6DdUhxGsO+8O5uQRF62d8XhTMxHOhsjaPtH68xxy9ScDM4LcNr8HclE6u\n\tTb2RA2dP1y8pUIscDq0lJ52igSWBjwPFSUBajMtgiuZ8PKOwjYZZs0hzOFxelWOd51jM\n\tKEAQ==","Sender":"rtc-linux@googlegroups.com","X-Gm-Message-State":"ALyK8tLpGNZtSqIUL0g8p75GaK6q5fOxL7zng0uGnbYZa2oHUbZ9QDNIyGOqdv19R3HIAQ==","X-Received":["by 10.157.11.173 with SMTP id 42mr557825oth.10.1466550372090;\n\tTue, 21 Jun 2016 16:06:12 -0700 (PDT)","by 10.157.38.150 with SMTP id l22mr25794642otb.28.1466550371782; \n\tTue, 21 Jun 2016 16:06:11 -0700 (PDT)","by 10.13.213.143 with SMTP id\n\tx137mr13387656ywd.253.1466550371463; \n\tTue, 21 Jun 2016 16:06:11 -0700 (PDT)"],"X-BeenThere":"rtc-linux@googlegroups.com","Received-SPF":"pass (google.com: domain of andrew.smirnov@gmail.com\n\tdesignates 2607:f8b0:4002:c05::22a as permitted sender)\n\tclient-ip=2607:f8b0:4002:c05::22a; ","MIME-Version":"1.0","In-Reply-To":"<20160621212238.GA5809@piout.net>","References":"<1466493770-11895-1-git-send-email-andrew.smirnov@gmail.com>\n\t<1466493770-11895-12-git-send-email-andrew.smirnov@gmail.com>\n\t<20160621212238.GA5809@piout.net>","From":"Andrey Smirnov ","Date":"Tue, 21 Jun 2016 16:06:11 -0700","Message-ID":"","Subject":"[rtc-linux] Re: [PATCH v2 13/17] RTC: ds1307: Report oscillator\n\tproblems more intelligently","To":"Alexandre Belloni ","Cc":"rtc-linux@googlegroups.com, Alessandro Zummo , \n\tlinux-kernel@vger.kernel.org, Chris Healy ","Content-Type":"text/plain; charset=UTF-8","X-Original-Sender":"andrew.smirnov@gmail.com","X-Original-Authentication-Results":"gmr-mx.google.com; dkim=pass\n\theader.i=@gmail.com; spf=pass (google.com: domain of\n\tandrew.smirnov@gmail.com designates 2607:f8b0:4002:c05::22a as\n\tpermitted\n\tsender) smtp.mailfrom=andrew.smirnov@gmail.com; dmarc=pass (p=NONE\n\tdis=NONE) header.from=gmail.com","Reply-To":"rtc-linux@googlegroups.com","Precedence":"list","Mailing-list":"list rtc-linux@googlegroups.com;\n\tcontact rtc-linux+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"rtc-linux@googlegroups.com","X-Google-Group-Id":"712029733259","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"}}]