[{"id":1386307,"web_url":"http://patchwork.ozlabs.org/comment/1386307/","msgid":"<20160621212629.GB5809@piout.net>","list_archive_url":null,"date":"2016-06-21T21:26:29","subject":"[rtc-linux] Re: [PATCH v2 01/17] RTC: ds1307: Add DS1341 variant","submitter":{"id":26276,"url":"http://patchwork.ozlabs.org/api/people/26276/","name":"Alexandre Belloni","email":"alexandre.belloni@free-electrons.com"},"content":"Please always include a commit message.\n\nOn 21/06/2016 at 00:20:50 -0700, Andrey Smirnov wrote :\n> Signed-off-by: Andrey Smirnov \n> ---\n> drivers/rtc/rtc-ds1307.c | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c\n> index 821d9c0..7e65e2e 100644\n> --- a/drivers/rtc/rtc-ds1307.c\n> +++ b/drivers/rtc/rtc-ds1307.c\n> @@ -35,6 +35,7 @@ enum ds_type {\n> \tds_1338,\n> \tds_1339,\n> \tds_1340,\n> +\tds_1341,\n> \tds_1388,\n> \tds_3231,\n> \tm41t00,\n> @@ -178,6 +179,7 @@ static const struct i2c_device_id ds1307_id[] = {\n> \t{ \"ds1337\", ds_1337 },\n> \t{ \"ds1338\", ds_1338 },\n> \t{ \"ds1339\", ds_1339 },\n> +\t{ \"ds1341\", ds_1341 },\n> \t{ \"ds1388\", ds_1388 },\n> \t{ \"ds1340\", ds_1340 },\n> \t{ \"ds3231\", ds_3231 },\n> @@ -424,6 +426,7 @@ static int ds1307_set_time(struct device *dev, struct rtc_time *t)\n> \tcase ds_1337:\n> \tcase ds_1339:\n> \tcase ds_3231:\n> +\tcase ds_1341:\n> \t\tbuf[DS1307_REG_MONTH] |= DS1337_BIT_CENTURY;\n> \t\tbreak;\n> \tcase ds_1340:\n> @@ -1242,6 +1245,7 @@ static int ds1307_probe(struct i2c_client *client,\n> \n> \tstatic const int\tbbsqi_bitpos[] = {\n> \t\t[ds_1337] = 0,\n> +\t\t[ds_1341] = 0,\n> \t\t[ds_1339] = DS1339_BIT_BBSQI,\n> \t\t[ds_3231] = DS3231_BIT_BBSQW,\n> \t};\n> @@ -1301,6 +1305,7 @@ static int ds1307_probe(struct i2c_client *client,\n> \tcase ds_1337:\n> \tcase ds_1339:\n> \tcase ds_3231:\n> +\tcase ds_1341:\n> \t\t/* get registers that the \"rtc\" read below won't read... */\n> \t\ttmp = ds1307->read_block_data(ds1307->client,\n> \t\t\t\tDS1337_REG_CONTROL, 2, buf);\n> -- \n> 2.5.5\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Received":["from mail-lf0-x237.google.com (mail-lf0-x237.google.com\n\t[IPv6:2a00:1450:4010:c07::237])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rZ14n5442z9sdg\n\tfor ;\n\tWed, 22 Jun 2016 07:26:33 +1000 (AEST)","by mail-lf0-x237.google.com with SMTP id a4sf13157639lfa.0\n\tfor ;\n\tTue, 21 Jun 2016 14:26:33 -0700 (PDT)","by 10.25.161.70 with SMTP id k67ls190789lfe.39.gmail; Tue, 21 Jun\n\t2016 14:26:30 -0700 (PDT)","from mail.free-electrons.com (down.free-electrons.com.\n\t[37.187.137.238]) by gmr-mx.google.com with ESMTP id\n\tx203si202711wme.0.2016.06.21.14.26.30\n\tfor ;\n\tTue, 21 Jun 2016 14:26:30 -0700 (PDT)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 8469530E; Tue, 21 Jun 2016 23:26:29 +0200 (CEST)","from localhost (unknown [88.191.26.124])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 5206F232;\n\tTue, 21 Jun 2016 23:26:29 +0200 (CEST)"],"Authentication-Results":"ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=yle55etl; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20120806;\n\th=sender:date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent:x-original-sender\n\t:x-original-authentication-results:reply-to:precedence:mailing-list\n\t:list-id:x-spam-checked-in-group:list-post:list-help:list-archive\n\t:list-subscribe:list-unsubscribe;\n\tbh=I/OJF/Mt9oc7HfnJbqtLt/zHX4yTOvBORiICpXzEPTA=;\n\tb=yle55etl9BArCQ9DOa17h1rQ7aM2rfOfVEVmPjtgF1OqWt9uOWWh8RVn+PVJri2cse\n\tVI9HpOS5h8StITN0b1IwMs+vci+zoSZjA4Hmk1fYTPI59ZUrKzFFORQGOl3kyd8xLy9+\n\t+ffdrbWBGDydwLeUz4GX9SIKBXxqeQad3EyELgd4kUw27S0Qxm8bD4NHH1pFIR3dXz6s\n\tT0VFSg/g8yNtSju8yv0P9enXVQIzYck7MGXFfOYZLvWmXII7dis1Ojh4pIKAuJBQb5hr\n\tEAuIDPzGGxO2vYvgQS//Dh1mm7RnIdo0zPsn3xr1DWtewaBt5r7jMrzlvg5M++vuScRq\n\trqcg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=sender:x-gm-message-state:date:from:to:cc:subject:message-id\n\t:references:mime-version:content-disposition:in-reply-to:user-agent\n\t:x-original-sender:x-original-authentication-results:reply-to\n\t:precedence:mailing-list:list-id:x-spam-checked-in-group:list-post\n\t:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=I/OJF/Mt9oc7HfnJbqtLt/zHX4yTOvBORiICpXzEPTA=;\n\tb=lI6+Nc6N9aIVLSXvT4rlDmlF+0WbiAf1QpeTa1Jruscc/s+7HFeHnGudOZngAZ4T1r\n\tKxW8Kxrbx4gzirsVMo4rxTYzevcFoRNrLbmiZ5urDV0zAS7BWPibm3iaL5itNmLwQB7m\n\txO9NE0fxsewDuqFib/0v2dWtTi3YUstoQpwcEZELm7Ig5drWRaIrePoCVrQRmE4KgMgC\n\tHjG2BW8dQ9BkVSVjvrYo87aQk9dqv8H9PAeBWEaBAaqjiR6XsIwk7Cr8NhWn80u2Mc44\n\tLt7ZzK+BBcThZraUWc2QX9+3bdp0jZvOP7v3xordNBw35WM0HaK+Q74lLsA0ZXT0At7f\n\taOXw==","Sender":"rtc-linux@googlegroups.com","X-Gm-Message-State":"ALyK8tI3OlvJh4Pw4CcvXpjY6Klj6JNmgDUu+76PDmmrFbhb+SX442HucmPzfSz461YgpQ==","X-Received":["by 10.25.196.16 with SMTP id u16mr108649lff.15.1466544390962;\n\tTue, 21 Jun 2016 14:26:30 -0700 (PDT)","by 10.46.1.134 with SMTP id f6mr4876071lji.6.1466544390143;\n\tTue, 21 Jun 2016 14:26:30 -0700 (PDT)"],"X-BeenThere":"rtc-linux@googlegroups.com","Received-SPF":"pass (google.com: domain of\n\talexandre.belloni@free-electrons.com designates\n\t37.187.137.238 as permitted sender) client-ip=37.187.137.238; ","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT\n\tshortcircuit=ham autolearn=disabled version=3.4.0","Date":"Tue, 21 Jun 2016 23:26:29 +0200","From":"Alexandre Belloni ","To":"Andrey Smirnov ","Cc":"rtc-linux@googlegroups.com, Alessandro Zummo ,\n\tlinux-kernel@vger.kernel.org, cphealy@gmail.com","Subject":"[rtc-linux] Re: [PATCH v2 01/17] RTC: ds1307: Add DS1341 variant","Message-ID":"<20160621212629.GB5809@piout.net>","References":"<1466493650-11509-1-git-send-email-andrew.smirnov@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Disposition":"inline","In-Reply-To":"<1466493650-11509-1-git-send-email-andrew.smirnov@gmail.com>","User-Agent":"Mutt/1.6.0 (2016-04-01)","X-Original-Sender":"alexandre.belloni@free-electrons.com","X-Original-Authentication-Results":"gmr-mx.google.com; spf=pass\n\t(google.com: domain of alexandre.belloni@free-electrons.com\n\tdesignates\n\t37.187.137.238 as permitted sender)\n\tsmtp.mailfrom=alexandre.belloni@free-electrons.com","Reply-To":"rtc-linux@googlegroups.com","Precedence":"list","Mailing-list":"list rtc-linux@googlegroups.com;\n\tcontact rtc-linux+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"rtc-linux@googlegroups.com","X-Google-Group-Id":"712029733259","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"}},{"id":1386404,"web_url":"http://patchwork.ozlabs.org/comment/1386404/","msgid":"","list_archive_url":null,"date":"2016-06-21T23:28:08","subject":"[rtc-linux] Re: [PATCH v2 01/17] RTC: ds1307: Add DS1341 variant","submitter":{"id":67013,"url":"http://patchwork.ozlabs.org/api/people/67013/","name":"Andrey Smirnov","email":"andrew.smirnov@gmail.com"},"content":"On Tue, Jun 21, 2016 at 2:26 PM, Alexandre Belloni\n wrote:\n> Please always include a commit message.\n\nOK, will fix in v3\n\n>\n> On 21/06/2016 at 00:20:50 -0700, Andrey Smirnov wrote :\n>> Signed-off-by: Andrey Smirnov \n>> ---\n>> drivers/rtc/rtc-ds1307.c | 5 +++++\n>> 1 file changed, 5 insertions(+)\n>>\n>> diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c\n>> index 821d9c0..7e65e2e 100644\n>> --- a/drivers/rtc/rtc-ds1307.c\n>> +++ b/drivers/rtc/rtc-ds1307.c\n>> @@ -35,6 +35,7 @@ enum ds_type {\n>> ds_1338,\n>> ds_1339,\n>> ds_1340,\n>> + ds_1341,\n>> ds_1388,\n>> ds_3231,\n>> m41t00,\n>> @@ -178,6 +179,7 @@ static const struct i2c_device_id ds1307_id[] = {\n>> { \"ds1337\", ds_1337 },\n>> { \"ds1338\", ds_1338 },\n>> { \"ds1339\", ds_1339 },\n>> + { \"ds1341\", ds_1341 },\n>> { \"ds1388\", ds_1388 },\n>> { \"ds1340\", ds_1340 },\n>> { \"ds3231\", ds_3231 },\n>> @@ -424,6 +426,7 @@ static int ds1307_set_time(struct device *dev, struct rtc_time *t)\n>> case ds_1337:\n>> case ds_1339:\n>> case ds_3231:\n>> + case ds_1341:\n>> buf[DS1307_REG_MONTH] |= DS1337_BIT_CENTURY;\n>> break;\n>> case ds_1340:\n>> @@ -1242,6 +1245,7 @@ static int ds1307_probe(struct i2c_client *client,\n>>\n>> static const int bbsqi_bitpos[] = {\n>> [ds_1337] = 0,\n>> + [ds_1341] = 0,\n>> [ds_1339] = DS1339_BIT_BBSQI,\n>> [ds_3231] = DS3231_BIT_BBSQW,\n>> };\n>> @@ -1301,6 +1305,7 @@ static int ds1307_probe(struct i2c_client *client,\n>> case ds_1337:\n>> case ds_1339:\n>> case ds_3231:\n>> + case ds_1341:\n>> /* get registers that the \"rtc\" read below won't read... */\n>> tmp = ds1307->read_block_data(ds1307->client,\n>> DS1337_REG_CONTROL, 2, buf);\n>> --\n>> 2.5.5\n>>\n>\n> --\n> Alexandre Belloni, Free Electrons\n> Embedded Linux, Kernel and Android engineering\n> http://free-electrons.com","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Received":["from mail-oi0-x23d.google.com (mail-oi0-x23d.google.com\n\t[IPv6:2607:f8b0:4003:c06::23d])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rZ3n86CZsz9sDk\n\tfor ;\n\tWed, 22 Jun 2016 09:28:12 +1000 (AEST)","by mail-oi0-x23d.google.com with SMTP id t8sf2172726oif.0\n\tfor ;\n\tTue, 21 Jun 2016 16:28:12 -0700 (PDT)","by 10.157.44.155 with SMTP id p27ls4322854otb.60.gmail; Tue, 21 Jun\n\t2016 16:28:09 -0700 (PDT)","from mail-yw0-x242.google.com (mail-yw0-x242.google.com.\n\t[2607:f8b0:4002:c05::242]) by gmr-mx.google.com with ESMTPS id\n\tc2si3966549ywf.5.2016.06.21.16.28.09\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 21 Jun 2016 16:28:09 -0700 (PDT)","by mail-yw0-x242.google.com with SMTP id i12so3918297ywa.0\n\tfor ;\n\tTue, 21 Jun 2016 16:28:09 -0700 (PDT)","by 10.83.35.205 with HTTP; Tue, 21 Jun 2016 16:28:08 -0700 (PDT)"],"Authentication-Results":"ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=c3AYBTM0; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=BoojB1Jz;\n\tdkim-atps=neutral","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20120806;\n\th=sender:mime-version:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:x-original-sender:x-original-authentication-results\n\t:reply-to:precedence:mailing-list:list-id:x-spam-checked-in-group\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=6pDfs09xj3bq8xxjB/nvqM0ZXqKuXl5PFv2MjGNnp64=;\n\tb=c3AYBTM0IdlH7hjs0Z7Q3APkLma4YSxKbNhZhdnw8gG6/bfP1mkxllHH+PzUFovLY0\n\tEK7iEP1gCPeYqvPI+xY0pV/q0Ek8Sciri42w/4Q26Ig5jMbY0WgLpgGSigElm0vBNuaG\n\tQcte6YdP56LOz1xP3f0LNjS+O+FP126Wn46jqUgjLpWqdGKfoGF8LBC4a9Lej3ky2YVr\n\tlAZ7RvZdOT128uVZ/uCYAV/ndJXXzlqupyg+MpU7s2Lucu0zuNY1VxkMRownf078qmuC\n\tvVGb0d17c3GNTsB+4ODBccnPaH6ImFaNSkujE/xlQkirNrg6n0DxJTcEk1aQ54g9uRp2\n\tN2Uw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20120113;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:x-original-sender:x-original-authentication-results:reply-to\n\t:precedence:mailing-list:list-id:x-spam-checked-in-group:list-post\n\t:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=6pDfs09xj3bq8xxjB/nvqM0ZXqKuXl5PFv2MjGNnp64=;\n\tb=BoojB1JzO/oLCNtelcUZD9PKjrSYkPk/yUqTpro0upQBcglCCXaQ/fbI3GpokelVWO\n\tPDuqxNSJ8LfqiCJnhYDOTmGGu9W2u3/4G1x2DXxlucw4sMwBNa7F3/BTmUeiT0FL920T\n\tFcVfIdlsknTTFLDKPSoVJDTY1BZn9A20kuJuqnIjmNYsy6pObpqAwmglgPggFwLOYbhG\n\tGWz7+ksy826RygAhUSpdKkqMA9ceXvyerKnzQz9XmfdKlV8sZuk2WQ3W6sNFFr+JPbRy\n\tuhD6k2AjbrDVY3qckjfRk+YKAM3Jow/uX8UUKGqINkPD6pSUbnyekG61zM4gsz8Lwfhv\n\t645w=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=sender:x-gm-message-state:mime-version:in-reply-to:references:from\n\t:date:message-id:subject:to:cc:x-original-sender\n\t:x-original-authentication-results:reply-to:precedence:mailing-list\n\t:list-id:x-spam-checked-in-group:list-post:list-help:list-archive\n\t:list-subscribe:list-unsubscribe;\n\tbh=6pDfs09xj3bq8xxjB/nvqM0ZXqKuXl5PFv2MjGNnp64=;\n\tb=h2xVeHqNRUWkyNCJFwhLml6k/6Un0QNkwEaqposb6NvVSUjSXzK/PdDm2BPvrZnU0o\n\tkaVUquceFy6MiyXRMicTNMjovyjWYHEjQESbyTvuTF2mw45OLcofxFEw8rgdmg894pgt\n\tLRA45uGP7l1dFLKKLMMbDybBksWt0OEeWMwIcxDUUHYmBgamf+/Dhfy/BNWjIWj5dlYD\n\tnMJszGopmeeQfstsa1OeqYsYyV6Z+rTqMVmKze0Ki513FUaOZCDJVK8G2+V3++5AOGDg\n\tHNwnVFfM8TZQVPT6GgAai6so4IX+IaRCKEeltYxQ/b25Xa0mHxPBT62rtozdSl5ZrK5Z\n\tZbDg==","Sender":"rtc-linux@googlegroups.com","X-Gm-Message-State":"ALyK8tKIskLain+6mmqGhFq2MYobf13PEBx6Ay1KcPldpd3gx8fFx2pspZCnYpWWkO4i4A==","X-Received":["by 10.157.9.102 with SMTP id 93mr904526otp.8.1466551689693;\n\tTue, 21 Jun 2016 16:28:09 -0700 (PDT)","by 10.237.34.131 with SMTP id p3mr29231380qtc.19.1466551689467; \n\tTue, 21 Jun 2016 16:28:09 -0700 (PDT)","by 10.37.78.193 with SMTP id c184mr12872819ybb.10.1466551689260; \n\tTue, 21 Jun 2016 16:28:09 -0700 (PDT)"],"X-BeenThere":"rtc-linux@googlegroups.com","Received-SPF":"pass (google.com: domain of andrew.smirnov@gmail.com\n\tdesignates 2607:f8b0:4002:c05::242 as permitted sender)\n\tclient-ip=2607:f8b0:4002:c05::242; ","MIME-Version":"1.0","In-Reply-To":"<20160621212629.GB5809@piout.net>","References":"<1466493650-11509-1-git-send-email-andrew.smirnov@gmail.com>\n\t<20160621212629.GB5809@piout.net>","From":"Andrey Smirnov ","Date":"Tue, 21 Jun 2016 16:28:08 -0700","Message-ID":"","Subject":"[rtc-linux] Re: [PATCH v2 01/17] RTC: ds1307: Add DS1341 variant","To":"Alexandre Belloni ","Cc":"rtc-linux@googlegroups.com, Alessandro Zummo , \n\tlinux-kernel@vger.kernel.org, Chris Healy ","Content-Type":"text/plain; charset=UTF-8","X-Original-Sender":"andrew.smirnov@gmail.com","X-Original-Authentication-Results":"gmr-mx.google.com; dkim=pass\n\theader.i=@gmail.com; spf=pass (google.com: domain of\n\tandrew.smirnov@gmail.com designates 2607:f8b0:4002:c05::242 as\n\tpermitted\n\tsender) smtp.mailfrom=andrew.smirnov@gmail.com; dmarc=pass (p=NONE\n\tdis=NONE) header.from=gmail.com","Reply-To":"rtc-linux@googlegroups.com","Precedence":"list","Mailing-list":"list rtc-linux@googlegroups.com;\n\tcontact rtc-linux+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"rtc-linux@googlegroups.com","X-Google-Group-Id":"712029733259","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"}}]