[{"id":1290816,"web_url":"http://patchwork.ozlabs.org/comment/1290816/","msgid":"","date":"2016-03-07T23:47:47","subject":"Re: [PATCH] dma driver: fix potential oom issue of fsldma","submitter":{"id":69,"url":"http://patchwork.ozlabs.org/api/people/69/","name":"Yang Li","email":"leoli@freescale.com"},"content":"The change looks to be correct. But we need better formatting and description.\n\nMake the title something like:\n\ndmaengine: fsldma: fix memory leak\n\nOn Thu, Dec 24, 2015 at 1:26 AM, Xuelin Shi wrote:\n> From: Xuelin Shi \n>\n> missing unmap sources and destinations while doing dequeue.\n\nHow can this describe your change?\n\nRegards,\nLeo\n>\n> Signed-off-by: Xuelin Shi \n> ---\n> drivers/dma/fsldma.c | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c\n> index 2209f75..aac85c3 100644\n> --- a/drivers/dma/fsldma.c\n> +++ b/drivers/dma/fsldma.c\n> @@ -522,6 +522,8 @@ static dma_cookie_t fsldma_run_tx_complete_actions(struct fsldma_chan *chan,\n> chan_dbg(chan, \"LD %p callback\\n\", desc);\n> txd->callback(txd->callback_param);\n> }\n> +\n> + dma_descriptor_unmap(txd);\n> }\n>\n> /* Run any dependencies */\n> --\n> 1.8.4\n>\n> _______________________________________________\n> Linuxppc-dev mailing list\n> Linuxppc-dev@lists.ozlabs.org\n> https://lists.ozlabs.org/listinfo/linuxppc-dev","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id D2A841402A8\n\tfor ;\n\tTue, 8 Mar 2016 10:49:22 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 8F9D61A0B72\n\tfor ;\n\tTue, 8 Mar 2016 10:49:22 +1100 (AEDT)","from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com\n\t[IPv6:2a00:1450:400c:c09::22c])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 23F881A01EB\n\tfor ;\n\tTue, 8 Mar 2016 10:47:53 +1100 (AEDT)","by mail-wm0-x22c.google.com with SMTP id n186so108671740wmn.1\n\tfor ;\n\tMon, 07 Mar 2016 15:47:53 -0800 (PST)","by 10.194.11.38 with HTTP; Mon, 7 Mar 2016 15:47:47 -0800 (PST)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=DBpS7VAO;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=DBpS7VAO;\n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=DBpS7VAO;\n\tdkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=mime-version:sender:in-reply-to:references:date:message-id:subject\n\t:from:to:cc; bh=cn/QyxWSrtSNJ2D+1XJRbJbN9+4prFb0y4x+TAikBmo=;\n\tb=DBpS7VAO6yncjZR3CszbJnHg0afrPP5qZ2pEDLdP91p98FYqGKhrHca9hp25CG7qje\n\tMP05oO68jcFn1LuPvhVQwBFShPomK2TebbIqvkI+iH5myP2Vceu2GXlmN1FpKBTa4OEx\n\t/gLRaFJ/cAHNp00z0wJi3u2rz3F9LqTBwlBUokacebom/kz0a+KCmPwspnfFOJpCgUNG\n\tmKfSeBRpxG/RR2nXN6coE7HbmGlvgPAIDMAqNrHU8i9LYYmGsKsdy7t2EAZwZJHv1miZ\n\tatKx5ejoSj/Wc+7wDEYw2wRxRyfLhfBwQqFvxZR0vjN0kxU1OELR6DRAp4TZGpzSc4Z8\n\t06fQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:date\n\t:message-id:subject:from:to:cc;\n\tbh=cn/QyxWSrtSNJ2D+1XJRbJbN9+4prFb0y4x+TAikBmo=;\n\tb=NvUtHxtWj/UYpNECUNTh1pab9jhpeFJd+W4bYo2cYHvXkRi1elg0xTZ4uqhs5FskXV\n\tc7gb1G1E/5P/EwGtyr3VkLWLQ3TTQ9N7Iosly8dnteBFXkQD8PLRv+GWUz14NQqZGfxh\n\tT6xr49tL9fxflr8As0ZNsvriu7vbfZsXVegUKPp0xc32tnVsMqFi0vuomTzRC9xLx2DC\n\t/TOoK1UlIHKUrKSIouak1iXIHD82IA3SWnt4XHQrsmfVF22z4TSrX9Uj9TmV9wMvRb6g\n\tNHlACW8Ye4CUOQ0oNPvFiRaxu7bU1HQ8Dmjuy6A5DaPByZseuK2a3rOz7pbAxHobF65I\n\ttpww==","X-Gm-Message-State":"AD7BkJITkkiD7K4UB6NzOgpLeSNoSlBdDX273pyJdKfQkIlSA0eNtmLEhCIpex8FDJQeqpxs171MEg00Qz1pTg==","MIME-Version":"1.0","X-Received":"by 10.28.59.212 with SMTP id i203mr15099433wma.69.1457394467804; \n\tMon, 07 Mar 2016 15:47:47 -0800 (PST)","In-Reply-To":"<1450941981-11900-1-git-send-email-xuelin.shi@nxp.com>","References":"<1450941981-11900-1-git-send-email-xuelin.shi@nxp.com>","Date":"Mon, 7 Mar 2016 17:47:47 -0600","X-Google-Sender-Auth":"UIgfpudOMgt0SN3kTN6z82FyFCM","Message-ID":"","Subject":"Re: [PATCH] dma driver: fix potential oom issue of fsldma","From":"Li Yang ","To":"Xuelin Shi ","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Xuelin Shi ,\n\tlinuxppc-dev ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1290818,"web_url":"http://patchwork.ozlabs.org/comment/1290818/","msgid":"","date":"2016-03-07T23:49:19","subject":"Re: [PATCH] dma driver: fix potential oom issue of fsldma","submitter":{"id":69,"url":"http://patchwork.ozlabs.org/api/people/69/","name":"Yang Li","email":"leoli@freescale.com"},"content":"On Thu, Dec 24, 2015 at 1:26 AM, Xuelin Shi wrote:\n> From: Xuelin Shi \n\nAnd please cc dmaengine maintainers and its mailing list when you send\nnext version.\n\n>\n> missing unmap sources and destinations while doing dequeue.\n>\n> Signed-off-by: Xuelin Shi \n> ---\n> drivers/dma/fsldma.c | 2 ++\n> 1 file changed, 2 insertions(+)\n>\n> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c\n> index 2209f75..aac85c3 100644\n> --- a/drivers/dma/fsldma.c\n> +++ b/drivers/dma/fsldma.c\n> @@ -522,6 +522,8 @@ static dma_cookie_t fsldma_run_tx_complete_actions(struct fsldma_chan *chan,\n> chan_dbg(chan, \"LD %p callback\\n\", desc);\n> txd->callback(txd->callback_param);\n> }\n> +\n> + dma_descriptor_unmap(txd);\n> }\n>\n> /* Run any dependencies */\n> --\n> 1.8.4\n>\n> _______________________________________________\n> Linuxppc-dev mailing list\n> Linuxppc-dev@lists.ozlabs.org\n> https://lists.ozlabs.org/listinfo/linuxppc-dev","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id E23F61402A8\n\tfor ;\n\tTue, 8 Mar 2016 10:51:12 +1100 (AEDT)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id B80041A0365\n\tfor ;\n\tTue, 8 Mar 2016 10:51:12 +1100 (AEDT)","from mail-wm0-x229.google.com (mail-wm0-x229.google.com\n\t[IPv6:2a00:1450:400c:c09::229])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 087391A0B73\n\tfor ;\n\tTue, 8 Mar 2016 10:49:23 +1100 (AEDT)","by mail-wm0-x229.google.com with SMTP id p65so6355585wmp.0\n\tfor ;\n\tMon, 07 Mar 2016 15:49:22 -0800 (PST)","by 10.194.11.38 with HTTP; Mon, 7 Mar 2016 15:49:19 -0800 (PST)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=KSEGVUQf;\n\tdkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=KSEGVUQf;\n\tdkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=KSEGVUQf;\n\tdkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=mime-version:sender:in-reply-to:references:date:message-id:subject\n\t:from:to:cc; bh=0KImX628urs1UCiSfGLeMRM5iKnWtVECxlytfjvJHCY=;\n\tb=KSEGVUQfV9IX7RJBJBgOGhJ7086cp0WZ0c7VUgK5PhGPcDiBR5dJSgTan/Jb7YXsdv\n\t/txvBLMUl01UxO8xxdjinO7qMKg/r+pkFlJ8WsHh5DMYkzzxye5P8Vb3YF5wNGM0vBVX\n\to8gwjAWR55ytJldjxb8//3jgupqs4bXeYzz3kL8LFa7w+oerkIga1+MOs1h/cThW/pzQ\n\t/KmZ2rEJyIIgzR1s0Tsuu9YgPJwSsDkVsXb5fSbBbDtu2vsmTyJvSP0JR9Z3Lm4GJ11/\n\t6sLimanYoHks80EitSzv3YW63QZBJztwWQZtROmEU4UTKGwtZw/O4nPRqPMYi7eSnCUk\n\t5Lrw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:date\n\t:message-id:subject:from:to:cc;\n\tbh=0KImX628urs1UCiSfGLeMRM5iKnWtVECxlytfjvJHCY=;\n\tb=VncTApm3F2XNN7UykwrPoDz2mSf1LU6RMs3Sl+pTMHUdvfg1n4rH577UZuTlrzx5Q7\n\tBRkpqXq97IaCCMzJXiY3T4sc+om+Q1b9ficj1Suh9NEv6NeLTGzTXa3oNc1EDs9xgDTk\n\t0JYcUJFxSXH/hGsRsH1v9SaiV9SPOZePSStboZT7i6/SlkfXZLmJyLlTdQcBDmP+wDMC\n\tIxME6WOnL4y6noIfaOcWbQXRfW3zb0OnZ38I+5bV9zDFxLz217hsywMsEpq9gBmcyUyl\n\tGdPJRlq/zjcJbiAcNJBjCqsLTnuFQzZBaqb6NlfSXbHvUKdCeEQ9MyfQWDe7btNokbPB\n\t+fFQ==","X-Gm-Message-State":"AD7BkJK59xorn8/J7Py/az8libiXsutClXHz6CCJLAXvmVh5V45vK2+6n/z7uFA4DKhJgBSPNY03EoRObXV1nw==","MIME-Version":"1.0","X-Received":"by 10.194.63.144 with SMTP id g16mr30144462wjs.149.1457394559881;\n\tMon, 07 Mar 2016 15:49:19 -0800 (PST)","In-Reply-To":"<1450941981-11900-1-git-send-email-xuelin.shi@nxp.com>","References":"<1450941981-11900-1-git-send-email-xuelin.shi@nxp.com>","Date":"Mon, 7 Mar 2016 17:49:19 -0600","X-Google-Sender-Auth":"pAEUOwAzIq2h4WUe9abNXK7GiOw","Message-ID":"","Subject":"Re: [PATCH] dma driver: fix potential oom issue of fsldma","From":"Li Yang ","To":"Xuelin Shi ","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Xuelin Shi ,\n\tlinuxppc-dev ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]