[{"id":1239,"web_url":"http://patchwork.ozlabs.org/comment/1239/","msgid":"<20080918.162948.150019388.davem@davemloft.net>","list_archive_url":null,"date":"2008-09-18T23:29:48","subject":"Re: [PATCH 2/2] sctp: Fix oops when INIT-ACK indicates that peer\n\tdoesn't support AUTH","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Vlad Yasevich \nDate: Thu, 18 Sep 2008 17:31:04 -0400\n\n> If INIT-ACK is received with SupportedExtensions parameter which\n> indicates that the peer does not support AUTH, the packet will be\n> silently ignore, and sctp_process_init() do cleanup all of the\n> transports in the association.\n> When T1-Init timer is expires, OOPS happen while we try to choose\n> a different init transport.\n> \n> The solution is to only clean up the non-active transports, i.e\n> the ones that the peer added. However, that introduces a problem\n> with sctp_connectx(), because we don't mark the proper state for\n> the transports provided by the user. So, we'll simply mark\n> user-provided transports as ACTIVE. That will allow INIT\n> retransmissions to work properly in the sctp_connectx() context\n> and prevent the crash.\n> \n> Signed-off-by: Vlad Yasevich \n\nApplied, thanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 5EE04DDFB3\n\tfor ;\n\tFri, 19 Sep 2008 09:30:09 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755035AbYIRXaD (ORCPT );\n\tThu, 18 Sep 2008 19:30:03 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1755501AbYIRXaB\n\t(ORCPT ); Thu, 18 Sep 2008 19:30:01 -0400","from 74-93-104-97-Washington.hfc.comcastbusiness.net\n\t([74.93.104.97]:39886\n\t\"EHLO sunset.davemloft.net\" rhost-flags-OK-FAIL-OK-OK)\n\tby vger.kernel.org with ESMTP id S1755473AbYIRXaA (ORCPT\n\t); Thu, 18 Sep 2008 19:30:00 -0400","from localhost (localhost [127.0.0.1])\n\tby sunset.davemloft.net (Postfix) with ESMTP id 262E4C8C181;\n\tThu, 18 Sep 2008 16:29:48 -0700 (PDT)"],"Date":"Thu, 18 Sep 2008 16:29:48 -0700 (PDT)","Message-Id":"<20080918.162948.150019388.davem@davemloft.net>","To":"vladislav.yasevich@hp.com","Cc":"linux-sctp@vger.kernel.org,\n\tlksctp-developers@lists.sourceforge.net, netdev@vger.kernel.org","Subject":"Re: [PATCH 2/2] sctp: Fix oops when INIT-ACK indicates that peer\n\tdoesn't support AUTH","From":"David Miller ","In-Reply-To":"<1221773464-28845-2-git-send-email-vladislav.yasevich@hp.com>","References":"<1221773464-28845-1-git-send-email-vladislav.yasevich@hp.com>\n\t<1221773464-28845-2-git-send-email-vladislav.yasevich@hp.com>","X-Mailer":"Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]