[{"id":1240,"web_url":"http://patchwork.ozlabs.org/comment/1240/","msgid":"<20080918.163633.223533656.davem@davemloft.net>","list_archive_url":null,"date":"2008-09-18T23:36:33","subject":"Re: clarify code intent","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Mathieu Lacage \nDate: Thu, 18 Sep 2008 10:07:48 -0700\n\n> The attached patch hopefully clarifies the intent of the unix_bind\n> function in net/unix/af_unix.c.\n\nI've rejected this patch over and over in the past, and nothing\nhas happened to change my mind since then.\n\n----------------------------------------\nSubject: Re: [PATCH,TRIVIAL] AF_UNIX, accept() and addrlen\nFrom: David Miller \nTo: samuel.thibault@ens-lyon.org\nCc: mtk.manpages@gmail.com, mtk.manpages@googlemail.com,\n andi@firstfloor.org, linux-kernel@vger.kernel.org\nDate: Sat, 26 Apr 2008 22:54:32 -0700 (PDT)\nX-Mailer: Mew version 5.2 on Emacs 22.1 / Mule 5.0 (SAKAKI)\n\nFrom: Samuel Thibault \nDate: Sat, 26 Apr 2008 02:44:45 +0100\n\n> AF_UNIX: make unix_getname use sizeof(sunaddr->sun_family) instead of\n> sizeof(short).\n> \n> Signed-off-by: Samuel Thibault \n\nThis is just syntactic masterbation, sa_family_t is typedef'd\n\"unsigned short\".\n\nNo system on planet earth providing the BSD sockets API uses\nanything other than uint16_t or unsigned short for this.\n\nSorry, I'm not applying this.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id A2012DDFC1\n\tfor ;\n\tFri, 19 Sep 2008 09:36:52 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754235AbYIRXgq (ORCPT );\n\tThu, 18 Sep 2008 19:36:46 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1754039AbYIRXgq\n\t(ORCPT ); Thu, 18 Sep 2008 19:36:46 -0400","from 74-93-104-97-Washington.hfc.comcastbusiness.net\n\t([74.93.104.97]:34969\n\t\"EHLO sunset.davemloft.net\" rhost-flags-OK-FAIL-OK-OK)\n\tby vger.kernel.org with ESMTP id S1753368AbYIRXgp (ORCPT\n\t); Thu, 18 Sep 2008 19:36:45 -0400","from localhost (localhost [127.0.0.1])\n\tby sunset.davemloft.net (Postfix) with ESMTP id D8642C8C181;\n\tThu, 18 Sep 2008 16:36:33 -0700 (PDT)"],"Date":"Thu, 18 Sep 2008 16:36:33 -0700 (PDT)","Message-Id":"<20080918.163633.223533656.davem@davemloft.net>","To":"mathieu.lacage@sophia.inria.fr","Cc":"netdev@vger.kernel.org","Subject":"Re: clarify code intent","From":"David Miller ","In-Reply-To":"<1221757668.23007.12.camel@ns-test>","References":"<1221757668.23007.12.camel@ns-test>","X-Mailer":"Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1250,"web_url":"http://patchwork.ozlabs.org/comment/1250/","msgid":"<1221782020.23007.37.camel@ns-test>","list_archive_url":null,"date":"2008-09-18T23:53:40","subject":"Re: clarify code intent","submitter":{"id":270,"url":"http://patchwork.ozlabs.org/api/people/270/","name":"Mathieu Lacage","email":"mathieu.lacage@sophia.inria.fr"},"content":"On Thu, 2008-09-18 at 16:36 -0700, David Miller wrote:\n\n> This is just syntactic masterbation, sa_family_t is typedef'd\n> \"unsigned short\".\n\nWould you take a patch to remove sa_family_t from the kernel code and\nheaders ? Otherwise, I suspect that you can understand that it is a bit\nhard for others to figure out where it is appropriate to use it and\nwhere it is not.\n\nregards,\nMathieu","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 64144DDF04\n\tfor ;\n\tFri, 19 Sep 2008 09:53:06 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755527AbYIRXxB (ORCPT );\n\tThu, 18 Sep 2008 19:53:01 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1755623AbYIRXxB\n\t(ORCPT ); Thu, 18 Sep 2008 19:53:01 -0400","from mail2-relais-roc.national.inria.fr ([192.134.164.83]:51953\n\t\"EHLO mail2-relais-roc.national.inria.fr\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1754452AbYIRXxA (ORCPT\n\t); Thu, 18 Sep 2008 19:53:00 -0400","from ns-test.ee.washington.edu (HELO [128.95.3.63]) ([128.95.3.63])\n\tby mail2-relais-roc.national.inria.fr with\n\tESMTP/TLS/DHE-RSA-AES256-SHA; 19 Sep 2008 01:52:58 +0200"],"X-IronPort-AV":"E=Sophos;i=\"4.32,424,1217800800\"; d=\"scan'208\";a=\"15114136\"","Subject":"Re: clarify code intent","From":"Mathieu Lacage ","To":"David Miller ","Cc":"netdev@vger.kernel.org","In-Reply-To":"<20080918.163633.223533656.davem@davemloft.net>","References":"<1221757668.23007.12.camel@ns-test>\n\t<20080918.163633.223533656.davem@davemloft.net>","Content-Type":"text/plain","Date":"Thu, 18 Sep 2008 16:53:40 -0700","Message-Id":"<1221782020.23007.37.camel@ns-test>","Mime-Version":"1.0","X-Mailer":"Evolution 2.12.1 ","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1255,"web_url":"http://patchwork.ozlabs.org/comment/1255/","msgid":"<20080918.165911.07741111.davem@davemloft.net>","list_archive_url":null,"date":"2008-09-18T23:59:11","subject":"Re: clarify code intent","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Mathieu Lacage \nDate: Thu, 18 Sep 2008 16:53:40 -0700\n\n> On Thu, 2008-09-18 at 16:36 -0700, David Miller wrote:\n> \n> > This is just syntactic masterbation, sa_family_t is typedef'd\n> > \"unsigned short\".\n> \n> Would you take a patch to remove sa_family_t from the kernel code and\n> headers ? Otherwise, I suspect that you can understand that it is a bit\n> hard for others to figure out where it is appropriate to use it and\n> where it is not.\n\nNo, that would break older userspace.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 9BEAEDDF57\n\tfor ;\n\tFri, 19 Sep 2008 09:59:41 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1757384AbYIRX7Z (ORCPT );\n\tThu, 18 Sep 2008 19:59:25 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1755623AbYIRX7Y\n\t(ORCPT ); Thu, 18 Sep 2008 19:59:24 -0400","from 74-93-104-97-Washington.hfc.comcastbusiness.net\n\t([74.93.104.97]:40325\n\t\"EHLO sunset.davemloft.net\" rhost-flags-OK-FAIL-OK-OK)\n\tby vger.kernel.org with ESMTP id S1757364AbYIRX7X (ORCPT\n\t); Thu, 18 Sep 2008 19:59:23 -0400","from localhost (localhost [127.0.0.1])\n\tby sunset.davemloft.net (Postfix) with ESMTP id 7B657C8C181;\n\tThu, 18 Sep 2008 16:59:11 -0700 (PDT)"],"Date":"Thu, 18 Sep 2008 16:59:11 -0700 (PDT)","Message-Id":"<20080918.165911.07741111.davem@davemloft.net>","To":"mathieu.lacage@sophia.inria.fr","Cc":"netdev@vger.kernel.org","Subject":"Re: clarify code intent","From":"David Miller ","In-Reply-To":"<1221782020.23007.37.camel@ns-test>","References":"<1221757668.23007.12.camel@ns-test>\n\t<20080918.163633.223533656.davem@davemloft.net>\n\t<1221782020.23007.37.camel@ns-test>","X-Mailer":"Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":2261,"web_url":"http://patchwork.ozlabs.org/comment/2261/","msgid":"<87d4ivr9gu.fsf@basil.nowhere.org>","list_archive_url":null,"date":"2008-09-23T00:29:05","subject":"Re: clarify code intent","submitter":{"id":422,"url":"http://patchwork.ozlabs.org/api/people/422/","name":"Andi Kleen","email":"andi@firstfloor.org"},"content":"Mathieu Lacage writes:\n\n> The attached patch hopefully clarifies the intent of the unix_bind\n> function in net/unix/af_unix.c. That 'feature' (the ability to delegate\n> the endpoint allocation to the kernel with bind by sending a\n> sockaddr_un.sun_family = AF_UNIX rather than have to wait until the\n> autobind is triggered by a later call to send) would be nice to document\n> in the unix '7' manpage but, I have no idea where these are maintained.\n\nThey are maintained by the manpage maintainer mtk.manpages@googlemail.com\n\n-Andi\n--\nTo unsubscribe from this list: send the line \"unsubscribe netdev\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id DFC9DDDED1\n\tfor ;\n\tTue, 23 Sep 2008 10:29:14 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753483AbYIWA3J (ORCPT );\n\tMon, 22 Sep 2008 20:29:09 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1753468AbYIWA3I\n\t(ORCPT ); Mon, 22 Sep 2008 20:29:08 -0400","from one.firstfloor.org ([213.235.205.2]:53954 \"EHLO\n\tone.firstfloor.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753457AbYIWA3I (ORCPT\n\t); Mon, 22 Sep 2008 20:29:08 -0400","from basil.firstfloor.org (f053157049.adsl.alicedsl.de\n\t[78.53.157.49])\n\tby one.firstfloor.org (Postfix) with ESMTP id 84F7318900BE;\n\tTue, 23 Sep 2008 02:33:57 +0200 (CEST)","by basil.firstfloor.org (Postfix, from userid 1000)\n\tid 8BA533E6A07; Tue, 23 Sep 2008 02:29:05 +0200 (CEST)"],"To":"Mathieu Lacage ","Cc":"netdev@vger.kernel.org","Subject":"Re: clarify code intent","From":"Andi Kleen ","References":"<1221757668.23007.12.camel@ns-test>","Date":"Tue, 23 Sep 2008 02:29:05 +0200","In-Reply-To":"<1221757668.23007.12.camel@ns-test> (Mathieu Lacage's message\n\tof \"Thu, 18 Sep 2008 10:07:48 -0700\")","Message-ID":"<87d4ivr9gu.fsf@basil.nowhere.org>","User-Agent":"Gnus/5.1008 (Gnus v5.10.8) Emacs/21.3 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]