[{"id":1241,"web_url":"http://patchwork.ozlabs.org/comment/1241/","msgid":"<20080918.163848.194697920.davem@davemloft.net>","list_archive_url":null,"date":"2008-09-18T23:38:48","subject":"Re: [UPDATED][NET-NEXT PATCH 1/4] bnx2: In bnx2_set_mac_link()\n\treturn void rather then int","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: \"Benjamin Li\" <benli@broadcom.com>\nDate: Thu, 18 Sep 2008 09:57:10 -0700\n\n> bnx2_set_mac_link() doesn't need to return any error codes.  And\n> all the callers don't check the return code. It is safe to\n> change the return type to a void.\n> \n> Signed-off-by: Benjamin Li <benli@broadcom.com>\n> Signed-off-by: Michael Chan <mchan@broadcom.com>\n\nApplied.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id EC0F2DDF90\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 19 Sep 2008 09:39:07 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755022AbYIRXjD (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 18 Sep 2008 19:39:03 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1755271AbYIRXjC\n\t(ORCPT <rfc822; netdev-outgoing>); Thu, 18 Sep 2008 19:39:02 -0400","from 74-93-104-97-Washington.hfc.comcastbusiness.net\n\t([74.93.104.97]:53741\n\t\"EHLO sunset.davemloft.net\" rhost-flags-OK-FAIL-OK-OK)\n\tby vger.kernel.org with ESMTP id S1755018AbYIRXjB (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 18 Sep 2008 19:39:01 -0400","from localhost (localhost [127.0.0.1])\n\tby sunset.davemloft.net (Postfix) with ESMTP id 02721C8C181;\n\tThu, 18 Sep 2008 16:38:48 -0700 (PDT)"],"Date":"Thu, 18 Sep 2008 16:38:48 -0700 (PDT)","Message-Id":"<20080918.163848.194697920.davem@davemloft.net>","To":"benli@broadcom.com","Cc":"jeff@garzik.org, netdev@vger.kernel.org","Subject":"Re: [UPDATED][NET-NEXT PATCH 1/4] bnx2: In bnx2_set_mac_link()\n\treturn void rather then int","From":"David Miller <davem@davemloft.net>","In-Reply-To":"<1221757033-4874-2-git-send-email-benli@broadcom.com>","References":"<20080918063933.GA8027@verge.net.au>\n\t<1221757033-4874-1-git-send-email-benli@broadcom.com>\n\t<1221757033-4874-2-git-send-email-benli@broadcom.com>","X-Mailer":"Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]