[{"id":988,"web_url":"http://patchwork.ozlabs.org/comment/988/","msgid":"<871vziwoxj.fsf@macbook.be.48ers.dk>","date":"2008-09-17T19:30:16","subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC\n\tGPIOs","submitter":{"id":103,"url":"http://patchwork.ozlabs.org/api/people/103/","name":"Peter Korsgaard","email":"jacmet@sunsite.dk"},"content":">>>>> \"Anton\" == Anton Vorontsov writes:\n\nHi,\n\n Anton> This patch implements GPIOLIB support for MPC8349-compatible SOC GPIOs.\n Anton> MPC8610 adopted this GPIO unit, so let's place it into sysdev.\n\n Anton> We'll need these gpios to support IrDA transceiver on MPC8610HPCD.\n\nIt seems basically the same as my patch (gpio driver for\nmpc831x/mpc834x/mpc837x with OF bindings) from September 5th except\nyou don't have any documentation and the Kconfig doesn't depend on\n831x/834x/837x.\n\nGalak, did you have time to look at these patches yet?\n\n Anton> +struct fsl_gpio_chip {\n Anton> +\tstruct of_mm_gpio_chip mm_gc;\n Anton> +\tspinlock_t lock;\n Anton> +\n Anton> +\t/* shadowed data register to clear/set bits safely */\n Anton> +\tu32 gpdat;\n\nWhy do you need this when you have the lock?","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 49A89DE2E9\n\tfor ;\n\tThu, 18 Sep 2008 05:31:28 +1000 (EST)","from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.27])\n\tby ozlabs.org (Postfix) with ESMTP id 2A0C3DDF09\n\tfor ; Thu, 18 Sep 2008 05:30:22 +1000 (EST)","by ey-out-2122.google.com with SMTP id 6so1431624eyi.15\n\tfor ; Wed, 17 Sep 2008 12:30:20 -0700 (PDT)","by 10.210.22.16 with SMTP id 16mr3661198ebv.27.1221679820599;\n\tWed, 17 Sep 2008 12:30:20 -0700 (PDT)","from macbook.be.48ers.dk ( [88.197.163.5])\n\tby mx.google.com with ESMTPS id t12sm5310857gvd.4.2008.09.17.12.30.18\n\t(version=TLSv1/SSLv3 cipher=RC4-MD5);\n\tWed, 17 Sep 2008 12:30:19 -0700 (PDT)","by macbook.be.48ers.dk (Postfix, from userid 1000)\n\tid 0DE8A98CB77; Wed, 17 Sep 2008 21:30:16 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; \n\th=domainkey-signature:received:received:received:to:cc:subject\n\t:references:from:date:in-reply-to:message-id:user-agent:mime-version\n\t:content-type:sender;\n\tbh=nJpt5zlxCvAOfr2U6wcdUzCa4OU4f/q21fIvSVMsfqE=;\n\tb=CVQ56brCCXovQyjyu/Tq99r/GfpCTzV65VHe4BqMM+kZky4MtBqS4vYNMyRhMSxngu\n\tIH1NblEE3xuiNlzaUVwzVMFG3w0Zv7Vfy5mlCvZGGRxNJ9Yp08ZK4X2YncfsXyAp5s7V\n\tIGaISsnkjEVLFY8XaapqnuhKSltZseQEgcsSk=","DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\n\th=to:cc:subject:references:from:date:in-reply-to:message-id\n\t:user-agent:mime-version:content-type:sender;\n\tb=USd5xQTgNwPxQHlF8BL95l9hqO0ZU71XmEdjbcoporslypqfOxUNdhXwwJm+u9etWP\n\tF7ZELo4A4PqebBirutsSsLgRlrTNbhk/ixkSWl27fakHCTEssEcMjJjqB0/2ntwnOQ4v\n\tmnWTZnUccLJJOlzCWCFDQXeyXAdYO0FA3kguE=","To":"Anton Vorontsov ","Subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC\n\tGPIOs","References":"<20080917175820.GA22539@oksana.dev.rtsoft.ru>","From":"Peter Korsgaard ","Date":"Wed, 17 Sep 2008 21:30:16 +0200","In-Reply-To":"<20080917175820.GA22539@oksana.dev.rtsoft.ru> (Anton Vorontsov's\n\tmessage of \"Wed\\, 17 Sep 2008 21\\:58\\:20 +0400\")","Message-ID":"<871vziwoxj.fsf@macbook.be.48ers.dk>","User-Agent":"Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)","MIME-Version":"1.0","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":1112,"web_url":"http://patchwork.ozlabs.org/comment/1112/","msgid":"<20080918112020.GA11584@oksana.dev.rtsoft.ru>","date":"2008-09-18T11:20:20","subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible\n\tSOC GPIOs","submitter":{"id":45,"url":"http://patchwork.ozlabs.org/api/people/45/","name":"Anton Vorontsov","email":"avorontsov@ru.mvista.com"},"content":"On Wed, Sep 17, 2008 at 09:30:16PM +0200, Peter Korsgaard wrote:\n> >>>>> \"Anton\" == Anton Vorontsov writes:\n> \n> Hi,\n> \n> Anton> This patch implements GPIOLIB support for MPC8349-compatible SOC GPIOs.\n> Anton> MPC8610 adopted this GPIO unit, so let's place it into sysdev.\n> \n> Anton> We'll need these gpios to support IrDA transceiver on MPC8610HPCD.\n> \n> It seems basically the same as my patch (gpio driver for\n> mpc831x/mpc834x/mpc837x with OF bindings) from September 5th except\n> you don't have any documentation\n\nWell, do we really need documentation for every trivial gpio controller?\nThe bindings are the same, only different compatible entries...\n\nIf we do need the documentation for this, I can readily include it.\n\n> and the Kconfig doesn't depend on\n> 831x/834x/837x.\n\nThis is purposely. We also need support for 8610, and maybe\nlater we'll find another chip with the same unit. So, to not touch\nthe Kconfig for every new chip I just made it PPC32-wide. Other\noption is to depend on FSL_SOC, but the driver really does not\ndepend on any fsl_soc stuff...\n\n> Galak, did you have time to look at these patches yet?\n> \n> Anton> +struct fsl_gpio_chip {\n> Anton> +\tstruct of_mm_gpio_chip mm_gc;\n> Anton> +\tspinlock_t lock;\n> Anton> +\n> Anton> +\t/* shadowed data register to clear/set bits safely */\n> Anton> +\tu32 gpdat;\n> \n> Why do you need this when you have the lock?\n\nSee this discussion:\n\nhttp://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg12299.html\n\nThanks,","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 166D5DE16D\n\tfor ;\n\tThu, 18 Sep 2008 21:20:37 +1000 (EST)","from buildserver.ru.mvista.com (unknown [85.21.88.6])\n\tby ozlabs.org (Postfix) with ESMTP id 75E40DDE0D\n\tfor ; Thu, 18 Sep 2008 21:20:23 +1000 (EST)","from localhost (unknown [10.150.0.9])\n\tby buildserver.ru.mvista.com (Postfix) with ESMTP\n\tid BBBF3881B; Thu, 18 Sep 2008 16:20:20 +0500 (SAMST)"],"Date":"Thu, 18 Sep 2008 15:20:20 +0400","From":"Anton Vorontsov ","To":"Peter Korsgaard ","Subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible\n\tSOC GPIOs","Message-ID":"<20080918112020.GA11584@oksana.dev.rtsoft.ru>","References":"<20080917175820.GA22539@oksana.dev.rtsoft.ru>\n\t<871vziwoxj.fsf@macbook.be.48ers.dk>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<871vziwoxj.fsf@macbook.be.48ers.dk>","User-Agent":"Mutt/1.5.18 (2008-05-17)","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","Reply-To":"avorontsov@ru.mvista.com","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":1385,"web_url":"http://patchwork.ozlabs.org/comment/1385/","msgid":"<87ej3gyxv0.fsf@macbook.be.48ers.dk>","date":"2008-09-19T15:11:15","subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC\n\tGPIOs","submitter":{"id":103,"url":"http://patchwork.ozlabs.org/api/people/103/","name":"Peter Korsgaard","email":"jacmet@sunsite.dk"},"content":">>>>> \"Anton\" == Anton Vorontsov writes:\n\nHi,\n\n >> It seems basically the same as my patch (gpio driver for\n >> mpc831x/mpc834x/mpc837x with OF bindings) from September 5th except\n >> you don't have any documentation\n\n Anton> Well, do we really need documentation for every trivial gpio\n Anton> controller? The bindings are the same, only different compatible\n Anton> entries...\n\nWell, we need some way of knowing that atleast. Having people grepping\nthrough arch/powerpc/boot/dts/ (and knowing that they should look for\n8349 even though they might use 8313 or 8610) doesn't seem optimal to\nme - I take it that's why we created\nDocumentation/powerpc/dts-bindings in the first place?\n\n Anton> If we do need the documentation for this, I can readily include it.\n\n >> and the Kconfig doesn't depend on\n >> 831x/834x/837x.\n\n Anton> This is purposely. We also need support for 8610, and maybe\n Anton> later we'll find another chip with the same unit. So, to not touch\n Anton> the Kconfig for every new chip I just made it PPC32-wide. Other\n Anton> option is to depend on FSL_SOC, but the driver really does not\n Anton> depend on any fsl_soc stuff...\n\nAdding another symbol to the Kconfig once it is verified that a new\nSoC is compatible doesn't seem like a big deal - Figuring out all the\nknobs we already have is, without having options for stuff that is\nknown to be irrelevant for the SoC.\n\nThe other 83xx specific drivers also depend on PPC_83xx.\n\n >> Why do you need this when you have the lock?\n\n Anton> See this discussion:\n\n Anton> http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg12299.html\n\nAhh, for open drain outputs. gpiolib doesn't actually provide an\ninterface to put the gpios in that mode, but it could ofcause have\nbeen set up in the bootloader. I'll fix that and send an updated\npatch.","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id D4D5CDE37D\n\tfor ;\n\tSat, 20 Sep 2008 01:11:36 +1000 (EST)","from ug-out-1314.google.com (ug-out-1314.google.com\n\t[66.249.92.172]) by ozlabs.org (Postfix) with ESMTP id A4F70DE0BD\n\tfor ; Sat, 20 Sep 2008 01:11:21 +1000 (EST)","by ug-out-1314.google.com with SMTP id m2so1063757uge.14\n\tfor ; Fri, 19 Sep 2008 08:11:18 -0700 (PDT)","by 10.86.29.8 with SMTP id c8mr2056728fgc.30.1221837078261;\n\tFri, 19 Sep 2008 08:11:18 -0700 (PDT)","from macbook.be.48ers.dk (191.207-78-194.adsl-fix.skynet.be\n\t[194.78.207.191])\n\tby mx.google.com with ESMTPS id l12sm682035fgb.6.2008.09.19.08.11.15\n\t(version=TLSv1/SSLv3 cipher=RC4-MD5);\n\tFri, 19 Sep 2008 08:11:16 -0700 (PDT)","by macbook.be.48ers.dk (Postfix, from userid 1000)\n\tid B2DD798CD12; Fri, 19 Sep 2008 17:11:15 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; \n\th=domainkey-signature:received:received:received:to:cc:subject\n\t:references:from:date:in-reply-to:message-id:user-agent:mime-version\n\t:content-type:sender;\n\tbh=r/b2ZVPNtX8PDabG0zMPPCHbjwnUu9ZvWbYWysY0uGk=;\n\tb=jgzJuCNnaMxaZTmiJRAFFm/zk0Sn1u2P0U8PJpq0SGjv+gVnykkt50lZHNW1UShkhK\n\tIr6Rxd/t2+CpmDqfmTun149UCmYFHEVzfHyMI/DkUffUwNtndaAmpTLeoKLK3Fo0TXE9\n\tPyunb05zjKwBGtUs/+cIj7yQJzidOYBvn3JrY=","DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\n\th=to:cc:subject:references:from:date:in-reply-to:message-id\n\t:user-agent:mime-version:content-type:sender;\n\tb=EjAZD5BG5h7RBHlifa+JSzdGxt+4GGEHAmdtLkqxmNByvqhByXy+Ubxkp3iOBmnnQ/\n\tMUg+Xvn/hfUXUnNuHmeblxNJ65dQPZ2EIPuZ9231xRq6cbdN1+dAJAPVEZ3NYJtr0UDs\n\tFS4GNk0oCtJYLlVx7yNgZGHShoyuKZOutZupk=","To":"avorontsov@ru.mvista.com","Subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC\n\tGPIOs","References":"<20080917175820.GA22539@oksana.dev.rtsoft.ru>\n\t<871vziwoxj.fsf@macbook.be.48ers.dk>\n\t<20080918112020.GA11584@oksana.dev.rtsoft.ru>","From":"Peter Korsgaard ","Date":"Fri, 19 Sep 2008 17:11:15 +0200","In-Reply-To":"<20080918112020.GA11584@oksana.dev.rtsoft.ru> (Anton Vorontsov's\n\tmessage of \"Thu\\, 18 Sep 2008 15\\:20\\:20 +0400\")","Message-ID":"<87ej3gyxv0.fsf@macbook.be.48ers.dk>","User-Agent":"Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)","MIME-Version":"1.0","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":1391,"web_url":"http://patchwork.ozlabs.org/comment/1391/","msgid":"<20080919153325.GA548@oksana.dev.rtsoft.ru>","date":"2008-09-19T15:33:25","subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible\n\tSOC GPIOs","submitter":{"id":45,"url":"http://patchwork.ozlabs.org/api/people/45/","name":"Anton Vorontsov","email":"avorontsov@ru.mvista.com"},"content":"On Fri, Sep 19, 2008 at 05:11:15PM +0200, Peter Korsgaard wrote:\n> >>>>> \"Anton\" == Anton Vorontsov writes:\n> \n> Hi,\n> \n> >> It seems basically the same as my patch (gpio driver for\n> >> mpc831x/mpc834x/mpc837x with OF bindings) from September 5th except\n> >> you don't have any documentation\n> \n> Anton> Well, do we really need documentation for every trivial gpio\n> Anton> controller? The bindings are the same, only different compatible\n> Anton> entries...\n> \n> Well, we need some way of knowing that atleast. Having people grepping\n> through arch/powerpc/boot/dts/ (and knowing that they should look for\n> 8349 even though they might use 8313 or 8610) doesn't seem optimal to\n> me - I take it that's why we created\n> Documentation/powerpc/dts-bindings in the first place?\n\nOk.\n\n> Anton> If we do need the documentation for this, I can readily include it.\n> \n> >> and the Kconfig doesn't depend on\n> >> 831x/834x/837x.\n> \n> Anton> This is purposely. We also need support for 8610, and maybe\n> Anton> later we'll find another chip with the same unit. So, to not touch\n> Anton> the Kconfig for every new chip I just made it PPC32-wide. Other\n> Anton> option is to depend on FSL_SOC, but the driver really does not\n> Anton> depend on any fsl_soc stuff...\n> \n> Adding another symbol to the Kconfig once it is verified that a new\n> SoC is compatible doesn't seem like a big deal - Figuring out all the\n> knobs we already have is, without having options for stuff that is\n> known to be irrelevant for the SoC.\n> \n> The other 83xx specific drivers also depend on PPC_83xx.\n\nLets wait for Kumar's comments. We've already had a PPC_* mess\nfor the USB_EHCI_FSL symbol. What I've learned from it, is that\nhuge PPC_* list isn't perfect either.\n\nSee this discussion:\n\nhttp://www.mail-archive.com/linux-usb@vger.kernel.org/msg01926.html\n\nAnd this one:\n\nhttp://fixunix.com/kernel/397972-patch-1-4-spi-powerpc-spi_mpc83xx-handles-freescale-mpc8610-well.html\n\n> >> Why do you need this when you have the lock?\n> \n> Anton> See this discussion:\n> \n> Anton> http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg12299.html\n> \n> Ahh, for open drain outputs. gpiolib doesn't actually provide an\n> interface to put the gpios in that mode, but it could ofcause have\n> been set up in the bootloader. I'll fix that and send an updated\n> patch.\n\nPardon? Who will send an updated patch, and what patch exactly? ;-)","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id BA5AADE23D\n\tfor ;\n\tSat, 20 Sep 2008 01:33:42 +1000 (EST)","from buildserver.ru.mvista.com (unknown [85.21.88.6])\n\tby ozlabs.org (Postfix) with ESMTP id 7EC91DE0B2\n\tfor ; Sat, 20 Sep 2008 01:33:28 +1000 (EST)","from localhost (unknown [10.150.0.9])\n\tby buildserver.ru.mvista.com (Postfix) with ESMTP\n\tid 6E0D58821; Fri, 19 Sep 2008 20:33:25 +0500 (SAMST)"],"Date":"Fri, 19 Sep 2008 19:33:25 +0400","From":"Anton Vorontsov ","To":"Peter Korsgaard ","Subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible\n\tSOC GPIOs","Message-ID":"<20080919153325.GA548@oksana.dev.rtsoft.ru>","References":"<20080917175820.GA22539@oksana.dev.rtsoft.ru>\n\t<871vziwoxj.fsf@macbook.be.48ers.dk>\n\t<20080918112020.GA11584@oksana.dev.rtsoft.ru>\n\t<87ej3gyxv0.fsf@macbook.be.48ers.dk>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<87ej3gyxv0.fsf@macbook.be.48ers.dk>","User-Agent":"Mutt/1.5.18 (2008-05-17)","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","Reply-To":"avorontsov@ru.mvista.com","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":1436,"web_url":"http://patchwork.ozlabs.org/comment/1436/","msgid":"<1BA571BA-BA43-4C18-9CBF-0F1461E6734E@kernel.crashing.org>","date":"2008-09-19T18:02:11","subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC\n\tGPIOs","submitter":{"id":5,"url":"http://patchwork.ozlabs.org/api/people/5/","name":"Kumar Gala","email":"galak@kernel.crashing.org"},"content":"On Sep 19, 2008, at 10:33 AM, Anton Vorontsov wrote:\n\n> On Fri, Sep 19, 2008 at 05:11:15PM +0200, Peter Korsgaard wrote:\n>>>>>>> \"Anton\" == Anton Vorontsov writes:\n>>\n>> Hi,\n>>\n>>>> It seems basically the same as my patch (gpio driver for\n>>>> mpc831x/mpc834x/mpc837x with OF bindings) from September 5th except\n>>>> you don't have any documentation\n>>\n>> Anton> Well, do we really need documentation for every trivial gpio\n>> Anton> controller? The bindings are the same, only different \n>> compatible\n>> Anton> entries...\n>>\n>> Well, we need some way of knowing that atleast. Having people \n>> grepping\n>> through arch/powerpc/boot/dts/ (and knowing that they should look for\n>> 8349 even though they might use 8313 or 8610) doesn't seem optimal to\n>> me - I take it that's why we created\n>> Documentation/powerpc/dts-bindings in the first place?\n>\n> Ok.\n>\n>> Anton> If we do need the documentation for this, I can readily \n>> include it.\n>>\n>>>> and the Kconfig doesn't depend on\n>>>> 831x/834x/837x.\n>>\n>> Anton> This is purposely. We also need support for 8610, and maybe\n>> Anton> later we'll find another chip with the same unit. So, to not \n>> touch\n>> Anton> the Kconfig for every new chip I just made it PPC32-wide. \n>> Other\n>> Anton> option is to depend on FSL_SOC, but the driver really does not\n>> Anton> depend on any fsl_soc stuff...\n>>\n>> Adding another symbol to the Kconfig once it is verified that a new\n>> SoC is compatible doesn't seem like a big deal - Figuring out all the\n>> knobs we already have is, without having options for stuff that is\n>> known to be irrelevant for the SoC.\n>>\n>> The other 83xx specific drivers also depend on PPC_83xx.\n>\n> Lets wait for Kumar's comments. We've already had a PPC_* mess\n> for the USB_EHCI_FSL symbol. What I've learned from it, is that\n> huge PPC_* list isn't perfect either.\n\nI've alone glanced over this, but some initial comments are.. lets \nrename the thing to not be 83xx specific since 8610 uses it and I'm \nsure we'll have other parts that do similar things.\n\nWith regards to the binding, lets make it generic like 'fsl,mpc8xxx- \ngpio\", \"fsl,CHIP-gpio\" and than we can use cpm1/cpm2/pq1/pq2 as \nprefixes to distinguish and major differences.\n\n- k","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id C8DCBDE4FE\n\tfor ;\n\tSat, 20 Sep 2008 04:02:47 +1000 (EST)","from gate.crashing.org (gate.crashing.org [63.228.1.57])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id 7165ADDFDB\n\tfor ; Sat, 20 Sep 2008 04:02:18 +1000 (EST)","from [IPv6:::1] (localhost.localdomain [127.0.0.1])\n\tby gate.crashing.org (8.14.1/8.13.8) with ESMTP id m8JI2CGq017304;\n\tFri, 19 Sep 2008 13:02:13 -0500"],"Message-Id":"<1BA571BA-BA43-4C18-9CBF-0F1461E6734E@kernel.crashing.org>","From":"Kumar Gala ","To":"avorontsov@ru.mvista.com","In-Reply-To":"<20080919153325.GA548@oksana.dev.rtsoft.ru>","Mime-Version":"1.0 (Apple Message framework v926)","Subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC\n\tGPIOs","Date":"Fri, 19 Sep 2008 13:02:11 -0500","References":"<20080917175820.GA22539@oksana.dev.rtsoft.ru>\n\t<871vziwoxj.fsf@macbook.be.48ers.dk>\n\t<20080918112020.GA11584@oksana.dev.rtsoft.ru>\n\t<87ej3gyxv0.fsf@macbook.be.48ers.dk>\n\t<20080919153325.GA548@oksana.dev.rtsoft.ru>","X-Mailer":"Apple Mail (2.926)","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"; DelSp=\"yes\"","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":1441,"web_url":"http://patchwork.ozlabs.org/comment/1441/","msgid":"<20080919181258.GA14093@oksana.dev.rtsoft.ru>","date":"2008-09-19T18:12:58","subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible\n\tSOC GPIOs","submitter":{"id":45,"url":"http://patchwork.ozlabs.org/api/people/45/","name":"Anton Vorontsov","email":"avorontsov@ru.mvista.com"},"content":"On Fri, Sep 19, 2008 at 01:02:11PM -0500, Kumar Gala wrote:\n[...]\n>>> Anton> This is purposely. We also need support for 8610, and maybe\n>>> Anton> later we'll find another chip with the same unit. So, to not \n>>> touch\n>>> Anton> the Kconfig for every new chip I just made it PPC32-wide. \n>>> Other\n>>> Anton> option is to depend on FSL_SOC, but the driver really does not\n>>> Anton> depend on any fsl_soc stuff...\n>>>\n>>> Adding another symbol to the Kconfig once it is verified that a new\n>>> SoC is compatible doesn't seem like a big deal - Figuring out all the\n>>> knobs we already have is, without having options for stuff that is\n>>> known to be irrelevant for the SoC.\n>>>\n>>> The other 83xx specific drivers also depend on PPC_83xx.\n>>\n>> Lets wait for Kumar's comments. We've already had a PPC_* mess\n>> for the USB_EHCI_FSL symbol. What I've learned from it, is that\n>> huge PPC_* list isn't perfect either.\n>\n> I've alone glanced over this, but some initial comments are.. lets \n> rename the thing to not be 83xx specific since 8610 uses it and I'm sure \n> we'll have other parts that do similar things.\n\nOk, mpc8xxx_gpio.c would be fine? (Note that I'm agree with 8xxx, for\nthe file name).\n\n> With regards to the binding, lets make it generic like 'fsl,mpc8xxx- \n> gpio\", \"fsl,CHIP-gpio\" and than we can use cpm1/cpm2/pq1/pq2 as prefixes \n> to distinguish and major differences.\n\nBut for compatible entry, shouldn't we use the last compatiblle entry\nas a generic one? Then fsl,mpc8349-gpio is perfectly valid. I.e.,\nfor MPC8610 chips we will have:\n\n\"fsl,mpc8610-gpio\", \"fsl,mpc8349-gpio\"\n\nThe last entry is most generic, and 8610 is registers-compatible with\nthe earlier (8349) chips. I thought that we tend to not do \"made up\"\n8xxx things in the device tree... Am I wrong?\n\n\nThanks!","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 4245EDE45F\n\tfor ;\n\tSat, 20 Sep 2008 04:13:15 +1000 (EST)","from buildserver.ru.mvista.com (unknown [85.21.88.6])\n\tby ozlabs.org (Postfix) with ESMTP id BA9EBDDF19\n\tfor ; Sat, 20 Sep 2008 04:12:59 +1000 (EST)","from localhost (unknown [10.150.0.9])\n\tby buildserver.ru.mvista.com (Postfix) with ESMTP\n\tid 1B6688822; Fri, 19 Sep 2008 23:12:58 +0500 (SAMST)"],"Date":"Fri, 19 Sep 2008 22:12:58 +0400","From":"Anton Vorontsov ","To":"Kumar Gala ","Subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible\n\tSOC GPIOs","Message-ID":"<20080919181258.GA14093@oksana.dev.rtsoft.ru>","References":"<20080917175820.GA22539@oksana.dev.rtsoft.ru>\n\t<871vziwoxj.fsf@macbook.be.48ers.dk>\n\t<20080918112020.GA11584@oksana.dev.rtsoft.ru>\n\t<87ej3gyxv0.fsf@macbook.be.48ers.dk>\n\t<20080919153325.GA548@oksana.dev.rtsoft.ru>\n\t<1BA571BA-BA43-4C18-9CBF-0F1461E6734E@kernel.crashing.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1BA571BA-BA43-4C18-9CBF-0F1461E6734E@kernel.crashing.org>","User-Agent":"Mutt/1.5.18 (2008-05-17)","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","Reply-To":"avorontsov@ru.mvista.com","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":1452,"web_url":"http://patchwork.ozlabs.org/comment/1452/","msgid":"","date":"2008-09-19T18:46:49","subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC\n\tGPIOs","submitter":{"id":5,"url":"http://patchwork.ozlabs.org/api/people/5/","name":"Kumar Gala","email":"galak@kernel.crashing.org"},"content":"On Sep 19, 2008, at 1:12 PM, Anton Vorontsov wrote:\n\n> On Fri, Sep 19, 2008 at 01:02:11PM -0500, Kumar Gala wrote:\n> [...]\n>>>> Anton> This is purposely. We also need support for 8610, and maybe\n>>>> Anton> later we'll find another chip with the same unit. So, to not\n>>>> touch\n>>>> Anton> the Kconfig for every new chip I just made it PPC32-wide.\n>>>> Other\n>>>> Anton> option is to depend on FSL_SOC, but the driver really does \n>>>> not\n>>>> Anton> depend on any fsl_soc stuff...\n>>>>\n>>>> Adding another symbol to the Kconfig once it is verified that a new\n>>>> SoC is compatible doesn't seem like a big deal - Figuring out all \n>>>> the\n>>>> knobs we already have is, without having options for stuff that is\n>>>> known to be irrelevant for the SoC.\n>>>>\n>>>> The other 83xx specific drivers also depend on PPC_83xx.\n>>>\n>>> Lets wait for Kumar's comments. We've already had a PPC_* mess\n>>> for the USB_EHCI_FSL symbol. What I've learned from it, is that\n>>> huge PPC_* list isn't perfect either.\n>>\n>> I've alone glanced over this, but some initial comments are.. lets\n>> rename the thing to not be 83xx specific since 8610 uses it and I'm \n>> sure\n>> we'll have other parts that do similar things.\n>\n> Ok, mpc8xxx_gpio.c would be fine? (Note that I'm agree with 8xxx, for\n> the file name).\n>\n>> With regards to the binding, lets make it generic like 'fsl,mpc8xxx-\n>> gpio\", \"fsl,CHIP-gpio\" and than we can use cpm1/cpm2/pq1/pq2 as \n>> prefixes\n>> to distinguish and major differences.\n>\n> But for compatible entry, shouldn't we use the last compatiblle entry\n> as a generic one? Then fsl,mpc8349-gpio is perfectly valid. I.e.,\n> for MPC8610 chips we will have:\n>\n> \"fsl,mpc8610-gpio\", \"fsl,mpc8349-gpio\"\n\nYeah the order is correct.. should be:\n\n\"fsl,CHIP-gpio\", \"fsl,mpc8xxx-gpio\"\n\nThe last entry is most generic, and 8610 is registers-compatible with\n>\n> the earlier (8349) chips. I thought that we tend to not do \"made up\"\n> 8xxx things in the device tree... Am I wrong?\n\nYou are correct we try to avoid this, but than I suggest we do it by \nfamily. I think its confusing to show 8610 and 8349 in the same dev \ntree.\n\nWhat we do in PCI is use the first in family. So lets take 8379 as an \nexample it would look like:\n\n\"fsl,mpc8379-gpio\", \"fsl-mpc8349-gpio\"\n\nand 8610 would look like:\n\n\"fsl,mpc8610-gpio\"\n\nThis way the compatiable binding in the code just lists something like \n\"fsl,mpc8349-gpio\", \"fsl,mpc8610-gpio\", \"fsl,mpc8572-gpio\".\n\nDoes that make sense?\n\n- k","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 1FF44DE6D1\n\tfor ;\n\tSat, 20 Sep 2008 04:47:14 +1000 (EST)","from gate.crashing.org (gate.crashing.org [63.228.1.57])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id 88528DE015\n\tfor ; Sat, 20 Sep 2008 04:46:56 +1000 (EST)","from [IPv6:::1] (localhost.localdomain [127.0.0.1])\n\tby gate.crashing.org (8.14.1/8.13.8) with ESMTP id m8JIkoX3020895;\n\tFri, 19 Sep 2008 13:46:51 -0500"],"Message-Id":"","From":"Kumar Gala ","To":"avorontsov@ru.mvista.com","In-Reply-To":"<20080919181258.GA14093@oksana.dev.rtsoft.ru>","Mime-Version":"1.0 (Apple Message framework v926)","Subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC\n\tGPIOs","Date":"Fri, 19 Sep 2008 13:46:49 -0500","References":"<20080917175820.GA22539@oksana.dev.rtsoft.ru>\n\t<871vziwoxj.fsf@macbook.be.48ers.dk>\n\t<20080918112020.GA11584@oksana.dev.rtsoft.ru>\n\t<87ej3gyxv0.fsf@macbook.be.48ers.dk>\n\t<20080919153325.GA548@oksana.dev.rtsoft.ru>\n\t<1BA571BA-BA43-4C18-9CBF-0F1461E6734E@kernel.crashing.org>\n\t<20080919181258.GA14093@oksana.dev.rtsoft.ru>","X-Mailer":"Apple Mail (2.926)","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"; DelSp=\"yes\"","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":1787,"web_url":"http://patchwork.ozlabs.org/comment/1787/","msgid":"<871vzdz48y.fsf@macbook.be.48ers.dk>","date":"2008-09-21T19:30:05","subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC\n\tGPIOs","submitter":{"id":103,"url":"http://patchwork.ozlabs.org/api/people/103/","name":"Peter Korsgaard","email":"jacmet@sunsite.dk"},"content":">>>>> \"Kumar\" == Kumar Gala writes:\n\nHi,\n\n Kumar> This way the compatiable binding in the code just lists something like\n Kumar> \"fsl,mpc8349-gpio\", \"fsl,mpc8610-gpio\", \"fsl,mpc8572-gpio\".\n\n Kumar> Does that make sense?\n\nYes, sounds fine - I'll adapt the patch and resend.","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id F274ADDFE6\n\tfor ;\n\tMon, 22 Sep 2008 05:30:37 +1000 (EST)","from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.25])\n\tby ozlabs.org (Postfix) with ESMTP id 7673EDDEE1\n\tfor ; Mon, 22 Sep 2008 05:30:10 +1000 (EST)","by ey-out-2122.google.com with SMTP id 6so325044eyi.15\n\tfor ; Sun, 21 Sep 2008 12:30:08 -0700 (PDT)","by 10.210.109.20 with SMTP id h20mr3745589ebc.54.1222025408483;\n\tSun, 21 Sep 2008 12:30:08 -0700 (PDT)","from macbook.be.48ers.dk ( [88.197.163.5])\n\tby mx.google.com with ESMTPS id m5sm930222gve.3.2008.09.21.12.30.06\n\t(version=TLSv1/SSLv3 cipher=RC4-MD5);\n\tSun, 21 Sep 2008 12:30:07 -0700 (PDT)","by macbook.be.48ers.dk (Postfix, from userid 1000)\n\tid 4BEF498CD12; Sun, 21 Sep 2008 21:30:05 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; \n\th=domainkey-signature:received:received:received:to:cc:subject\n\t:references:from:date:in-reply-to:message-id:user-agent:mime-version\n\t:content-type:sender;\n\tbh=lNV0mnO729j7y5GrdKR9QGLZOP6oy91thEK6/WMHdqw=;\n\tb=noNxdN+Rr1y3N17izr71iFVp8snSdtfSbsPEVyFLuXwj6EFJCtn3nDrEEO6BIjsLvq\n\taBjm71CnlcTFJ9ClZ75xbw3MMz4aWkR+Y9eGhY2Ed+GnUyb15UsovtaYdverEREgTUN+\n\tdkMZ20Pkc5bh29u3MgG5iV9jZScKxRyx3b6T0=","DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\n\th=to:cc:subject:references:from:date:in-reply-to:message-id\n\t:user-agent:mime-version:content-type:sender;\n\tb=HBEF93PLx5y9EBPyzsWsU/S51JWWRVWnKCdWKNe0YuJfodYIrtIVzhKqkmBo1R97Ti\n\tOnvuuELWO6Aoj2U3QiK8B7TIYd1yEnIvv7Ux3hKjYaDwfky1QOELAUMmigG34LDvkNZ4\n\t1f+0wC4blSXEeMyxdVYmqL1+TtzzSS9I3uE7k=","To":"Kumar Gala ","Subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC\n\tGPIOs","References":"<20080917175820.GA22539@oksana.dev.rtsoft.ru>\n\t<871vziwoxj.fsf@macbook.be.48ers.dk>\n\t<20080918112020.GA11584@oksana.dev.rtsoft.ru>\n\t<87ej3gyxv0.fsf@macbook.be.48ers.dk>\n\t<20080919153325.GA548@oksana.dev.rtsoft.ru>\n\t<1BA571BA-BA43-4C18-9CBF-0F1461E6734E@kernel.crashing.org>\n\t<20080919181258.GA14093@oksana.dev.rtsoft.ru>\n\t","From":"Peter Korsgaard ","Date":"Sun, 21 Sep 2008 21:30:05 +0200","In-Reply-To":"\n\t(Kumar Gala's message of \"Fri\\, 19 Sep 2008 13\\:46\\:49 -0500\")","Message-ID":"<871vzdz48y.fsf@macbook.be.48ers.dk>","User-Agent":"Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)","MIME-Version":"1.0","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":3508,"web_url":"http://patchwork.ozlabs.org/comment/3508/","msgid":"<20080925164118.GA4435@ld0162-tx32.am.freescale.net>","date":"2008-09-25T16:41:18","subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC\n\tGPIOs","submitter":{"id":11,"url":"http://patchwork.ozlabs.org/api/people/11/","name":"Scott Wood","email":"scottwood@freescale.com"},"content":"On Fri, Sep 19, 2008 at 01:46:49PM -0500, Kumar Gala wrote:\n> You are correct we try to avoid this, but than I suggest we do it by \n> family. I think its confusing to show 8610 and 8349 in the same dev \n> tree.\n\nI don't think it's confusing (at least, not moreso than picking an\narbitrary chip within the same family), if it really is compatible and\nthere is nothing new in the 86xx GPIO that warrants having a common\ncompatible for them.\n\n-Scott","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 9DCDADE587\n\tfor ;\n\tFri, 26 Sep 2008 02:41:44 +1000 (EST)","from de01egw02.freescale.net (de01egw02.freescale.net\n\t[192.88.165.103])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client CN \"de01egw02.freescale.net\",\n\tIssuer \"Thawte Premium Server CA\" (verified OK))\n\tby ozlabs.org (Postfix) with ESMTPS id A3387DDF6A\n\tfor ; Fri, 26 Sep 2008 02:41:28 +1000 (EST)","from de01smr01.freescale.net (de01smr01.freescale.net\n\t[10.208.0.31])\n\tby de01egw02.freescale.net (8.12.11/de01egw02) with ESMTP id\n\tm8PGfJhR020684\n\tfor ; Thu, 25 Sep 2008 09:41:20 -0700 (MST)","from ld0162-tx32.am.freescale.net (ld0162-tx32.am.freescale.net\n\t[10.82.19.112])\n\tby de01smr01.freescale.net (8.13.1/8.13.0) with ESMTP id\n\tm8PGfJiO016025\n\tfor ; Thu, 25 Sep 2008 11:41:19 -0500 (CDT)","by ld0162-tx32.am.freescale.net (Postfix, from userid 65002828)\n\tid B07E68081; Thu, 25 Sep 2008 11:41:18 -0500 (CDT)"],"Date":"Thu, 25 Sep 2008 11:41:18 -0500","From":"Scott Wood ","To":"Kumar Gala ","Subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC\n\tGPIOs","Message-ID":"<20080925164118.GA4435@ld0162-tx32.am.freescale.net>","References":"<20080917175820.GA22539@oksana.dev.rtsoft.ru>\n\t<871vziwoxj.fsf@macbook.be.48ers.dk>\n\t<20080918112020.GA11584@oksana.dev.rtsoft.ru>\n\t<87ej3gyxv0.fsf@macbook.be.48ers.dk>\n\t<20080919153325.GA548@oksana.dev.rtsoft.ru>\n\t<1BA571BA-BA43-4C18-9CBF-0F1461E6734E@kernel.crashing.org>\n\t<20080919181258.GA14093@oksana.dev.rtsoft.ru>\n\t","Mime-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.4.1i","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":3513,"web_url":"http://patchwork.ozlabs.org/comment/3513/","msgid":"<20080925164348.GB4435@ld0162-tx32.am.freescale.net>","date":"2008-09-25T16:43:48","subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC\n\tGPIOs","submitter":{"id":11,"url":"http://patchwork.ozlabs.org/api/people/11/","name":"Scott Wood","email":"scottwood@freescale.com"},"content":"On Fri, Sep 19, 2008 at 05:11:15PM +0200, Peter Korsgaard wrote:\n> Anton> This is purposely. We also need support for 8610, and maybe\n> Anton> later we'll find another chip with the same unit. So, to not touch\n> Anton> the Kconfig for every new chip I just made it PPC32-wide. Other\n> Anton> option is to depend on FSL_SOC, but the driver really does not\n> Anton> depend on any fsl_soc stuff...\n> \n> Adding another symbol to the Kconfig once it is verified that a new\n> SoC is compatible doesn't seem like a big deal - Figuring out all the\n> knobs we already have is, without having options for stuff that is\n> known to be irrelevant for the SoC.\n\nI agree with Anton; it's a lot less of a headache to say \"no\" to\nsome unfamiliar kconfig option than it is to hunt around and figure out\nwhy you're not being given the option. I'd be OK with depending on\nFSL_SOC.\n\n> The other 83xx specific drivers also depend on PPC_83xx.\n\nAs pointed out above, this isn't 83xx-specific.\n\n-Scott","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 894D3DE6EF\n\tfor ;\n\tFri, 26 Sep 2008 02:44:10 +1000 (EST)","from de01egw01.freescale.net (de01egw01.freescale.net\n\t[192.88.165.102])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id E83AADDF6C\n\tfor ; Fri, 26 Sep 2008 02:43:56 +1000 (EST)","from de01smr01.freescale.net (de01smr01.freescale.net\n\t[10.208.0.31])\n\tby de01egw01.freescale.net (8.12.11/az33egw01) with ESMTP id\n\tm8PGhnCx001369\n\tfor ; Thu, 25 Sep 2008 09:43:49 -0700 (MST)","from ld0162-tx32.am.freescale.net (ld0162-tx32.am.freescale.net\n\t[10.82.19.112])\n\tby de01smr01.freescale.net (8.13.1/8.13.0) with ESMTP id\n\tm8PGhngQ016628\n\tfor ; Thu, 25 Sep 2008 11:43:49 -0500 (CDT)","by ld0162-tx32.am.freescale.net (Postfix, from userid 65002828)\n\tid A2DCF8081; Thu, 25 Sep 2008 11:43:48 -0500 (CDT)"],"Date":"Thu, 25 Sep 2008 11:43:48 -0500","From":"Scott Wood ","To":"Peter Korsgaard ","Subject":"Re: [PATCH v2] powerpc: implement support for MPC8349-compatible SOC\n\tGPIOs","Message-ID":"<20080925164348.GB4435@ld0162-tx32.am.freescale.net>","References":"<20080917175820.GA22539@oksana.dev.rtsoft.ru>\n\t<871vziwoxj.fsf@macbook.be.48ers.dk>\n\t<20080918112020.GA11584@oksana.dev.rtsoft.ru>\n\t<87ej3gyxv0.fsf@macbook.be.48ers.dk>","Mime-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<87ej3gyxv0.fsf@macbook.be.48ers.dk>","User-Agent":"Mutt/1.4.1i","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}}]