[{"id":814943,"web_url":"http://patchwork.ozlabs.org/comment/814943/","msgid":"<20140714051908.GQ609@spoyarek.pnq.redhat.com>","list_archive_url":null,"date":"2014-07-14T05:19:08","subject":"Re: [PATCH] parsemail: Fallback to common charsets when charset is\n\tNone or x-unknown","submitter":{"id":13028,"url":"http://patchwork.ozlabs.org/api/people/13028/","name":"Siddhesh Poyarekar","email":"siddhesh@redhat.com"},"content":"On Mon, Jul 14, 2014 at 10:21:32AM +0800, Jeremy Kerr wrote:\n>          if not isinstance(payload, unicode):\n> -            payload = unicode(payload, charset)\n> +            charset = part.get_content_charset()\n> +\n> +            # Check that we have a charset that we understand. Otherwise,\n> +            # ignore it and fallback to our standard set.\n> +            if charset is not None:\n> +                try:\n> +                    codec = codecs.lookup(charset)\n> +                except LookupError:\n> +                    charset = None\n\nThanks, that looks like a better idea to me too.\n\nThanks,\nSiddhesh","headers":{"Return-Path":"<patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","patchwork@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","patchwork@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 5CAD6140096\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 14 Jul 2014 15:19:19 +1000 (EST)","from ozlabs.org (ozlabs.org [103.22.144.67])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3D2371A014E\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 14 Jul 2014 15:19:19 +1000 (EST)","from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id BA65C1A0013\n\tfor <patchwork@lists.ozlabs.org>;\n\tMon, 14 Jul 2014 15:19:17 +1000 (EST)","from int-mx10.intmail.prod.int.phx2.redhat.com\n\t(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\tby mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6E5JDqw008755\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Mon, 14 Jul 2014 01:19:14 -0400","from spoyarek.pnq.redhat.com (dhcp193-137.pnq.redhat.com\n\t[10.65.193.137])\n\tby int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id s6E5J9ZU028463\n\t(version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO);\n\tMon, 14 Jul 2014 01:19:12 -0400"],"Date":"Mon, 14 Jul 2014 10:49:08 +0530","From":"Siddhesh Poyarekar <siddhesh@redhat.com>","To":"Jeremy Kerr <jk@ozlabs.org>","Subject":"Re: [PATCH] parsemail: Fallback to common charsets when charset is\n\tNone or x-unknown","Message-ID":"<20140714051908.GQ609@spoyarek.pnq.redhat.com>","References":"<53C33BF6.8060900@ozlabs.org>\n\t<1405304492.528839.24449452940.1.gpush@pablo>","MIME-Version":"1.0","In-Reply-To":["<1405304492.528839.24449452940.1.gpush@pablo>","53BDDFB0.6090805@cs.ucla.edu"],"User-Agent":"Mutt/1.5.22.1-rc1 (2013-10-16)","X-Scanned-By":"MIMEDefang 2.68 on 10.5.11.23","Cc":"patchwork@lists.ozlabs.org","X-BeenThere":"patchwork@lists.ozlabs.org","X-Mailman-Version":"2.1.16","Precedence":"list","List-Id":"Patchwork development <patchwork.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/patchwork>,\n\t<mailto:patchwork-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/patchwork/>","List-Post":"<mailto:patchwork@lists.ozlabs.org>","List-Help":"<mailto:patchwork-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/patchwork>,\n\t<mailto:patchwork-request@lists.ozlabs.org?subject=subscribe>","Content-Type":"multipart/mixed;\n\tboundary=\"===============1149271968724304239==\"","Errors-To":"patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Patchwork\"\n\t<patchwork-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"}}]