[{"id":74500,"web_url":"http://patchwork.ozlabs.org/comment/74500/","msgid":"<20090803113225.4cd414ec@nehalam>","list_archive_url":null,"date":"2009-08-03T18:32:25","subject":"Re: [PATCH 7/7] venet: add scatter-gather/GSO support","submitter":{"id":423,"url":"http://patchwork.ozlabs.org/api/people/423/","name":"stephen hemminger","email":"shemminger@vyatta.com"},"content":"On Mon, 03 Aug 2009 13:18:07 -0400\nGregory Haskins wrote:\n\n> SG/GSO significantly enhance the performance of network traffic under\n> certain circumstances. We implement this feature as a separate patch\n> to avoid intially complicating the baseline venet driver. This will\n> presumably make the review process slightly easier, since we can\n> focus on the basic interface first.\n> \n> Signed-off-by: Gregory Haskins \n\nNever mind, previous comment about adding TSO. But it still would\nbe good to have ethtool interface for this.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@bilbo.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","patchwork-incoming@ozlabs.org"],"Received":["from ozlabs.org (ozlabs.org [203.10.76.45])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client CN \"mx.ozlabs.org\",\n\tIssuer \"CA Cert Signing Authority\" (verified OK))\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 30A2DB6F34\n\tfor ;\n\tTue, 4 Aug 2009 04:33:46 +1000 (EST)","by ozlabs.org (Postfix)\n\tid 221BADDDA2; Tue, 4 Aug 2009 04:33:46 +1000 (EST)","from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 9DEBBDDD04\n\tfor ;\n\tTue, 4 Aug 2009 04:33:45 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753863AbZHCScb (ORCPT );\n\tMon, 3 Aug 2009 14:32:31 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1753912AbZHCScb\n\t(ORCPT ); Mon, 3 Aug 2009 14:32:31 -0400","from mail.vyatta.com ([76.74.103.46]:46257 \"EHLO mail.vyatta.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1753395AbZHCSca (ORCPT );\n\tMon, 3 Aug 2009 14:32:30 -0400","from localhost (localhost.localdomain [127.0.0.1])\n\tby mail.vyatta.com (Postfix) with ESMTP id 81D3A4F4252;\n\tMon, 3 Aug 2009 11:32:31 -0700 (PDT)","from mail.vyatta.com ([127.0.0.1])\n\tby localhost (mail.vyatta.com [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id dWUOLqSXGAcB; Mon, 3 Aug 2009 11:32:26 -0700 (PDT)","from nehalam (pool-71-117-243-208.ptldor.fios.verizon.net\n\t[71.117.243.208])\n\tby mail.vyatta.com (Postfix) with ESMTP id 933374F4013;\n\tMon, 3 Aug 2009 11:32:26 -0700 (PDT)"],"X-Virus-Scanned":"amavisd-new at tahiti.vyatta.com","Date":"Mon, 3 Aug 2009 11:32:25 -0700","From":"Stephen Hemminger ","To":"Gregory Haskins ","Cc":"linux-kernel@vger.kernel.org,\n\talacrityvm-devel@lists.sourceforge.net, netdev@vger.kernel.org","Subject":"Re: [PATCH 7/7] venet: add scatter-gather/GSO support","Message-ID":"<20090803113225.4cd414ec@nehalam>","In-Reply-To":"<20090803171807.17268.49836.stgit@dev.haskins.net>","References":"<20090803171030.17268.26962.stgit@dev.haskins.net>\n\t<20090803171807.17268.49836.stgit@dev.haskins.net>","Organization":"Vyatta","X-Mailer":"Claws Mail 3.6.1 (GTK+ 2.16.1; x86_64-pc-linux-gnu)","Mime-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":74502,"web_url":"http://patchwork.ozlabs.org/comment/74502/","msgid":"<20090803113355.734e69b6@nehalam>","list_archive_url":null,"date":"2009-08-03T18:33:55","subject":"Re: [PATCH 7/7] venet: add scatter-gather/GSO support","submitter":{"id":423,"url":"http://patchwork.ozlabs.org/api/people/423/","name":"stephen hemminger","email":"shemminger@vyatta.com"},"content":"On Mon, 03 Aug 2009 13:18:07 -0400\nGregory Haskins wrote:\n\n> +\tstruct {\n> +\t\tint sg:1;\n> +\t\tint tso:1;\n> +\t\tint ufo:1;\n> +\t\tint tso6:1;\n> +\t\tint ecn:1;\n> +\t} flags;\n\nWhy do you have to shadow flags that are already available in net_device?\nIt is bad design to replicate state in a device driver. The problem\nwith replicated state is that it has to be updated in both places.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@bilbo.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","patchwork-incoming@ozlabs.org"],"Received":["from ozlabs.org (ozlabs.org [203.10.76.45])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client CN \"mx.ozlabs.org\",\n\tIssuer \"CA Cert Signing Authority\" (verified OK))\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id EE3B6B6F1F\n\tfor ;\n\tTue, 4 Aug 2009 04:34:37 +1000 (EST)","by ozlabs.org (Postfix)\n\tid DF614DDDA2; Tue, 4 Aug 2009 04:34:37 +1000 (EST)","from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 67495DDDA0\n\tfor ;\n\tTue, 4 Aug 2009 04:34:37 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753885AbZHCSeB (ORCPT );\n\tMon, 3 Aug 2009 14:34:01 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1753409AbZHCSeB\n\t(ORCPT ); Mon, 3 Aug 2009 14:34:01 -0400","from mail.vyatta.com ([76.74.103.46]:46323 \"EHLO mail.vyatta.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1753090AbZHCSeA (ORCPT );\n\tMon, 3 Aug 2009 14:34:00 -0400","from localhost (localhost.localdomain [127.0.0.1])\n\tby mail.vyatta.com (Postfix) with ESMTP id A62D24F4252;\n\tMon, 3 Aug 2009 11:34:01 -0700 (PDT)","from mail.vyatta.com ([127.0.0.1])\n\tby localhost (mail.vyatta.com [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FA3xqx3XT0WS; Mon, 3 Aug 2009 11:33:57 -0700 (PDT)","from nehalam (pool-71-117-243-208.ptldor.fios.verizon.net\n\t[71.117.243.208])\n\tby mail.vyatta.com (Postfix) with ESMTP id B7C464F4013;\n\tMon, 3 Aug 2009 11:33:56 -0700 (PDT)"],"X-Virus-Scanned":"amavisd-new at tahiti.vyatta.com","Date":"Mon, 3 Aug 2009 11:33:55 -0700","From":"Stephen Hemminger ","To":"Gregory Haskins ","Cc":"linux-kernel@vger.kernel.org,\n\talacrityvm-devel@lists.sourceforge.net, netdev@vger.kernel.org","Subject":"Re: [PATCH 7/7] venet: add scatter-gather/GSO support","Message-ID":"<20090803113355.734e69b6@nehalam>","In-Reply-To":"<20090803171807.17268.49836.stgit@dev.haskins.net>","References":"<20090803171030.17268.26962.stgit@dev.haskins.net>\n\t<20090803171807.17268.49836.stgit@dev.haskins.net>","Organization":"Vyatta","X-Mailer":"Claws Mail 3.6.1 (GTK+ 2.16.1; x86_64-pc-linux-gnu)","Mime-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":74523,"web_url":"http://patchwork.ozlabs.org/comment/74523/","msgid":"<4A773AC2.2080106@gmail.com>","list_archive_url":null,"date":"2009-08-03T19:30:10","subject":"Re: [PATCH 7/7] venet: add scatter-gather/GSO support","submitter":{"id":1241,"url":"http://patchwork.ozlabs.org/api/people/1241/","name":"Gregory Haskins","email":"gregory.haskins@gmail.com"},"content":"Stephen Hemminger wrote:\n> On Mon, 03 Aug 2009 13:18:07 -0400\n> Gregory Haskins wrote:\n> \n>> SG/GSO significantly enhance the performance of network traffic under\n>> certain circumstances. We implement this feature as a separate patch\n>> to avoid intially complicating the baseline venet driver. This will\n>> presumably make the review process slightly easier, since we can\n>> focus on the basic interface first.\n>>\n>> Signed-off-by: Gregory Haskins \n> \n> Never mind, previous comment about adding TSO.\n\n\nI should probably fold 6+7 together anyway, so this was my fault. I\nthink I was originally keeping them separate because the venet was\nserving as the canonical example for the vbus interface. But Ill just\ncome up with something simpler to demonstrate the interface and merge\nthese two patches.\n\n> But it still would be good to have ethtool interface for this.\n\nAck. Will do.\n\nThanks Stephen,\n-Greg","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@bilbo.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","patchwork-incoming@ozlabs.org"],"Received":["from ozlabs.org (ozlabs.org [203.10.76.45])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client CN \"mx.ozlabs.org\",\n\tIssuer \"CA Cert Signing Authority\" (verified OK))\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 0E6FAB6F20\n\tfor ;\n\tTue, 4 Aug 2009 05:37:43 +1000 (EST)","by ozlabs.org (Postfix)\n\tid F1EC1DDDA2; Tue, 4 Aug 2009 05:37:42 +1000 (EST)","from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 7B111DDD04\n\tfor ;\n\tTue, 4 Aug 2009 05:37:42 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754582AbZHCThS (ORCPT );\n\tMon, 3 Aug 2009 15:37:18 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1754350AbZHCThS\n\t(ORCPT ); Mon, 3 Aug 2009 15:37:18 -0400","from mail-px0-f201.google.com ([209.85.216.201]:47529 \"EHLO\n\tmail-px0-f201.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753399AbZHCThR (ORCPT\n\t); Mon, 3 Aug 2009 15:37:17 -0400","by pxi39 with SMTP id 39so2539875pxi.4\n\tfor ; Mon, 03 Aug 2009 12:37:17 -0700 (PDT)","by 10.114.59.13 with SMTP id h13mr8026064waa.146.1249327815451;\n\tMon, 03 Aug 2009 12:30:15 -0700 (PDT)","from Greg.laurelwood.net (68-116-192-8.dhcp.oxfr.ma.charter.com\n\t[68.116.192.8]) by mx.google.com with ESMTPS id\n\tm34sm11457481waf.57.2009.08.03.12.30.12\n\t(version=TLSv1/SSLv3 cipher=RC4-MD5);\n\tMon, 03 Aug 2009 12:30:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\n\th=domainkey-signature:received:received:message-id:date:from\n\t:user-agent:mime-version:to:cc:subject:references:in-reply-to\n\t:x-enigmail-version:content-type;\n\tbh=Tob6uxF2IyRawtAL8r2MsmBY4IRHYcur/Q6Z3I9ughw=;\n\tb=l+sqHWaE3V9tEP9ALMUknr6dq235/RQdz/bDjPu6DSyj/BCeLdAnh2hKfT01+ejCXC\n\t2pYdfDdIvEvQ0oZgDOU2O8h/L5EzypYrE26dk29XPn0EdGundBI23BjBT7fzWHowUDms\n\tvyXjxTr141pvPut3BPjLMgTuI+WwwUp3dvxoQ=","DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\n\th=message-id:date:from:user-agent:mime-version:to:cc:subject\n\t:references:in-reply-to:x-enigmail-version:content-type;\n\tb=xsibD7Oc2UarCnjeomJE52cQlKm/soRGHpF4qZiR8s9OkLFS6Mf7768FwAe4b/fIvR\n\t5/ydqZ8GncfxBbjqW7Ab+T/3+65KQUOq0kQ1QTblVgPN4QzYaFoGOv9OX7b6gvUySenb\n\tFkM1efPrr9/qnbz076YjSZyxujvjXeXpTLtkE=","Message-ID":"<4A773AC2.2080106@gmail.com>","Date":"Mon, 03 Aug 2009 15:30:10 -0400","From":"Gregory Haskins ","User-Agent":"Thunderbird 2.0.0.22 (Macintosh/20090605)","MIME-Version":"1.0","To":"Stephen Hemminger ","CC":"Gregory Haskins , linux-kernel@vger.kernel.org,\n\talacrityvm-devel@lists.sourceforge.net, netdev@vger.kernel.org","Subject":"Re: [PATCH 7/7] venet: add scatter-gather/GSO support","References":"<20090803171030.17268.26962.stgit@dev.haskins.net>\t<20090803171807.17268.49836.stgit@dev.haskins.net>\n\t<20090803113225.4cd414ec@nehalam>","In-Reply-To":"<20090803113225.4cd414ec@nehalam>","X-Enigmail-Version":"0.96.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"------------enigBE4790AD4B3E23612DA70C1F\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":74535,"web_url":"http://patchwork.ozlabs.org/comment/74535/","msgid":"<4A774147.8090207@novell.com>","list_archive_url":null,"date":"2009-08-03T19:57:59","subject":"Re: [PATCH 7/7] venet: add scatter-gather/GSO support","submitter":{"id":642,"url":"http://patchwork.ozlabs.org/api/people/642/","name":"Gregory Haskins","email":"ghaskins@novell.com"},"content":"Stephen Hemminger wrote:\n> On Mon, 03 Aug 2009 13:18:07 -0400\n> Gregory Haskins wrote:\n> \n>> +\tstruct {\n>> +\t\tint sg:1;\n>> +\t\tint tso:1;\n>> +\t\tint ufo:1;\n>> +\t\tint tso6:1;\n>> +\t\tint ecn:1;\n>> +\t} flags;\n> \n> Why do you have to shadow flags that are already available in net_device?\n> It is bad design to replicate state in a device driver. The problem\n> with replicated state is that it has to be updated in both places.\n> \n\nYa, you are right. I think the rationale was that the flags were \"hw\"\nstate, whereas dev->features was software state. But thinking about it\nafter you comments, I don't think it makes much difference either way.\n\nI will just have the negcap() function set the features directly in v2.\n\nKind Regards,\n-Greg","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@bilbo.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","patchwork-incoming@ozlabs.org"],"Received":["from ozlabs.org (ozlabs.org [203.10.76.45])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client CN \"mx.ozlabs.org\",\n\tIssuer \"CA Cert Signing Authority\" (verified OK))\n\tby bilbo.ozlabs.org (Postfix) with ESMTPS id 7EB8BB6F31\n\tfor ;\n\tTue, 4 Aug 2009 05:58:30 +1000 (EST)","by ozlabs.org (Postfix)\n\tid 73230DDDA2; Tue, 4 Aug 2009 05:58:30 +1000 (EST)","from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id E5A55DDD0C\n\tfor ;\n\tTue, 4 Aug 2009 05:58:29 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754877AbZHCT6H (ORCPT );\n\tMon, 3 Aug 2009 15:58:07 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1754734AbZHCT6G\n\t(ORCPT ); Mon, 3 Aug 2009 15:58:06 -0400","from victor.provo.novell.com ([137.65.250.26]:58207 \"EHLO\n\tvictor.provo.novell.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753618AbZHCT6F (ORCPT\n\t); Mon, 3 Aug 2009 15:58:05 -0400","from Greg.laurelwood.net (prv-ext-foundry1int.gns.novell.com\n\t[137.65.251.240])\n\tby victor.provo.novell.com with ESMTP (TLS encrypted);\n\tMon, 03 Aug 2009 13:58:00 -0600"],"Message-ID":"<4A774147.8090207@novell.com>","Date":"Mon, 03 Aug 2009 15:57:59 -0400","From":"Gregory Haskins ","User-Agent":"Thunderbird 2.0.0.22 (Macintosh/20090605)","MIME-Version":"1.0","To":"Stephen Hemminger ","CC":"linux-kernel@vger.kernel.org,\n\talacrityvm-devel@lists.sourceforge.net, netdev@vger.kernel.org","Subject":"Re: [PATCH 7/7] venet: add scatter-gather/GSO support","References":"<20090803171030.17268.26962.stgit@dev.haskins.net>\t<20090803171807.17268.49836.stgit@dev.haskins.net>\n\t<20090803113355.734e69b6@nehalam>","In-Reply-To":"<20090803113355.734e69b6@nehalam>","X-Enigmail-Version":"0.96.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"------------enig729E2AC306E0E4CAC25F29DB\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]