[{"id":694,"web_url":"http://patchwork.ozlabs.org/comment/694/","msgid":"<1221546997.3106.54.camel@macbook.infradead.org>","list_archive_url":null,"date":"2008-09-16T06:36:37","subject":"Re: [PATCH V2] [MTD] m25p80.c extended jedec support","submitter":{"id":26,"url":"http://patchwork.ozlabs.org/api/people/26/","name":"David Woodhouse","email":"dwmw2@infradead.org"},"content":"On Tue, 2008-09-16 at 14:14 +0800, Chen Gong wrote:\n> BTW, dave, I don't find any other fixes in this file recently. What do\n> you mean something has been there in the git tree, which git tree ?\n\nhttp:// or git:// git.infradead.org/mtd-2.6.git\n\nMost of your patch is already there (and thus also in linux-next).\nPlease could we have an incremental patch?\n\nWhat happens if you call spi_write_then_read(spi, x, x, x, 5) on a\ndevice which is only expecting to return 3 bytes. Does the call return\nfailure? Or just pad to 5 bytes with zeroes?","headers":{"Return-Path":"","X-Original-To":"patchwork@ozlabs.org","Delivered-To":"patchwork@ozlabs.org","Received":["from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id DC671DDF2A\n\tfor ; Tue, 16 Sep 2008 16:36:47 +1000 (EST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KfUAy-0000aQ-NF; Tue, 16 Sep 2008 06:36:40 +0000","from [208.252.119.213]\n\tby bombadil.infradead.org with esmtpsa (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KfUAw-0000aG-Or; Tue, 16 Sep 2008 06:36:39 +0000"],"Subject":"Re: [PATCH V2] [MTD] m25p80.c extended jedec support","From":"David Woodhouse ","To":"Chen Gong ","In-Reply-To":"<1221545652-2280-1-git-send-email-g.chen@freescale.com>","References":"<1221545652-2280-1-git-send-email-g.chen@freescale.com>","Date":"Mon, 15 Sep 2008 23:36:37 -0700","Message-Id":"<1221546997.3106.54.camel@macbook.infradead.org>","Mime-Version":"1.0","X-Mailer":"Evolution 2.22.3.1 (2.22.3.1-1.fc9) ","Cc":"linux-mtd@lists.infradead.org","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.9","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linux-mtd-bounces@lists.infradead.org","Errors-To":"linux-mtd-bounces+patchwork=ozlabs.org@lists.infradead.org"}},{"id":696,"web_url":"http://patchwork.ozlabs.org/comment/696/","msgid":"","list_archive_url":null,"date":"2008-09-16T06:41:35","subject":"RE: [PATCH V2] [MTD] m25p80.c extended jedec support","submitter":{"id":153,"url":"http://patchwork.ozlabs.org/api/people/153/","name":"Chen Gong-B11801","email":"G.Chen@freescale.com"},"content":"> -----Original Message-----\n> From: David Woodhouse [mailto:dwmw2@infradead.org] \n> Sent: 2008?9?16? 14:37\n> To: Chen Gong-B11801\n> Cc: linux-mtd@lists.infradead.org\n> Subject: Re: [PATCH V2] [MTD] m25p80.c extended jedec support\n> \n> On Tue, 2008-09-16 at 14:14 +0800, Chen Gong wrote:\n> > BTW, dave, I don't find any other fixes in this file \n> recently. What do\n> > you mean something has been there in the git tree, which git tree ?\n> \n> http:// or git:// git.infradead.org/mtd-2.6.git\n> \n> Most of your patch is already there (and thus also in linux-next).\n> Please could we have an incremental patch?\n\nyou mean I should create a patch based that tree, not torvalds's tree,\nright ?\n\n> \n> What happens if you call spi_write_then_read(spi, x, x, x, 5) on a\n> device which is only expecting to return 3 bytes. Does the call return\n> failure? Or just pad to 5 bytes with zeroes?\n\nfrankly, I'm not sure to much, but from the datasheet I'v read, if CS#\ndoesn't\nbe pulled high, it should can read zero or Hi-Z(maybe some mess data)\n\n> \n> -- \n> David Woodhouse Open Source \n> Technology Centre\n> David.Woodhouse@intel.com Intel \n> Corporation\n> \n>","headers":{"Return-Path":"","X-Original-To":"patchwork@ozlabs.org","Delivered-To":"patchwork@ozlabs.org","Received":["from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id B19F7DDE1A\n\tfor ; Tue, 16 Sep 2008 16:42:11 +1000 (EST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KfUGB-00017Q-Ek; Tue, 16 Sep 2008 06:42:03 +0000","from az33egw02.freescale.net ([192.88.158.103])\n\tby bombadil.infradead.org with esmtps (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KfUG5-00017E-MM\n\tfor linux-mtd@lists.infradead.org; Tue, 16 Sep 2008 06:42:01 +0000","from az33smr02.freescale.net (az33smr02.freescale.net\n\t[10.64.34.200])\n\tby az33egw02.freescale.net (8.12.11/az33egw02) with ESMTP id\n\tm8G6fbG1025513 for ;\n\tMon, 15 Sep 2008 23:41:50 -0700 (MST)","from zch01exm21.fsl.freescale.net (zch01exm21.ap.freescale.net\n\t[10.192.129.205])\n\tby az33smr02.freescale.net (8.13.1/8.13.0) with ESMTP id\n\tm8G6faio014963 for ;\n\tTue, 16 Sep 2008 01:41:36 -0500 (CDT)"],"X-MimeOLE":"Produced By Microsoft Exchange V6.5","Content-class":"urn:content-classes:message","MIME-Version":"1.0","Subject":"RE: [PATCH V2] [MTD] m25p80.c extended jedec support","Date":"Tue, 16 Sep 2008 14:41:35 +0800","Message-ID":"","In-Reply-To":"<1221546997.3106.54.camel@macbook.infradead.org>","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","Thread-Topic":"[PATCH V2] [MTD] m25p80.c extended jedec support","Thread-Index":"AckXxp6kZ3g1iwuKTyq13HXCeAB7JAAAChog","References":"<1221545652-2280-1-git-send-email-g.chen@freescale.com>\n\t<1221546997.3106.54.camel@macbook.infradead.org>","From":"\"Chen Gong-B11801\" ","To":"\"David Woodhouse\" ","X-Spam-Score":"0.0 (/)","Cc":"linux-mtd@lists.infradead.org","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.9","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linux-mtd-bounces@lists.infradead.org","Errors-To":"linux-mtd-bounces+patchwork=ozlabs.org@lists.infradead.org"}},{"id":700,"web_url":"http://patchwork.ozlabs.org/comment/700/","msgid":"<1221547914.3106.56.camel@macbook.infradead.org>","list_archive_url":null,"date":"2008-09-16T06:51:54","subject":"RE: [PATCH V2] [MTD] m25p80.c extended jedec support","submitter":{"id":26,"url":"http://patchwork.ozlabs.org/api/people/26/","name":"David Woodhouse","email":"dwmw2@infradead.org"},"content":"On Tue, 2008-09-16 at 14:41 +0800, Chen Gong-B11801 wrote:\n> you mean I should create a patch based that tree, not torvalds's tree,\n> right ?\n\nYes, please.\n\n> > \n> > What happens if you call spi_write_then_read(spi, x, x, x, 5) on a\n> > device which is only expecting to return 3 bytes. Does the call return\n> > failure? Or just pad to 5 bytes with zeroes?\n> \n> frankly, I'm not sure to much, but from the datasheet I'v read, if CS#\n> doesn't be pulled high, it should can read zero or Hi-Z(maybe some mess data)\n\nI would like to be sure that we're not going to break on older chips.","headers":{"Return-Path":"","X-Original-To":"patchwork@ozlabs.org","Delivered-To":"patchwork@ozlabs.org","Received":["from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id 45C8FDE0FB\n\tfor ; Tue, 16 Sep 2008 16:52:10 +1000 (EST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KfUPm-0002Xe-Bb; Tue, 16 Sep 2008 06:51:58 +0000","from [208.252.119.213]\n\tby bombadil.infradead.org with esmtpsa (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KfUPj-0002XX-Sv; Tue, 16 Sep 2008 06:51:56 +0000"],"Subject":"RE: [PATCH V2] [MTD] m25p80.c extended jedec support","From":"David Woodhouse ","To":"Chen Gong-B11801 ","In-Reply-To":"","References":"<1221545652-2280-1-git-send-email-g.chen@freescale.com>\n\t<1221546997.3106.54.camel@macbook.infradead.org>\n\t","Date":"Mon, 15 Sep 2008 23:51:54 -0700","Message-Id":"<1221547914.3106.56.camel@macbook.infradead.org>","Mime-Version":"1.0","X-Mailer":"Evolution 2.22.3.1 (2.22.3.1-1.fc9) ","Cc":"linux-mtd@lists.infradead.org","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.9","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linux-mtd-bounces@lists.infradead.org","Errors-To":"linux-mtd-bounces+patchwork=ozlabs.org@lists.infradead.org"}},{"id":703,"web_url":"http://patchwork.ozlabs.org/comment/703/","msgid":"","list_archive_url":null,"date":"2008-09-16T07:00:21","subject":"RE: [PATCH V2] [MTD] m25p80.c extended jedec support","submitter":{"id":153,"url":"http://patchwork.ozlabs.org/api/people/153/","name":"Chen Gong-B11801","email":"G.Chen@freescale.com"},"content":"> -----Original Message-----\n> From: David Woodhouse [mailto:dwmw2@infradead.org] \n> Sent: 2008?9?16? 14:52\n> To: Chen Gong-B11801\n> Cc: linux-mtd@lists.infradead.org\n> Subject: RE: [PATCH V2] [MTD] m25p80.c extended jedec support\n> \n> On Tue, 2008-09-16 at 14:41 +0800, Chen Gong-B11801 wrote:\n> > you mean I should create a patch based that tree, not \n> torvalds's tree,\n> > right ?\n> \n> Yes, please.\n\nsure, but becuase I can't use git protocol in the company and the http\nlooks can't work either, which reports \n\"error: Could not interpret response from server '\".\nI will have this work done when I go back home :-)\n> \n> > > \n> > > What happens if you call spi_write_then_read(spi, x, x, x, 5) on a\n> > > device which is only expecting to return 3 bytes. Does \n> the call return\n> > > failure? Or just pad to 5 bytes with zeroes?\n> > \n> > frankly, I'm not sure to much, but from the datasheet I'v \n> read, if CS#\n> > doesn't be pulled high, it should can read zero or \n> Hi-Z(maybe some mess data)\n> \n> I would like to be sure that we're not going to break on older chips.\n> \n> -- \n> dwmw2\n> \n>","headers":{"Return-Path":"","X-Original-To":"patchwork@ozlabs.org","Delivered-To":"patchwork@ozlabs.org","Received":["from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id 274ADDE0B0\n\tfor ; Tue, 16 Sep 2008 17:00:36 +1000 (EST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KfUY2-0003r7-P8; Tue, 16 Sep 2008 07:00:30 +0000","from de01egw02.freescale.net ([192.88.165.103])\n\tby bombadil.infradead.org with esmtps (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KfUY0-0003qx-Da\n\tfor linux-mtd@lists.infradead.org; Tue, 16 Sep 2008 07:00:28 +0000","from de01smr02.am.mot.com (de01smr02.freescale.net [10.208.0.151])\n\tby de01egw02.freescale.net (8.12.11/de01egw02) with ESMTP id\n\tm8G70PRr011238 for ;\n\tTue, 16 Sep 2008 00:00:25 -0700 (MST)","from zch01exm21.fsl.freescale.net (zch01exm21.ap.freescale.net\n\t[10.192.129.205])\n\tby de01smr02.am.mot.com (8.13.1/8.13.0) with ESMTP id m8G70NjW016115\n\tfor ;\n\tTue, 16 Sep 2008 02:00:24 -0500 (CDT)"],"X-MimeOLE":"Produced By Microsoft Exchange V6.5","Content-class":"urn:content-classes:message","MIME-Version":"1.0","Subject":"RE: [PATCH V2] [MTD] m25p80.c extended jedec support","Date":"Tue, 16 Sep 2008 15:00:21 +0800","Message-ID":"","In-Reply-To":"<1221547914.3106.56.camel@macbook.infradead.org>","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","Thread-Topic":"[PATCH V2] [MTD] m25p80.c extended jedec support","Thread-Index":"AckXyLm5TnAmycDVQ2ys20nTNL7ufQAACY0g","References":"<1221545652-2280-1-git-send-email-g.chen@freescale.com>\n\t<1221546997.3106.54.camel@macbook.infradead.org>\n\t\n\t<1221547914.3106.56.camel@macbook.infradead.org>","From":"\"Chen Gong-B11801\" ","To":"\"David Woodhouse\" ","X-Spam-Score":"0.0 (/)","Cc":"linux-mtd@lists.infradead.org","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.9","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linux-mtd-bounces@lists.infradead.org","Errors-To":"linux-mtd-bounces+patchwork=ozlabs.org@lists.infradead.org"}}]