[{"id":1291,"web_url":"http://patchwork.ozlabs.org/comment/1291/","msgid":"<20080919075653.GA10241@secretlab.ca>","date":"2008-09-19T07:56:53","subject":"Re: [PATCH] bootwrapper: support u-boot multi component images","submitter":{"id":19,"url":"http://patchwork.ozlabs.org/api/people/19/","name":"Grant Likely","email":"grant.likely@secretlab.ca"},"content":"On Mon, Sep 15, 2008 at 08:53:53PM +0200, Peter Korsgaard wrote:\n> From: peter Korsgaard <jacmet@sunsite.dk>\n> \n> Support uImage.<platform>, which are U-Boot multi component images\n> containing a kernel, dtb and possibly an initrd.\n> \n> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>\n> ---\n>  Documentation/powerpc/bootwrapper.txt |    4 ++++\n>  arch/powerpc/boot/Makefile            |   11 +++++++++--\n>  arch/powerpc/boot/wrapper             |   20 +++++++++++++++++++-\n>  3 files changed, 32 insertions(+), 3 deletions(-)\n> \n> diff --git a/Documentation/powerpc/bootwrapper.txt b/Documentation/powerpc/bootwrapper.txt\n> index d60fced..f0b34b3 100644\n> --- a/Documentation/powerpc/bootwrapper.txt\n> +++ b/Documentation/powerpc/bootwrapper.txt\n> @@ -91,6 +91,10 @@ Currently, the following image format targets exist:\n>  \t\t\ta device tree to the kernel at boot.  If using an older\n>  \t\t\tversion of U-Boot, then you need to use a cuImage\n>  \t\t\tinstead.\n> +   uImage.thinx:\tU-Boot multi component image. Similar to uImage,\n\nChange this to \"uImage.%:\" to match the rest of this document.\n\n> diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile\n> index 717a3bc..41ab6aa 100644\n> --- a/arch/powerpc/boot/Makefile\n> +++ b/arch/powerpc/boot/Makefile\n> @@ -352,7 +359,7 @@ install: $(CONFIGURE) $(addprefix $(obj)/, $(image-y))\n>  clean-files += $(image-) $(initrd-) cuImage.* dtbImage.* treeImage.* \\\n>  \tzImage zImage.initrd zImage.chrp zImage.coff zImage.holly \\\n>  \tzImage.iseries zImage.miboot zImage.pmac zImage.pseries \\\n> -\totheros.bld *.dtb\n> +\totheros.bld uImage.* *.dtb\n\nActually, you can probably make this \"uImage*\" instead because plain\n'uImage' targets are missing from this list.\n\n>  \n>  # clean up files cached by wrapper\n>  clean-kernel := vmlinux.strip vmlinux.bin\n> diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper\n> index 965c237..b7c0b23 100755\n> --- a/arch/powerpc/boot/wrapper\n> +++ b/arch/powerpc/boot/wrapper\n> @@ -153,7 +153,7 @@ coff)\n>      lds=$object/zImage.coff.lds\n>      link_address='0x500000'\n>      ;;\n> -miboot|uboot)\n> +miboot|uboot|uboot-*)\n\nSimilarly, uboot and uboot-* can probably be collapsed to 'uboot*'\n\ng.","headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 29585DE0D3\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 19 Sep 2008 17:57:23 +1000 (EST)","from rv-out-0506.google.com (rv-out-0506.google.com\n\t[209.85.198.235]) by ozlabs.org (Postfix) with ESMTP id A326FDDEFF\n\tfor <linuxppc-dev@ozlabs.org>; Fri, 19 Sep 2008 17:57:08 +1000 (EST)","by rv-out-0506.google.com with SMTP id f6so285458rvb.9\n\tfor <linuxppc-dev@ozlabs.org>; Fri, 19 Sep 2008 00:57:07 -0700 (PDT)","by 10.140.125.1 with SMTP id x1mr8199787rvc.287.1221811027242;\n\tFri, 19 Sep 2008 00:57:07 -0700 (PDT)","from trillian.cg.shawcable.net ( [68.146.22.144])\n\tby mx.google.com with ESMTPS id g22sm748269rvb.8.2008.09.19.00.57.05\n\t(version=TLSv1/SSLv3 cipher=RC4-MD5);\n\tFri, 19 Sep 2008 00:57:06 -0700 (PDT)","by trillian.cg.shawcable.net (Postfix, from userid 1000)\n\tid C856311597; Fri, 19 Sep 2008 00:56:53 -0700 (PDT)"],"Date":"Fri, 19 Sep 2008 00:56:53 -0700","From":"Grant Likely <grant.likely@secretlab.ca>","To":"Peter Korsgaard <jacmet@sunsite.dk>","Subject":"Re: [PATCH] bootwrapper: support u-boot multi component images","Message-ID":"<20080919075653.GA10241@secretlab.ca>","References":"<1221504833-5096-1-git-send-email-jacmet@sunsite.dk>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1221504833-5096-1-git-send-email-jacmet@sunsite.dk>","User-Agent":"Mutt/1.5.18 (2008-05-17)","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>","List-Unsubscribe":"<https://ozlabs.org/mailman/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>","List-Archive":"<http://ozlabs.org/pipermail/linuxppc-dev>","List-Post":"<mailto:linuxppc-dev@ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@ozlabs.org?subject=help>","List-Subscribe":"<https://ozlabs.org/mailman/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":1294,"web_url":"http://patchwork.ozlabs.org/comment/1294/","msgid":"<87myi4k139.fsf@macbook.be.48ers.dk>","date":"2008-09-19T08:10:34","subject":"Re: [PATCH] bootwrapper: support u-boot multi component images","submitter":{"id":103,"url":"http://patchwork.ozlabs.org/api/people/103/","name":"Peter Korsgaard","email":"jacmet@sunsite.dk"},"content":">>>>> \"Grant\" == Grant Likely <grant.likely@secretlab.ca> writes:\n\nHi,\n\n Grant> On Mon, Sep 15, 2008 at 08:53:53PM +0200, Peter Korsgaard wrote:\n >> +   uImage.thinx:\tU-Boot multi component image. Similar to uImage,\n\n Grant> Change this to \"uImage.%:\" to match the rest of this document.\n\nArgh, guess what my platform is called ;)\n\n >> -\totheros.bld *.dtb\n >> +\totheros.bld uImage.* *.dtb\n\n Grant> Actually, you can probably make this \"uImage*\" instead because plain\n Grant> 'uImage' targets are missing from this list.\n\nOk, will do.\n\n >> -miboot|uboot)\n >> +miboot|uboot|uboot-*)\n\n Grant> Similarly, uboot and uboot-* can probably be collapsed to 'uboot*'\n\nYeah, I kept it like this to keep it clear that it doesn't impact the\nnormal uImage support - Will fix.\n\nI'll send an updated patch.","headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org>","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id BA7BADDFE6\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri, 19 Sep 2008 18:10:53 +1000 (EST)","from fg-out-1718.google.com (fg-out-1718.google.com\n\t[72.14.220.153]) by ozlabs.org (Postfix) with ESMTP id A5163DDE3A\n\tfor <linuxppc-dev@ozlabs.org>; Fri, 19 Sep 2008 18:10:39 +1000 (EST)","by fg-out-1718.google.com with SMTP id d23so517925fga.39\n\tfor <linuxppc-dev@ozlabs.org>; Fri, 19 Sep 2008 01:10:37 -0700 (PDT)","by 10.86.71.1 with SMTP id t1mr1619533fga.36.1221811837738;\n\tFri, 19 Sep 2008 01:10:37 -0700 (PDT)","from macbook.be.48ers.dk ( [194.78.207.191])\n\tby mx.google.com with ESMTPS id 4sm1457681fge.8.2008.09.19.01.10.35\n\t(version=TLSv1/SSLv3 cipher=RC4-MD5);\n\tFri, 19 Sep 2008 01:10:36 -0700 (PDT)","by macbook.be.48ers.dk (Postfix, from userid 1000)\n\tid 11A2C98CD0F; Fri, 19 Sep 2008 10:10:34 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; \n\th=domainkey-signature:received:received:received:to:cc:subject\n\t:references:from:date:in-reply-to:message-id:user-agent:mime-version\n\t:content-type:sender;\n\tbh=fRPAVXj/Hbj6M4Nrc9Eb/vbtXddXD9SwyTD25vm/zrk=;\n\tb=OWRIoWvA+9iU7E5VW/XG0wkhcRLtzpPHj4p/dAhoHiWOpfJPPJ/6jnNWtGi/uvDj0Q\n\tcKMQHbSOm54GrpcOe7Q+fME7Q1pctRA/QUtQFg3Mj5jugdOdNfgSTbPtqvn+cnDP+fp7\n\tatDNdb67S71k4Y2Ci9ohwnA6gSr6+kDrCo4Fk=","DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\n\th=to:cc:subject:references:from:date:in-reply-to:message-id\n\t:user-agent:mime-version:content-type:sender;\n\tb=Dc2HFsRq6vhvv13qDNa23+USDYoKVQXoCQjhe7pDV/SHLLNwPxdUfp31FcLFRNugRh\n\tx3eSjpBoke488kVXAopseSKFYhjjPGf1jnDc47lwTv+BrepEuusIQMEAlClcH9DvbG6s\n\tNnJ5MIdjM2+ZtSN6sBcg02ecFJsFA3rRV//pA=","To":"Grant Likely <grant.likely@secretlab.ca>","Subject":"Re: [PATCH] bootwrapper: support u-boot multi component images","References":"<1221504833-5096-1-git-send-email-jacmet@sunsite.dk>\n\t<20080919075653.GA10241@secretlab.ca>","From":"Peter Korsgaard <jacmet@sunsite.dk>","Date":"Fri, 19 Sep 2008 10:10:34 +0200","In-Reply-To":"<20080919075653.GA10241@secretlab.ca> (Grant Likely's message of\n\t\"Fri\\, 19 Sep 2008 00\\:56\\:53 -0700\")","Message-ID":"<87myi4k139.fsf@macbook.be.48ers.dk>","User-Agent":"Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux)","MIME-Version":"1.0","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>","List-Unsubscribe":"<https://ozlabs.org/mailman/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>","List-Archive":"<http://ozlabs.org/pipermail/linuxppc-dev>","List-Post":"<mailto:linuxppc-dev@ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@ozlabs.org?subject=help>","List-Subscribe":"<https://ozlabs.org/mailman/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}}]