[{"id":646,"web_url":"http://patchwork.ozlabs.org/comment/646/","msgid":"<20080913104701.GF21603@xi.wantstofly.org>","list_archive_url":null,"date":"2008-09-13T10:47:01","subject":"Re: [PATCH 3/3] [MTD] physmap.c: Add a dummy release function","submitter":{"id":94,"url":"http://patchwork.ozlabs.org/api/people/94/","name":"Lennert Buytenhek","email":"buytenh@wantstofly.org"},"content":"On Fri, Sep 12, 2008 at 11:33:08PM -0700, Zev Weiss wrote:\n\n> Adding a dummy release function to the physmap device so as to silence a log\n> warning on initialization.\n> \n> Signed-off-by: Zev Weiss \n> ---\n> drivers/mtd/maps/physmap.c | 5 +++++\n> 1 files changed, 5 insertions(+), 0 deletions(-)\n> \n> diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c\n> index 49e2039..73a8d3c 100644\n> --- a/drivers/mtd/maps/physmap.c\n> +++ b/drivers/mtd/maps/physmap.c\n> @@ -277,11 +277,16 @@ static struct resource physmap_flash_resource = {\n> \t.flags\t\t= IORESOURCE_MEM,\n> };\n> \n> +static void physmap_dummy_release(struct device *dev)\n> +{\n> +}\n> +\n> static struct platform_device physmap_flash = {\n> \t.name\t\t= \"physmap-flash\",\n> \t.id\t\t= 0,\n> \t.dev\t\t= {\n> \t\t.platform_data\t= &physmap_flash_data,\n> +\t\t.release\t= &physmap_dummy_release,\n> \t},\n> \t.num_resources\t= 1,\n> \t.resource\t= &physmap_flash_resource,\n\nIsn't that just papering over the issue?","headers":{"Return-Path":"","X-Original-To":"patchwork@ozlabs.org","Delivered-To":"patchwork@ozlabs.org","Received":["from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id 92F43DDD0B\n\tfor ; Sat, 13 Sep 2008 20:47:09 +1000 (EST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KeSed-0002DA-8f; Sat, 13 Sep 2008 10:47:03 +0000","from [2002:53a0:b870::1] (helo=xi.wantstofly.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KeSeb-0002Cx-Ly\n\tfor linux-mtd@lists.infradead.org; Sat, 13 Sep 2008 10:47:01 +0000","by xi.wantstofly.org (Postfix, from userid 500)\n\tid 42B8B7FAB1; Sat, 13 Sep 2008 12:47:01 +0200 (CEST)"],"Date":"Sat, 13 Sep 2008 12:47:01 +0200","From":"Lennert Buytenhek ","To":"Zev Weiss ","Subject":"Re: [PATCH 3/3] [MTD] physmap.c: Add a dummy release function","Message-ID":"<20080913104701.GF21603@xi.wantstofly.org>","References":"<48CB5EA4.10907@gmail.com>","Mime-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<48CB5EA4.10907@gmail.com>","User-Agent":"Mutt/1.4.2.2i","X-Spam-Score":"-0.0 (/)","Cc":"linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.9","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linux-mtd-bounces@lists.infradead.org","Errors-To":"linux-mtd-bounces+patchwork=ozlabs.org@lists.infradead.org"}},{"id":647,"web_url":"http://patchwork.ozlabs.org/comment/647/","msgid":"<48CBA308.1070309@gmail.com>","list_archive_url":null,"date":"2008-09-13T11:24:56","subject":"Re: [PATCH 3/3] [MTD] physmap.c: Add a dummy release function","submitter":{"id":35,"url":"http://patchwork.ozlabs.org/api/people/35/","name":"Zev Weiss","email":"zevweiss@gmail.com"},"content":"Lennert Buytenhek wrote:\n> On Fri, Sep 12, 2008 at 11:33:08PM -0700, Zev Weiss wrote:\n> \n>> Adding a dummy release function to the physmap device so as to silence a log\n>> warning on initialization.\n>>\n>> Signed-off-by: Zev Weiss \n>> ---\n>> drivers/mtd/maps/physmap.c | 5 +++++\n>> 1 files changed, 5 insertions(+), 0 deletions(-)\n>>\n>> diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c\n>> index 49e2039..73a8d3c 100644\n>> --- a/drivers/mtd/maps/physmap.c\n>> +++ b/drivers/mtd/maps/physmap.c\n>> @@ -277,11 +277,16 @@ static struct resource physmap_flash_resource = {\n>> \t.flags\t\t= IORESOURCE_MEM,\n>> };\n>>\n>> +static void physmap_dummy_release(struct device *dev)\n>> +{\n>> +}\n>> +\n>> static struct platform_device physmap_flash = {\n>> \t.name\t\t= \"physmap-flash\",\n>> \t.id\t\t= 0,\n>> \t.dev\t\t= {\n>> \t\t.platform_data\t= &physmap_flash_data,\n>> +\t\t.release\t= &physmap_dummy_release,\n>> \t},\n>> \t.num_resources\t= 1,\n>> \t.resource\t= &physmap_flash_resource,\n> \n> Isn't that just papering over the issue?\n> \n\nQuite possibly -- is there something it *should* be doing? (I don't mean to suggest \nI particularly think there's not, honest question.) I had figured it was a minor \noversight and the warning was sort of a \"spurious\" one, though I'm admittedly well \nout of my depth here, so perhaps I shouldn't be doing such things (though I suppose \nit's one way to learn).","headers":{"Return-Path":"","X-Original-To":"patchwork@ozlabs.org","Delivered-To":"patchwork@ozlabs.org","Received":["from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id CFF9ADDDE0\n\tfor ; Sat, 13 Sep 2008 21:25:13 +1000 (EST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KeTFP-0006C9-QI; Sat, 13 Sep 2008 11:25:03 +0000","from wf-out-1314.google.com ([209.85.200.171])\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KeTFN-0005pd-MV\n\tfor linux-mtd@lists.infradead.org; Sat, 13 Sep 2008 11:25:02 +0000","by wf-out-1314.google.com with SMTP id 28so1202192wfc.24\n\tfor ;\n\tSat, 13 Sep 2008 04:25:00 -0700 (PDT)","by 10.142.217.19 with SMTP id p19mr1848649wfg.348.1221305100165;\n\tSat, 13 Sep 2008 04:25:00 -0700 (PDT)","from ?192.168.1.2? ( [24.84.185.161])\n\tby mx.google.com with ESMTPS id 30sm17485838wfc.5.2008.09.13.04.24.58\n\t(version=TLSv1/SSLv3 cipher=RC4-MD5);\n\tSat, 13 Sep 2008 04:24:59 -0700 (PDT)"],"Message-ID":"<48CBA308.1070309@gmail.com>","Date":"Sat, 13 Sep 2008 04:24:56 -0700","From":"Zev Weiss ","User-Agent":"Thunderbird 2.0.0.16 (X11/20080723)","MIME-Version":"1.0","To":"Lennert Buytenhek ","Subject":"Re: [PATCH 3/3] [MTD] physmap.c: Add a dummy release function","References":"<48CB5EA4.10907@gmail.com>\n\t<20080913104701.GF21603@xi.wantstofly.org>","In-Reply-To":"<20080913104701.GF21603@xi.wantstofly.org>","X-Spam-Score":"0.0 (/)","Cc":"linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.9","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linux-mtd-bounces@lists.infradead.org","Errors-To":"linux-mtd-bounces+patchwork=ozlabs.org@lists.infradead.org"}},{"id":977,"web_url":"http://patchwork.ozlabs.org/comment/977/","msgid":"<20080917120129.f6d3544b.akpm@linux-foundation.org>","list_archive_url":null,"date":"2008-09-17T19:01:29","subject":"Re: [PATCH 3/3] [MTD] physmap.c: Add a dummy release function","submitter":{"id":107,"url":"http://patchwork.ozlabs.org/api/people/107/","name":"Andrew Morton","email":"akpm@linux-foundation.org"},"content":"> Subject: [PATCH 3/3] [MTD] physmap.c: Add a dummy release function\n\nPlease avoid putting the \"MTD\" inside the [] characters. Anything\nwhich is inside [] is supposed to be discarded by the patch-receiving\nparty. This is for things like [rfc], [patch 3/12], [2.6.27-rc5], etc.\n\nBut we do want the \"mtd\" text to go all the way through into the\nmainline git metadata.\n\nOn Fri, 12 Sep 2008 23:33:08 -0700\nZev Weiss wrote:\n\n> \n> Adding a dummy release function to the physmap device so as to silence a log\n> warning on initialization.\n> \n> Signed-off-by: Zev Weiss \n> ---\n> drivers/mtd/maps/physmap.c | 5 +++++\n> 1 files changed, 5 insertions(+), 0 deletions(-)\n> \n> diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c\n> index 49e2039..73a8d3c 100644\n> --- a/drivers/mtd/maps/physmap.c\n> +++ b/drivers/mtd/maps/physmap.c\n> @@ -277,11 +277,16 @@ static struct resource physmap_flash_resource = {\n> \t.flags\t\t= IORESOURCE_MEM,\n> };\n> \n> +static void physmap_dummy_release(struct device *dev)\n> +{\n> +}\n> +\n> static struct platform_device physmap_flash = {\n> \t.name\t\t= \"physmap-flash\",\n> \t.id\t\t= 0,\n> \t.dev\t\t= {\n> \t\t.platform_data\t= &physmap_flash_data,\n> +\t\t.release\t= &physmap_dummy_release,\n> \t},\n> \t.num_resources\t= 1,\n> \t.resource\t= &physmap_flash_resource,\n\nNope. Please see Documentation/kobject.txt - search for the text\n\"mocked mercilessly\".","headers":{"Return-Path":"","X-Original-To":"linux-kernel@ozlabs.org","Delivered-To":"linux-kernel@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id C60B8DDF2D\n\tfor ; Thu, 18 Sep 2008 05:01:59 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754098AbYIQTBq (ORCPT );\n\tWed, 17 Sep 2008 15:01:46 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1752068AbYIQTBg\n\t(ORCPT );\n\tWed, 17 Sep 2008 15:01:36 -0400","from smtp1.linux-foundation.org ([140.211.169.13]:41741 \"EHLO\n\tsmtp1.linux-foundation.org\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751823AbYIQTBf (ORCPT\n\t);\n\tWed, 17 Sep 2008 15:01:35 -0400","from imap1.linux-foundation.org (imap1.linux-foundation.org\n\t[140.211.169.55])\n\tby smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with\n\tESMTP id m8HJ1Uue020930\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);\n\tWed, 17 Sep 2008 12:01:31 -0700","from akpm.corp.google.com (localhost [127.0.0.1])\n\tby imap1.linux-foundation.org\n\t(8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with SMTP id\n\tm8HJ1T9Z025556; Wed, 17 Sep 2008 12:01:29 -0700"],"Date":"Wed, 17 Sep 2008 12:01:29 -0700","From":"Andrew Morton ","To":"Zev Weiss ","Cc":"linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH 3/3] [MTD] physmap.c: Add a dummy release function","Message-Id":"<20080917120129.f6d3544b.akpm@linux-foundation.org>","In-Reply-To":"<48CB5EA4.10907@gmail.com>","References":"<48CB5EA4.10907@gmail.com>","X-Mailer":"Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu)","Mime-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, hits=-3.354 required=5 tests=AWL, BAYES_00,\n\tOSDL_HEADER_SUBJECT_BRACKETED","X-Spam-Checker-Version":"SpamAssassin 3.2.4-osdl_revision__1.47__","X-MIMEDefang-Filter":"lf$Revision: 1.188 $","X-Scanned-By":"MIMEDefang 2.63 on 140.211.169.13","Sender":"linux-kernel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-kernel@vger.kernel.org"}}]