[{"id":644,"web_url":"http://patchwork.ozlabs.org/comment/644/","msgid":"<20080913104542.GD21603@xi.wantstofly.org>","list_archive_url":null,"date":"2008-09-13T10:45:42","subject":"Re: [PATCH 1/3] [MTD] physmap.c: Check return of\n\tplatform_device_register()","submitter":{"id":94,"url":"http://patchwork.ozlabs.org/api/people/94/","name":"Lennert Buytenhek","email":"buytenh@wantstofly.org"},"content":"On Fri, Sep 12, 2008 at 11:32:58PM -0700, Zev Weiss wrote:\n\n> The PHYSMAP_COMPAT code had been ignoring the return value of\n> platform_device_register() in the physmap_init() function.\n> \n> Signed-off-by: Zev Weiss \n> ---\n> drivers/mtd/maps/physmap.c | 2 +-\n> 1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c\n> index 42d844f..6fba0d4 100644\n> --- a/drivers/mtd/maps/physmap.c\n> +++ b/drivers/mtd/maps/physmap.c\n> @@ -312,7 +312,7 @@ static int __init physmap_init(void)\n> \terr = platform_driver_register(&physmap_flash_driver);\n> #ifdef PHYSMAP_COMPAT\n> \tif (err == 0)\n> -\t\tplatform_device_register(&physmap_flash);\n> +\t\terr = platform_device_register(&physmap_flash);\n> #endif\n\nI don't think you want the registration of the physmap driver to fail\nif the compat platform device fails to register.\n\nOne reason that the compat platform device can fail to register can be\nthat there is already a non-compat platform device for the compat flash\nchip, and in that case I don't think you want to fail the driver init\n(while leaving the physmap_flash_driver registered, too!).","headers":{"Return-Path":"","X-Original-To":"patchwork@ozlabs.org","Delivered-To":"patchwork@ozlabs.org","Received":["from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id C861FDDDE1\n\tfor ; Sat, 13 Sep 2008 20:46:14 +1000 (EST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KeSdQ-0002A2-KB; Sat, 13 Sep 2008 10:45:48 +0000","from [2002:53a0:b870::1] (helo=xi.wantstofly.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KeSdN-00029w-K4\n\tfor linux-mtd@lists.infradead.org; Sat, 13 Sep 2008 10:45:46 +0000","by xi.wantstofly.org (Postfix, from userid 500)\n\tid D21E07FAB2; Sat, 13 Sep 2008 12:45:42 +0200 (CEST)"],"Date":"Sat, 13 Sep 2008 12:45:42 +0200","From":"Lennert Buytenhek ","To":"Zev Weiss ","Subject":"Re: [PATCH 1/3] [MTD] physmap.c: Check return of\n\tplatform_device_register()","Message-ID":"<20080913104542.GD21603@xi.wantstofly.org>","References":"<48CB5E9A.4010000@gmail.com>","Mime-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<48CB5E9A.4010000@gmail.com>","User-Agent":"Mutt/1.4.2.2i","X-Spam-Score":"-0.0 (/)","Cc":"linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.9","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linux-mtd-bounces@lists.infradead.org","Errors-To":"linux-mtd-bounces+patchwork=ozlabs.org@lists.infradead.org"}},{"id":649,"web_url":"http://patchwork.ozlabs.org/comment/649/","msgid":"<48CBA3A4.7020308@gmail.com>","list_archive_url":null,"date":"2008-09-13T11:27:32","subject":"Re: [PATCH 1/3] [MTD] physmap.c: Check return of\n\tplatform_device_register()","submitter":{"id":35,"url":"http://patchwork.ozlabs.org/api/people/35/","name":"Zev Weiss","email":"zevweiss@gmail.com"},"content":"Lennert Buytenhek wrote:\n> On Fri, Sep 12, 2008 at 11:32:58PM -0700, Zev Weiss wrote:\n> \n>> The PHYSMAP_COMPAT code had been ignoring the return value of\n>> platform_device_register() in the physmap_init() function.\n>>\n>> Signed-off-by: Zev Weiss \n>> ---\n>> drivers/mtd/maps/physmap.c | 2 +-\n>> 1 files changed, 1 insertions(+), 1 deletions(-)\n>>\n>> diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c\n>> index 42d844f..6fba0d4 100644\n>> --- a/drivers/mtd/maps/physmap.c\n>> +++ b/drivers/mtd/maps/physmap.c\n>> @@ -312,7 +312,7 @@ static int __init physmap_init(void)\n>> \terr = platform_driver_register(&physmap_flash_driver);\n>> #ifdef PHYSMAP_COMPAT\n>> \tif (err == 0)\n>> -\t\tplatform_device_register(&physmap_flash);\n>> +\t\terr = platform_device_register(&physmap_flash);\n>> #endif\n> \n> I don't think you want the registration of the physmap driver to fail\n> if the compat platform device fails to register.\n> \n> One reason that the compat platform device can fail to register can be\n> that there is already a non-compat platform device for the compat flash\n> chip, and in that case I don't think you want to fail the driver init\n> (while leaving the physmap_flash_driver registered, too!).\n> \n\nChalk another one up to ignorance on my part...sounds like a nak all 'round.","headers":{"Return-Path":"","X-Original-To":"patchwork@ozlabs.org","Delivered-To":"patchwork@ozlabs.org","Received":["from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id 10EF0DDDE0\n\tfor ; Sat, 13 Sep 2008 21:27:43 +1000 (EST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KeTHt-0006Jv-IY; Sat, 13 Sep 2008 11:27:37 +0000","from wf-out-1314.google.com ([209.85.200.174])\n\tby bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux))\n\tid 1KeTHs-0006Jl-4S\n\tfor linux-mtd@lists.infradead.org; Sat, 13 Sep 2008 11:27:36 +0000","by wf-out-1314.google.com with SMTP id 28so1202899wfc.24\n\tfor ;\n\tSat, 13 Sep 2008 04:27:35 -0700 (PDT)","by 10.142.231.7 with SMTP id d7mr1854383wfh.246.1221305255419;\n\tSat, 13 Sep 2008 04:27:35 -0700 (PDT)","from ?192.168.1.2? ( [24.84.185.161])\n\tby mx.google.com with ESMTPS id 30sm17525324wfg.9.2008.09.13.04.27.33\n\t(version=TLSv1/SSLv3 cipher=RC4-MD5);\n\tSat, 13 Sep 2008 04:27:34 -0700 (PDT)"],"Message-ID":"<48CBA3A4.7020308@gmail.com>","Date":"Sat, 13 Sep 2008 04:27:32 -0700","From":"Zev Weiss ","User-Agent":"Thunderbird 2.0.0.16 (X11/20080723)","MIME-Version":"1.0","To":"Lennert Buytenhek ","Subject":"Re: [PATCH 1/3] [MTD] physmap.c: Check return of\n\tplatform_device_register()","References":"<48CB5E9A.4010000@gmail.com>\n\t<20080913104542.GD21603@xi.wantstofly.org>","In-Reply-To":"<20080913104542.GD21603@xi.wantstofly.org>","X-Spam-Score":"0.0 (/)","Cc":"linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.9","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linux-mtd-bounces@lists.infradead.org","Errors-To":"linux-mtd-bounces+patchwork=ozlabs.org@lists.infradead.org"}},{"id":975,"web_url":"http://patchwork.ozlabs.org/comment/975/","msgid":"<20080917115746.e36cacc6.akpm@linux-foundation.org>","list_archive_url":null,"date":"2008-09-17T18:57:46","subject":"Re: [PATCH 1/3] [MTD] physmap.c: Check return of\n\tplatform_device_register()","submitter":{"id":107,"url":"http://patchwork.ozlabs.org/api/people/107/","name":"Andrew Morton","email":"akpm@linux-foundation.org"},"content":"On Fri, 12 Sep 2008 23:32:58 -0700\nZev Weiss wrote:\n\n> The PHYSMAP_COMPAT code had been ignoring the return value of\n> platform_device_register() in the physmap_init() function.\n> \n> Signed-off-by: Zev Weiss \n> ---\n> drivers/mtd/maps/physmap.c | 2 +-\n> 1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c\n> index 42d844f..6fba0d4 100644\n> --- a/drivers/mtd/maps/physmap.c\n> +++ b/drivers/mtd/maps/physmap.c\n> @@ -312,7 +312,7 @@ static int __init physmap_init(void)\n> \terr = platform_driver_register(&physmap_flash_driver);\n> #ifdef PHYSMAP_COMPAT\n> \tif (err == 0)\n> -\t\tplatform_device_register(&physmap_flash);\n> +\t\terr = platform_device_register(&physmap_flash);\n> #endif\n> \n> \treturn err;\n\nYour email client is performing space-stuffing, thus making the patches\nunapplyable.\n\nPresumably we should run platform_driver_unregister() if the\nplatform_device_register() failed.","headers":{"Return-Path":"","X-Original-To":"linux-kernel@ozlabs.org","Delivered-To":"linux-kernel@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 18F5DDDFC3\n\tfor ; Thu, 18 Sep 2008 04:58:27 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753380AbYIQS6K (ORCPT );\n\tWed, 17 Sep 2008 14:58:10 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1752399AbYIQS5z\n\t(ORCPT );\n\tWed, 17 Sep 2008 14:57:55 -0400","from smtp1.linux-foundation.org ([140.211.169.13]:38168 \"EHLO\n\tsmtp1.linux-foundation.org\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1752266AbYIQS5y (ORCPT\n\t);\n\tWed, 17 Sep 2008 14:57:54 -0400","from imap1.linux-foundation.org (imap1.linux-foundation.org\n\t[140.211.169.55])\n\tby smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with\n\tESMTP id m8HIvkLc020761\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);\n\tWed, 17 Sep 2008 11:57:47 -0700","from akpm.corp.google.com (localhost [127.0.0.1])\n\tby imap1.linux-foundation.org\n\t(8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with SMTP id\n\tm8HIvku7025387; Wed, 17 Sep 2008 11:57:46 -0700"],"Date":"Wed, 17 Sep 2008 11:57:46 -0700","From":"Andrew Morton ","To":"Zev Weiss ","Cc":"linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH 1/3] [MTD] physmap.c: Check return of\n\tplatform_device_register()","Message-Id":"<20080917115746.e36cacc6.akpm@linux-foundation.org>","In-Reply-To":"<48CB5E9A.4010000@gmail.com>","References":"<48CB5E9A.4010000@gmail.com>","X-Mailer":"Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu)","Mime-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Spam-Status":"No, hits=-3.354 required=5 tests=AWL, BAYES_00,\n\tOSDL_HEADER_SUBJECT_BRACKETED","X-Spam-Checker-Version":"SpamAssassin 3.2.4-osdl_revision__1.47__","X-MIMEDefang-Filter":"lf$Revision: 1.188 $","X-Scanned-By":"MIMEDefang 2.63 on 140.211.169.13","Sender":"linux-kernel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-kernel@vger.kernel.org"}},{"id":990,"web_url":"http://patchwork.ozlabs.org/comment/990/","msgid":"<48D15DC8.60307@ru.mvista.com>","list_archive_url":null,"date":"2008-09-17T19:43:04","subject":"Re: [PATCH 1/3] [MTD] physmap.c: Check return\n\tof\tplatform_device_register()","submitter":{"id":238,"url":"http://patchwork.ozlabs.org/api/people/238/","name":"Sergei Shtylyov","email":"sshtylyov@ru.mvista.com"},"content":"Hello.\n\nAndrew Morton wrote:\n\n>>The PHYSMAP_COMPAT code had been ignoring the return value of\n>>platform_device_register() in the physmap_init() function.\n\n>>Signed-off-by: Zev Weiss \n[...]\n>>diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c\n>>index 42d844f..6fba0d4 100644\n>>--- a/drivers/mtd/maps/physmap.c\n>>+++ b/drivers/mtd/maps/physmap.c\n>>@@ -312,7 +312,7 @@ static int __init physmap_init(void)\n>> \terr = platform_driver_register(&physmap_flash_driver);\n>> #ifdef PHYSMAP_COMPAT\n>> \tif (err == 0)\n>>-\t\tplatform_device_register(&physmap_flash);\n>>+\t\terr = platform_device_register(&physmap_flash);\n>> #endif\n>>\n>> \treturn err;\n\n> Your email client is performing space-stuffing, thus making the patches\n> unapplyable.\n\n Er... are you sure? The patch looks alright tab wise, even after quoting...\n\n> Presumably we should run platform_driver_unregister() if the\n> platform_device_register() failed.\n\n Why is that? There could be \"normal\" platform devices out there...\n\nWBR, Sergei","headers":{"Return-Path":"","X-Original-To":"linux-kernel@ozlabs.org","Delivered-To":"linux-kernel@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 99C63DE0B9\n\tfor ; Thu, 18 Sep 2008 05:42:51 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755276AbYIQTm3 (ORCPT );\n\tWed, 17 Sep 2008 15:42:29 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1752926AbYIQTmR\n\t(ORCPT );\n\tWed, 17 Sep 2008 15:42:17 -0400","from h155.mvista.com ([63.81.120.155]:50336 \"EHLO\n\timap.sh.mvista.com\"\n\trhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1752916AbYIQTmQ (ORCPT );\n\tWed, 17 Sep 2008 15:42:16 -0400","from [192.168.1.234] (unknown [10.150.0.9])\n\tby imap.sh.mvista.com (Postfix) with ESMTP\n\tid 13C603ECC; Wed, 17 Sep 2008 12:42:15 -0700 (PDT)"],"Message-ID":"<48D15DC8.60307@ru.mvista.com>","Date":"Wed, 17 Sep 2008 23:43:04 +0400","From":"Sergei Shtylyov ","Organization":"MontaVista Software Inc.","User-Agent":"Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803","X-Accept-Language":"ru, en-us, en-gb","MIME-Version":"1.0","To":"Andrew Morton ","Cc":"Zev Weiss , linux-mtd@lists.infradead.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 1/3] [MTD] physmap.c: Check return\n\tof\tplatform_device_register()","References":"<48CB5E9A.4010000@gmail.com>\n\t<20080917115746.e36cacc6.akpm@linux-foundation.org>","In-Reply-To":"<20080917115746.e36cacc6.akpm@linux-foundation.org>","Content-Type":"text/plain; charset=us-ascii; format=flowed","Content-Transfer-Encoding":"7bit","Sender":"linux-kernel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-kernel@vger.kernel.org"}},{"id":992,"web_url":"http://patchwork.ozlabs.org/comment/992/","msgid":"<48D15EAD.1030804@ru.mvista.com>","list_archive_url":null,"date":"2008-09-17T19:46:53","subject":"Re: [PATCH 1/3] [MTD] physmap.c: Check return\n\tof\tplatform_device_register()","submitter":{"id":238,"url":"http://patchwork.ozlabs.org/api/people/238/","name":"Sergei Shtylyov","email":"sshtylyov@ru.mvista.com"},"content":"I just wrote:\n\n>>> The PHYSMAP_COMPAT code had been ignoring the return value of\n>>> platform_device_register() in the physmap_init() function.\n\n>>> Signed-off-by: Zev Weiss \n\n> [...]\n\n>>> diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c\n>>> index 42d844f..6fba0d4 100644\n>>> --- a/drivers/mtd/maps/physmap.c\n>>> +++ b/drivers/mtd/maps/physmap.c\n>>> @@ -312,7 +312,7 @@ static int __init physmap_init(void)\n>>> err = platform_driver_register(&physmap_flash_driver);\n>>> #ifdef PHYSMAP_COMPAT\n>>> if (err == 0)\n>>> - platform_device_register(&physmap_flash);\n>>> + err = platform_device_register(&physmap_flash);\n>>> #endif\n>>>\n>>> return err;\n\n[...]\n\n>> Presumably we should run platform_driver_unregister() if the\n>> platform_device_register() failed.\n\n> Why is that? There could be \"normal\" platform devices out there...\n\n With that said, the patch is pointless (as already noted by Lennert).\n\nWBR, Sergei","headers":{"Return-Path":"","X-Original-To":"linux-kernel@ozlabs.org","Delivered-To":"linux-kernel@ozlabs.org","Received":["from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id 6B48BDDEE4\n\tfor ; Thu, 18 Sep 2008 05:46:35 +1000 (EST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755420AbYIQTqT (ORCPT );\n\tWed, 17 Sep 2008 15:46:19 -0400","(majordomo@vger.kernel.org) by vger.kernel.org id S1752554AbYIQTqI\n\t(ORCPT );\n\tWed, 17 Sep 2008 15:46:08 -0400","from h155.mvista.com ([63.81.120.155]:50379 \"EHLO\n\timap.sh.mvista.com\"\n\trhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1752460AbYIQTqF (ORCPT );\n\tWed, 17 Sep 2008 15:46:05 -0400","from [192.168.1.234] (unknown [10.150.0.9])\n\tby imap.sh.mvista.com (Postfix) with ESMTP\n\tid 6EA9C3ECC; Wed, 17 Sep 2008 12:46:04 -0700 (PDT)"],"Message-ID":"<48D15EAD.1030804@ru.mvista.com>","Date":"Wed, 17 Sep 2008 23:46:53 +0400","From":"Sergei Shtylyov ","Organization":"MontaVista Software Inc.","User-Agent":"Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803","X-Accept-Language":"ru, en-us, en-gb","MIME-Version":"1.0","To":"Andrew Morton ","Cc":"Zev Weiss , linux-mtd@lists.infradead.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 1/3] [MTD] physmap.c: Check return\n\tof\tplatform_device_register()","References":"<48CB5E9A.4010000@gmail.com>\n\t<20080917115746.e36cacc6.akpm@linux-foundation.org>\n\t<48D15DC8.60307@ru.mvista.com>","In-Reply-To":"<48D15DC8.60307@ru.mvista.com>","Content-Type":"text/plain; charset=us-ascii; format=flowed","Content-Transfer-Encoding":"7bit","Sender":"linux-kernel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-kernel@vger.kernel.org"}}]