[{"id":652,"web_url":"http://patchwork.ozlabs.org/comment/652/","msgid":"<1221328571.7675.29.camel@pasglop>","date":"2008-09-13T17:56:11","subject":"Re: [PATCH v4 1/4] powerpc: Introduce local (non-broadcast) forms\n\tof tlb invalidates","submitter":{"id":38,"url":"http://patchwork.ozlabs.org/api/people/38/","name":"Benjamin Herrenschmidt","email":"benh@kernel.crashing.org"},"content":">  static inline void flush_tlb_range(struct vm_area_struct *vma,\n>  \t\t\t\t   unsigned long start, unsigned long end)\n>  {\n> -\t_tlbia();\n> +\t_tlbil_all();\n>  }\n\nWhy not the _pid() variant here ?\n\n> +/*\n> + * Flush MMU TLB for a particular process id, but only on the local processor\n> + * (no broadcast)\n> + */\n> +_GLOBAL(_tlbil_pid)\n> +\tli\tr3,(MMUCSR0_TLBFI)@l\n> +\tmtspr\tSPRN_MMUCSR0, r3\n> +1:\n> +\tmfspr\tr3,SPRN_MMUCSR0\n> +\tandi.\tr3,r3,MMUCSR0_TLBFI@l\n> +\tbne\t1b\n> +\tblr\n\nThis will do a full inval of the TLB right ? Might be worth mentioning\nthis implementation limitation in a comment..\n\nCheers,\nBen.","headers":{"Return-Path":"<linuxppc-dev-bounces+patchwork=ozlabs.org@ozlabs.org>","X-Original-To":["patchwork@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 96093DDF85\n\tfor <patchwork@ozlabs.org>; Sun, 14 Sep 2008 03:56:34 +1000 (EST)","from gate.crashing.org (gate.crashing.org [63.228.1.57])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id 6E680DDE24\n\tfor <linuxppc-dev@ozlabs.org>; Sun, 14 Sep 2008 03:56:16 +1000 (EST)","from [127.0.0.1] (localhost.localdomain [127.0.0.1])\n\tby gate.crashing.org (8.14.1/8.13.8) with ESMTP id m8DHuCik021223;\n\tSat, 13 Sep 2008 12:56:12 -0500"],"Subject":"Re: [PATCH v4 1/4] powerpc: Introduce local (non-broadcast) forms\n\tof tlb invalidates","From":"Benjamin Herrenschmidt <benh@kernel.crashing.org>","To":"Kumar Gala <galak@kernel.crashing.org>","In-Reply-To":"<1221253688-25864-1-git-send-email-galak@kernel.crashing.org>","References":"<1221253688-25864-1-git-send-email-galak@kernel.crashing.org>","Date":"Sat, 13 Sep 2008 10:56:11 -0700","Message-Id":"<1221328571.7675.29.camel@pasglop>","Mime-Version":"1.0","X-Mailer":"Evolution 2.22.3.1 ","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","Reply-To":"benh@kernel.crashing.org","List-Id":"Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>","List-Unsubscribe":"<https://ozlabs.org/mailman/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>","List-Archive":"<http://ozlabs.org/pipermail/linuxppc-dev>","List-Post":"<mailto:linuxppc-dev@ozlabs.org>","List-Help":"<mailto:linuxppc-dev-request@ozlabs.org?subject=help>","List-Subscribe":"<https://ozlabs.org/mailman/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork=ozlabs.org@ozlabs.org"}}]