[{"id":9638,"web_url":"http://patchwork.ozlabs.org/comment/9638/","msgid":"<20081013144904.GB18363@yoda.jdub.homelinux.org>","date":"2008-10-13T14:49:04","subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","submitter":{"id":8,"url":"http://patchwork.ozlabs.org/api/people/8/","name":"Josh Boyer","email":"jwboyer@linux.vnet.ibm.com"},"content":"On Fri, Sep 12, 2008 at 03:34:46PM -0500, Becky Bruce wrote:\n>We essentially adopt the 64-bit dma code, with some changes to support\n>32-bit systems, including HIGHMEM. dma functions on 32-bit are now\n>invoked via accessor functions which call the correct op for a device based\n>on archdata dma_ops. If there is no archdata dma_ops, this defaults\n>to dma_direct_ops.\n>\n>In addition, the dma_map/unmap_page functions are added to dma_ops\n>because we can't just fall back on map/unmap_single when HIGHMEM is\n>enabled. In the case of dma_direct_*, we stop using map/unmap_single\n>and just use the page version - this saves a lot of ugly\n>ifdeffing. We leave map/unmap_single in the dma_ops definition,\n>though, because they are needed by the iommu code, which does not\n>implement map/unmap_page. Ideally, going forward, we will completely\n>eliminate map/unmap_single and just have map/unmap_page, if it's\n>workable for 64-bit.\n>\n>Signed-off-by: Becky Bruce \n\nWhile doing a buildall this morning, I notice chrp32_defconfig fails\nto build with:\n\ndrivers/built-in.o: In function `hard_dma_setup':\nfloppy.c:(.text+0x6e40e): undefined reference to `isa_bridge_pcidev'\nfloppy.c:(.text+0x6e412): undefined reference to `isa_bridge_pcidev'\nfloppy.c:(.text+0x6e53e): undefined reference to `isa_bridge_pcidev'\nfloppy.c:(.text+0x6e546): undefined reference to `isa_bridge_pcidev'\nfloppy.c:(.text+0x6e54a): undefined reference to `isa_bridge_pcidev'\nmake[1]: *** [.tmp_vmlinux1] Error 1\n\n(the hard_dma_setup thing is in arch/powerpc/include/asm/floppy.h).\n\nI did a git bisect and it pointed at this commit as causing the build\nto fail. Why, I have no idea.\n\njosh","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 80FDEDE4F2\n\tfor ;\n\tTue, 14 Oct 2008 01:50:43 +1100 (EST)","from yx-out-2324.google.com (yx-out-2324.google.com [74.125.44.29])\n\tby ozlabs.org (Postfix) with ESMTP id C55B9DE0BA\n\tfor ; Tue, 14 Oct 2008 01:50:29 +1100 (EST)","by yx-out-2324.google.com with SMTP id 8so383386yxg.39\n\tfor ; Mon, 13 Oct 2008 07:50:27 -0700 (PDT)","by 10.90.99.3 with SMTP id w3mr5550614agb.27.1223909427372;\n\tMon, 13 Oct 2008 07:50:27 -0700 (PDT)","from yoda.jdub.homelinux.org\n\t(24-247-237-59.dhcp.aldl.mi.charter.com [24.247.237.59])\n\tby mx.google.com with ESMTPS id 20sm6568774agb.38.2008.10.13.07.50.25\n\t(version=TLSv1/SSLv3 cipher=RC4-MD5);\n\tMon, 13 Oct 2008 07:50:26 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; \n\th=domainkey-signature:received:received:date:from:to:cc:subject\n\t:message-id:references:mime-version:content-type:content-disposition\n\t:in-reply-to:user-agent:sender;\n\tbh=XFtMhyTU2H1vQWiYESnsa0tZmLwXZgn9MFHyRa5+Q/0=;\n\tb=Zm6bZacfdtHfANA6lMtiEKzGfKiiSlNIYokfrlOIv9SaUUde8n71ACIR8rawpQiPiB\n\tv711yICU8ZIgX0oTcHLXp6XDxzdJiIMyhwGIaddN87XispYqsuj9E7RjGeymSOmWefpb\n\tDd1a0I5OQfF5u3Tv/NrRY4MEFBn2kjPQI2ofQ=","DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-type:content-disposition:in-reply-to:user-agent:sender;\n\tb=ay/s36uSTGuYl7R9XcKGCUn4GZXVZgZkiyHinFTF/zY6+Rp7aGcOSLe35VKeCkkBEH\n\to7SQ+R5UWxXb+G4TmqWbWsh+RfbiGu3uR/OUCG4juJvyUueBlr7RZhLQqGT2yAlCeEth\n\tfTMZZVeJRdfaF4I9tBcGI96Ce3yKzIvND8qAk=","Date":"Mon, 13 Oct 2008 10:49:04 -0400","From":"Josh Boyer ","To":"Becky Bruce ","Subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","Message-ID":"<20081013144904.GB18363@yoda.jdub.homelinux.org>","References":"<1220900995-11928-5-git-send-email-becky.bruce@freescale.com>\n\t<1221251686-5567-1-git-send-email-becky.bruce@freescale.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1221251686-5567-1-git-send-email-becky.bruce@freescale.com>","User-Agent":"Mutt/1.5.18 (2008-05-17)","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":9652,"web_url":"http://patchwork.ozlabs.org/comment/9652/","msgid":"<20081013154127.GA27124@yoda.jdub.homelinux.org>","date":"2008-10-13T15:41:27","subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","submitter":{"id":8,"url":"http://patchwork.ozlabs.org/api/people/8/","name":"Josh Boyer","email":"jwboyer@linux.vnet.ibm.com"},"content":"On Mon, Oct 13, 2008 at 10:49:04AM -0400, Josh Boyer wrote:\n>On Fri, Sep 12, 2008 at 03:34:46PM -0500, Becky Bruce wrote:\n>>We essentially adopt the 64-bit dma code, with some changes to support\n>>32-bit systems, including HIGHMEM. dma functions on 32-bit are now\n>>invoked via accessor functions which call the correct op for a device based\n>>on archdata dma_ops. If there is no archdata dma_ops, this defaults\n>>to dma_direct_ops.\n>>\n>>In addition, the dma_map/unmap_page functions are added to dma_ops\n>>because we can't just fall back on map/unmap_single when HIGHMEM is\n>>enabled. In the case of dma_direct_*, we stop using map/unmap_single\n>>and just use the page version - this saves a lot of ugly\n>>ifdeffing. We leave map/unmap_single in the dma_ops definition,\n>>though, because they are needed by the iommu code, which does not\n>>implement map/unmap_page. Ideally, going forward, we will completely\n>>eliminate map/unmap_single and just have map/unmap_page, if it's\n>>workable for 64-bit.\n>>\n>>Signed-off-by: Becky Bruce \n>\n>While doing a buildall this morning, I notice chrp32_defconfig fails\n>to build with:\n>\n>drivers/built-in.o: In function `hard_dma_setup':\n>floppy.c:(.text+0x6e40e): undefined reference to `isa_bridge_pcidev'\n>floppy.c:(.text+0x6e412): undefined reference to `isa_bridge_pcidev'\n>floppy.c:(.text+0x6e53e): undefined reference to `isa_bridge_pcidev'\n>floppy.c:(.text+0x6e546): undefined reference to `isa_bridge_pcidev'\n>floppy.c:(.text+0x6e54a): undefined reference to `isa_bridge_pcidev'\n>make[1]: *** [.tmp_vmlinux1] Error 1\n>\n>(the hard_dma_setup thing is in arch/powerpc/include/asm/floppy.h).\n>\n>I did a git bisect and it pointed at this commit as causing the build\n>to fail. Why, I have no idea.\n\nOk, I was annoyed enough to look at why.\n\nBasically, before this patch pci_map_single on 32-bit PPC seemed to\nbe compiled down to __dma_sync(ptr, size, direction); and the \"dev\"\nparameter to the function was never actually used. The compiler\nseems to have optimized this out entirely, so we don't get the odd\nlink reference to isa_bridge_pcidev at all. (Neither pci_map_single\nor isa_bridge_pcidev are present in the vmlinux at all).\n\nWith the patch, the compiler doesn't do this code elimination\nbecause pci_map_single boils down to dma_map_page, which calls\nget_dma_direct_offset with the \"dev\" parameter. So since it is\nstill used, the compiler can't eliminate it and hence FAIL.\n\nI have no patch for this at the moment. Someone should look at\nit more closely, because this is causing the 5 chrp32_defconfig\nusers to weep.\n\njosh","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 5DE45DE52E\n\tfor ;\n\tTue, 14 Oct 2008 02:43:12 +1100 (EST)","from mail-gx0-f14.google.com (mail-gx0-f14.google.com\n\t[209.85.217.14]) by ozlabs.org (Postfix) with ESMTP id 50EB5DE04B\n\tfor ; Tue, 14 Oct 2008 02:42:57 +1100 (EST)","by gxk7 with SMTP id 7so4481982gxk.9\n\tfor ; Mon, 13 Oct 2008 08:42:55 -0700 (PDT)","by 10.100.14.17 with SMTP id 17mr5868848ann.97.1223912575111;\n\tMon, 13 Oct 2008 08:42:55 -0700 (PDT)","from yoda.jdub.homelinux.org\n\t(24-247-237-59.dhcp.aldl.mi.charter.com [24.247.237.59])\n\tby mx.google.com with ESMTPS id s12sm9814514qbs.9.2008.10.13.08.42.53\n\t(version=TLSv1/SSLv3 cipher=RC4-MD5);\n\tMon, 13 Oct 2008 08:42:53 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; \n\th=domainkey-signature:received:received:date:from:to:cc:subject\n\t:message-id:references:mime-version:content-type:content-disposition\n\t:in-reply-to:user-agent:sender;\n\tbh=OuGC2ACKrUfCaMJgmqk9BeYFIxS1IW87zqx2S8Lk0ik=;\n\tb=TZYBINbn39OidWTTKor+Bt1hSJ2ACWsT2YLLLPZtubPPMOqa3OzXGN8qar9asxGYcR\n\t314EVf731cgXdZPiZILAjjpH1UGNqOin9AXu+J1X1O3vqe+JXvQt9/Uh5ri0KwGvlMnH\n\too/UcT3HXlI9K6VBLtnegn0u7mFZBiRmp23TE=","DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-type:content-disposition:in-reply-to:user-agent:sender;\n\tb=YA4kC9SGiA1UtBdP36/dbG/XXwbHc9k7eYq2nzpp6VLwdYHHGnTL7vtUDnqxpLo3SI\n\tUq47hSELX35qOjM8T64ZX/51GJmTft/NZb5CdlKBvT8xNheRCK6G24RrVYlTZvpQQ0Cb\n\tHPksGUTfU/ZJ9Gy7MCVN5++vGgSRj9UT5WG1E=","Date":"Mon, 13 Oct 2008 11:41:27 -0400","From":"Josh Boyer ","To":"Becky Bruce ","Subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","Message-ID":"<20081013154127.GA27124@yoda.jdub.homelinux.org>","References":"<1220900995-11928-5-git-send-email-becky.bruce@freescale.com>\n\t<1221251686-5567-1-git-send-email-becky.bruce@freescale.com>\n\t<20081013144904.GB18363@yoda.jdub.homelinux.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20081013144904.GB18363@yoda.jdub.homelinux.org>","User-Agent":"Mutt/1.5.18 (2008-05-17)","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":9707,"web_url":"http://patchwork.ozlabs.org/comment/9707/","msgid":"<209E575D-DDE2-406A-82DE-2DD445046C02@kernel.crashing.org>","date":"2008-10-13T18:06:36","subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","submitter":{"id":5,"url":"http://patchwork.ozlabs.org/api/people/5/","name":"Kumar Gala","email":"galak@kernel.crashing.org"},"content":"On Oct 13, 2008, at 10:41 AM, Josh Boyer wrote:\n\n> On Mon, Oct 13, 2008 at 10:49:04AM -0400, Josh Boyer wrote:\n>> On Fri, Sep 12, 2008 at 03:34:46PM -0500, Becky Bruce wrote:\n>>> We essentially adopt the 64-bit dma code, with some changes to \n>>> support\n>>> 32-bit systems, including HIGHMEM. dma functions on 32-bit are now\n>>> invoked via accessor functions which call the correct op for a \n>>> device based\n>>> on archdata dma_ops. If there is no archdata dma_ops, this defaults\n>>> to dma_direct_ops.\n>>>\n>>> In addition, the dma_map/unmap_page functions are added to dma_ops\n>>> because we can't just fall back on map/unmap_single when HIGHMEM is\n>>> enabled. In the case of dma_direct_*, we stop using map/unmap_single\n>>> and just use the page version - this saves a lot of ugly\n>>> ifdeffing. We leave map/unmap_single in the dma_ops definition,\n>>> though, because they are needed by the iommu code, which does not\n>>> implement map/unmap_page. Ideally, going forward, we will \n>>> completely\n>>> eliminate map/unmap_single and just have map/unmap_page, if it's\n>>> workable for 64-bit.\n>>>\n>>> Signed-off-by: Becky Bruce \n>>\n>> While doing a buildall this morning, I notice chrp32_defconfig fails\n>> to build with:\n>>\n>> drivers/built-in.o: In function `hard_dma_setup':\n>> floppy.c:(.text+0x6e40e): undefined reference to `isa_bridge_pcidev'\n>> floppy.c:(.text+0x6e412): undefined reference to `isa_bridge_pcidev'\n>> floppy.c:(.text+0x6e53e): undefined reference to `isa_bridge_pcidev'\n>> floppy.c:(.text+0x6e546): undefined reference to `isa_bridge_pcidev'\n>> floppy.c:(.text+0x6e54a): undefined reference to `isa_bridge_pcidev'\n>> make[1]: *** [.tmp_vmlinux1] Error 1\n>>\n>> (the hard_dma_setup thing is in arch/powerpc/include/asm/floppy.h).\n>>\n>> I did a git bisect and it pointed at this commit as causing the build\n>> to fail. Why, I have no idea.\n>\n> Ok, I was annoyed enough to look at why.\n>\n> Basically, before this patch pci_map_single on 32-bit PPC seemed to\n> be compiled down to __dma_sync(ptr, size, direction); and the \"dev\"\n> parameter to the function was never actually used. The compiler\n> seems to have optimized this out entirely, so we don't get the odd\n> link reference to isa_bridge_pcidev at all. (Neither pci_map_single\n> or isa_bridge_pcidev are present in the vmlinux at all).\n>\n> With the patch, the compiler doesn't do this code elimination\n> because pci_map_single boils down to dma_map_page, which calls\n> get_dma_direct_offset with the \"dev\" parameter. So since it is\n> still used, the compiler can't eliminate it and hence FAIL.\n>\n> I have no patch for this at the moment. Someone should look at\n> it more closely, because this is causing the 5 chrp32_defconfig\n> users to weep.\n\nIsn't this the type of regression we should fix post -rc1 :)\n\n- k","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 26372DE9ED\n\tfor ;\n\tTue, 14 Oct 2008 05:10:23 +1100 (EST)","from gate.crashing.org (gate.crashing.org [63.228.1.57])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id EA14DDE072\n\tfor ; Tue, 14 Oct 2008 05:10:03 +1100 (EST)","from [IPv6:::1] (localhost.localdomain [127.0.0.1])\n\tby gate.crashing.org (8.14.1/8.13.8) with ESMTP id m9DI6bBY001510;\n\tMon, 13 Oct 2008 13:06:37 -0500"],"Message-Id":"<209E575D-DDE2-406A-82DE-2DD445046C02@kernel.crashing.org>","From":"Kumar Gala ","To":"Josh Boyer ","In-Reply-To":"<20081013154127.GA27124@yoda.jdub.homelinux.org>","Mime-Version":"1.0 (Apple Message framework v929.2)","Subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","Date":"Mon, 13 Oct 2008 13:06:36 -0500","References":"<1220900995-11928-5-git-send-email-becky.bruce@freescale.com>\n\t<1221251686-5567-1-git-send-email-becky.bruce@freescale.com>\n\t<20081013144904.GB18363@yoda.jdub.homelinux.org>\n\t<20081013154127.GA27124@yoda.jdub.homelinux.org>","X-Mailer":"Apple Mail (2.929.2)","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"; DelSp=\"yes\"","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":9714,"web_url":"http://patchwork.ozlabs.org/comment/9714/","msgid":"<20081013142100.7efc2c81@zod.rchland.ibm.com>","date":"2008-10-13T18:21:00","subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","submitter":{"id":8,"url":"http://patchwork.ozlabs.org/api/people/8/","name":"Josh Boyer","email":"jwboyer@linux.vnet.ibm.com"},"content":"On Mon, 13 Oct 2008 13:06:36 -0500\nKumar Gala wrote:\n\n> \n> On Oct 13, 2008, at 10:41 AM, Josh Boyer wrote:\n> \n> > On Mon, Oct 13, 2008 at 10:49:04AM -0400, Josh Boyer wrote:\n> >> On Fri, Sep 12, 2008 at 03:34:46PM -0500, Becky Bruce wrote:\n> >>> We essentially adopt the 64-bit dma code, with some changes to \n> >>> support\n> >>> 32-bit systems, including HIGHMEM. dma functions on 32-bit are now\n> >>> invoked via accessor functions which call the correct op for a \n> >>> device based\n> >>> on archdata dma_ops. If there is no archdata dma_ops, this defaults\n> >>> to dma_direct_ops.\n> >>>\n> >>> In addition, the dma_map/unmap_page functions are added to dma_ops\n> >>> because we can't just fall back on map/unmap_single when HIGHMEM is\n> >>> enabled. In the case of dma_direct_*, we stop using map/unmap_single\n> >>> and just use the page version - this saves a lot of ugly\n> >>> ifdeffing. We leave map/unmap_single in the dma_ops definition,\n> >>> though, because they are needed by the iommu code, which does not\n> >>> implement map/unmap_page. Ideally, going forward, we will \n> >>> completely\n> >>> eliminate map/unmap_single and just have map/unmap_page, if it's\n> >>> workable for 64-bit.\n> >>>\n> >>> Signed-off-by: Becky Bruce \n> >>\n> >> While doing a buildall this morning, I notice chrp32_defconfig fails\n> >> to build with:\n> >>\n> >> drivers/built-in.o: In function `hard_dma_setup':\n> >> floppy.c:(.text+0x6e40e): undefined reference to `isa_bridge_pcidev'\n> >> floppy.c:(.text+0x6e412): undefined reference to `isa_bridge_pcidev'\n> >> floppy.c:(.text+0x6e53e): undefined reference to `isa_bridge_pcidev'\n> >> floppy.c:(.text+0x6e546): undefined reference to `isa_bridge_pcidev'\n> >> floppy.c:(.text+0x6e54a): undefined reference to `isa_bridge_pcidev'\n> >> make[1]: *** [.tmp_vmlinux1] Error 1\n> >>\n> >> (the hard_dma_setup thing is in arch/powerpc/include/asm/floppy.h).\n> >>\n> >> I did a git bisect and it pointed at this commit as causing the build\n> >> to fail. Why, I have no idea.\n> >\n> > Ok, I was annoyed enough to look at why.\n> >\n> > Basically, before this patch pci_map_single on 32-bit PPC seemed to\n> > be compiled down to __dma_sync(ptr, size, direction); and the \"dev\"\n> > parameter to the function was never actually used. The compiler\n> > seems to have optimized this out entirely, so we don't get the odd\n> > link reference to isa_bridge_pcidev at all. (Neither pci_map_single\n> > or isa_bridge_pcidev are present in the vmlinux at all).\n> >\n> > With the patch, the compiler doesn't do this code elimination\n> > because pci_map_single boils down to dma_map_page, which calls\n> > get_dma_direct_offset with the \"dev\" parameter. So since it is\n> > still used, the compiler can't eliminate it and hence FAIL.\n> >\n> > I have no patch for this at the moment. Someone should look at\n> > it more closely, because this is causing the 5 chrp32_defconfig\n> > users to weep.\n> \n> Isn't this the type of regression we should fix post -rc1 :)\n\nI don't think it matters much when it gets fixed, pre or post -rc1. But\nit should probably get fixed. My hack was to pull isa_bridge_pcidev\ninto pci-common.c and export it from there. The 64-bit PCI code can\ninitialized it, and the 32-bit can leave it NULL. But I have no idea\nif that is sane. If so, I can probably submit a patch for it.\n\njosh","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 8488DDE87F\n\tfor ;\n\tTue, 14 Oct 2008 05:26:32 +1100 (EST)","from e5.ny.us.ibm.com (e5.ny.us.ibm.com [32.97.182.145])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client CN \"e5.ny.us.ibm.com\", Issuer \"Equifax\" (verified OK))\n\tby ozlabs.org (Postfix) with ESMTPS id 4E26EDDFFC\n\tfor ; Tue, 14 Oct 2008 05:21:10 +1100 (EST)","from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])\n\tby e5.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m9DIL3Ro016990\n\tfor ; Mon, 13 Oct 2008 14:21:03 -0400","from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])\n\tby d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id\n\tm9DIL3LZ225916\n\tfor ; Mon, 13 Oct 2008 14:21:03 -0400","from d01av04.pok.ibm.com (loopback [127.0.0.1])\n\tby d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id\n\tm9DIL2Vp024275\n\tfor ; Mon, 13 Oct 2008 14:21:03 -0400","from zod.rchland.ibm.com ([9.49.218.14])\n\tby d01av04.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id\n\tm9DIL2q2024162; Mon, 13 Oct 2008 14:21:02 -0400"],"Date":"Mon, 13 Oct 2008 14:21:00 -0400","From":"Josh Boyer ","To":"Kumar Gala ","Subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","Message-ID":"<20081013142100.7efc2c81@zod.rchland.ibm.com>","In-Reply-To":"<209E575D-DDE2-406A-82DE-2DD445046C02@kernel.crashing.org>","References":"<1220900995-11928-5-git-send-email-becky.bruce@freescale.com>\n\t<1221251686-5567-1-git-send-email-becky.bruce@freescale.com>\n\t<20081013144904.GB18363@yoda.jdub.homelinux.org>\n\t<20081013154127.GA27124@yoda.jdub.homelinux.org>\n\t<209E575D-DDE2-406A-82DE-2DD445046C02@kernel.crashing.org>","X-Mailer":"Claws Mail 3.5.0 (GTK+ 2.12.8; i386-redhat-linux-gnu)","Mime-Version":"1.0","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":9715,"web_url":"http://patchwork.ozlabs.org/comment/9715/","msgid":"","date":"2008-10-13T18:22:24","subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","submitter":{"id":5,"url":"http://patchwork.ozlabs.org/api/people/5/","name":"Kumar Gala","email":"galak@kernel.crashing.org"},"content":">>>>>\n>>>> While doing a buildall this morning, I notice chrp32_defconfig \n>>>> fails\n>>>> to build with:\n>>>>\n>>>> drivers/built-in.o: In function `hard_dma_setup':\n>>>> floppy.c:(.text+0x6e40e): undefined reference to \n>>>> `isa_bridge_pcidev'\n>>>> floppy.c:(.text+0x6e412): undefined reference to \n>>>> `isa_bridge_pcidev'\n>>>> floppy.c:(.text+0x6e53e): undefined reference to \n>>>> `isa_bridge_pcidev'\n>>>> floppy.c:(.text+0x6e546): undefined reference to \n>>>> `isa_bridge_pcidev'\n>>>> floppy.c:(.text+0x6e54a): undefined reference to \n>>>> `isa_bridge_pcidev'\n>>>> make[1]: *** [.tmp_vmlinux1] Error 1\n>>>>\n>>>> (the hard_dma_setup thing is in arch/powerpc/include/asm/floppy.h).\n>>>>\n>>>> I did a git bisect and it pointed at this commit as causing the \n>>>> build\n>>>> to fail. Why, I have no idea.\n>>>\n>>> Ok, I was annoyed enough to look at why.\n>>>\n>>> Basically, before this patch pci_map_single on 32-bit PPC seemed to\n>>> be compiled down to __dma_sync(ptr, size, direction); and the \"dev\"\n>>> parameter to the function was never actually used. The compiler\n>>> seems to have optimized this out entirely, so we don't get the odd\n>>> link reference to isa_bridge_pcidev at all. (Neither pci_map_single\n>>> or isa_bridge_pcidev are present in the vmlinux at all).\n>>>\n>>> With the patch, the compiler doesn't do this code elimination\n>>> because pci_map_single boils down to dma_map_page, which calls\n>>> get_dma_direct_offset with the \"dev\" parameter. So since it is\n>>> still used, the compiler can't eliminate it and hence FAIL.\n>>>\n>>> I have no patch for this at the moment. Someone should look at\n>>> it more closely, because this is causing the 5 chrp32_defconfig\n>>> users to weep.\n>>\n>> Isn't this the type of regression we should fix post -rc1 :)\n>\n> I don't think it matters much when it gets fixed, pre or post -rc1. \n> But\n> it should probably get fixed. My hack was to pull isa_bridge_pcidev\n> into pci-common.c and export it from there. The 64-bit PCI code can\n> initialized it, and the 32-bit can leave it NULL. But I have no idea\n> if that is sane. If so, I can probably submit a patch for it.\n\nI was just joking around about our \"new\" regression policy.. anyways I \nhope ben or maybe anton can comment about the ISA code.\n\n- k","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id C3F1BDECB1\n\tfor ;\n\tTue, 14 Oct 2008 05:27:43 +1100 (EST)","from gate.crashing.org (gate.crashing.org [63.228.1.57])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id 52728DE095\n\tfor ; Tue, 14 Oct 2008 05:24:38 +1100 (EST)","from [IPv6:::1] (localhost.localdomain [127.0.0.1])\n\tby gate.crashing.org (8.14.1/8.13.8) with ESMTP id m9DIMP7K005569;\n\tMon, 13 Oct 2008 13:22:26 -0500"],"Message-Id":"","From":"Kumar Gala ","To":"Josh Boyer ","In-Reply-To":"<20081013142100.7efc2c81@zod.rchland.ibm.com>","Mime-Version":"1.0 (Apple Message framework v929.2)","Subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","Date":"Mon, 13 Oct 2008 13:22:24 -0500","References":"<1220900995-11928-5-git-send-email-becky.bruce@freescale.com>\n\t<1221251686-5567-1-git-send-email-becky.bruce@freescale.com>\n\t<20081013144904.GB18363@yoda.jdub.homelinux.org>\n\t<20081013154127.GA27124@yoda.jdub.homelinux.org>\n\t<209E575D-DDE2-406A-82DE-2DD445046C02@kernel.crashing.org>\n\t<20081013142100.7efc2c81@zod.rchland.ibm.com>","X-Mailer":"Apple Mail (2.929.2)","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"; DelSp=\"yes\"","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":9823,"web_url":"http://patchwork.ozlabs.org/comment/9823/","msgid":"<1223940603.8157.286.camel@pasglop>","date":"2008-10-13T23:30:03","subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","submitter":{"id":38,"url":"http://patchwork.ozlabs.org/api/people/38/","name":"Benjamin Herrenschmidt","email":"benh@kernel.crashing.org"},"content":"On Mon, 2008-10-13 at 14:21 -0400, Josh Boyer wrote:\n> I don't think it matters much when it gets fixed, pre or post -rc1. But\n> it should probably get fixed. My hack was to pull isa_bridge_pcidev\n> into pci-common.c and export it from there. The 64-bit PCI code can\n> initialized it, and the 32-bit can leave it NULL. But I have no idea\n> if that is sane. If so, I can probably submit a patch for it.\n\nI think the proper fix in the long run is to make the isa bridge\nhandling code in pci-64 common, but that's going to be after I rework\nthe IO space allocation/mapping mechanisms for pci-32 to also look like\npci-64 so it will take a little while.\n\nIn the meantime, I agree, just leave it to NULL, we can do a better\nfixup on top of that. As it is, it's going to hurt Pegasos too (the\nother 5 users :-)\n\nCheers,\nBen.","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 436FEDDF59\n\tfor ;\n\tTue, 14 Oct 2008 10:30:24 +1100 (EST)","from gate.crashing.org (gate.crashing.org [63.228.1.57])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id A51A9DDEED\n\tfor ; Tue, 14 Oct 2008 10:30:11 +1100 (EST)","from [127.0.0.1] (localhost.localdomain [127.0.0.1])\n\tby gate.crashing.org (8.14.1/8.13.8) with ESMTP id m9DNU3Za031570;\n\tMon, 13 Oct 2008 18:30:04 -0500"],"Subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","From":"Benjamin Herrenschmidt ","To":"Josh Boyer ","In-Reply-To":"<20081013142100.7efc2c81@zod.rchland.ibm.com>","References":"<1220900995-11928-5-git-send-email-becky.bruce@freescale.com>\n\t<1221251686-5567-1-git-send-email-becky.bruce@freescale.com>\n\t<20081013144904.GB18363@yoda.jdub.homelinux.org>\n\t<20081013154127.GA27124@yoda.jdub.homelinux.org>\n\t<209E575D-DDE2-406A-82DE-2DD445046C02@kernel.crashing.org>\n\t<20081013142100.7efc2c81@zod.rchland.ibm.com>","Date":"Tue, 14 Oct 2008 10:30:03 +1100","Message-Id":"<1223940603.8157.286.camel@pasglop>","Mime-Version":"1.0","X-Mailer":"Evolution 2.22.3.1 ","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","Reply-To":"benh@kernel.crashing.org","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":9824,"web_url":"http://patchwork.ozlabs.org/comment/9824/","msgid":"<1223940659.8157.288.camel@pasglop>","date":"2008-10-13T23:30:59","subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","submitter":{"id":38,"url":"http://patchwork.ozlabs.org/api/people/38/","name":"Benjamin Herrenschmidt","email":"benh@kernel.crashing.org"},"content":"On Mon, 2008-10-13 at 13:22 -0500, Kumar Gala wrote:\n> > I don't think it matters much when it gets fixed, pre or post -rc1. \n> > But\n> > it should probably get fixed. My hack was to pull isa_bridge_pcidev\n> > into pci-common.c and export it from there. The 64-bit PCI code can\n> > initialized it, and the 32-bit can leave it NULL. But I have no idea\n> > if that is sane. If so, I can probably submit a patch for it.\n> \n> I was just joking around about our \"new\" regression policy.. anyways I \n> hope ben or maybe anton can comment about the ISA code.\n\nMy policy for that sort of bug is fix ASAP. I'll give it a go when I do\nmy test builds. Funny I didn't catch it, I might be lacking a chrp32\ndefconfig in my build tests :-)\n\nCheers,\nBen.","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 256BADE5F6\n\tfor ;\n\tTue, 14 Oct 2008 10:31:43 +1100 (EST)","from gate.crashing.org (gate.crashing.org [63.228.1.57])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id 7DE95DDF00\n\tfor ; Tue, 14 Oct 2008 10:31:30 +1100 (EST)","from [127.0.0.1] (localhost.localdomain [127.0.0.1])\n\tby gate.crashing.org (8.14.1/8.13.8) with ESMTP id m9DNV0e7031630;\n\tMon, 13 Oct 2008 18:31:01 -0500"],"Subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","From":"Benjamin Herrenschmidt ","To":"Kumar Gala ","In-Reply-To":"","References":"<1220900995-11928-5-git-send-email-becky.bruce@freescale.com>\n\t<1221251686-5567-1-git-send-email-becky.bruce@freescale.com>\n\t<20081013144904.GB18363@yoda.jdub.homelinux.org>\n\t<20081013154127.GA27124@yoda.jdub.homelinux.org>\n\t<209E575D-DDE2-406A-82DE-2DD445046C02@kernel.crashing.org>\n\t<20081013142100.7efc2c81@zod.rchland.ibm.com>\n\t","Date":"Tue, 14 Oct 2008 10:30:59 +1100","Message-Id":"<1223940659.8157.288.camel@pasglop>","Mime-Version":"1.0","X-Mailer":"Evolution 2.22.3.1 ","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","Reply-To":"benh@kernel.crashing.org","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":9878,"web_url":"http://patchwork.ozlabs.org/comment/9878/","msgid":"<9EE82BA3-5B0C-43BB-90B4-2A93999285C1@kernel.crashing.org>","date":"2008-10-14T01:52:25","subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","submitter":{"id":5,"url":"http://patchwork.ozlabs.org/api/people/5/","name":"Kumar Gala","email":"galak@kernel.crashing.org"},"content":"On Oct 13, 2008, at 6:30 PM, Benjamin Herrenschmidt wrote:\n\n> On Mon, 2008-10-13 at 13:22 -0500, Kumar Gala wrote:\n>>> I don't think it matters much when it gets fixed, pre or post -rc1.\n>>> But\n>>> it should probably get fixed. My hack was to pull isa_bridge_pcidev\n>>> into pci-common.c and export it from there. The 64-bit PCI code can\n>>> initialized it, and the 32-bit can leave it NULL. But I have no \n>>> idea\n>>> if that is sane. If so, I can probably submit a patch for it.\n>>\n>> I was just joking around about our \"new\" regression policy.. \n>> anyways I\n>> hope ben or maybe anton can comment about the ISA code.\n>\n> My policy for that sort of bug is fix ASAP. I'll give it a go when I \n> do\n> my test builds. Funny I didn't catch it, I might be lacking a chrp32\n> defconfig in my build tests :-)\n\nI pointed out to Stephen that kisskb.ellerman.id.au hasn't been \nupdating.. there is a chrp32 defconfig in there that would normally \ncatch something like this.\n\n- k","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 14B63DE5E5\n\tfor ;\n\tTue, 14 Oct 2008 13:17:06 +1100 (EST)","from gate.crashing.org (gate.crashing.org [63.228.1.57])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id E4CF2DDE17\n\tfor ; Tue, 14 Oct 2008 12:53:09 +1100 (EST)","from [IPv6:::1] (localhost.localdomain [127.0.0.1])\n\tby gate.crashing.org (8.14.1/8.13.8) with ESMTP id m9E1qQqe006208;\n\tMon, 13 Oct 2008 20:52:27 -0500"],"Message-Id":"<9EE82BA3-5B0C-43BB-90B4-2A93999285C1@kernel.crashing.org>","From":"Kumar Gala ","To":"benh@kernel.crashing.org","In-Reply-To":"<1223940659.8157.288.camel@pasglop>","Mime-Version":"1.0 (Apple Message framework v929.2)","Subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","Date":"Mon, 13 Oct 2008 20:52:25 -0500","References":"<1220900995-11928-5-git-send-email-becky.bruce@freescale.com>\n\t<1221251686-5567-1-git-send-email-becky.bruce@freescale.com>\n\t<20081013144904.GB18363@yoda.jdub.homelinux.org>\n\t<20081013154127.GA27124@yoda.jdub.homelinux.org>\n\t<209E575D-DDE2-406A-82DE-2DD445046C02@kernel.crashing.org>\n\t<20081013142100.7efc2c81@zod.rchland.ibm.com>\n\t\n\t<1223940659.8157.288.camel@pasglop>","X-Mailer":"Apple Mail (2.929.2)","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"; DelSp=\"yes\"","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":9987,"web_url":"http://patchwork.ozlabs.org/comment/9987/","msgid":"<20081014062429.48abfb43@zod.rchland.ibm.com>","date":"2008-10-14T10:24:29","subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","submitter":{"id":8,"url":"http://patchwork.ozlabs.org/api/people/8/","name":"Josh Boyer","email":"jwboyer@linux.vnet.ibm.com"},"content":"On Mon, 13 Oct 2008 20:52:25 -0500\nKumar Gala wrote:\n\n> \n> On Oct 13, 2008, at 6:30 PM, Benjamin Herrenschmidt wrote:\n> \n> > On Mon, 2008-10-13 at 13:22 -0500, Kumar Gala wrote:\n> >>> I don't think it matters much when it gets fixed, pre or post -rc1.\n> >>> But\n> >>> it should probably get fixed. My hack was to pull isa_bridge_pcidev\n> >>> into pci-common.c and export it from there. The 64-bit PCI code can\n> >>> initialized it, and the 32-bit can leave it NULL. But I have no \n> >>> idea\n> >>> if that is sane. If so, I can probably submit a patch for it.\n> >>\n> >> I was just joking around about our \"new\" regression policy.. \n> >> anyways I\n> >> hope ben or maybe anton can comment about the ISA code.\n> >\n> > My policy for that sort of bug is fix ASAP. I'll give it a go when I \n> > do\n> > my test builds. Funny I didn't catch it, I might be lacking a chrp32\n> > defconfig in my build tests :-)\n> \n> I pointed out to Stephen that kisskb.ellerman.id.au hasn't been \n> updating.. there is a chrp32 defconfig in there that would normally \n> catch something like this.\n\nExcept if kissb catches it, it's already committed in tree. Better\nthan nothing, but it would be nice if people did a buildall before they\ncommit.\n\njosh","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 900F2DE521\n\tfor ;\n\tTue, 14 Oct 2008 21:25:21 +1100 (EST)","from e6.ny.us.ibm.com (e6.ny.us.ibm.com [32.97.182.146])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client CN \"e6.ny.us.ibm.com\", Issuer \"Equifax\" (verified OK))\n\tby ozlabs.org (Postfix) with ESMTPS id 9A909DE108\n\tfor ; Tue, 14 Oct 2008 21:24:57 +1100 (EST)","from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])\n\tby e6.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m9EARPGj006319\n\tfor ; Tue, 14 Oct 2008 06:27:25 -0400","from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])\n\tby d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id\n\tm9EAOW6U260202\n\tfor ; Tue, 14 Oct 2008 06:24:32 -0400","from d01av04.pok.ibm.com (loopback [127.0.0.1])\n\tby d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id\n\tm9EAOWdD029591\n\tfor ; Tue, 14 Oct 2008 06:24:32 -0400","from zod.rchland.ibm.com (sig-9-49-134-116.mts.ibm.com\n\t[9.49.134.116])\n\tby d01av04.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id\n\tm9EAOURA029517; Tue, 14 Oct 2008 06:24:31 -0400"],"Date":"Tue, 14 Oct 2008 06:24:29 -0400","From":"Josh Boyer ","To":"Kumar Gala ","Subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","Message-ID":"<20081014062429.48abfb43@zod.rchland.ibm.com>","In-Reply-To":"<9EE82BA3-5B0C-43BB-90B4-2A93999285C1@kernel.crashing.org>","References":"<1220900995-11928-5-git-send-email-becky.bruce@freescale.com>\n\t<1221251686-5567-1-git-send-email-becky.bruce@freescale.com>\n\t<20081013144904.GB18363@yoda.jdub.homelinux.org>\n\t<20081013154127.GA27124@yoda.jdub.homelinux.org>\n\t<209E575D-DDE2-406A-82DE-2DD445046C02@kernel.crashing.org>\n\t<20081013142100.7efc2c81@zod.rchland.ibm.com>\n\t\n\t<1223940659.8157.288.camel@pasglop>\n\t<9EE82BA3-5B0C-43BB-90B4-2A93999285C1@kernel.crashing.org>","X-Mailer":"Claws Mail 3.5.0 (GTK+ 2.12.8; i386-redhat-linux-gnu)","Mime-Version":"1.0","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":10012,"web_url":"http://patchwork.ozlabs.org/comment/10012/","msgid":"<1223985921.8157.341.camel@pasglop>","date":"2008-10-14T12:05:21","subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","submitter":{"id":38,"url":"http://patchwork.ozlabs.org/api/people/38/","name":"Benjamin Herrenschmidt","email":"benh@kernel.crashing.org"},"content":"On Tue, 2008-10-14 at 06:24 -0400, Josh Boyer wrote:\n> > I pointed out to Stephen that kisskb.ellerman.id.au hasn't been \n> > updating.. there is a chrp32 defconfig in there that would\n> normally \n> > catch something like this.\n> \n> Except if kissb catches it, it's already committed in tree. Better\n> than nothing, but it would be nice if people did a buildall before\n> they\n> commit.\n\nI have a script that builds a dozen of config's, it looks like it didn't\ncatch that one. I'm going to add a chrp32_defconfig to it. Mistakes\nhappen, hopefully we can at least make sure the common configs are well\ntested.\n\nCheers,\nBen.","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 183CADE17D\n\tfor ;\n\tTue, 14 Oct 2008 23:05:51 +1100 (EST)","from gate.crashing.org (gate.crashing.org [63.228.1.57])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\tby ozlabs.org (Postfix) with ESMTPS id 9B12DDDEE4\n\tfor ; Tue, 14 Oct 2008 23:05:36 +1100 (EST)","from [127.0.0.1] (localhost.localdomain [127.0.0.1])\n\tby gate.crashing.org (8.14.1/8.13.8) with ESMTP id m9EC5MDn016608;\n\tTue, 14 Oct 2008 07:05:22 -0500"],"Subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","From":"Benjamin Herrenschmidt ","To":"Josh Boyer ","In-Reply-To":"<20081014062429.48abfb43@zod.rchland.ibm.com>","References":"<1220900995-11928-5-git-send-email-becky.bruce@freescale.com>\n\t<1221251686-5567-1-git-send-email-becky.bruce@freescale.com>\n\t<20081013144904.GB18363@yoda.jdub.homelinux.org>\n\t<20081013154127.GA27124@yoda.jdub.homelinux.org>\n\t<209E575D-DDE2-406A-82DE-2DD445046C02@kernel.crashing.org>\n\t<20081013142100.7efc2c81@zod.rchland.ibm.com>\n\t\n\t<1223940659.8157.288.camel@pasglop>\n\t<9EE82BA3-5B0C-43BB-90B4-2A93999285C1@kernel.crashing.org>\n\t<20081014062429.48abfb43@zod.rchland.ibm.com>","Date":"Tue, 14 Oct 2008 23:05:21 +1100","Message-Id":"<1223985921.8157.341.camel@pasglop>","Mime-Version":"1.0","X-Mailer":"Evolution 2.22.3.1 ","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","Reply-To":"benh@kernel.crashing.org","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}},{"id":10187,"web_url":"http://patchwork.ozlabs.org/comment/10187/","msgid":"<282F2715-EFD2-42E5-9AF5-304292F576A8@freescale.com>","date":"2008-10-14T15:45:15","subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","submitter":{"id":12,"url":"http://patchwork.ozlabs.org/api/people/12/","name":"Becky Bruce","email":"becky.bruce@freescale.com"},"content":"On Oct 14, 2008, at 7:05 AM, Benjamin Herrenschmidt wrote:\n\n> On Tue, 2008-10-14 at 06:24 -0400, Josh Boyer wrote:\n>>> I pointed out to Stephen that kisskb.ellerman.id.au hasn't been\n>>> updating.. there is a chrp32 defconfig in there that would\n>> normally\n>>> catch something like this.\n>>\n>> Except if kissb catches it, it's already committed in tree. Better\n>> than nothing, but it would be nice if people did a buildall before\n>> they\n>> commit.\n>\n> I have a script that builds a dozen of config's, it looks like it \n> didn't\n> catch that one. I'm going to add a chrp32_defconfig to it. Mistakes\n> happen, hopefully we can at least make sure the common configs are \n> well\n> tested.\n\nBlah. I thought I had built everything before I pushed this stuff \nout. My apologies (and also for being offline for when the fun \noccurred here.... I just got back from vacation this morning.) Ben, \nthanks for fixing - let me know if there's anything you need from my \nend.\n\n-B","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@ozlabs.org"],"Received":["from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 01AE6DDED1\n\tfor ;\n\tWed, 15 Oct 2008 11:08:22 +1100 (EST)","from az33egw01.freescale.net (az33egw01.freescale.net\n\t[192.88.158.102])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client CN \"az33egw01.freescale.net\",\n\tIssuer \"Thawte Premium Server CA\" (verified OK))\n\tby ozlabs.org (Postfix) with ESMTPS id 99EEFDDF51\n\tfor ; Wed, 15 Oct 2008 11:05:06 +1100 (EST)","from az33smr01.freescale.net (az33smr01.freescale.net\n\t[10.64.34.199])\n\tby az33egw01.freescale.net (8.12.11/az33egw01) with ESMTP id\n\tm9EIChB8014671; Tue, 14 Oct 2008 11:25:35 -0700 (MST)","from udp110633uds.am.freescale.net (udp110633uds.am.freescale.net\n\t[10.82.16.50])\n\tby az33smr01.freescale.net (8.13.1/8.13.0) with ESMTP id\n\tm9EFjFqN015296; Tue, 14 Oct 2008 10:45:16 -0500 (CDT)"],"Message-Id":"<282F2715-EFD2-42E5-9AF5-304292F576A8@freescale.com>","From":"Becky Bruce ","To":"benh@kernel.crashing.org","In-Reply-To":"<1223985921.8157.341.camel@pasglop>","Mime-Version":"1.0 (Apple Message framework v929.2)","Subject":"Re: [PATCH V2 4/4] POWERPC: Merge 32 and 64-bit dma code","Date":"Tue, 14 Oct 2008 10:45:15 -0500","References":"<1220900995-11928-5-git-send-email-becky.bruce@freescale.com>\n\t<1221251686-5567-1-git-send-email-becky.bruce@freescale.com>\n\t<20081013144904.GB18363@yoda.jdub.homelinux.org>\n\t<20081013154127.GA27124@yoda.jdub.homelinux.org>\n\t<209E575D-DDE2-406A-82DE-2DD445046C02@kernel.crashing.org>\n\t<20081013142100.7efc2c81@zod.rchland.ibm.com>\n\t\n\t<1223940659.8157.288.camel@pasglop>\n\t<9EE82BA3-5B0C-43BB-90B4-2A93999285C1@kernel.crashing.org>\n\t<20081014062429.48abfb43@zod.rchland.ibm.com>\n\t<1223985921.8157.341.camel@pasglop>","X-Mailer":"Apple Mail (2.929.2)","Cc":"linuxppc-dev@ozlabs.org","X-BeenThere":"linuxppc-dev@ozlabs.org","X-Mailman-Version":"2.1.11","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"; DelSp=\"yes\"","Sender":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org"}}]