[{"id":3688789,"web_url":"http://patchwork.ozlabs.org/comment/3688789/","msgid":"<7854820a-9879-47ec-95ba-7f7ae65374a0@oss.qualcomm.com>","list_archive_url":null,"date":"2026-05-09T00:59:14","subject":"Re: [PATCH v5 6/6] target-info-qom: use a single class_init for\n target-info-* classes","submitter":{"id":93152,"url":"http://patchwork.ozlabs.org/api/people/93152/","name":"Pierrick Bouvier","email":"pierrick.bouvier@oss.qualcomm.com"},"content":"On 5/8/2026 5:54 PM, Pierrick Bouvier wrote:\n> Instead of defining a class_init per class, just use a common\n> constructor and set class_data to corresponding TargetInfo structure.\n> \n> Suggested-by: Richard Henderson \n> Signed-off-by: Pierrick Bouvier \n> ---\n> include/qemu/target-info-init.h | 14 ++------------\n> include/qemu/target-info-qom.h | 1 +\n> target-info-qom.c | 6 ++++++\n> 3 files changed, 9 insertions(+), 12 deletions(-)\n> \n> diff --git a/include/qemu/target-info-init.h b/include/qemu/target-info-init.h\n> index 176fd975a16..3945f2998e0 100644\n> --- a/include/qemu/target-info-init.h\n> +++ b/include/qemu/target-info-init.h\n> @@ -37,8 +37,6 @@ const TargetInfo *target_info(void) \\\n> #include \"qemu/target-info-qom.h\"\n> #include \"qom/object.h\"\n> \n> -#define TYPE_TARGET_INFO_TARGET TYPE_TARGET_INFO\"-\"TARGET_NAME\n> -\n> typedef struct TargetInfoQomTarget {\n> TargetInfoQom parent;\n> } TargetInfoQomTarget;\n> @@ -47,24 +45,16 @@ typedef struct TargetInfoQomTargetClass {\n> TargetInfoQomClass parent_class;\n> } TargetInfoQomTargetClass;\n> \n> -OBJECT_DECLARE_TYPE(TargetInfoQomTarget, TargetInfoQomTargetClass, TARGET_INFO_TARGET)\n> -\n> #define target_info_init(ti_var) \\\n> -static void target_info_qom_class_init(ObjectClass *oc, const void * data) \\\n> -{ \\\n> - TargetInfoQomTargetClass *klass = TARGET_INFO_TARGET_CLASS(oc); \\\n> - klass->parent_class.target_info = &ti_var; \\\n> -} \\\n> - \\\n> static const TypeInfo target_info_qom_target_type_info = { \\\n> - .name = TYPE_TARGET_INFO_TARGET, \\\n> + .name = TYPE_TARGET_INFO\"-\"TARGET_NAME, \\\n> .parent = TYPE_TARGET_INFO, \\\n> .instance_size = sizeof(TargetInfoQomTarget), \\\n> .class_size = sizeof(TargetInfoQomTargetClass), \\\n> .class_init = target_info_qom_class_init, \\\n> + .class_data = &ti_var, \\\n> .abstract = false, \\\n> }; \\\n> - \\\n> DEFINE_TARGET_INFO_TYPE(target_info_qom_target_type_info)\n> \n> #endif /* CONFIG_USER_ONLY */\n> diff --git a/include/qemu/target-info-qom.h b/include/qemu/target-info-qom.h\n> index 91be415ed33..a37c3e101e0 100644\n> --- a/include/qemu/target-info-qom.h\n> +++ b/include/qemu/target-info-qom.h\n> @@ -25,6 +25,7 @@ typedef struct TargetInfoQomClass {\n> \n> OBJECT_DECLARE_TYPE(TargetInfoQom, TargetInfoQomClass, TARGET_INFO)\n> \n> +void target_info_qom_class_init(ObjectClass *oc, const void * data);\n> void target_info_qom_set_target(void);\n> \n> #endif /* QEMU_TARGET_INFO_QOM_H */\n> diff --git a/target-info-qom.c b/target-info-qom.c\n> index cc470b3b4d6..5b0498ca654 100644\n> --- a/target-info-qom.c\n> +++ b/target-info-qom.c\n> @@ -37,6 +37,12 @@ static const TypeInfo target_info_parent_type = {\n> \n> DEFINE_TARGET_INFO_TYPE(target_info_parent_type)\n> \n> +void target_info_qom_class_init(ObjectClass *oc, const void * data)\n> +{\n> + TargetInfoQomClass *klass = TARGET_INFO_CLASS(oc);\n> + klass->target_info = data;\n> +}\n> +\n> static const TargetInfo *target_info_ptr;\n> \n> const TargetInfo *target_info(void)\n\nThis patch can be squashed with 3, but I thought it might be better for\nreview to keep it on top for now.\n\nRegards,\nPierrick","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=WyJIy0tM;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=kQY1E2Xu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gC71P6kNbz1yCg\n\tfor ; Sat, 09 May 2026 10:59:37 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wLW2N-0003cu-S8; Fri, 08 May 2026 20:59:23 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wLW2L-0003cm-Q7\n for qemu-devel@nongnu.org; Fri, 08 May 2026 20:59:21 -0400","from mx0a-0031df01.pphosted.com ([205.220.168.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wLW2K-0006VS-6S\n for qemu-devel@nongnu.org; Fri, 08 May 2026 20:59:21 -0400","from pps.filterd (m0279866.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 648GTgQQ145197\n for ; Sat, 9 May 2026 00:59:18 GMT","from mail-dy1-f198.google.com (mail-dy1-f198.google.com\n [74.125.82.198])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e1kdc1c8n-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Sat, 09 May 2026 00:59:18 +0000 (GMT)","by mail-dy1-f198.google.com with SMTP id\n 5a478bee46e88-2ef62078ee7so3184454eec.0\n for ; Fri, 08 May 2026 17:59:18 -0700 (PDT)","from [192.168.1.170] (216-71-219-44.dyn.novuscom.net.\n [216.71.219.44]) by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-1327865a1a4sm4572208c88.10.2026.05.08.17.59.15\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 08 May 2026 17:59:15 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n mtlcyq4gW2kekOHPEsMKa9ui5E+y29feXr6fBtrcslI=; b=WyJIy0tMdVKt+Ke/\n b+gVABQcClqDma+rIWOWd2RxdVrynDBMM0tzPHox+EsNPJ3ASDpmaoIkjRq+c1ae\n BkjsA8S7jUwKtTKWWoKGiM8OvGMZFF1Ynju8HXvVYuV0imD61FlYhIbIes75hjTD\n f1MnMVBNwTJKnmh2FIjB2Hfx/MofmHgqLBTRTP0rykRh3ib8CrbbpLdxHyh37NMr\n 8ieweIQlhNKiq5r7UfjAP28NRyK1LRWShCzJA1pnh7LBcN+h61LU6ccwsA1SFqjr\n MeWn7rTzqT0LZMdNmsnKW1uaPzPIVEOozgSEKoZUg7rhO71FYnH93kK+DGbRvq8j\n tQDqng==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1778288357; x=1778893157; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=mtlcyq4gW2kekOHPEsMKa9ui5E+y29feXr6fBtrcslI=;\n b=kQY1E2XuqEP2i2pEIrQn2jl8OqKkQ7rv7HWnXvSL1k/Uin6YWKpV/V/KoKD6CEg4D6\n iC5BGEQVEvzgesgxqPFgpdNWN/LLcczyp4SV7zHeh3BftNp+EImRDvycf6DYapA5k4aI\n 8I7f5DTrrNO0r2u1WqBkcVD7NeddtrU7pAdLJlUsp2WU86lwFxDUgL1M2qvQtBXlnQyw\n CBYIGTLYyaJPkYOdA/bw24BrNZDmjm/3LKZ7ksuSDdTYbjImVNvlv9pAO0xnmQu/qlw1\n y6ZXQcgAO3ookLKduw54q6fO7Gh1LiGXZ8Q81T4b8J080QV67KxN0f0QqwQhI1RM2iNg\n gvTQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778288357; x=1778893157;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=mtlcyq4gW2kekOHPEsMKa9ui5E+y29feXr6fBtrcslI=;\n b=CrPRQ8w0Pl/WyG+4e9iKIDajnzjFF47N2n4VdI4adNm4TYZR8kB2n4tR0nBoOGToA2\n T+XsfsmttSjJPjhwjXxxHZUrvuQwUdP14kKwthsVHanOCNH77k9LOrZFM8DoLboOCnqM\n U2BPocG1PSfHU95vtm3dGTfxS0elJgCIeJGQJYIljOqertfcMkVqHGWMr+Y0zTYmlQ1Z\n 3v93jUXalLzPKfYbd/nmnTpzhoFGMlNPZyHmCyIlHPM3tsvo6Lq0M4q6ZqBlHb16zpBe\n Aw05f4FeJiag+CesNmI9VJTsZ8QCte7QaQnYLnlXz6CGF8scNGeuHPCVvVoi4p23TJJi\n zWXg==","X-Gm-Message-State":"AOJu0YzfAbBKNFK5jP7lTpj5XRquFlSMqJ9almrdXeYJYagwTtP33yIm\n izPL5soSaH3KmSf+TCdNBhl+yvjHuzqzwOq+KnBEmAMkcRFHQVykATdnwwlCpy4Eu7wV9WMExql\n WU4n41Zx1uVsmfwASmq4cP/0+BcdFokArnQsRrNG4F3gk15J2Aog+0wSOmgCRJjuosgw7","X-Gm-Gg":"AeBDiesQbED/hjzj3d8txhXB9wdlEuQCSrr+J0Vfrw5a94uSKrdJdHiYCmGZkBXS3Cy\n dUTpYbWc0HFAMvkcGtLNOrCNfeRThRc8FvnXIK6Q9tEj13LqOk3NyKXhHebdNWu6fPU1/JyroDP\n Ntes2O9jM3DYEKJj60J7sGTNnNsbceRUglJqmFtD0VCLP9ocVuwicMz/wiY3yOsT3K3K3st4h5f\n UZV6fs/lPNcB4o/htAZKPRCLKVQ7bQI6oKbKmZdSPOkxx3Q4lovqUZ65L/uE9FgWbygpau8L8eH\n c6zBJIw4X0BXSWEDEkcrl/z/HjypEWz0TdPsgI9NWbt8UvNf6SwlkvGPCYWCRyFIaednySUcJkN\n 2KnoVEfipbYLD3OjxO8p5PxRfGzRS4tKCQnuUD9/2LqfNqzF4dZMgEHEQ/eWXUdIqHyHj6xaQWI\n 9qUzxkW3myn4bzqQ==","X-Received":["by 2002:a05:7022:4594:b0:11a:fb3c:568b with SMTP id\n a92af1059eb24-131853e5b5amr6478633c88.17.1778288356908;\n Fri, 08 May 2026 17:59:16 -0700 (PDT)","by 2002:a05:7022:4594:b0:11a:fb3c:568b with SMTP id\n a92af1059eb24-131853e5b5amr6478622c88.17.1778288356331;\n Fri, 08 May 2026 17:59:16 -0700 (PDT)"],"Message-ID":"<7854820a-9879-47ec-95ba-7f7ae65374a0@oss.qualcomm.com>","Date":"Fri, 8 May 2026 17:59:14 -0700","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 6/6] target-info-qom: use a single class_init for\n target-info-* classes","To":"qemu-devel@nongnu.org","Cc":"Richard Henderson , =?utf-8?q?Daniel_P=2E_?=\n\t=?utf-8?q?Berrang=C3=A9?= , =?utf-8?q?Marc-Andr=C3=A9_?=\n\t=?utf-8?q?Lureau?= ,\n Markus Armbruster , Max Filippov ,\n Paolo Bonzini ,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Anton Johansson ","References":"<20260509005453.3984184-1-pierrick.bouvier@oss.qualcomm.com>\n <20260509005453.3984184-7-pierrick.bouvier@oss.qualcomm.com>","From":"Pierrick Bouvier ","Content-Language":"en-US","In-Reply-To":"<20260509005453.3984184-7-pierrick.bouvier@oss.qualcomm.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNTA5MDAwNyBTYWx0ZWRfX48nFLEvbD0gl\n 5JnkYspa+060r1BXfwuTQbaatXqfck49NOjPEVF2F8LQ0AxtMULO6qpgCKsvxrvCXlIFecuxS8q\n bM60TG37FOMjZRvvb6SQZmDsQlA+zYhiCiWYMV3f/k962kQX/fjA/ZAdXjZuepRCzgvGBOsp7FN\n j0q8cAwKE69TzX+SYm/y8omQLOsuYvk+jMhKSvtCEMMuS1As+XZfSHjOKb6wQupy7SRPWUr1yge\n IVkhXjv+UZHFVdy+bszVJAQ6sF70VZNoQJp0Rzjj/gbk/hrdQbV8dzyuwQZ6B+B9HBZ4nPhp0v+\n OzOaDK848STcjWMPy0Lj11a0r9sSmfGajZJ7kfXr91imwhsCMVljTp+eYXMcNqwQj3AQNUkgL2k\n desPEQRQ2eN3Ib50+UG5rsWCHKbCd0yLsvVHTaxQkmO3tBZnkIr879WUOxhT3p+tSZsuYaveIk7\n 93IGaIg3XNbTuBAFG/w==","X-Authority-Analysis":"v=2.4 cv=RZOgzVtv c=1 sm=1 tr=0 ts=69fe86e6 cx=c_pps\n a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=iLqgmErQAxjCjdq5jj1Aqg==:17\n a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22\n a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=h2DMTY1dD-fEPWrfL-YA:9 a=QEXdDO2ut3YA:10\n a=bBxd6f-gb0O0v-kibOvt:22 a=cvBusfyB2V15izCimMoJ:22","X-Proofpoint-GUID":"0ULXmnpA8lRL276W5h7JXI3Iks6eNSFc","X-Proofpoint-ORIG-GUID":"0ULXmnpA8lRL276W5h7JXI3Iks6eNSFc","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-05-09_01,2026-05-08_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n clxscore=1015 bulkscore=0 suspectscore=0 impostorscore=0 malwarescore=0\n adultscore=0 phishscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605090007","Received-SPF":"pass client-ip=205.220.168.131;\n envelope-from=pierrick.bouvier@oss.qualcomm.com;\n helo=mx0a-0031df01.pphosted.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]