[{"id":3688720,"web_url":"http://patchwork.ozlabs.org/comment/3688720/","msgid":"<3a7ba262-9344-472b-9154-b3bcd61c73b4@linaro.org>","list_archive_url":null,"date":"2026-05-08T20:40:42","subject":"Re: [PATCH 3/4] hw/display/exynos4210_fimd: Use LOG_GUEST_ERROR\n instead of hw_error()","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 5/8/26 11:20, Peter Maydell wrote:\n> The exynos4210_fimd device model uses hw_error() in several places\n> for \"the guest set this register field to something out of range\";\n> update to the more modern LOG_GUEST_ERROR.\n> \n> Resolves:https://gitlab.com/qemu-project/qemu/-/work_items/3405\n> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>\n> ---\n>   hw/display/exynos4210_fimd.c | 7 +++++--\n>   1 file changed, 5 insertions(+), 2 deletions(-)\n\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\n\nr~","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=pUKNBmfY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gC1H85RvXz1yHW\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 09 May 2026 06:41:08 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wLS0I-0000i2-IE; Fri, 08 May 2026 16:41:00 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wLS09-0000fw-4E\n for qemu-devel@nongnu.org; Fri, 08 May 2026 16:40:50 -0400","from mail-oi1-x232.google.com ([2607:f8b0:4864:20::232])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wLS06-0001gq-1y\n for qemu-devel@nongnu.org; Fri, 08 May 2026 16:40:47 -0400","by mail-oi1-x232.google.com with SMTP id\n 5614622812f47-47cbd445021so1428606b6e.1\n for <qemu-devel@nongnu.org>; Fri, 08 May 2026 13:40:45 -0700 (PDT)","from ?IPV6:2607:fb91:1a91:1de:21e3:45a9:5df:5a65?\n ([2607:fb91:1a91:1de:21e3:45a9:5df:5a65])\n by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-43557109b67sm2536638fac.6.2026.05.08.13.40.44\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 08 May 2026 13:40:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778272845; x=1778877645; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=PSWPIr97x3tuuSvWr8rkm2/CIIhC4NsePasPoT/2Vmc=;\n b=pUKNBmfYzSAK3FRgJIb/IuJhGSICSJd8w0uoj6CkaQb0SQ4fxwVJakFcVy3T2jOgGH\n zdSZsuEnKtdOOd+FAM25ULyErdHGMXGoj+bsJKzCTW1LFj4TU9uckzDaJb/0kd/7FNAt\n Exu3Uy/81iAXz6DwGwrkXPcKc6jfL1TLXS5n/YM1DGjBohSwKUi2hfoJCNvl3hmgFjrj\n syLkhSFYoqshkFhQgpxc5KUP7Bk3+QpdnDQttdD84mOCj+nTqOzhyJ1w2gMSZRJDAk0y\n ydRcx8Q7w8C2ljFwBpyibotupnR1x1clsGRVZeGnLxqS+JEv9w2dc+cMgtnhrQVRfIOe\n ywkw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778272845; x=1778877645;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=PSWPIr97x3tuuSvWr8rkm2/CIIhC4NsePasPoT/2Vmc=;\n b=p7lQG1WqzlA727qM+IG7ahuQ6tUor5ocN5ePjthXMT5mDBRGv0l9b5Vv2UoNWEsLsF\n csdZryTFsSIsX0zdHeZyOMu3VHB/rA4WvH5ylhHzproZXwg+uKBd6Vm8tMI7iNhpcELY\n ee6vF1hypzMBQ140USQOD6HLDtIvtvLm/9xrYeXpgz5pK++dcXa1lw3cEDxrTkhNOPHc\n UAjJnLTnqJ/MYPT9GeeUFahiyJbp/W+h2jRHYua27Q8SZt7lxPqB5fl3d7HhX4+ML05j\n 7d5ht317h1HVaI/OQXxLv8rGg6/EodEXpNBeYWMQUFGMI6nrl41qXqv0HFejt3QS5Tk+\n Nr9w==","X-Gm-Message-State":"AOJu0YxO9xI/wm9mzgVszxizr0k9kUt5wuAPWqC6le/0pMPYB1JjANbz\n vbluW7l7G2fti0lbWBdjt2mPFGoQZ3bd9evaH7dm9iSI5yoXt3hSw1uUCqEZaEcgDbhaijExCrw\n 1FqQQ","X-Gm-Gg":"AeBDieu1lgxMANNovMkvgsIhf0or2MkjMJxpxnmEkHV31JEUT6JYJO2dh2mc60Ck+/p\n ii+bxg/to7qYE6vb5WTZ3fxZdDsl+gzheQKJ9eq8eV9DBZQBL4/KydaHQVV2inO0XXRbR3JC0Lb\n MxzfeUFG7PaJ30144VBu3rq7se41G2cbx82AH1kxpd+7y5U3hDRhBAsaamMXQYj/Rt3gDATjVx6\n rD7yjpGfFFVnXNSGq0glB5qAIxxSKYR07Lu7T7U7wFtR3IdjNz6xif45U9tG6ZSA/uOuLieKD0F\n OJLQL1fsGGMRKouOe0melLF7H6Mq0tmZFDsYkyKRksdHvtlKsQlQ2qbgrQvGFiRTFdUPNwSR2dn\n u+9zKYVXSDc1/4l+mr9I5GN5gQPwQsvtGY6Yd1dwBbMRXopQbSuQX4X9PqhQZ6U4lGliBb/M/Ez\n uJSP/KWICEnlw5uQRw3vh0mn0Is7ZAo9uaL9gG32CQ0HZR1nXEO1fcDfH3Mh6DhR2NlMYi74+LU\n A+d114=","X-Received":"by 2002:a05:6808:c1b6:b0:479:dac7:afa5 with SMTP id\n 5614622812f47-4807fe5c82emr2725797b6e.47.1778272844782;\n Fri, 08 May 2026 13:40:44 -0700 (PDT)","Message-ID":"<3a7ba262-9344-472b-9154-b3bcd61c73b4@linaro.org>","Date":"Fri, 8 May 2026 15:40:42 -0500","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 3/4] hw/display/exynos4210_fimd: Use LOG_GUEST_ERROR\n instead of hw_error()","To":"qemu-devel@nongnu.org","References":"<20260508162013.2751001-1-peter.maydell@linaro.org>\n <20260508162013.2751001-4-peter.maydell@linaro.org>","From":"Richard Henderson <richard.henderson@linaro.org>","Content-Language":"en-US","In-Reply-To":"<20260508162013.2751001-4-peter.maydell@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::232;\n envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x232.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]