[{"id":3688719,"web_url":"http://patchwork.ozlabs.org/comment/3688719/","msgid":"<09e4e0f3-299c-4ced-85cd-8dbacfaad8b1@linaro.org>","list_archive_url":null,"date":"2026-05-08T20:40:22","subject":"Re: [PATCH 2/4] hw/arm/integratorcp: Use LOG_UNIMP rather than\n hw_error()","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 5/8/26 11:20, Peter Maydell wrote:\n> The integratorcp board has some onboard registers which can be used\n> to raise IRQ and FIQ to the CPU; these outputs are supposed to be\n> ORed together with the main ones from the PIC. We've never\n> implemented this obscure bit of functionality, and instead call\n> hw_error() if the guest does try to raise an interrupt this way.\n> \n> Replace the hw_error() call with the more modern way to note\n> unimplemented QEMU behaviour, a LOG_UNIMP log.\n> \n> Resolves:https://gitlab.com/qemu-project/qemu/-/work_items/3406\n> Signed-off-by: Peter Maydell\n> ---\n> hw/arm/integratorcp.c | 16 +++++++++++-----\n> 1 file changed, 11 insertions(+), 5 deletions(-)\n\nReviewed-by: Richard Henderson \n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=yjtOLZi8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gC1Gy1s97z1yHW\n\tfor ; Sat, 09 May 2026 06:40:58 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wLRzs-0000eV-3z; Fri, 08 May 2026 16:40:32 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wLRzp-0000eL-Ko\n for qemu-devel@nongnu.org; Fri, 08 May 2026 16:40:29 -0400","from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wLRzn-0001fv-Mb\n for qemu-devel@nongnu.org; Fri, 08 May 2026 16:40:29 -0400","by mail-oi1-x231.google.com with SMTP id\n 5614622812f47-45f053b7b90so1466823b6e.0\n for ; Fri, 08 May 2026 13:40:27 -0700 (PDT)","from ?IPV6:2607:fb91:1a91:1de:21e3:45a9:5df:5a65?\n ([2607:fb91:1a91:1de:21e3:45a9:5df:5a65])\n by smtp.gmail.com with ESMTPSA id\n 5614622812f47-47c76400028sm15287741b6e.5.2026.05.08.13.40.24\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 08 May 2026 13:40:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778272826; x=1778877626; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=qUdubkRHScVeWTzRucOYI/lytJpyZIKRIyWDx82e1f8=;\n b=yjtOLZi8WqybN4Twoyti075UKvUh9bqJe9KjsARgs9cLyl1Crp2N31+MnqqHwll/4k\n c1mty+UMtw2yQU5IHa8cWDclAVLDXr1K/OnfQUXYXi0wXsJXgExMjAw7pFR8e/P61at7\n 2R7/uFI98MSCVe4PR2RKF25YzJqP2rL+HrQmrHIuLuJDWloCqB+zotVge4AhN0U6R+iL\n H4FlE4CB3yuomRXXlZVjq0HQdFMpM8dSuLGyqig2G3d+Me2cKwAGbHgHfIUFrMfqy3UV\n cbQgheXz9XDWT6muq7lgPN5Aoo495ZA/g6lrkRHE8xG0jxuIY6WPgUKZq7nDGdlj5ZDg\n 85YA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778272826; x=1778877626;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=qUdubkRHScVeWTzRucOYI/lytJpyZIKRIyWDx82e1f8=;\n b=neG7twDhvyVnDQTEyaGWG/2w1eDaqBvGFx0cXOBjWoZKLJOUr3lPN/fZd31pM5JZwT\n ehtmQyMC05laXsOnAEOAnF8SekQUMkNqjYDBlB6Zu2/S7YJ5vQAGMyl7GzFYtqCy5Mbu\n 7IAvwpRDg6HoPOk7XS2H7b69vWm5OmRhHdGHVpaWlsCqXKOlunFx2mXEDtExj7ALFfdQ\n OBSUbNWkwON3v5wvYVeyVDZpeOhlYkNkn9Ys1JXmbDo6MHFKGGVGlIvD8fs754w1tRQG\n ppSXkkxYOWOT/qdDTetVb/61XRxGe7HY+iI9Eo23KU/NFX+7BU58hbFw+yPjNSEy4WsC\n XuNA==","X-Gm-Message-State":"AOJu0Yxm332VKYpL+pm9IjXInfhQnrv/6gHHNxNcWBHGaV4Ha1ZyUl3M\n zM37EzQqoNmZ1gKVieQjoRfsgH496r59VrZaOgXVB7+Hgv4So/T0OasonmV8BIG46xjdJpihVaC\n mDgMF","X-Gm-Gg":"AeBDievrFuwvowdb0ZVr3wNCDfr090RADJIZyl1wKlpJD4TrphHVG7WQ23Ukm7FayzX\n gp8Sw27E8/tSg8udNoahPlxDyAPhBqZxjULVMUDCJ9r4m0juzHb6o7uFaDSAfIeQFhjGGsPJBoy\n CBwLI1uiF1cWdyfvQlrusExgEHyeJsjADqgsHyd6lCjAYIukpVsbu6N0T6u5sFvqXuYx46Lfs3T\n j/ZfLTbCbnESNBOW+TbQT7TI3tHjWLW5BunZW8LETZnS0C3lOkBRgvZr0O4lh42M9O5EsXs5NsO\n vPXdvGvMQHW6nCTZ/UPjqcl7d0JAyFUupXgtpd0e97sAWYKxXwn/ssvXTo6e4hDuVcETi5jvZvR\n 6RX7d8zaYmQE5n0tRaHK1Ef0IKH3k6uHpeNX6dGgKr0pJsN/PLZUpAlxQuyLx3YJyy6I7uf1zBs\n k0Bv85xf+x2CPccnetvFQJcWl2MQIDlXMxD1cuplcYmOZnK6jOHvYpfqx/jmhdecygMRr/bcEXK\n 0ijCgcYMDGrs2/pOA==","X-Received":"by 2002:a05:6808:bc7:b0:479:e869:5424 with SMTP id\n 5614622812f47-48042236082mr9244784b6e.19.1778272825913;\n Fri, 08 May 2026 13:40:25 -0700 (PDT)","Message-ID":"<09e4e0f3-299c-4ced-85cd-8dbacfaad8b1@linaro.org>","Date":"Fri, 8 May 2026 15:40:22 -0500","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/4] hw/arm/integratorcp: Use LOG_UNIMP rather than\n hw_error()","To":"qemu-devel@nongnu.org","References":"<20260508162013.2751001-1-peter.maydell@linaro.org>\n <20260508162013.2751001-3-peter.maydell@linaro.org>","From":"Richard Henderson ","Content-Language":"en-US","In-Reply-To":"<20260508162013.2751001-3-peter.maydell@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::231;\n envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x231.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]